ANN: VS2008 deprecation happening now

114 views
Skip to first unread message

Carlos Pizano

unread,
Oct 12, 2012, 6:07:49 PM10/12/12
to chromi...@chromium.org
Given that all the things outlined in the post  "ANN: VS2010 to become the main toolchain on Windows" [1] have happened and in very short order there would be no VS2008 bots [2] and given that the official builds are in VS2010 [3] for a while. It is my pleasure to announce that Visual Studio 2008 will be officially deprecated as of Monday October 15.

If you develop on Windows please transition to VS2010 now. If you are a reviewer do not ok "fix VS2008 build" patches.

Q: Why are you doing this?
A: Many reasons. Windows 8, consolidation of our infrastructure and VS2012. Even the newer Microsoft SDK is VS2008 unfriendly. Read the discussions linked below for more context.

Q: This is so sudden, can we do this in X weeks?
A: There is nearly zero coverage in the bots. It means that we are going to break you and no sheriff is going to notice. We consider 5 months ample warning.

Q: Why move to VS2010? why not move to VS2012?
A: We intent to support VS2012 in the near future. Two big issues: Chromium does not compile on VS2012 and it cannot produce binaries that run on XP. We are addressing the first and Microsoft is addressing the second. Not to mention we need bot coverage on that toolchain. We don't have a timeline yet.

Q: But the VS2010 IDE is very slow!
A: That is not enough of a reason to stay behind. Unlike VS2008, VS2010 gives you more/better ways to control [4] that it does in the background. Please use them.

Q: So VS2010 supports some C++11, so can I use any of that goodness?
A: Hold your horses. We need to figure out what subset we are going to allow and update the style guide. If you have strong opinions about it, please start a separate thread.

John Abd-El-Malek

unread,
Oct 12, 2012, 6:14:15 PM10/12/12
to c...@chromium.org, chromi...@chromium.org
On Fri, Oct 12, 2012 at 3:07 PM, Carlos Pizano <c...@chromium.org> wrote:
Given that all the things outlined in the post  "ANN: VS2010 to become the main toolchain on Windows" [1] have happened and in very short order there would be no VS2008 bots [2] and given that the official builds are in VS2010 [3] for a while. It is my pleasure to announce that Visual Studio 2008 will be officially deprecated as of Monday October 15.

If you develop on Windows please transition to VS2010 now. If you are a reviewer do not ok "fix VS2008 build" patches.

Q: Why are you doing this?
A: Many reasons. Windows 8, consolidation of our infrastructure and VS2012. Even the newer Microsoft SDK is VS2008 unfriendly. Read the discussions linked below for more context.

Q: This is so sudden, can we do this in X weeks?
A: There is nearly zero coverage in the bots. It means that we are going to break you and no sheriff is going to notice. We consider 5 months ample warning.

Q: Why move to VS2010? why not move to VS2012?
A: We intent to support VS2012 in the near future. Two big issues: Chromium does not compile on VS2012 and it cannot produce binaries that run on XP. We are addressing the first and Microsoft is addressing the second. Not to mention we need bot coverage on that toolchain. We don't have a timeline yet.

Q: But the VS2010 IDE is very slow!
A: That is not enough of a reason to stay behind. Unlike VS2008, VS2010 gives you more/better ways to control [4] that it does in the background. Please use them.

Small note for others like me who find VS2010's IDE too slow: you can still use VS2008 IDE. You'll have to be using ninja to build, and that'll still use VS 2010 under the scenes.

set GYP_MSVS_VERSION=2008
set GYP_GENERATORS=msvs
gclient runhooks
set GYP_MSVS_VERSION=
set GYP_GENERATORS=ninja

And now you have a VS2008 solution t

Q: So VS2010 supports some C++11, so can I use any of that goodness?
A: Hold your horses. We need to figure out what subset we are going to allow and update the style guide. If you have strong opinions about it, please start a separate thread.

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

William Chan (陈智昌)

unread,
Oct 12, 2012, 6:32:32 PM10/12/12
to Carlos Pizano, chromium-dev
On Fri, Oct 12, 2012 at 3:07 PM, Carlos Pizano <c...@chromium.org> wrote:
Given that all the things outlined in the post  "ANN: VS2010 to become the main toolchain on Windows" [1] have happened and in very short order there would be no VS2008 bots [2] and given that the official builds are in VS2010 [3] for a while. It is my pleasure to announce that Visual Studio 2008 will be officially deprecated as of Monday October 15.

If you develop on Windows please transition to VS2010 now. If you are a reviewer do not ok "fix VS2008 build" patches.

Q: Why are you doing this?
A: Many reasons. Windows 8, consolidation of our infrastructure and VS2012. Even the newer Microsoft SDK is VS2008 unfriendly. Read the discussions linked below for more context.

Q: This is so sudden, can we do this in X weeks?
A: There is nearly zero coverage in the bots. It means that we are going to break you and no sheriff is going to notice. We consider 5 months ample warning.

Q: Why move to VS2010? why not move to VS2012?
A: We intent to support VS2012 in the near future. Two big issues: Chromium does not compile on VS2012 and it cannot produce binaries that run on XP. We are addressing the first and Microsoft is addressing the second. Not to mention we need bot coverage on that toolchain. We don't have a timeline yet.

Q: But the VS2010 IDE is very slow!
A: That is not enough of a reason to stay behind. Unlike VS2008, VS2010 gives you more/better ways to control [4] that it does in the background. Please use them.

Q: So VS2010 supports some C++11, so can I use any of that goodness?
A: Hold your horses. We need to figure out what subset we are going to allow and update the style guide. If you have strong opinions about it, please start a separate thread.

Note that the internal Google C++ style guide dictates what's allowed in terms of C++11. I think we should stay consistent with Google style. If the external style guide is out of date, I can prod whoever (isn't that Elliot?) to update it. Also, I think there are other considerations, like whether or not the C++11 standard library is shipped with the platforms we care about.
 

Peter Kasting

unread,
Oct 12, 2012, 6:37:53 PM10/12/12
to William Chan (陈智昌), Carlos Pizano, chromium-dev
On Fri, Oct 12, 2012 at 3:32 PM, William Chan (陈智昌) <will...@chromium.org> wrote:
Q: So VS2010 supports some C++11, so can I use any of that goodness?
A: Hold your horses. We need to figure out what subset we are going to allow and update the style guide. If you have strong opinions about it, please start a separate thread.

Note that the internal Google C++ style guide dictates what's allowed in terms of C++11. I think we should stay consistent with Google style. If the external style guide is out of date, I can prod whoever (isn't that Elliot?) to update it. Also, I think there are other considerations, like whether or not the C++11 standard library is shipped with the platforms we care about.

In general, we want to be consistent with the Google style guide.  In the specific case of C++11, our support for a variety of ports and platforms has meant that there are practical considerations most Google projects don't have, so we've asked developers to avoid C++11 in Chrome for the moment.  We fully intend to support C++11 eventually, presumably with the same constraints as the Google style guide, but we aren't supporting it _yet_.  Given how little is currently allowed internally, that's hopefully not too huge of an issue at the moment.

PK

William Chan (陈智昌)

unread,
Oct 12, 2012, 6:40:51 PM10/12/12
to Peter Kasting, Carlos Pizano, chromium-dev
Sorry, yes, that's what I meant. I just didn't want us to choose a subset of C++11 that was not a subset of what the Google style guide allows.

Alex Pakhunov

unread,
Oct 12, 2012, 7:17:53 PM10/12/12
to c...@chromium.org, chromium-dev
I've been compiling Chrome without having Visual Studio installed for a while now. If you don't use VS IDE, don't mind building from the command line and don't want to spend 2 hours installing VS2010, please, read on.

You will need Wiindows SDK 7.1 (compiler and libraries) and WDK (provides ATL) installed on you machine. The steps are:
  1. Get Windows 8 SDK and DirectX SDK per build instructions page: http://dev.chromium.org/developers/how-tos/build-instructions-windows 
  2. Install Windows SDK 7.1: http://www.microsoft.com/en-us/download/details.aspx?id=8279
  3. Install SP1 update for the compiler: http://www.microsoft.com/en-us/download/details.aspx?id=4422
  4. Install WDK: http://www.microsoft.com/en-us/download/details.aspx?id=11800
  5. Define WDK_DIR environment variable so that it points to WDK installation. For example:

    set WDK_DIR=C:\WinDDK\7600.16385.1

  6. Edit your %USERPROFILE%\.gyp\include.gypi and add the following:

      'target_defaults': {
        'configurations': {
          'x86_Base': {
            'msvs_settings': {
              'VCLinkerTool': {
                'AdditionalLibraryDirectories': [
                  '$(DXSDK_DIR)/lib/x86',
                  '$(WDK_DIR)/lib/ATL/i386',
                ],
              },
              'VCLibrarianTool': {
                'AdditionalLibraryDirectories': [
                  '$(DXSDK_DIR)/lib/x86',
                  '$(WDK_DIR)/lib/ATL/i386',
                ],
              },
            },
          },
          'x64_Base': {
            'msvs_settings': {
              'VCLibrarianTool': {
                'AdditionalLibraryDirectories': [
                  '$(DXSDK_DIR)/lib/x64',
                  '$(WDK_DIR)/lib/ATL/amd64',
                ],
              },
              'VCLinkerTool': {
                'AdditionalLibraryDirectories': [
                  '$(DXSDK_DIR)/lib/x64',
                  '$(WDK_DIR)/lib/ATL/amd64',
                ],
              },
            },
          },
        },
        'msvs_system_include_dirs': [
          '$(DXSDK_DIR)/include',
          '$(WDK_DIR)/inc/atl71',
          '$(WDK_DIR)/inc/mfc42',
        ],
      },

  7. Set up msbuild/ninja build: http://dev.chromium.org/developers/how-tos/build-instructions-windows 
  8. Set up Goma if you use it.
  9. Launch Windows SDK 7.1 command line environment:

    setenv.cmd /x86

  10. Clear TARGET_CPU environment variable (if you want to build x64 targets using msbuild only):

    set TARGET_CPU=

Once you did all of that you should be able to run gclient runhooks and build it from command line:

  1. msbuild all.sln /p:Configuration=Debug /p:Platform=Win32 /m
  2. ninja -C out\Debug chrome -j 300
I'll prepare a CL that should make include.gypi modification unnecessary if there is any interest in VS-less builds.


On Fri, Oct 12, 2012 at 3:07 PM, Carlos Pizano <c...@chromium.org> wrote:

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev



--
Alex.

James Robinson

unread,
Oct 15, 2012, 3:52:01 PM10/15/12
to c...@chromium.org, chromi...@chromium.org
On Fri, Oct 12, 2012 at 3:07 PM, Carlos Pizano <c...@chromium.org> wrote:
Given that all the things outlined in the post  "ANN: VS2010 to become the main toolchain on Windows" [1] have happened and in very short order there would be no VS2008 bots [2] and given that the official builds are in VS2010 [3] for a while. It is my pleasure to announce that Visual Studio 2008 will be officially deprecated as of Monday October 15.


Does that mean we should now ignore all compile failures on "Win Builder 2008 (dbg)" ?  Can we take it off the waterfall?

- James

If you develop on Windows please transition to VS2010 now. If you are a reviewer do not ok "fix VS2008 build" patches.

Q: Why are you doing this?
A: Many reasons. Windows 8, consolidation of our infrastructure and VS2012. Even the newer Microsoft SDK is VS2008 unfriendly. Read the discussions linked below for more context.

Q: This is so sudden, can we do this in X weeks?
A: There is nearly zero coverage in the bots. It means that we are going to break you and no sheriff is going to notice. We consider 5 months ample warning.

Q: Why move to VS2010? why not move to VS2012?
A: We intent to support VS2012 in the near future. Two big issues: Chromium does not compile on VS2012 and it cannot produce binaries that run on XP. We are addressing the first and Microsoft is addressing the second. Not to mention we need bot coverage on that toolchain. We don't have a timeline yet.

Q: But the VS2010 IDE is very slow!
A: That is not enough of a reason to stay behind. Unlike VS2008, VS2010 gives you more/better ways to control [4] that it does in the background. Please use them.

Q: So VS2010 supports some C++11, so can I use any of that goodness?
A: Hold your horses. We need to figure out what subset we are going to allow and update the style guide. If you have strong opinions about it, please start a separate thread.

Dominic Mazzoni

unread,
Oct 15, 2012, 4:00:34 PM10/15/12
to alex...@google.com, c...@chromium.org, chromium-dev
On Fri, Oct 12, 2012 at 4:17 PM, Alex Pakhunov <alex...@google.com> wrote:
I've been compiling Chrome without having Visual Studio installed for a while now. If you don't use VS IDE, don't mind building from the command line and don't want to spend 2 hours installing VS2010, please, read on.

I've also been doing this for a few months. It forced me to learn WinDBG and once I got the hang of that, I haven't missed VS once.
 
I'll prepare a CL that should make include.gypi modification unnecessary if there is any interest in VS-less builds.

+1, that would be awesome. It took me a while to fiddle with all of this and get it working. I'd love to not have to worry about that next time I refresh my machine.

Please add these notes to the Windows build page on chromium.org.

- Dominic

Nicolas Sylvain

unread,
Oct 15, 2012, 4:38:28 PM10/15/12
to James Robinson, c...@chromium.org, chromium-dev
On Mon, Oct 15, 2012 at 12:52 PM, James Robinson <jam...@google.com> wrote:


On Fri, Oct 12, 2012 at 3:07 PM, Carlos Pizano <c...@chromium.org> wrote:
Given that all the things outlined in the post  "ANN: VS2010 to become the main toolchain on Windows" [1] have happened and in very short order there would be no VS2008 bots [2] and given that the official builds are in VS2010 [3] for a while. It is my pleasure to announce that Visual Studio 2008 will be officially deprecated as of Monday October 15.


Does that mean we should now ignore all compile failures on "Win Builder 2008 (dbg)" ?  Can we take it off the waterfall?
I have a change pending for this. It will take effect at the next master restart.

Nicolas

Alex Pakhunov

unread,
Oct 18, 2012, 12:19:52 PM10/18/12
to Dominic Mazzoni, c...@chromium.org, chromium-dev
Just a quick update. As of http://crrev.com/162666 you can set up Visual Studio-less build environment without editing %USERPROFILE%\.gyp\include.gypi. Just follow the instructions: Setting up the environment for building without Visual Studio.

--
Alex.

Gabriel Charette

unread,
Oct 22, 2012, 10:15:29 AM10/22/12
to Alex Pakhunov, Dominic Mazzoni, c...@chromium.org, chromium-dev
On Thu, Oct 18, 2012 at 12:19 PM, Alex Pakhunov <alex...@google.com> wrote:
Just a quick update. As of http://crrev.com/162666 you can set up Visual Studio-less build environment without editing %USERPROFILE%\.gyp\include.gypi. Just follow the instructions: Setting up the environment for building without Visual Studio.

I don't see such a section on the current wiki..?
 



On Mon, Oct 15, 2012 at 1:00 PM, Dominic Mazzoni <dmaz...@chromium.org> wrote:
On Fri, Oct 12, 2012 at 4:17 PM, Alex Pakhunov <alex...@google.com> wrote:
I've been compiling Chrome without having Visual Studio installed for a while now. If you don't use VS IDE, don't mind building from the command line and don't want to spend 2 hours installing VS2010, please, read on.

I've also been doing this for a few months. It forced me to learn WinDBG and once I got the hang of that, I haven't missed VS once.
 
I'll prepare a CL that should make include.gypi modification unnecessary if there is any interest in VS-less builds.

+1, that would be awesome. It took me a while to fiddle with all of this and get it working. I'd love to not have to worry about that next time I refresh my machine.

Please add these notes to the Windows build page on chromium.org.

- Dominic




--
Alex.

Wez

unread,
Oct 22, 2012, 1:24:36 PM10/22/12
to g...@chromium.org, Alex Pakhunov, Dominic Mazzoni, c...@chromium.org, chromium-dev
It's been merged into "Setting up the environment for building with Visual C++ 2010 Express or Windows 7.1 SDK".
Reply all
Reply to author
Forward
0 new messages