--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALNjmMrbWafsnCbqYm%3DK9c18%2BsYzOmCqHW--rdvihZG-VVZS9g%40mail.gmail.com.
I commented on the doc. Unfortunately, I don't think it will be possible toturn mksnapshot into a data_dep due to embedded builtins (mksnapshotgenerates embedded.cc, required to build libv8.so).
But looking at the graph above, it seems like splitting up code-stub-assembler.cc may besomething to investigate?
--
--
v8-dev mailing list
v8-...@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+un...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--Takuto IkutaSoftware Engineer in TokyoChrome Infrastructure (goma team)
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALNjmMoDA3hyO-0G_esiG%3Dn4k8FJu%3Dhfd_ucBG5hRusL1OAuxA%40mail.gmail.com.
This is something I also would like to see solved. The long phase in the middle can be even more pronounced in Chromium jumbo builds and from a high level it looks like it ought to be fixable.I would look for a solution that does not require adding another dependency type though. Brett Wilson has stated many times that the coarse dependency system in gn is intentional because there were so many subtle dependency bugs with gyp's more fine grained dependencies.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--Takuto IkutaSoftware Engineer in TokyoChrome Infrastructure (goma team)
--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALNjmMoDA3hyO-0G_esiG%3Dn4k8FJu%3Dhfd_ucBG5hRusL1OAuxA%40mail.gmail.com.
Google Germany GmbH
Erika-Mann-Straße 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.
This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.
Slightly tangential: Just by looking at the trace, it would already help if some builders got started with the big files (code-stub-assembler.cc and objects.cc) right at the beginning, instead of first doing some smaller tasks and only then getting started with the bigger ones. Is that doable?(That is orthogonal to the problem that when mksnapshot is running, nothing else gets done.)
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAED6dUC%2BkyQrZUwnAWS7AsQWfGNQAV5Zv7ggqPhbSV0zQnAnEA%40mail.gmail.com.
On Fri, Apr 20, 2018 at 5:40 AM, Takuto Ikuta <tik...@google.com> wrote:2018-04-19 23:12 GMT+09:00 Marja Hölttä <ma...@chromium.org>:Slightly tangential: Just by looking at the trace, it would already help if some builders got started with the big files (code-stub-assembler.cc and objects.cc) right at the beginning, instead of first doing some smaller tasks and only then getting started with the bigger ones. Is that doable?(That is orthogonal to the problem that when mksnapshot is running, nothing else gets done.)Yes. There is some effort for better scheduling on ninja side.
That link is about explicit build orders - would it make sense to try and distribute compile work evenly over builders, taking e.g. file size as a metric to approximate compile time?
2018-04-19 23:12 GMT+09:00 Marja Hölttä <ma...@chromium.org>:Slightly tangential: Just by looking at the trace, it would already help if some builders got started with the big files (code-stub-assembler.cc and objects.cc) right at the beginning, instead of first doing some smaller tasks and only then getting started with the bigger ones. Is that doable?(That is orthogonal to the problem that when mksnapshot is running, nothing else gets done.)Yes. There is some effort for better scheduling on ninja side.
I sent proposal of link_deps to gn-dev. The proposal will fix the issue next time.2018-04-20 15:39 GMT+09:00 Jakob Gruber <jgr...@chromium.org>:On Fri, Apr 20, 2018 at 5:40 AM, Takuto Ikuta <tik...@google.com> wrote:2018-04-19 23:12 GMT+09:00 Marja Hölttä <ma...@chromium.org>:Slightly tangential: Just by looking at the trace, it would already help if some builders got started with the big files (code-stub-assembler.cc and objects.cc) right at the beginning, instead of first doing some smaller tasks and only then getting started with the bigger ones. Is that doable?(That is orthogonal to the problem that when mksnapshot is running, nothing else gets done.)Yes. There is some effort for better scheduling on ninja side.That link is about explicit build orders - would it make sense to try and distribute compile work evenly over builders, taking e.g. file size as a metric to approximate compile time?I want to do some investigation for this, but ninja's owner does not actively review PRs. But if I could sure that there is large improvement, I will ping them.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CALNjmMrOt0YmrEQEBAqVPwGHLn%2BbQ4b%3D8YRJ3-na6%3Dtry_ssbQ%40mail.gmail.com.