how to optimize chrome.dll by pgo

[Cai Huan]

does anybody know how to optimize chorome.dll by using pgo

[Sébastien Marchand]

Yes, I'm travelling today and tomorrow but I'll be able to help you next week. What's the error you're having?

Le 20 sept. 2017 04 h 59, "Cai Huan" <cai.h...@gmail.com> a écrit :

does anybody know how to optimize chorome.dll by using pgo

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/bcb1ae78-396c-4aca-82b3-bd6e42101870%40chromium.org.

[Cai Huan]

the python script post below message when i run merge_pgc_files.py

--------------------------------------------------------

f:\liebao\source_code\chrome_2987_v57_original\src\out\release\chrome!45.pgc: Used 12.4% (57899296 / 468103168) of total

 space reserved.  0.0% of the counts were dropped due to overflow.

PGOMGR : fatal error PG0003: Unhandled exception: access violation exception at 0x00FC85D5 attempting to write at 0x0000

0036.

--------------------------------------------------------

[Cai Huan]

hi~  :)

On Thursday, September 21, 2017 at 9:00:23 PM UTC+8, Sébastien Marchand wrote:

[Sébastien Marchand]

Hey, sorry but as mentioned in my reply I was travelling and unable to reply earlier.

It looks like the script is using the 32-bit build of pgomgr.exe, is should be using the x64 one. Which version of the toolchain are you using?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/443e63c5-53dc-43f1-80e1-3d445833716d%40chromium.org.

--

Sébastien Marchand | Software Developer | sebma...@google.com 

[Cai Huan]

i use 64 bit pgosweep.exe to run benchmark and using 64 bit pgomgr.exe to merge pgc files

[Cai Huan]

i add configs += [ "//build/config/compiler/pgo:default_pgo_flags" ] to chrome/BUILD.gn

pgo for chrome_child.dll is ok~but chrome.dll post error

[Daniel Bratell]

I don't have any specifics for this error but I know that pgomgr has bad error handling so there might be something wrong with  chrome!45.pgc. Maybe you can investigate that file.

/Daniel

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/134e01d0-a250-4702-b4e4-f5af1d3555cc%40chromium.org.

--

/* Opera Software, Linköping, Sweden: CET (UTC+1) */

[Cai Huan]

thanks   :)

[Sébastien Marchand]

Hey,

note that PGO is only supported for chrome_child.dll , there's no guarantee that it'll work for chrome.dll.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/fc643ee3-e13b-4fec-9f4b-99586426e69f%40chromium.org.

[Cai Huan]

thank you very much. : )

i wanna making chrome faster by chrome.dll pgo but it looks like mistake

[Cai Huan]

https://connect.microsoft.com/VisualStudio/feedback/details/831502/pgomg-exe-stack-overflow-when-trying-to-merge-pgc-files

i find you posted chrome.dll pgo bug three years ago and this problem will be fixed in the next update   (´･ω･｀)

[Sébastien Marchand]

It was for a different issue, this was a stack overflow in pgomgr.exe directly, in this case it's an issue with the profile database (the pgc and pgd files).

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/ec39d877-a36c-441a-a880-c68686b7374b%40chromium.org.

[Daniel Bratell]

I have done such experiments and it had no big impact. Opera is structured differently so our PGO optimizes a bit more code than Chrome does, but the majority of heavy processing is done in the renderers so optimizing anything else has only a small impact.

The browser process is also a bit tricky to PGO-optimize correctly because it's by design mostly idle. It is easy for PGO to get the impression that no code matter (and it might be mostly right).

So if you can get PGO working on chrome_child.dll it should be good enough.

/Daniel

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/54a84ef6-a9d1-4067-8746-b20182d22797%40chromium.org.

[Cai Huan]

thanks :)