[LNA] Turn on LNA split permissions by default. [chromium/src : main]
0 views
Skip to first unread message
Chris Thompson (Gerrit)
Jan 8, 2026, 12:11:24 PM (3 days ago) Jan 8
to Hubert Chao, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao
Chris Thompson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Jan 8, 2026, 12:14:15 PM (3 days ago) Jan 8
to Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Rick Byers and mmenke
Hubert Chao added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Hubert Chao . resolved
@mme...@chromium.org for services/network/public/cpp/features.cc
@rby...@chromium.org for third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
Related details
Attention is currently required from:
- Rick Byers
- mmenke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
mmenke (Gerrit)
Jan 8, 2026, 12:20:41 PM (3 days ago) Jan 8
to Hubert Chao, Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao and Rick Byers
mmenke voted and added 1 comment![]( "Open in Gerrit")
Votes added by mmenke
| Code-Review | +1 |
1 comment
Patchset-level comments
mmenke . resolved
services/network/public/cpp/features.cc LGTM, didn't look at anything else.
Related details
Attention is currently required from:
- Hubert Chao
- Rick Byers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rick Byers (Gerrit)
Jan 8, 2026, 2:32:41 PM (3 days ago) Jan 8
to Hubert Chao, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao
Rick Byers added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
Line 58, Patchset 8 (Latest):
loopback-networkRick Byers . unresolved
This is a new web-exposed API so it needs a spec, WPTs etc. before we can ship it to stable. I don't see it mentioned in the spec yet, right? https://wicg.github.io/local-network-access/#integration-with-permissions-policy I think you'll need to get an I2S approved before we make it enabled by default.
Related details
Attention is currently required from:
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Jan 9, 2026, 10:05:24 AM (2 days ago) Jan 9
to Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Rick Byers
Hubert Chao added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
Line 58, Patchset 8 (Latest):
loopback-networkRick Byers . resolved
This is a new web-exposed API so it needs a spec, WPTs etc. before we can ship it to stable. I don't see it mentioned in the spec yet, right? https://wicg.github.io/local-network-access/#integration-with-permissions-policy I think you'll need to get an I2S approved before we make it enabled by default.
Attention is currently required from:
- Rick Byers
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rick Byers (Gerrit)
Jan 9, 2026, 11:00:43 AM (2 days ago) Jan 9
to Hubert Chao, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Attention needed from Hubert Chao
Rick Byers voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rick Byers
| Code-Review | +1 |
2 comments
Patchset-level comments
Rick Byers . resolved
.../virtual/stable/webexposed/ LGTM with nit
Commit Message
Line 10, Patchset 8 (Latest):
doc at go/split-lna-permission-ddRick Byers . unresolved
Nit
```suggestion
doc at go/split-lna-permission-dd
Approved I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Zl3P6NHhMBw
```
Related details
Attention is currently required from:
- Hubert Chao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Jan 9, 2026, 11:03:17 AM (2 days ago) Jan 9
to Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Hubert Chao added 1 comment![]( "Open in Gerrit")
Commit Message
Nit
```suggestion
doc at go/split-lna-permission-dd
Approved I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Zl3P6NHhMBw
```
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hubert Chao (Gerrit)
Jan 9, 2026, 11:03:22 AM (2 days ago) Jan 9
to Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Hubert Chao voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 11:30:12 AM (2 days ago) Jan 9
to Hubert Chao, Rick Byers, Chris Thompson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/57109.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 12:18:19 PM (2 days ago) Jan 9
to Hubert Chao, Blink W3C Test Autoroller, Rick Byers, Chris Thompson, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
8 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[LNA] Turn on LNA split permissions by default.
Changing LNA to use split permissions through waterfall launch. Design
doc at go/split-lna-permission-dd
Approved I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Zl3P6NHhMBw
Change-Id: Ib7d140d00f349c003855336a3e22321dbdc07e6f
Bug: 465491626
Reviewed-by: mmenke <mme...@chromium.org>
Reviewed-by: Chris Thompson <cth...@chromium.org>
Reviewed-by: Rick Byers <rby...@chromium.org>
Commit-Queue: Hubert Chao <hc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566992}
Files:
- M chrome/browser/local_network_access/local_network_access_iframe_browsertest.cc
- M chrome/browser/local_network_access/local_network_access_split_permission_browsertest.cc
- M services/network/public/cpp/features.cc
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/iframe.tentative.https.window.js
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/resources/fetch-local-http.html
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/resources/fetch-local.html
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/resources/fetch-public-http-wrong-address-space.html
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/resources/iframer.html
- M third_party/blink/web_tests/external/wpt/fetch/local-network-access/resources/support.sub.js
- M third_party/blink/web_tests/virtual/stable/webexposed/feature-policy-features-expected.txt
- M third_party/blink/web_tests/webexposed/feature-policy-features-expected.txt
- M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy-stable/permissions_policy.https.html
- M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html
Change size: M
Delta: 13 files changed, 67 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by mmenke, +1 by Rick Byers, +1 by Chris Thompson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jan 9, 2026, 12:51:28 PM (2 days ago) Jan 9
to Chromium LUCI CQ, Hubert Chao, Rick Byers, Chris Thompson, AyeAye, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, network-ser...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/57109
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages