PSA: wtf/ is dead, long live platform/wtf/!

104 views
Skip to first unread message

Yuta Kitamura

unread,
Mar 27, 2017, 5:10:01 AM3/27/17
to blink-dev, Kentaro Hara
Hi Blink devs,


I'm happy to announce that all the code of wtf/ has been moved to platform/wtf/, and there are only forwarding headers left in wtf/ now. 

I would like to start replacing all the existing #include "wtf/XXX.h" to #include "platform/wtf/XXX.h" this week. Along with this change, I'll run clang-format on all affected files, and this will make those files conform to Chromium-style #include order (#include <XXX> first, then #include "YYY"). See also Nico's previous announcement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/w0b63ZHuxgo/t3YnK9PtBQAJ

You don't have to manually update the existing #include lines. I'll rewrite all the existing references, so don't worry about them. You may receive code reviews, though :)

If you introduce a new #include to a WTF header, please be sure to use the new directory: i.e. #include "platform/wtf/XXX.h". I'm planning to place a DEPS rule in each Blink module to forbid including the old directory, after the conversion is done.

If there's any concern about this plan, please let me know ASAP. Thanks for your cooperation!

Thanks,
Yuta

Nico Weber

unread,
Mar 27, 2017, 8:04:45 AM3/27/17
to Yuta Kitamura, Kentaro Hara, blink-dev
Sounds good. Note that you can (and should) just run `git cl format` after running sed (or whatever you'll use to update the include lines) -- then only include blocks will be reformatted and you won't get unrelated formatting changes.

Yuta Kitamura

unread,
Mar 28, 2017, 5:07:13 AM3/28/17
to blink-dev, Kentaro Hara
Hi all,

Let me (regrettably) announce that my last change moving the WTF files got reverted, and some headers are currently missing in platform/wtf.

Most of the headers are already present in platform/wtf/, so you should be able to #include most of WTF headers with the new path ("platform/wtf/XXX.h"). If you see an error regarding nonexistent include path, use the old path ("wtf/XXX.h") in the meantime.

Sorry for the hassle,

Yuta

Yuta Kitamura

unread,
Mar 31, 2017, 6:05:50 AM3/31/17
to blink-dev, Kentaro Hara
On Tue, Mar 28, 2017 at 6:06 PM, Yuta Kitamura <yu...@chromium.org> wrote:
Hi all,

Let me (regrettably) announce that my last change moving the WTF files got reverted, and some headers are currently missing in platform/wtf.

Most of the headers are already present in platform/wtf/, so you should be able to #include most of WTF headers with the new path ("platform/wtf/XXX.h"). If you see an error regarding nonexistent include path, use the old path ("wtf/XXX.h") in the meantime.

I have relanded all the reverted changes. If it sticks, I'll start rewriting the existing #include lines next week.

Thank you for your patience!
Reply all
Reply to author
Forward
0 new messages