Olivier Tilloy
unread,Oct 5, 2020, 10:19:03 AM10/5/20Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Sign in to report message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to chromium-packagers
Hi chromium packagers,
With the promotion of 87.0.4278.0 to the dev channel, linux builds
switched to PGO (from AFDO). When building offline from a source
tarball, the build fails early because profile data (*.profdata) files
cannot be found:
ERROR at //build/config/compiler/pgo/BUILD.gn:58:35: Script returned
non-zero exit code.
pgo_data_path = rebase_path(exec_script("//tools/update_pgo_profiles.py",
^----------
Current dir: <BUILDDIR>/out/argtest/
Command: python <BUILDDIR>/tools/update_pgo_profiles.py --target linux
get_profile_path
Returned 1.
stderr:
Traceback (most recent call last):
File "<BUILDDIR>/tools/update_pgo_profiles.py", line 154, in <module>
sys.exit(main())
File "<BUILDDIR>/tools/update_pgo_profiles.py", line 150, in main
return args.func(args)
File "<BUILDDIR>/tools/update_pgo_profiles.py", line 122, in _get_profile_path
profile_path)
RuntimeError: requested profile
"<BUILDDIR>/chrome/build/pgo_profiles/chrome-linux-master-1601358844-b8defbe977309018021c72a700e18c84f94d16d4.profdata"
doesn't exist, please make sure "checkout_pgo_profiles" is set to True
in the "custom_vars" section of your .gclient file, e.g.:
solutions = [
{
"name": "src",
# ...
"custom_vars": {
"checkout_pgo_profiles": True,
},
},
],
and then run "gclient runhooks" to download it. You can also simply
disable the PGO optimizations by setting |chrome_pgo_phase = 0| in
your GN arguments.
See //build/config/BUILDCONFIG.gn:335:3: which caused the file to be included.
"//build/config/compiler/pgo:default_pgo_flags",
^----------------------------------------------
I'm wondering if *.profdata files missing from the source tarball is
intentional, or an oversight?
Thanks,
Olivier