Move core/layout/style to core/style (issue 1045723009 by dstockwell@chromium.org)

dstoc...@chromium.org

unread,

Mar 31, 2015, 2:52:39 AM3/31/15

to tim...@chromium.org, jchaf...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org, esp...@chromium.org, ru...@opera.com

Reviewers: Timothy Loh, Julien Chaffraix - PST,

Description:
Move core/layout/style to core/style

As proposed[1] by jchaffraix@ on blink-dev.

[1]
https://groups.google.com/a/chromium.org/d/msg/blink-dev/0x7LO7FUh4c/Q05CN47_ku8J

Please review this at https://codereview.chromium.org/1045723009/

Base URL: svn://svn.chromium.org/blink/trunk

Affected files (+431, -14453 lines):
M Source/core/animation/ShadowStyleInterpolation.h
M Source/core/animation/StringKeyframe.cpp
M Source/core/animation/animatable/AnimatableImage.h
M Source/core/animation/animatable/AnimatableImage.cpp
M Source/core/animation/animatable/AnimatableSVGPaint.h
M Source/core/animation/animatable/AnimatableShadow.h
M Source/core/animation/animatable/AnimatableShapeValue.h
M Source/core/animation/animatable/AnimatableStrokeDasharrayList.h
M Source/core/animation/animatable/AnimatableStrokeDasharrayListTest.cpp
M Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp
M Source/core/animation/animatable/AnimatableVisibility.h
M Source/core/animation/css/CSSAnimatableValueFactory.cpp
M Source/core/animation/css/CSSAnimationData.h
M Source/core/animation/css/CSSAnimations.cpp
M Source/core/animation/css/CSSPropertyEquality.cpp
M Source/core/core.gypi
M Source/core/css/BasicShapeFunctions.h
M Source/core/css/BasicShapeFunctions.cpp
M Source/core/css/CSSCalculationValueTest.cpp
M Source/core/css/CSSComputedStyleDeclaration.h
M Source/core/css/CSSComputedStyleDeclaration.cpp
M Source/core/css/CSSCrossfadeValue.cpp
M Source/core/css/CSSCursorImageValue.cpp
M Source/core/css/CSSGridTemplateAreasValue.h
M Source/core/css/CSSImageSetValue.cpp
M Source/core/css/CSSImageValue.cpp
M Source/core/css/CSSMatrix.cpp
M Source/core/css/CSSPrimitiveValue.cpp
M Source/core/css/CSSPrimitiveValueMappings.h
M Source/core/css/CSSProperty.cpp
M Source/core/css/CSSSelector.h
M Source/core/css/CSSToLengthConversionData.cpp
M Source/core/css/CSSValuePool.cpp
M Source/core/css/ComputedStyleCSSValueMapping.cpp
M Source/core/css/ElementRuleCollector.cpp
M Source/core/css/FontFaceSet.cpp
M Source/core/css/MediaQueryEvaluator.cpp
M Source/core/css/MediaValues.cpp
M Source/core/css/PseudoStyleRequest.h
M Source/core/css/SelectorChecker.cpp
M Source/core/css/SiblingTraversalStrategies.h
M Source/core/css/parser/CSSPropertyParser.cpp
M Source/core/css/resolver/AnimatedStyleBuilder.cpp
M Source/core/css/resolver/CSSToStyleMap.h
M Source/core/css/resolver/CSSToStyleMap.cpp
M Source/core/css/resolver/ElementResolveContext.h
M Source/core/css/resolver/ElementStyleResources.cpp
M Source/core/css/resolver/FontBuilderTest.cpp
M Source/core/css/resolver/MatchedPropertiesCache.cpp
M Source/core/css/resolver/SharedStyleFinder.cpp
M Source/core/css/resolver/StyleAdjuster.cpp
M Source/core/css/resolver/StyleBuilderConverter.h
M Source/core/css/resolver/StyleBuilderCustom.cpp
M Source/core/css/resolver/StyleResolver.h
M Source/core/css/resolver/StyleResolver.cpp
M Source/core/css/resolver/StyleResolverState.h
M Source/core/css/resolver/StyleResourceLoader.cpp
M Source/core/dom/CSSSelectorWatch.cpp
M Source/core/dom/ElementRareData.h
M Source/core/dom/ElementRareData.cpp
M Source/core/dom/Node.h
M Source/core/dom/NodeComputedStyle.h
M Source/core/dom/PseudoElement.h
M Source/core/dom/PseudoElement.cpp
M Source/core/dom/VisitedLinkState.h
M Source/core/editing/ApplyBlockElementCommand.cpp
M Source/core/editing/EditingStyle.cpp
M Source/core/editing/SimplifyMarkupCommand.cpp
M Source/core/frame/FrameView.cpp
M Source/core/html/HTMLDialogElement.cpp
M Source/core/html/HTMLLinkElement.cpp
M Source/core/html/HTMLTitleElement.cpp
M Source/core/html/shadow/DateTimeEditElement.cpp
M Source/core/inspector/InspectorDOMAgent.h
M Source/core/inspector/InspectorHighlight.cpp
M Source/core/layout/ClipPathOperation.h
M Source/core/layout/LayoutBlock.h
M Source/core/layout/LayoutBlock.cpp
M Source/core/layout/LayoutBlockFlow.h
M Source/core/layout/LayoutBox.cpp
M Source/core/layout/LayoutBoxModelObject.h
M Source/core/layout/LayoutBoxModelObject.cpp
M Source/core/layout/LayoutCounter.h
M Source/core/layout/LayoutCounter.cpp
M Source/core/layout/LayoutFlexibleBox.cpp
M Source/core/layout/LayoutFullScreen.h
M Source/core/layout/LayoutGrid.h
M Source/core/layout/LayoutGrid.cpp
M Source/core/layout/LayoutImageResource.h
M Source/core/layout/LayoutImageResourceStyleImage.h
M Source/core/layout/LayoutImageResourceStyleImage.cpp
M Source/core/layout/LayoutInline.cpp
M Source/core/layout/LayoutObject.h
M Source/core/layout/LayoutObject.cpp
M Source/core/layout/LayoutObjectChildList.cpp
M Source/core/layout/LayoutQuote.h
M Source/core/layout/LayoutRuby.cpp
M Source/core/layout/LayoutScrollbar.h
M Source/core/layout/LayoutSliderThumb.cpp
M Source/core/layout/LayoutTable.h
M Source/core/layout/LayoutTable.cpp
M Source/core/layout/LayoutTableCell.cpp
M Source/core/layout/LayoutTableRow.cpp
M Source/core/layout/LayoutTheme.cpp
M Source/core/layout/LayoutThemeMac.mm
M Source/core/layout/LayoutThemeTest.cpp
M Source/core/layout/PointerEventsHitRules.h
M Source/core/layout/TextRunConstructor.cpp
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
M Source/core/layout/line/EllipsisBox.cpp
M Source/core/layout/line/InlineFlowBox.h
M Source/core/layout/line/InlineFlowBox.cpp
M Source/core/layout/shapes/Shape.h
M Source/core/layout/shapes/Shape.cpp
M Source/core/layout/shapes/ShapeOutsideInfo.h
D Source/core/layout/style/AppliedTextDecoration.h
D Source/core/layout/style/AppliedTextDecoration.cpp
D Source/core/layout/style/AuthorStyleInfo.h
D Source/core/layout/style/BasicShapes.h
D Source/core/layout/style/BasicShapes.cpp
D Source/core/layout/style/BorderData.h
D Source/core/layout/style/BorderEdge.h
D Source/core/layout/style/BorderEdge.cpp
D Source/core/layout/style/BorderImageLength.h
D Source/core/layout/style/BorderImageLengthBox.h
D Source/core/layout/style/BorderValue.h
D Source/core/layout/style/CachedUAStyle.h
D Source/core/layout/style/CollapsedBorderValue.h
D Source/core/layout/style/ComputedStyle.h
D Source/core/layout/style/ComputedStyle.cpp
D Source/core/layout/style/ComputedStyleConstants.h
D Source/core/layout/style/ComputedStyleTest.cpp
D Source/core/layout/style/ContentData.h
D Source/core/layout/style/ContentData.cpp
D Source/core/layout/style/CounterContent.h
D Source/core/layout/style/CounterDirectives.h
D Source/core/layout/style/CounterDirectives.cpp
D Source/core/layout/style/CursorData.h
D Source/core/layout/style/DataEquivalency.h
D Source/core/layout/style/DataRef.h
D Source/core/layout/style/FillLayer.h
D Source/core/layout/style/FillLayer.cpp
D Source/core/layout/style/GridCoordinate.h
D Source/core/layout/style/GridLength.h
D Source/core/layout/style/GridPosition.h
D Source/core/layout/style/GridResolvedPosition.h
D Source/core/layout/style/GridResolvedPosition.cpp
D Source/core/layout/style/GridTrackSize.h
D Source/core/layout/style/KeyframeList.h
D Source/core/layout/style/KeyframeList.cpp
D Source/core/layout/style/LineClampValue.h
D Source/core/layout/style/NinePieceImage.h
D Source/core/layout/style/NinePieceImage.cpp
D Source/core/layout/style/OutlineValue.h
D Source/core/layout/style/OutlineValueTest.cpp
D Source/core/layout/style/PathStyleMotionPath.h
D Source/core/layout/style/PathStyleMotionPath.cpp
D Source/core/layout/style/QuotesData.h
D Source/core/layout/style/QuotesData.cpp
D Source/core/layout/style/SVGComputedStyle.h
D Source/core/layout/style/SVGComputedStyle.cpp
D Source/core/layout/style/SVGComputedStyleDefs.h
D Source/core/layout/style/SVGComputedStyleDefs.cpp
D Source/core/layout/style/SVGComputedStyleTest.cpp
D Source/core/layout/style/ShadowData.h
D Source/core/layout/style/ShadowData.cpp
D Source/core/layout/style/ShadowList.h
D Source/core/layout/style/ShadowList.cpp
D Source/core/layout/style/ShapeValue.h
D Source/core/layout/style/StyleBackgroundData.h
D Source/core/layout/style/StyleBackgroundData.cpp
D Source/core/layout/style/StyleBoxData.h
D Source/core/layout/style/StyleBoxData.cpp
D Source/core/layout/style/StyleDeprecatedFlexibleBoxData.h
D Source/core/layout/style/StyleDeprecatedFlexibleBoxData.cpp
D Source/core/layout/style/StyleDifference.h
D Source/core/layout/style/StyleFetchedImage.h
D Source/core/layout/style/StyleFetchedImage.cpp
D Source/core/layout/style/StyleFetchedImageSet.h
D Source/core/layout/style/StyleFetchedImageSet.cpp
D Source/core/layout/style/StyleFilterData.h
D Source/core/layout/style/StyleFilterData.cpp
D Source/core/layout/style/StyleFlexibleBoxData.h
D Source/core/layout/style/StyleFlexibleBoxData.cpp
D Source/core/layout/style/StyleGeneratedImage.h
D Source/core/layout/style/StyleGeneratedImage.cpp
D Source/core/layout/style/StyleGridData.h
D Source/core/layout/style/StyleGridData.cpp
D Source/core/layout/style/StyleGridItemData.h
D Source/core/layout/style/StyleGridItemData.cpp
D Source/core/layout/style/StyleImage.h
D Source/core/layout/style/StyleInheritedData.h
D Source/core/layout/style/StyleInheritedData.cpp
D Source/core/layout/style/StyleMotionData.h
D Source/core/layout/style/StyleMotionData.cpp
D Source/core/layout/style/StyleMotionPath.h
D Source/core/layout/style/StyleMultiColData.h
D Source/core/layout/style/StyleMultiColData.cpp
D Source/core/layout/style/StylePendingImage.h
D Source/core/layout/style/StyleRareInheritedData.h
[[ 155 additional files ]]

tim...@chromium.org

unread,

Mar 31, 2015, 3:03:58 AM3/31/15

to dstoc...@chromium.org, jchaf...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+svgw...@chromium.org, pdr+renderi...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org, esp...@chromium.org, ru...@opera.com

rs-lgtm

https://codereview.chromium.org/1045723009/

jchaf...@chromium.org

unread,

Mar 31, 2015, 12:42:31 PM3/31/15

to dstoc...@chromium.org, tim...@chromium.org, dpr...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, dstoc...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

Awesome! lgtm.

+Dirk for Tools/ RS

https://codereview.chromium.org/1045723009/diff/1/Source/core/style/StyleGeneratedImage.h
File Source/core/style/StyleGeneratedImage.h (right):

https://codereview.chromium.org/1045723009/diff/1/Source/core/style/StyleGeneratedImage.h#newcode25
Source/core/style/StyleGeneratedImage.h:25: #define
StyleGeneratedImage_h
Do we want to rename this (and similar classes in core/style/) to
ComputedStyleGeneratedImage? (I would argue yes for consistency)

https://codereview.chromium.org/1045723009/

dpr...@chromium.org

unread,

Mar 31, 2015, 1:33:36 PM3/31/15

to dstoc...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, dstoc...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

lgtm

https://codereview.chromium.org/1045723009/

dstoc...@chromium.org

unread,

Mar 31, 2015, 6:20:53 PM3/31/15

to dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

+tkent for Source/web

https://codereview.chromium.org/1045723009/

p...@chromium.org

unread,

Mar 31, 2015, 6:38:49 PM3/31/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

On 2015/03/31 at 22:20:53, dstockwell wrote:
> +tkent for Source/web

Source/web LGTM!

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Mar 31, 2015, 6:52:42 PM3/31/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1045723009/1

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Mar 31, 2015, 7:06:38 PM3/31/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:
blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30185)

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Mar 31, 2015, 9:22:21 PM3/31/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/patch-status/1045723009/20001

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Apr 1, 2015, 2:54:46 AM4/1/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:

mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/49882)

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Apr 1, 2015, 2:58:41 AM4/1/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

commi...@chromium.org

unread,

Apr 1, 2015, 5:52:29 AM4/1/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

Try jobs failed on following builders:
mac_blink_rel on tryserver.blink (JOB_FAILED,

http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/49955)

https://codereview.chromium.org/1045723009/

commi...@chromium.org

unread,

Apr 1, 2015, 5:55:06 AM4/1/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

commi...@chromium.org

unread,

Apr 1, 2015, 7:20:49 AM4/1/15

to dstoc...@chromium.org, dpr...@chromium.org, jchaf...@chromium.org, tim...@chromium.org, tk...@chromium.org, dstoc...@chromium.org, aandre...@chromium.org, abox...@chromium.org, alexis...@intel.com, apavlo...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, caseq...@chromium.org, devtools...@chromium.org, dglazko...@chromium.org, dmaz...@chromium.org, dominik....@intel.com, dongseo...@intel.com, dsch...@chromium.org, eae+bli...@chromium.org, ed+bli...@opera.com, ericwi...@chromium.org, esp...@chromium.org, fma...@chromium.org, f...@opera.com, gavinp+p...@chromium.org, gyuyou...@webkit.org, jchaffraix...@chromium.org, je_jul...@samsung.com, jfern...@igalia.com, kenneth.ch...@gmail.com, kouhe...@chromium.org, kozyatins...@chromium.org, leviw+re...@chromium.org, loislo...@chromium.org, lushnik...@chromium.org, malch...@chromium.org, mikel...@chromium.org, nek...@chromium.org, pdr+renderi...@chromium.org, pdr+svgw...@chromium.org, pfeldma...@chromium.org, re...@igalia.com, rjwr...@chromium.org, rob....@samsung.com, ru...@opera.com, sche...@chromium.org, sergey...@chromium.org, sh...@chromium.org, sigb...@opera.com, slimming-pa...@chromium.org, steve...@chromium.org, svi...@igalia.com, tim...@chromium.org, yo...@yoav.ws, yurys...@chromium.org, zol...@webkit.org

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192919

https://codereview.chromium.org/1045723009/

Reply all

Reply to author

Forward