Renaming LayoutStyle (formerly RenderStyle) to ComputedStyle

[Douglas Stockwell]

As part of the render to layout rename, RenderStyle was renamed to LayoutStyle. This name is unfortunate as the instances contain more than just layout information.

After talking with several people who work in style we've come to the conclusion that ComputedStyle is a more appropriate name. Unless there is further bikeshedding or concerns I'll go ahead with another rename.

- Doug

[Emil A Eklund]

SGTM

[Elliott Sprehn]

+1

On Tue, Mar 24, 2015 at 4:24 PM, Douglas Stockwell <dstoc...@chromium.org> wrote:

[Levi Weintraub]

I like it. Can you make it papayawhip?

[Christian Biesinger]

That's so much clearer!

-christian

[Chris Harrelson]

Nice.

To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+...@chromium.org.

[Kouhei Ueno]

+1

Wow. So much understandable!

--

Kouhei Ueno

[Julien Chaffraix]

>>> > As part of the render to layout rename, RenderStyle was renamed to
>>> > LayoutStyle. This name is unfortunate as the instances contain more
>>> > than
>>> > just layout information.
>>> >
>>> > After talking with several people who work in style we've come to the
>>> > conclusion that ComputedStyle is a more appropriate name. Unless there
>>> > is
>>> > further bikeshedding or concerns I'll go ahead with another rename.

The renaming makes sense. Thanks for following up on that.

We could also use this opportunity to move the class to a better
location: layout/style doesn't seem like the good home for
ComputedStyle. css/style/ would work or just style/. I have a slight
preference for style/ but either directories can be argued reasonably.

And if we want to stretch the change even further, we could add a
class comment about what it does for good measure.

Julien