logdog breaks stdio links in buildbot emails, see: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120

10 views
Skip to first unread message

Nico Weber

unread,
Mar 13, 2017, 9:04:45 PM3/13/17
to infr...@chromium.org
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?

---------- Forwarded message ----------
From: <buil...@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-d...@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gateke...@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-de...@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org


http://build.chromium.org/p/chromium/waterfall

Automatically closing tree for "compile" on "Android"

http://build.chromium.org/p/chromium/builders/Android/builds/69617

Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6
Blame list: bugs...@chromium.org,caseq@chromium.org,catapult-deps-rol...@chromium.org,dbeam@chromium.org,dcheng@chromium.org,dgo...@chromium.org,dimu@google.com,dmazzoni@chromium.org,eostr...@chromium.org,esec...@chromium.org,gmanikpure...@chromium.org,gogag2@gmail.com,hs121...@samsung.com,ikilpat...@chromium.org,jamescook...@chromium.org,jrummell@chromium.org,klausw@chromium.org,mar...@mwiacek.com,mcasas@chromium.org,michaeldo@chromium.org,mlamouri@chromium.org,nacl-deps-roller@chromium.org,ortuno@chromium.org,pdfium-deps-roller@chromium.org,qyearsley@chromium.org,tfarina@chromium.org,tha...@chromium.org,wangxian...@chromium.org,ynovikov@chromium.org

Build 69617
running steps via annotated script
preamble
stdio
update_scripts<br>git - d7eb0898521e651b149e493293be7ddb6c3a5975
stdio
gclient_json
LogDog Bootstrap
stdio
setup_build<br>running recipe: "chromium"
stdio
run_recipe
makedirs checkout path
stdio
python.inline
bot_update<br>[85GB/492GB used (17%)]
stdio
json.output
ensure_goma
stdio
ensure_goma.ensure_installed
stdio
json.output
swarming.py --version<br>0.8.10
stdio
rmtree clobber
stdio
gclient runhooks
stdio
get compile targets for scripts
stdio
json.output
read test spec (chromium.json)<br>path: /b/c/b/Android/src/testing/buildbot/chromium.json
stdio
json.output
cleanup_temp
stdio
clean local files
stdio
python.inline
tree truth steps
stdio
generate_build_files
stdio
calculate the number of recommended jobs
stdio
preprocess_for_goma
stdio
preprocess_for_goma.makedirs goma cache directory
stdio
python.inline
preprocess_for_goma.start_goma
stdio
preprocess_for_goma.start cloudtail
stdio
compile
stdio
postprocess_for_goma
stdio
postprocess_for_goma.goma_jsonstatus
stdio
json.output (invalid)
postprocess_for_goma.write_jsonstatus
stdio
postprocess_for_goma.goma_stat
stdio
postprocess_for_goma.stop_goma
stdio
postprocess_for_goma.upload_log
stdio
postprocess_for_goma.stop cloudtail
stdio
Uncaught Exception<br>Uncaught Exception: AssertionError()
stdio
exception
Failure reason
stdio
reason

Changed by: gmani...@chromium.org
Changed at: Mon 13 Mar 2017 15:55:48
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045
Changed files:

  • chrome/test/chromedriver/test/test_expectations
Comments: 
[Chromedriver] Re-enable tests on Android HEAD.

BUG=chromedriver:922

Review-Url: https://codereview.chromium.org/2748843002
Cr-Commit-Position: refs/heads/master@{#456520}
Properties:
  • git_revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045

Changed by: qyea...@chromium.org
Changed at: Mon 13 Mar 2017 15:57:24
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 98e6d4474ac2dbe5ff3305c47833c241fa937a42
Changed files:

  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.png
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/border-vertical-lr-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-lr-text-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/writing-mode/japanese-rl-text-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.png
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/border-vertical-lr-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-lr-text-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac-retina/fast/writing-mode/japanese-rl-text-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-vertical-lr-expected.png
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/border-vertical-lr-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-lr-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-lr-text-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-rl-selection-expected.txt
  • third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/japanese-rl-text-expected.txt
Comments: 
Rebaseline writing-mode tests for Mac10.12.

TBR=eae
TBR_REASON=sheriff, getting builder green again
BUG=700898

Review-Url: https://codereview.chromium.org/2750473004
Cr-Commit-Position: refs/heads/master@{#456521}
Properties:
  • git_revision: 98e6d4474ac2dbe5ff3305c47833c241fa937a42

Changed by: kla...@chromium.org
Changed at: Mon 13 Mar 2017 15:58:45
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482
Changed files:

  • third_party/WebKit/Source/modules/vr/VRDisplay.cpp
Comments: 
Apply sanity check for accelerated rendering unconditionally.

We want this check in production builds also, not just debug.

BUG=698643

Review-Url: https://codereview.chromium.org/2747903002
Cr-Commit-Position: refs/heads/master@{#456522}
Properties:
  • git_revision: 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482

Changed by: tfa...@chromium.org
Changed at: Mon 13 Mar 2017 16:00:46
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 2376acd53cf462a35e9330fe298590d02ea084f9
Changed files:

  • chrome/app/theme/default_100_percent/common/allowed_fullscreen.png
  • chrome/app/theme/default_100_percent/common/allowed_mouse_cursor.png
  • chrome/app/theme/default_100_percent/common/blocked_mouse_cursor.png
  • chrome/app/theme/default_100_percent/common/close_1_mask.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom_left.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_bottom_right.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_center.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_left.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_right.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top_left.png
  • chrome/app/theme/default_100_percent/common/supervised_user_theme/label_bg_top_right.png
  • chrome/app/theme/default_100_percent/cros/limited_user.png
  • chrome/app/theme/default_100_percent/legacy/avatar_menu_child.png
  • chrome/app/theme/default_100_percent/legacy/avatar_menu_legacy_supervised.png
  • chrome/app/theme/default_100_percent/legacy/avatar_menu_lock.png
  • chrome/app/theme/default_100_percent/legacy/chevron.png
  • chrome/app/theme/default_100_percent/legacy/icon_legacy_supervised.png
  • chrome/app/theme/default_100_percent/legacy/keyword_search_magnifier.png
  • chrome/app/theme/default_100_percent/legacy/tab_audio_indicator.png
  • chrome/app/theme/default_100_percent/legacy/tab_audio_muting_indicator.png
  • chrome/app/theme/default_100_percent/legacy/tab_bluetooth_indicator.png
  • chrome/app/theme/default_100_percent/legacy/tab_capture_indicator.png
  • chrome/app/theme/default_100_percent/legacy/tab_usb_indicator.png
  • chrome/app/theme/default_100_percent/legacy/translate_active.png
  • chrome/app/theme/default_100_percent/legacy/zoom_minus.png
  • chrome/app/theme/default_100_percent/legacy/zoom_plus.png
  • chrome/app/theme/default_100_percent/legacy/zoom_reset.png
  • chrome/app/theme/default_200_percent/common/allowed_fullscreen.png
  • chrome/app/theme/default_200_percent/common/allowed_mouse_cursor.png
  • chrome/app/theme/default_200_percent/common/blocked_mouse_cursor.png
  • chrome/app/theme/default_200_percent/common/close_1_mask.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom_left.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_bottom_right.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_center.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_left.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_right.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top_left.png
  • chrome/app/theme/default_200_percent/common/supervised_user_theme/label_bg_top_right.png
  • chrome/app/theme/default_200_percent/cros/limited_user.png
  • chrome/app/theme/default_200_percent/legacy/avatar_menu_child.png
  • chrome/app/theme/default_200_percent/legacy/avatar_menu_legacy_supervised.png
  • chrome/app/theme/default_200_percent/legacy/avatar_menu_lock.png
  • chrome/app/theme/default_200_percent/legacy/chevron.png
  • chrome/app/theme/default_200_percent/legacy/icon_legacy_supervised.png
  • chrome/app/theme/default_200_percent/legacy/keyword_search_magnifier.png
  • chrome/app/theme/default_200_percent/legacy/tab_audio_indicator.png
  • chrome/app/theme/default_200_percent/legacy/tab_audio_muting_indicator.png
  • chrome/app/theme/default_200_percent/legacy/tab_bluetooth_indicator.png
  • chrome/app/theme/default_200_percent/legacy/tab_capture_indicator.png
  • chrome/app/theme/default_200_percent/legacy/tab_usb_indicator.png
  • chrome/app/theme/default_200_percent/legacy/translate_active.png
  • chrome/app/theme/default_200_percent/legacy/zoom_minus.png
  • chrome/app/theme/default_200_percent/legacy/zoom_plus.png
  • chrome/app/theme/default_200_percent/legacy/zoom_reset.png
  • chrome/app/theme/theme_resources.grd
Comments: 
chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG=686270
R=pkas...@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2743543005
Cr-Commit-Position: refs/heads/master@{#456523}
Properties:
  • git_revision: 2376acd53cf462a35e9330fe298590d02ea084f9

Changed by: mlam...@chromium.org
Changed at: Mon 13 Mar 2017 16:05:14
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 554a52a54cc66abb2e1555180ec87df11c1709ae
Changed files:

  • third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt
  • third_party/WebKit/Source/core/css/CSSSelector.cpp
  • third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
  • third_party/WebKit/Source/core/frame/Deprecation.cpp
  • third_party/WebKit/Source/core/frame/UseCounter.h
Comments: 
Remove -internals-media-controls-cast-button as web exposed CSS selector.

It has been deprecated since M57 and the usage is fairly low.

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5145TSF3FJM/aAqhKuuXAgAJ

BUG=678285
R=joc...@chromium.org

Review-Url: https://codereview.chromium.org/2734093003
Cr-Commit-Position: refs/heads/master@{#456524}
Properties:
  • git_revision: 554a52a54cc66abb2e1555180ec87df11c1709ae

Changed by: tha...@chromium.org
Changed at: Mon 13 Mar 2017 16:06:58
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 7f118188c140989c8a633c60d531b4c08eef8564
Changed files:

  • build/config/ui.gni
  • cc/BUILD.gn
  • cc/output/vulkan_in_process_context_provider.cc
  • cc/output/vulkan_in_process_context_provider.h
  • cc/surfaces/BUILD.gn
  • cc/surfaces/display.cc
  • content/browser/BUILD.gn
  • content/browser/browser_main_loop.cc
  • content/browser/compositor/gpu_process_transport_factory.cc
  • content/browser/renderer_host/compositor_impl_android.cc
  • content/browser/renderer_host/compositor_impl_android.h
  • content/gpu/BUILD.gn
  • gpu/vulkan/BUILD.gn
  • gpu/vulkan/features.gni
Comments: 
Remove enable_vulkan from build/config, and move it to the buildflag_header system.

No intended behavior change.

TBR=avi
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744973002
Cr-Commit-Position: refs/heads/master@{#456525}
Properties:
  • git_revision: 7f118188c140989c8a633c60d531b4c08eef8564

Changed by: dmaz...@chromium.org
Changed at: Mon 13 Mar 2017 16:08:23
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 0b7c2e87280792050cf2a6ec569f1cb02056c7e5
Changed files:

  • ui/views/accessibility/ax_window_obj_wrapper.cc
  • ui/views/accessibility/ax_window_obj_wrapper.h
Comments: 
Update automation API when aura window bounds changes.

This fixes an issue in Switch Access where the bounds of objects were
incorrect after moving or resizing a window.

BUG=593885

Review-Url: https://codereview.chromium.org/2745213002
Cr-Commit-Position: refs/heads/master@{#456526}
Properties:
  • git_revision: 0b7c2e87280792050cf2a6ec569f1cb02056c7e5

Changed by: catapult-deps-roller@chromium.org
Changed at: Mon 13 Mar 2017 16:09:45
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9
Changed files:

  • DEPS
Comments: 
Roll src/third_party/catapult/ ae1fc136b..1ec68b3ec (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae1fc136b4a3..1ec68b3ec601

$ git log ae1fc136b..1ec68b3ec --date=short --no-merges --format='%ad %ae %s'
2017-03-13 simonhatch If the properties dict specifies improvement_direction, then there's no need to check the units direction since it'll be overwritten below.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2746253002
Cr-Commit-Position: refs/heads/master@{#456527}
Properties:
  • git_revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9

Changed by: esec...@chromium.org
Changed at: Mon 13 Mar 2017 16:11:06
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: d4b3ea55a73c7053a9591e1c0c6fba6e85e166da
Changed files:

  • cc/trees/layer_tree_host_unittest.cc
Comments: 
[cc] Fix LayerTreeHostTestBeginFrameSequenceNumbers flakiness.

DrawLayersOnThread and DisplayReceivedCompositorFrameOnThread were being
called for the second commit during shutdown of the test after EndTest(),
causing the expectations within to fail. Added early outs.

Also, DrawLayersOnThread is called after the draw has completed and,
thus, after the compositor frame was submitted. Fixed the expected
ordering in the test.

BUG=699640
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2738183002
Cr-Commit-Position: refs/heads/master@{#456528}
Properties:
  • git_revision: d4b3ea55a73c7053a9591e1c0c6fba6e85e166da

Changed by: jrum...@chromium.org
Changed at: Mon 13 Mar 2017 16:12:28
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: d708846d788809f0cc8bbaae7794f5349844fe1c
Changed files:

  • chrome/BUILD.gn
  • chrome/installer/linux/BUILD.gn
  • chrome/installer/linux/common/installer.include
  • third_party/widevine/cdm/BUILD.gn
Comments: 
Remove the Widevine signature files from the Linux and ChromeOS builds

BUG=684878,687320

Review-Url: https://codereview.chromium.org/2743433002
Cr-Commit-Position: refs/heads/master@{#456529}
Properties:
  • git_revision: d708846d788809f0cc8bbaae7794f5349844fe1c

Changed by: gog...@gmail.com
Changed at: Mon 13 Mar 2017 16:13:55
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: f77572d8707409ac0c7721ded9c575873e50698d
Changed files:

  • chromecast/browser/url_request_context_factory.cc
  • chromecast/media/cma/test/mock_frame_consumer.cc
  • chromecast/media/cma/test/mock_frame_provider.cc
Comments: 
Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chromecast/

BUG=644626

Review-Url: https://codereview.chromium.org/2745053002
Cr-Commit-Position: refs/heads/master@{#456530}
Properties:
  • git_revision: f77572d8707409ac0c7721ded9c575873e50698d

Changed by: jrum...@chromium.org
Changed at: Mon 13 Mar 2017 16:15:24
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 9f45b4f6264852e04eae4ff5a018f8ecd692b85e
Changed files:

  • media/mojo/BUILD.gn
  • media/mojo/clients/mojo_decryptor.cc
  • media/mojo/clients/mojo_decryptor.h
  • media/mojo/clients/mojo_decryptor_unittest.cc
  • media/mojo/interfaces/decryptor.mojom
  • media/mojo/interfaces/media_types.mojom
  • media/mojo/services/mojo_decryptor_service.cc
  • media/mojo/services/mojo_decryptor_service.h
Comments: 
media: Free shared video buffers after use

Change the way shared video buffers are freed by using an int to
identify the buffer rather than the shared buffer object.

BUG=641115
TEST=new test passes

Review-Url: https://codereview.chromium.org/2316843002
Cr-Commit-Position: refs/heads/master@{#456531}
Properties:
  • git_revision: 9f45b4f6264852e04eae4ff5a018f8ecd692b85e

Changed by: dch...@chromium.org
Changed at: Mon 13 Mar 2017 16:16:56
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 53b1dc5e2d6c84871013249b7e037375bb26ec70
Changed files:

  • third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
  • third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp
  • third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
  • third_party/WebKit/Source/bindings/core/v8/V8Binding.h
  • third_party/WebKit/Source/bindings/core/v8/V8DOMActivityLogger.cpp
  • third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp
  • third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.cpp
  • third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
  • third_party/WebKit/Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp
  • third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
  • third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
  • third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
Comments: 
Make V8Binding helpers return LocalFrame/LocalDOMWindow as appropriate

BUG=694179

Review-Url: https://codereview.chromium.org/2723973002
Cr-Commit-Position: refs/heads/master@{#456532}
Properties:
  • git_revision: 53b1dc5e2d6c84871013249b7e037375bb26ec70

Changed by: dgo...@chromium.org
Changed at: Mon 13 Mar 2017 16:18:13
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: d700fe9d7e86d51c112f2525a8d18261ffe4c855
Changed files:

  • third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
  • third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
  • third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
Comments: 
[DevTools] Reverse dependency between RuntimeModel and ConsoleModel

This is in preparation to extracting ConsoleModel out of SDK and
turning it into ConsoleView's presentation model.

BUG=none

Review-Url: https://codereview.chromium.org/2747663002
Cr-Commit-Position: refs/heads/master@{#456533}
Properties:
  • git_revision: d700fe9d7e86d51c112f2525a8d18261ffe4c855

Changed by: wangx...@chromium.org
Changed at: Mon 13 Mar 2017 16:19:31
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 1d2582b92877456a786a0f3b483dc8080c322fdf
Changed files:

  • third_party/WebKit/LayoutTests/TestExpectations
Comments: 
Remove Timeout expectations on mac10.9 for crashes

crbug.com/644303 seems to have been fixed. harness-tests/crash.html
no longer times out on mac10.9:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=harness-tests%2Fcrash.html

BUG=644303

Review-Url: https://codereview.chromium.org/2744243003
Cr-Commit-Position: refs/heads/master@{#456534}
Properties:
  • git_revision: 1d2582b92877456a786a0f3b483dc8080c322fdf

Changed by: eostr...@chromium.org
Changed at: Mon 13 Mar 2017 16:20:46
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 712524e1b297823b7f50ba08ebb4397b7a781253
Changed files:

  • third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
  • third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
Comments: 
[DevTools] Clear session storage

BUG=633970

Review-Url: https://codereview.chromium.org/2748693003
Cr-Commit-Position: refs/heads/master@{#456535}
Properties:
  • git_revision: 712524e1b297823b7f50ba08ebb4397b7a781253

Changed by: mlam...@chromium.org
Changed at: Mon 13 Mar 2017 16:22:22
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82
Changed files:

  • content/child/BUILD.gn
  • content/child/blink_platform_impl.cc
  • content/child/blink_platform_impl.h
  • media/blink/BUILD.gn
  • media/blink/webmediacapabilitiesclient_impl.cc
  • media/blink/webmediacapabilitiesclient_impl.h
  • third_party/WebKit/Source/modules/media_capabilities/AudioConfiguration.idl
  • third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
  • third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp
  • third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h
  • third_party/WebKit/public/platform/DEPS
  • third_party/WebKit/public/platform/Platform.h
  • third_party/WebKit/public/platform/modules/media_capabilities/OWNERS
  • third_party/WebKit/public/platform/modules/media_capabilities/WebAudioConfiguration.h
  • third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesClient.h
  • third_party/WebKit/public/platform/modules/media_capabilities/WebMediaConfiguration.h
  • third_party/WebKit/public/platform/modules/media_capabilities/WebMediaDecodingAbility.h
  • third_party/WebKit/public/platform/modules/media_capabilities/WebVideoConfiguration.h
Comments: 
Media Capabilities: add plumbing between Blink and media/blink/.

So much yummy plumbing! :)

Also fixing a typo in an IDL.

BUG=690380
R=chcunn...@chromium.org

Review-Url: https://codereview.chromium.org/2706313002
Cr-Commit-Position: refs/heads/master@{#456536}
Properties:
  • git_revision: fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82

Changed by: mca...@chromium.org
Changed at: Mon 13 Mar 2017 16:23:45
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed
Changed files:

  • media/capture/video/linux/v4l2_capture_delegate.cc
  • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
Comments: 
Image Capture: skip more PAN/TILT controls, including non-standard

Seems like I missed a bunch of PAN/TILT related controls.
This CL skips all PAN/TILT controls, including non-standard
ones that are defined on the spot.

BUG=697885

Review-Url: https://codereview.chromium.org/2744333002
Cr-Commit-Position: refs/heads/master@{#456537}
Properties:
  • git_revision: d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed

Changed by: mar...@mwiacek.com
Changed at: Mon 13 Mar 2017 16:25:10
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: c7cf8d3d4cd241e004853f89c5de4bdd42e27b21
Changed files:

  • components/location/android/java/src/org/chromium/components/location/LocationUtils.java
Comments: 
Remove warning for LOCATION_PROVIDER_ALLOWED

Used in code for Android before KITKAT, deprecated from API level 19, silenced with SupressWarnings.

Review-Url: https://codereview.chromium.org/2747823003
Cr-Commit-Position: refs/heads/master@{#456538}
Properties:
  • git_revision: c7cf8d3d4cd241e004853f89c5de4bdd42e27b21

Changed by: pdfium-deps-roller@chromium.org
Changed at: Mon 13 Mar 2017 16:26:31
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: ead4ab4ffb0784d727e827d901d708b38a1cefe1
Changed files:

  • DEPS
Comments: 
Roll src/third_party/pdfium/ 9818dc150..4ca5ba4de (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/9818dc150132..4ca5ba4dec65

$ git log 9818dc150..4ca5ba4de --date=short --no-merges --format='%ad %ae %s'
2017-03-13 npm Fix boundary value negation in bmp_read_header
2017-03-13 dsinclair Add utf-8 flag to win build.
2017-03-10 thestig Make most PDFium code pass Clang plugin's auto raw check.
2017-03-13 npm Fix some nits in fx_codec_fax
2017-03-13 npm Check run lengths in FaxG4GetRow

Created with:
  roll-dep src/third_party/pdfium
BUG=628559,699340

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsin...@chromium.org

Review-Url: https://codereview.chromium.org/2749553004
Cr-Commit-Position: refs/heads/master@{#456539}
Properties:
  • git_revision: ead4ab4ffb0784d727e827d901d708b38a1cefe1

Changed by: jame...@chromium.org
Changed at: Mon 13 Mar 2017 16:27:52
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 063733f75d45987b9db79b3e423603908bb558d0
Changed files:

  • ash/common/session/session_controller.cc
  • ash/common/session/session_controller.h
  • ash/common/session/session_controller_unittest.cc
  • ash/common/wm_shell.cc
  • ash/mus/system_tray_delegate_mus.cc
  • ash/mus/system_tray_delegate_mus.h
  • ash/shell.h
Comments: 
mash: Update LoginStatus with session state updates

In classic ash, chrome calls WmShell::UpdateUserLoginStatus() directly,
which updates the appearance of the system tray menu, status area
notifications icon, etc.

Fix mash so it updates LoginStatus as well so that the system tray menu
works more similarly to classic ash. (For example, it now hides the
notifications icon during oobe, hides the "sign out" item in the system
tray menu at the login screen, etc.)

BUG=699234,648964
TEST=added to ash_unittests SessionControllerTest

Review-Url: https://codereview.chromium.org/2741403004
Cr-Commit-Position: refs/heads/master@{#456540}
Properties:
  • git_revision: 063733f75d45987b9db79b3e423603908bb558d0

Changed by: ca...@chromium.org
Changed at: Mon 13 Mar 2017 16:29:23
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 97f425de047bcfa18633635370133d3eab7ee460
Changed files:

  • third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html
  • third_party/WebKit/LayoutTests/inspector/coverage/gutter-css.html
  • third_party/WebKit/LayoutTests/inspector/coverage/gutter-js.html
  • third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge-expected.txt
  • third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html
  • third_party/WebKit/LayoutTests/inspector/coverage/resources/subframe.html
  • third_party/WebKit/LayoutTests/inspector/coverage/segments-merge-expected.txt
  • third_party/WebKit/LayoutTests/inspector/coverage/segments-merge.html
  • third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
  • third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
  • third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
Comments: 
DevTools: merge coverage segments from different instances of same URL

This fixes a problem where for multiple occurrences of a resource with same
URL (a stylesheet or script reused in multiple frames) coverage stats were
just added together rather than being properly merged.

Review-Url: https://codereview.chromium.org/2745283002
Cr-Commit-Position: refs/heads/master@{#456541}
Properties:
  • git_revision: 97f425de047bcfa18633635370133d3eab7ee460

Changed by: ort...@chromium.org
Changed at: Mon 13 Mar 2017 16:31:35
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 7fbc5775e114cdb9715c0ddebecec53d86d0b768
Changed files:

  • chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
  • extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc
  • extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h
Comments: 
extensions: Dispatch event when characteristic value is read.

chrome.bluetoothLowEnergy states that a "onCharacteristicValueChanged"[1] shall be
"Fired when the value of a remote GATT characteristic changes, either as a
result of a read request, or a value change notification/indication"

The onCharacteristicValueChanged event was being fired whenever
BluetoothAdapterObserver::CharacteristicValueChanged was being called, which was
as a result of a read request or when a notification/indication arrived.

http://crrev.com/2728623004 changed device/bluetooth to no longer
call CharacteristicValueChanged after a successful read characteristic request
only for a notification/indication.

To avoid changing the behavior on Chrome Apps we call CharacteristicValueChanged
in the callback for the read request.

[1] https://developer.chrome.com/apps/bluetoothLowEnergy#event-onCharacteristicValueChanged

Review-Url: https://codereview.chromium.org/2743243002
Cr-Commit-Position: refs/heads/master@{#456542}
Properties:
  • git_revision: 7fbc5775e114cdb9715c0ddebecec53d86d0b768

Changed by: hs121...@samsung.com
Changed at: Mon 13 Mar 2017 16:34:03
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: b9414864f5480e5f83d24ecb949e60834e388a79
Changed files:

  • third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-quad.html
Comments: 
[GeometryInterface] file name was renamed for consistency with others.

geometry-interface-dom-quad.html -> geometry-interfaces-dom-quad.html

BUG=678237

Review-Url: https://codereview.chromium.org/2734693003
Cr-Commit-Position: refs/heads/master@{#456543}
Properties:
  • git_revision: b9414864f5480e5f83d24ecb949e60834e388a79

Changed by: bugs...@chromium.org
Changed at: Mon 13 Mar 2017 16:36:24
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a
Changed files:

  • third_party/WebKit/Source/core/BUILD.gn
Comments: 
Ordered outputs of css_properties in core/BUILD.gn alphabetically.

Ordered the generated files in the outputs parameter of the
css_properties target of core/BUILD.gn alphabetically.

This makes the file more readable and makes it simpler to add a new
file to the list while avoiding merge conflicts.

BUG=668012

Review-Url: https://codereview.chromium.org/2741913002
Cr-Commit-Position: refs/heads/master@{#456544}
Properties:
  • git_revision: 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a

Changed by: nacl-dep...@chromium.org
Changed at: Mon 13 Mar 2017 16:37:52
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 0d70c836af11f5d8b317be8339062de2caa4d049
Changed files:

  • DEPS
Comments: 
Roll src/native_client/ 62bfd122a..93a51ecd3 (1 commit)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/62bfd122aee8..93a51ecd3c78

$ git log 62bfd122a..93a51ecd3 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 dschuff Update revision for PNaCl

Created with:
  roll-dep src/native_client

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=msea...@chromium.org
BUG=nativeclient:4391

Review-Url: https://codereview.chromium.org/2753433002
Cr-Commit-Position: refs/heads/master@{#456545}
Properties:
  • git_revision: 0d70c836af11f5d8b317be8339062de2caa4d049

Changed by: db...@chromium.org
Changed at: Mon 13 Mar 2017 16:39:09
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: ffcbf762962091fe257f480dec34781b5864b120
Changed files:

  • chrome/browser/resources/settings/controls/settings_toggle_button.html
Comments: 
MD Settings: fix <settings-toggle-button> indent issue

I accidentally switched to -start margin instead of -end because of a
merge conflict between these patch sets:
https://codereview.chromium.org/2743863002/diff2/1:20001/chrome/browser/resources/settings/controls/settings_toggle_button.html

R=dpa...@chromium.org
BUG=none (yet)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751533002
Cr-Commit-Position: refs/heads/master@{#456546}
Properties:
  • git_revision: ffcbf762962091fe257f480dec34781b5864b120

Changed by: mich...@chromium.org
Changed at: Mon 13 Mar 2017 16:40:39
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: fdddcd9f56e18a8a6a484ea25e6385dba5e1c921
Changed files:

Comments: 
Increase timeout for NavigationItem state update.

HistoryStateOperationsTest.StateReplacement and
HistoryStateOperationsTest.StateReplacementBackForward tests are flaky,
failing to complete while waiting for NavigationItem state update.

BUG=684024

Review-Url: https://codereview.chromium.org/2753443002
Cr-Commit-Position: refs/heads/master@{#456547}
Properties:
  • git_revision: fdddcd9f56e18a8a6a484ea25e6385dba5e1c921

Changed by: qyea...@chromium.org
Changed at: Mon 13 Mar 2017 16:43:06
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 23c218f4fca388ba3e348b492cbcb7906d97a377
Changed files:

  • third_party/WebKit/LayoutTests/TestExpectations
Comments: 
Add flaky expectation for inspector-protocol/css/css-get-rule-list.html

TBR=caseq
TBR_REASON=sheriff, trying to make waterfall green again
BUG=700034

Review-Url: https://codereview.chromium.org/2746293002
Cr-Commit-Position: refs/heads/master@{#456548}
Properties:
  • git_revision: 23c218f4fca388ba3e348b492cbcb7906d97a377

Changed by: di...@google.com
Changed at: Mon 13 Mar 2017 16:44:57
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440
Changed files:

  • ash/strings/ash_strings_bg.xtb
  • ash/strings/ash_strings_bn.xtb
  • ash/strings/ash_strings_ca.xtb
  • ash/strings/ash_strings_cs.xtb
  • ash/strings/ash_strings_da.xtb
  • ash/strings/ash_strings_de.xtb
  • ash/strings/ash_strings_el.xtb
  • ash/strings/ash_strings_en-GB.xtb
  • ash/strings/ash_strings_es-419.xtb
  • ash/strings/ash_strings_es.xtb
  • ash/strings/ash_strings_et.xtb
  • ash/strings/ash_strings_fi.xtb
  • ash/strings/ash_strings_fil.xtb
  • ash/strings/ash_strings_fr.xtb
  • ash/strings/ash_strings_hr.xtb
  • ash/strings/ash_strings_hu.xtb
  • ash/strings/ash_strings_id.xtb
  • ash/strings/ash_strings_ja.xtb
  • ash/strings/ash_strings_ko.xtb
  • ash/strings/ash_strings_lt.xtb
  • ash/strings/ash_strings_lv.xtb
  • ash/strings/ash_strings_mr.xtb
  • ash/strings/ash_strings_ms.xtb
  • ash/strings/ash_strings_nl.xtb
  • ash/strings/ash_strings_no.xtb
  • ash/strings/ash_strings_pl.xtb
  • ash/strings/ash_strings_ro.xtb
  • ash/strings/ash_strings_ru.xtb
  • ash/strings/ash_strings_sk.xtb
  • ash/strings/ash_strings_sl.xtb
  • ash/strings/ash_strings_sr.xtb
  • ash/strings/ash_strings_sv.xtb
  • ash/strings/ash_strings_sw.xtb
  • ash/strings/ash_strings_ta.xtb
  • ash/strings/ash_strings_th.xtb
  • ash/strings/ash_strings_tr.xtb
  • ash/strings/ash_strings_zh-CN.xtb
  • ash/strings/ash_strings_zh-TW.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ko.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_no.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ro.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
  • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
  • chrome/app/resources/chromium_strings_am.xtb
  • chrome/app/resources/chromium_strings_ar.xtb
  • chrome/app/resources/chromium_strings_bg.xtb
  • chrome/app/resources/chromium_strings_bn.xtb
  • chrome/app/resources/chromium_strings_ca.xtb
  • chrome/app/resources/chromium_strings_cs.xtb
  • chrome/app/resources/chromium_strings_da.xtb
  • chrome/app/resources/chromium_strings_de.xtb
  • chrome/app/resources/chromium_strings_el.xtb
  • chrome/app/resources/chromium_strings_en-GB.xtb
  • chrome/app/resources/chromium_strings_es-419.xtb
  • chrome/app/resources/chromium_strings_es.xtb
  • chrome/app/resources/chromium_strings_et.xtb
  • chrome/app/resources/chromium_strings_fa.xtb
  • chrome/app/resources/chromium_strings_fi.xtb
  • chrome/app/resources/chromium_strings_fil.xtb
  • chrome/app/resources/chromium_strings_fr.xtb
  • chrome/app/resources/chromium_strings_gu.xtb
  • chrome/app/resources/chromium_strings_hi.xtb
  • chrome/app/resources/chromium_strings_hr.xtb
  • chrome/app/resources/chromium_strings_hu.xtb
  • chrome/app/resources/chromium_strings_id.xtb
  • chrome/app/resources/chromium_strings_it.xtb
  • chrome/app/resources/chromium_strings_iw.xtb
  • chrome/app/resources/chromium_strings_ja.xtb
  • chrome/app/resources/chromium_strings_kn.xtb
  • chrome/app/resources/chromium_strings_ko.xtb
  • chrome/app/resources/chromium_strings_lt.xtb
  • chrome/app/resources/chromium_strings_lv.xtb
  • chrome/app/resources/chromium_strings_ml.xtb
  • chrome/app/resources/chromium_strings_mr.xtb
  • chrome/app/resources/chromium_strings_ms.xtb
  • chrome/app/resources/chromium_strings_nl.xtb
  • chrome/app/resources/chromium_strings_no.xtb
  • chrome/app/resources/chromium_strings_pl.xtb
  • chrome/app/resources/chromium_strings_pt-BR.xtb
  • chrome/app/resources/chromium_strings_pt-PT.xtb
  • chrome/app/resources/chromium_strings_ro.xtb
  • chrome/app/resources/chromium_strings_ru.xtb
  • chrome/app/resources/chromium_strings_sk.xtb
  • chrome/app/resources/chromium_strings_sl.xtb
  • chrome/app/resources/chromium_strings_sr.xtb
  • chrome/app/resources/chromium_strings_sv.xtb
  • chrome/app/resources/chromium_strings_sw.xtb
  • chrome/app/resources/chromium_strings_ta.xtb
  • chrome/app/resources/chromium_strings_te.xtb
  • chrome/app/resources/chromium_strings_th.xtb
  • chrome/app/resources/chromium_strings_tr.xtb
  • chrome/app/resources/chromium_strings_uk.xtb
  • chrome/app/resources/chromium_strings_vi.xtb
  • chrome/app/resources/chromium_strings_zh-CN.xtb
  • chrome/app/resources/chromium_strings_zh-TW.xtb
  • chrome/app/resources/generated_resources_am.xtb
  • chrome/app/resources/generated_resources_ar.xtb
  • chrome/app/resources/generated_resources_bg.xtb
  • chrome/app/resources/generated_resources_bn.xtb
  • chrome/app/resources/generated_resources_ca.xtb
  • chrome/app/resources/generated_resources_cs.xtb
  • chrome/app/resources/generated_resources_da.xtb
  • chrome/app/resources/generated_resources_de.xtb
  • chrome/app/resources/generated_resources_el.xtb
  • chrome/app/resources/generated_resources_en-GB.xtb
  • chrome/app/resources/generated_resources_es-419.xtb
  • chrome/app/resources/generated_resources_es.xtb
  • chrome/app/resources/generated_resources_et.xtb
  • chrome/app/resources/generated_resources_fa.xtb
  • chrome/app/resources/generated_resources_fi.xtb
  • chrome/app/resources/generated_resources_fil.xtb
  • chrome/app/resources/generated_resources_fr.xtb
  • chrome/app/resources/generated_resources_gu.xtb
  • chrome/app/resources/generated_resources_hi.xtb
  • chrome/app/resources/generated_resources_hr.xtb
  • chrome/app/resources/generated_resources_hu.xtb
  • chrome/app/resources/generated_resources_id.xtb
  • chrome/app/resources/generated_resources_it.xtb
  • chrome/app/resources/generated_resources_iw.xtb
  • chrome/app/resources/generated_resources_ja.xtb
  • chrome/app/resources/generated_resources_kn.xtb
  • chrome/app/resources/generated_resources_ko.xtb
  • chrome/app/resources/generated_resources_lt.xtb
  • chrome/app/resources/generated_resources_lv.xtb
  • chrome/app/resources/generated_resources_ml.xtb
  • chrome/app/resources/generated_resources_mr.xtb
  • chrome/app/resources/generated_resources_ms.xtb
  • chrome/app/resources/generated_resources_nl.xtb
  • chrome/app/resources/generated_resources_no.xtb
  • chrome/app/resources/generated_resources_pl.xtb
  • chrome/app/resources/generated_resources_pt-BR.xtb
  • chrome/app/resources/generated_resources_pt-PT.xtb
  • chrome/app/resources/generated_resources_ro.xtb
  • chrome/app/resources/generated_resources_ru.xtb
  • chrome/app/resources/generated_resources_sk.xtb
  • chrome/app/resources/generated_resources_sl.xtb
  • chrome/app/resources/generated_resources_sr.xtb
  • chrome/app/resources/generated_resources_sv.xtb
  • chrome/app/resources/generated_resources_sw.xtb
  • chrome/app/resources/generated_resources_ta.xtb
  • chrome/app/resources/generated_resources_te.xtb
  • chrome/app/resources/generated_resources_th.xtb
  • chrome/app/resources/generated_resources_tr.xtb
  • chrome/app/resources/generated_resources_uk.xtb
  • chrome/app/resources/generated_resources_vi.xtb
  • chrome/app/resources/generated_resources_zh-CN.xtb
  • chrome/app/resources/generated_resources_zh-TW.xtb
  • chrome/app/resources/google_chrome_strings_am.xtb
  • chrome/app/resources/google_chrome_strings_ar.xtb
  • chrome/app/resources/google_chrome_strings_bg.xtb
  • chrome/app/resources/google_chrome_strings_bn.xtb
  • chrome/app/resources/google_chrome_strings_ca.xtb
  • chrome/app/resources/google_chrome_strings_cs.xtb
  • chrome/app/resources/google_chrome_strings_da.xtb
  • chrome/app/resources/google_chrome_strings_de.xtb
  • chrome/app/resources/google_chrome_strings_el.xtb
  • chrome/app/resources/google_chrome_strings_en-GB.xtb
  • chrome/app/resources/google_chrome_strings_es-419.xtb
  • chrome/app/resources/google_chrome_strings_es.xtb
  • chrome/app/resources/google_chrome_strings_et.xtb
  • chrome/app/resources/google_chrome_strings_fa.xtb
  • chrome/app/resources/google_chrome_strings_fi.xtb
  • chrome/app/resources/google_chrome_strings_fil.xtb
  • chrome/app/resources/google_chrome_strings_fr.xtb
  • chrome/app/resources/google_chrome_strings_gu.xtb
  • chrome/app/resources/google_chrome_strings_hi.xtb
  • chrome/app/resources/google_chrome_strings_hr.xtb
  • chrome/app/resources/google_chrome_strings_hu.xtb
  • chrome/app/resources/google_chrome_strings_id.xtb
  • chrome/app/resources/google_chrome_strings_it.xtb
  • chrome/app/resources/google_chrome_strings_iw.xtb
  • chrome/app/resources/google_chrome_strings_ja.xtb
  • chrome/app/resources/google_chrome_strings_kn.xtb
  • chrome/app/resources/google_chrome_strings_ko.xtb
  • chrome/app/resources/google_chrome_strings_lt.xtb
  • chrome/app/resources/google_chrome_strings_lv.xtb
  • chrome/app/resources/google_chrome_strings_ml.xtb
  • chrome/app/resources/google_chrome_strings_mr.xtb
  • chrome/app/resources/google_chrome_strings_ms.xtb
  • chrome/app/resources/google_chrome_strings_nl.xtb
  • chrome/app/resources/google_chrome_strings_no.xtb
  • chrome/app/resources/google_chrome_strings_pl.xtb
  • chrome/app/resources/google_chrome_strings_pt-BR.xtb
  • chrome/app/resources/google_chrome_strings_pt-PT.xtb
  • chrome/app/resources/google_chrome_strings_ro.xtb
  • chrome/app/resources/google_chrome_strings_ru.xtb
  • chrome/app/resources/google_chrome_strings_sk.xtb
  • chrome/app/resources/google_chrome_strings_sl.xtb
  • chrome/app/resources/google_chrome_strings_sr.xtb
  • chrome/app/resources/google_chrome_strings_sv.xtb
  • chrome/app/resources/google_chrome_strings_sw.xtb
  • chrome/app/resources/google_chrome_strings_ta.xtb
  • chrome/app/resources/google_chrome_strings_te.xtb
  • chrome/app/resources/google_chrome_strings_th.xtb
  • chrome/app/resources/google_chrome_strings_tr.xtb
  • chrome/app/resources/google_chrome_strings_uk.xtb
  • chrome/app/resources/google_chrome_strings_vi.xtb
  • chrome/app/resources/google_chrome_strings_zh-CN.xtb
  • chrome/app/resources/google_chrome_strings_zh-TW.xtb
  • components/policy/resources/policy_templates_am.xtb
  • components/policy/resources/policy_templates_ar.xtb
  • components/policy/resources/policy_templates_bg.xtb
  • components/policy/resources/policy_templates_bn.xtb
  • components/policy/resources/policy_templates_ca.xtb
  • components/policy/resources/policy_templates_cs.xtb
  • components/policy/resources/policy_templates_da.xtb
  • components/policy/resources/policy_templates_de.xtb
  • components/policy/resources/policy_templates_el.xtb
  • components/policy/resources/policy_templates_en-GB.xtb
  • components/policy/resources/policy_templates_es-419.xtb
  • components/policy/resources/policy_templates_es.xtb
  • components/policy/resources/policy_templates_et.xtb
  • components/policy/resources/policy_templates_fa.xtb
  • components/policy/resources/policy_templates_fi.xtb
  • components/policy/resources/policy_templates_fil.xtb
  • components/policy/resources/policy_templates_fr.xtb
  • components/policy/resources/policy_templates_gu.xtb
  • components/policy/resources/policy_templates_hi.xtb
  • components/policy/resources/policy_templates_hr.xtb
  • components/policy/resources/policy_templates_hu.xtb
  • components/policy/resources/policy_templates_id.xtb
  • components/policy/resources/policy_templates_it.xtb
  • components/policy/resources/policy_templates_iw.xtb
  • components/policy/resources/policy_templates_ja.xtb
  • components/policy/resources/policy_templates_kn.xtb
  • components/policy/resources/policy_templates_ko.xtb
  • components/policy/resources/policy_templates_lt.xtb
  • components/policy/resources/policy_templates_lv.xtb
  • components/policy/resources/policy_templates_ml.xtb
  • components/policy/resources/policy_templates_mr.xtb
  • components/policy/resources/policy_templates_ms.xtb
  • components/policy/resources/policy_templates_nl.xtb
  • components/policy/resources/policy_templates_no.xtb
  • components/policy/resources/policy_templates_pl.xtb
  • components/policy/resources/policy_templates_pt-BR.xtb
  • components/policy/resources/policy_templates_pt-PT.xtb
  • components/policy/resources/policy_templates_ro.xtb
  • components/policy/resources/policy_templates_ru.xtb
  • components/policy/resources/policy_templates_sk.xtb
  • components/policy/resources/policy_templates_sl.xtb
  • components/policy/resources/policy_templates_sr.xtb
  • components/policy/resources/policy_templates_sv.xtb
  • components/policy/resources/policy_templates_sw.xtb
  • components/policy/resources/policy_templates_ta.xtb
  • components/policy/resources/policy_templates_te.xtb
  • components/policy/resources/policy_templates_th.xtb
  • components/policy/resources/policy_templates_tr.xtb
  • components/policy/resources/policy_templates_uk.xtb
  • components/policy/resources/policy_templates_vi.xtb
  • components/policy/resources/policy_templates_zh-CN.xtb
  • components/policy/resources/policy_templates_zh-TW.xtb
  • components/strings/components_strings_am.xtb
  • components/strings/components_strings_ar.xtb
  • components/strings/components_strings_bg.xtb
  • components/strings/components_strings_bn.xtb
  • components/strings/components_strings_ca.xtb
  • components/strings/components_strings_cs.xtb
  • components/strings/components_strings_da.xtb
  • components/strings/components_strings_de.xtb
  • components/strings/components_strings_el.xtb
  • components/strings/components_strings_en-GB.xtb
  • components/strings/components_strings_es-419.xtb
  • components/strings/components_strings_es.xtb
  • components/strings/components_strings_et.xtb
  • components/strings/components_strings_fa.xtb
  • components/strings/components_strings_fi.xtb
  • components/strings/components_strings_fil.xtb
  • components/strings/components_strings_fr.xtb
  • components/strings/components_strings_gu.xtb
  • components/strings/components_strings_hi.xtb
  • components/strings/components_strings_hr.xtb
  • components/strings/components_strings_hu.xtb
  • components/strings/components_strings_id.xtb
  • components/strings/components_strings_it.xtb
  • components/strings/components_strings_iw.xtb
  • components/strings/components_strings_ja.xtb
  • components/strings/components_strings_kn.xtb
  • components/strings/components_strings_ko.xtb
  • components/strings/components_strings_lt.xtb
  • components/strings/components_strings_lv.xtb
  • components/strings/components_strings_ml.xtb
  • components/strings/components_strings_mr.xtb
  • components/strings/components_strings_ms.xtb
  • components/strings/components_strings_nl.xtb
  • components/strings/components_strings_no.xtb
  • components/strings/components_strings_pl.xtb
  • components/strings/components_strings_pt-BR.xtb
  • components/strings/components_strings_pt-PT.xtb
  • components/strings/components_strings_ro.xtb
  • components/strings/components_strings_ru.xtb
  • components/strings/components_strings_sk.xtb
  • components/strings/components_strings_sl.xtb
  • components/strings/components_strings_sr.xtb
  • components/strings/components_strings_sv.xtb
  • components/strings/components_strings_sw.xtb
  • components/strings/components_strings_ta.xtb
  • components/strings/components_strings_te.xtb
  • components/strings/components_strings_th.xtb
  • components/strings/components_strings_tr.xtb
  • components/strings/components_strings_uk.xtb
  • components/strings/components_strings_vi.xtb
  • components/strings/components_strings_zh-CN.xtb
  • components/strings/components_strings_zh-TW.xtb
  • content/app/strings/translations/content_strings_bg.xtb
  • content/app/strings/translations/content_strings_bn.xtb
  • content/app/strings/translations/content_strings_ca.xtb
  • content/app/strings/translations/content_strings_cs.xtb
  • content/app/strings/translations/content_strings_da.xtb
  • content/app/strings/translations/content_strings_de.xtb
  • content/app/strings/translations/content_strings_el.xtb
  • content/app/strings/translations/content_strings_es-419.xtb
  • content/app/strings/translations/content_strings_es.xtb
  • content/app/strings/translations/content_strings_et.xtb
  • content/app/strings/translations/content_strings_fi.xtb
  • content/app/strings/translations/content_strings_fil.xtb
  • content/app/strings/translations/content_strings_fr.xtb
  • content/app/strings/translations/content_strings_hr.xtb
  • content/app/strings/translations/content_strings_hu.xtb
  • content/app/strings/translations/content_strings_ja.xtb
  • content/app/strings/translations/content_strings_ko.xtb
  • content/app/strings/translations/content_strings_lt.xtb
  • content/app/strings/translations/content_strings_lv.xtb
  • content/app/strings/translations/content_strings_nl.xtb
  • content/app/strings/translations/content_strings_no.xtb
  • content/app/strings/translations/content_strings_ro.xtb
  • content/app/strings/translations/content_strings_ru.xtb
  • content/app/strings/translations/content_strings_sl.xtb
  • content/app/strings/translations/content_strings_sr.xtb
  • content/app/strings/translations/content_strings_sv.xtb
  • content/app/strings/translations/content_strings_ta.xtb
  • content/app/strings/translations/content_strings_th.xtb
  • content/app/strings/translations/content_strings_tr.xtb
  • content/app/strings/translations/content_strings_zh-CN.xtb
  • content/app/strings/translations/content_strings_zh-TW.xtb
  • ios/chrome/app/strings/resources/ios_strings_am.xtb
  • ios/chrome/app/strings/resources/ios_strings_ar.xtb
  • ios/chrome/app/strings/resources/ios_strings_bg.xtb
  • ios/chrome/app/strings/resources/ios_strings_bn.xtb
  • ios/chrome/app/strings/resources/ios_strings_ca.xtb
  • ios/chrome/app/strings/resources/ios_strings_cs.xtb
  • ios/chrome/app/strings/resources/ios_strings_da.xtb
  • ios/chrome/app/strings/resources/ios_strings_de.xtb
  • ios/chrome/app/strings/resources/ios_strings_el.xtb
  • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
  • ios/chrome/app/strings/resources/ios_strings_es-419.xtb
  • ios/chrome/app/strings/resources/ios_strings_es.xtb
  • ios/chrome/app/strings/resources/ios_strings_et.xtb
  • ios/chrome/app/strings/resources/ios_strings_fa.xtb
  • ios/chrome/app/strings/resources/ios_strings_fi.xtb
  • ios/chrome/app/strings/resources/ios_strings_fil.xtb
  • ios/chrome/app/strings/resources/ios_strings_fr.xtb
  • ios/chrome/app/strings/resources/ios_strings_gu.xtb
  • ios/chrome/app/strings/resources/ios_strings_hi.xtb
  • ios/chrome/app/strings/resources/ios_strings_hr.xtb
  • ios/chrome/app/strings/resources/ios_strings_hu.xtb
  • ios/chrome/app/strings/resources/ios_strings_id.xtb
  • ios/chrome/app/strings/resources/ios_strings_it.xtb
  • ios/chrome/app/strings/resources/ios_strings_iw.xtb
  • ios/chrome/app/strings/resources/ios_strings_ja.xtb
  • ios/chrome/app/strings/resources/ios_strings_kn.xtb
  • ios/chrome/app/strings/resources/ios_strings_ko.xtb
  • ios/chrome/app/strings/resources/ios_strings_lt.xtb
  • ios/chrome/app/strings/resources/ios_strings_lv.xtb
  • ios/chrome/app/strings/resources/ios_strings_ml.xtb
  • ios/chrome/app/strings/resources/ios_strings_mr.xtb
  • ios/chrome/app/strings/resources/ios_strings_ms.xtb
  • ios/chrome/app/strings/resources/ios_strings_nl.xtb
  • ios/chrome/app/strings/resources/ios_strings_no.xtb
  • ios/chrome/app/strings/resources/ios_strings_pl.xtb
  • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
  • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
  • ios/chrome/app/strings/resources/ios_strings_ro.xtb
  • ios/chrome/app/strings/resources/ios_strings_ru.xtb
  • ios/chrome/app/strings/resources/ios_strings_sk.xtb
  • ios/chrome/app/strings/resources/ios_strings_sl.xtb
  • ios/chrome/app/strings/resources/ios_strings_sr.xtb
  • ios/chrome/app/strings/resources/ios_strings_sv.xtb
  • ios/chrome/app/strings/resources/ios_strings_sw.xtb
  • ios/chrome/app/strings/resources/ios_strings_ta.xtb
  • ios/chrome/app/strings/resources/ios_strings_te.xtb
  • ios/chrome/app/strings/resources/ios_strings_th.xtb
  • ios/chrome/app/strings/resources/ios_strings_tr.xtb
  • ios/chrome/app/strings/resources/ios_strings_uk.xtb
  • ios/chrome/app/strings/resources/ios_strings_vi.xtb
  • ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb
  • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
Comments: 
Updating XTBs based on .GRDs from branch master

Cr-Commit-Position: refs/heads/master@{#456549}
Properties:
  • git_revision: 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440

Changed by: ynov...@chromium.org
Changed at: Mon 13 Mar 2017 16:46:54
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: 1aee72cca9f084155d38086325660fed191f2b46
Changed files:

  • content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
Comments: 
Suppress a WebGL2 failing test on Linux AMD R7 240

conformance2/textures/image_bitmap_from_video/
tex-2d-rgba16f-rgba-half_float.html

BUG=701138
TBR=k...@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2748883002
Cr-Commit-Position: refs/heads/master@{#456550}
Properties:
  • git_revision: 1aee72cca9f084155d38086325660fed191f2b46

Changed by: eostr...@chromium.org
Changed at: Mon 13 Mar 2017 16:48:55
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: c3cb4770dc953564b29c9bedb5f80f02f71a950c
Changed files:

  • third_party/WebKit/Source/devtools/front_end/ui/toolbar.css
Comments: 
[DevTools] Do not clip text for multi-line toolbar

BUG=696460

Review-Url: https://codereview.chromium.org/2751563002
Cr-Commit-Position: refs/heads/master@{#456551}
Properties:
  • git_revision: c3cb4770dc953564b29c9bedb5f80f02f71a950c

Changed by: ikilp...@chromium.org
Changed at: Mon 13 Mar 2017 16:50:32
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: ef24cecdfa9a5b06f294a3d0913cbdf326607bd6
Changed files:

  • third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
Comments: 
[LayoutNG] Remove checks for layout_box_ inside NGBlockNode.

We now always have one, remove branches. Also removed DCHECKs as its DCHECK'd
in the constructor.

BUG=635619

Review-Url: https://codereview.chromium.org/2749643003
Cr-Commit-Position: refs/heads/master@{#456552}
Properties:
  • git_revision: ef24cecdfa9a5b06f294a3d0913cbdf326607bd6


Dirk Pranke

unread,
Mar 13, 2017, 9:41:46 PM3/13/17
to Nico Weber, infr...@chromium.org
There is now:


Thanks for the (second) report of this :).

-- Dirk

On Mon, Mar 13, 2017 at 6:04 PM, Nico Weber <tha...@chromium.org> wrote:
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?
---------- Forwarded message ----------
From: <buildbot@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-deps-roller@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gatekeeper-ng@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-deps-roller@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org


Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6


--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGbLiGt77P5P2gRre%3DrhYoG2s3sN6FusB3Zby3CPDjxgEaJfA%40mail.gmail.com.

Nico Weber

unread,
Mar 27, 2017, 4:53:01 PM3/27/17
to Dirk Pranke, infr...@chromium.org
This is still broken. It's super hard to do anything with "hey you broke the build" emails since one has to manually hunt for the right waterfall page, find the right bot on there, and then find the right build on there -- all while being stressed out about just having broken some build.

On Mon, Mar 13, 2017 at 9:41 PM, Dirk Pranke <dpr...@chromium.org> wrote:
There is now:


Thanks for the (second) report of this :).

-- Dirk
On Mon, Mar 13, 2017 at 6:04 PM, Nico Weber <tha...@chromium.org> wrote:
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?
---------- Forwarded message ----------
From: <buil...@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-deps-roller@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gatekeeper-ng@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-de...@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org


Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6

Erik Staab

unread,
Mar 27, 2017, 5:21:18 PM3/27/17
to Nico Weber, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
Thanks for the reminder, I just posted an update on the bug. dnj@ is working on this and has a CL out to address at least part of it.

On Mon, Mar 27, 2017 at 1:52 PM, Nico Weber <tha...@chromium.org> wrote:
This is still broken. It's super hard to do anything with "hey you broke the build" emails since one has to manually hunt for the right waterfall page, find the right bot on there, and then find the right build on there -- all while being stressed out about just having broken some build.
On Mon, Mar 13, 2017 at 9:41 PM, Dirk Pranke <dpr...@chromium.org> wrote:
There is now:


Thanks for the (second) report of this :).

-- Dirk
On Mon, Mar 13, 2017 at 6:04 PM, Nico Weber <tha...@chromium.org> wrote:
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?
---------- Forwarded message ----------
From: <buil...@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-deps-roller@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gatekeeper-ng@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-de...@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org


Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6

...

[Message clipped]  

Daniel Jacques

unread,
Mar 27, 2017, 5:35:30 PM3/27/17
to Erik Staab, Nico Weber, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
I get that it is annoying to have bad links. Replacing the concept of log links in BuildBot and its data consumers is non-trivial, and will likely take some time and cost/benefit analysis to apply this to everything that has built up around BuildBot over the years.

In the meantime, until a fix is deployed, you can click the "Build #####" at the top of the e-mail and use the BuildBot interface to get to the actual failing log. This seems like a fairly accessible workaround.

On Mon, Mar 27, 2017 at 2:21 PM Erik Staab <est...@chromium.org> wrote:
Thanks for the reminder, I just posted an update on the bug. dnj@ is working on this and has a CL out to address at least part of it.
On Mon, Mar 27, 2017 at 1:52 PM, Nico Weber <tha...@chromium.org> wrote:
This is still broken. It's super hard to do anything with "hey you broke the build" emails since one has to manually hunt for the right waterfall page, find the right bot on there, and then find the right build on there -- all while being stressed out about just having broken some build.
On Mon, Mar 13, 2017 at 9:41 PM, Dirk Pranke <dpr...@chromium.org> wrote:
There is now:


Thanks for the (second) report of this :).

-- Dirk
On Mon, Mar 13, 2017 at 6:04 PM, Nico Weber <tha...@chromium.org> wrote:
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?
---------- Forwarded message ----------
From: <buil...@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-d...@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gateke...@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-de...@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org


Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6

chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG=686270
R=pkas...@chromium.org,s...@chromium.org


Changed at: Mon 13 Mar 2017 16:09:45
Repository: https://chromium.googlesource.com/chromium/src
Branch: master
Revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9
Changed files:

  • DEPS
Comments: 
Roll src/third_party/catapult/ ae1fc136b..1ec68b3ec (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae1fc136b4a3..1ec68b3ec601

$ git log ae1fc136b..1ec68b3ec --date=short --no-merges --format='%ad %ae %s'
2017-03-13 simonhatch If the properties dict specifies improvement_direction, then there's no need to check the units direction since it'll be overwritten below.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:
android_optional_gpu_tests_rel
TBR=catapult...@chromium.org
Nico Weber
unread,
Mar 27, 2017, 5:38:56 PM3/27/17
to Daniel Jacques, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
I tried that on an email I received today and it did not work (" The previous page is sending you to an invalid url (http:///builders/Linux%20Builder%20%28dbg%29/builds/109422).") I can forward you that email if it helps.

On Mon, Mar 27, 2017 at 5:35 PM, Daniel Jacques <d...@google.com> wrote:
I get that it is annoying to have bad links. Replacing the concept of log links in BuildBot and its data consumers is non-trivial, and will likely take some time and cost/benefit analysis to apply this to everything that has built up around BuildBot over the years.

In the meantime, until a fix is deployed, you can click the "Build #####" at the top of the e-mail and use the BuildBot interface to get to the actual failing log. This seems like a fairly accessible workaround.

On Mon, Mar 27, 2017 at 2:21 PM Erik Staab <est...@chromium.org> wrote:
Thanks for the reminder, I just posted an update on the bug. dnj@ is working on this and has a CL out to address at least part of it.
On Mon, Mar 27, 2017 at 1:52 PM, Nico Weber <tha...@chromium.org> wrote:
This is still broken. It's super hard to do anything with "hey you broke the build" emails since one has to manually hunt for the right waterfall page, find the right bot on there, and then find the right build on there -- all while being stressed out about just having broken some build.
On Mon, Mar 13, 2017 at 9:41 PM, Dirk Pranke <dpr...@chromium.org> wrote:
There is now:


Thanks for the (second) report of this :).

-- Dirk
On Mon, Mar 13, 2017 at 6:04 PM, Nico Weber <tha...@chromium.org> wrote:
The "stdio" link for the red compile step points to "LogDog Butler: I/O Keep-alive." instead of to logdog. Is there a bug somewhere for making the emails point to the right place?
---------- Forwarded message ----------
From:  <buildbot@chromium-build.appspotmail.com>
Date: Mon, Mar 13, 2017 at 8:10 PM
Subject: buildbot failure in Chromium on Android, revision ffcbf762962091fe257f480dec34781b5864b120
To: jame...@chromium.org, db...@chromium.org, ort...@chromium.org, gmani...@chromium.org, dch...@chromium.org, kla...@chromium.org, tha...@chromium.org, ynov...@chromium.org, dgo...@chromium.org, catapult-deps-roller@chromium.org, nacl-dep...@chromium.org, mlam...@chromium.org, ca...@chromium.org, gatekeeper-ng@chromium-gatekeeper-sentry.appspotmail.com, eostr...@chromium.org, bugs...@chromium.org, yoi...@google.com, di...@google.com, bcw...@google.com, dmaz...@chromium.org, wangx...@chromium.org, mich...@chromium.org, qyea...@chromium.org, jrum...@chromium.org, qyea...@google.com, blun...@google.com, ikilp...@chromium.org, pdfium-deps-roller@chromium.org, mca...@chromium.org, esec...@chromium.org, tfa...@chromium.org




  
    
  
  

    Revision: c1d42fbf8b87d4cfca9302eebf64f72ba6a23045, 98e6d4474ac2dbe5ff3305c47833c241fa937a42, 35940a6d7e30f4aa3de61eb5dc6a3caace1a1482, 2376acd53cf462a35e9330fe298590d02ea084f9, 554a52a54cc66abb2e1555180ec87df11c1709ae, 7f118188c140989c8a633c60d531b4c08eef8564, 0b7c2e87280792050cf2a6ec569f1cb02056c7e5, f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9, d4b3ea55a73c7053a9591e1c0c6fba6e85e166da, d708846d788809f0cc8bbaae7794f5349844fe1c, f77572d8707409ac0c7721ded9c575873e50698d, 9f45b4f6264852e04eae4ff5a018f8ecd692b85e, 53b1dc5e2d6c84871013249b7e037375bb26ec70, d700fe9d7e86d51c112f2525a8d18261ffe4c855, 1d2582b92877456a786a0f3b483dc8080c322fdf, 712524e1b297823b7f50ba08ebb4397b7a781253, fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82, d28d8e1388fe9ac7201d6ac1d934c4bc599d84ed, c7cf8d3d4cd241e004853f89c5de4bdd42e27b21, ead4ab4ffb0784d727e827d901d708b38a1cefe1, 063733f75d45987b9db79b3e423603908bb558d0, 97f425de047bcfa18633635370133d3eab7ee460, 7fbc5775e114cdb9715c0ddebecec53d86d0b768, b9414864f5480e5f83d24ecb949e60834e388a79, 0b8c6786e4cd01e31ce7d141bfdfb934ec0d886a, 0d70c836af11f5d8b317be8339062de2caa4d049, ffcbf762962091fe257f480dec34781b5864b120, fdddcd9f56e18a8a6a484ea25e6385dba5e1c921, 23c218f4fca388ba3e348b492cbcb7906d97a377, 5ad1d09ff3e95886a6f7f9b30a4dcbd39b109440, 1aee72cca9f084155d38086325660fed191f2b46, c3cb4770dc953564b29c9bedb5f80f02f71a950c, ef24cecdfa9a5b06f294a3d0913cbdf326607bd6
chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG=686270
R=pkas...@chromium.org,sky@chromium.org


    Changed at: Mon 13 Mar 2017 16:09:45

    
      Repository: https://chromium.googlesource.com/chromium/src

    
    
      Branch: master

    
    
      
        Revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9
      
    
    


    Changed files:
    
    
      
        
  • 
          
            DEPS
    • 
      
    


    Comments:
    
Roll src/third_party/catapult/ ae1fc136b..1ec68b3ec (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae1fc136b4a3..1ec68b3ec601

$ git log ae1fc136b..1ec68b3ec --date=short --no-merges --format='%ad %ae %s'
2017-03-13 simonhatch If the properties dict specifies improvement_direction, then there's no need to check the units direction since it'll be overwritten below.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:
android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org
Daniel Jacques
unread,
Mar 27, 2017, 5:40:27 PM3/27/17
to Nico Weber, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
Yeah please do. This works in the forwarded e-mail at the top. No changes, including LogDog, should have invalidated the builder URL, so if that is actually being emitted as invalid, it is an independent and (IMO) far worse bug.

chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG=686270
R=pkas...@chromium.org,s...@chromium.org


    Changed at: Mon 13 Mar 2017 16:09:45

    
      Repository: https://chromium.googlesource.com/chromium/src

    
    
      Branch: master

    
    
      
        Revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9
      
    
    


    Changed files:
    
    
      
        
  • 
          
            DEPS
    • 
      
    


    Comments:
    
Roll src/third_party/catapult/ ae1fc136b..1ec68b3ec (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae1fc136b4a3..1ec68b3ec601

$ git log ae1fc136b..1ec68b3ec --date=short --no-merges --format='%ad %ae %s'
2017-03-13 simonhatch If the properties dict specifies improvement_direction, then there's no need to check the units direction since it'll be overwritten below.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:
android_optional_gpu_tests_rel
TBR=catapult...@chromium.org
Nico Weber
unread,
Mar 27, 2017, 5:41:24 PM3/27/17
to Daniel Jacques, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
Done.

chrome: remove unused assets

Remove unused assets along with their associate IDRs.

BUG=686270
R=pkas...@chromium.org,sky@chromium.org


    Changed at: Mon 13 Mar 2017 16:09:45

    
      Repository: https://chromium.googlesource.com/chromium/src

    
    
      Branch: master

    
    
      
        Revision: f1488a2857a1bbc5d253ea4b926d4241e2bbd6c9
      
    
    


    Changed files:
    
    
      
        
  • 
          
            DEPS
    • 
      
    


    Comments:
    
Roll src/third_party/catapult/ ae1fc136b..1ec68b3ec (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ae1fc136b4a3..1ec68b3ec601

$ git log ae1fc136b..1ec68b3ec --date=short --no-merges --format='%ad %ae %s'
2017-03-13 simonhatch If the properties dict specifies improvement_direction, then there's no need to check the units direction since it'll be overwritten below.

Created with:
  roll-dep src/third_party/catapult

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:
android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org
Daniel Jacques
unread,
Mar 27, 2017, 5:48:20 PM3/27/17
to Nico Weber, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
OK, as I expected, this is a separate and worse bug. Tracking here: https://bugs.chromium.org/p/chromium/issues/detail?id=705701

Done.

Nico Weber
unread,
Mar 30, 2017, 7:51:06 PM3/30/17
to Daniel Jacques, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
Both the original bug and the separate and worse bug are still unfixed. (Guess who broke the build again.)

Done.

Daniel Jacques
unread,
Apr 3, 2017, 12:06:40 PM4/3/17
to Nico Weber, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
Looking into it: while a fix has landed for the initial issue, it has not rolled out yet due to some other independent changes that need to be carefully landed. WRT the bug, that definitely need to be addressed. I'm going to up to P0 for Gatekeeper team.

Done.

Nico Weber
unread,
Apr 20, 2017, 4:18:50 PM4/20/17
to Daniel Jacques, Erik Staab, Dirk Pranke, infr...@chromium.org, d...@chromium.org, Ryan Tseng
The stdout links work now, but clicking the build number is still broken.

Done.

Reply all
Reply to author
Forward
0 new messages