Missing afdo.prof in 68.0.3432.3 tarball

[Olivier Tilloy]

I'm trying to package 68.0.3432.3 from the recently published tarball,
and the build fails early with:

ninja: error: '../../chrome/android/profiles/afdo.prof', needed by
'obj/chrome/chrome_initial.inputs.stamp', missing and no known rule to
make it

AFDO was turned on by default
(https://chromium.googlesource.com/chromium/src/+/b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6)
but it looks like the script to generate the tarball wasn't updated
accordingly to run chrome/android/profiles/update_afdo_profile.py.

Regards,

Olivier

[Tom Anderson]

Thanks, I'm taking a look now.

Could you file a bug for this in the meantime?

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packagers+unsub...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.

[Lei Zhang]

Hopefully easy to fix by just including the AFDO profile.

On Thu, May 17, 2018 at 3:50 PM, 'Tom Anderson' via chromium-packagers
<chromium-...@chromium.org> wrote:
> Thanks, I'm taking a look now.
>
> Could you file a bug for this in the meantime?
>
> On Thu, May 17, 2018 at 3:22 PM, Olivier Tilloy
> <olivier...@canonical.com> wrote:
>>
>> I'm trying to package 68.0.3432.3 from the recently published tarball,
>> and the build fails early with:
>>
>> ninja: error: '../../chrome/android/profiles/afdo.prof', needed by
>> 'obj/chrome/chrome_initial.inputs.stamp', missing and no known rule to
>> make it
>>
>> AFDO was turned on by default
>>
>> (https://chromium.googlesource.com/chromium/src/+/b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6)
>> but it looks like the script to generate the tarball wasn't updated
>> accordingly to run chrome/android/profiles/update_afdo_profile.py.
>>
>> Regards,
>>
>> Olivier
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "chromium-packagers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an

>> email to chromium-packag...@chromium.org.

>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.
>
>

> --
> You received this message because you are subscribed to the Google Groups
> "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to chromium-packag...@chromium.org.

> To view this discussion on the web visit

> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAN2uRqqYUkCwOmdTOgo8hWBK5H%3DsLGjxAB7%2BeKtS80jVKGoHng%40mail.gmail.com.

[George Burgess]

Yeah, if these tarballs are meant to contain everything, then it should be as easy as running chrome/android/profiles/update_afdo_profile.py in the script that Olivier mentioned. Apologies for missing that :)

If someone can point me at it, I'm happy to write a CL.

[Tom Anderson]

Sorry I didn't post back sooner.  The cl is already written

https://chromium-review.googlesource.com/c/infra/infra/+/1065194

The issue was not that update_afdo_profile.py wasn't getting run (it does run as part of gclient runhooks).  It's that the chrome/android directory is pruned before creating the tarballs, so we need to make an exception for afdo.prof

>> email to chromium-packagers+unsub...@chromium.org.

>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to chromium-packagers+unsub...@chromium.org.

[Olivier Tilloy]

On Fri, May 18, 2018 at 3:56 AM, Tom Anderson <thomasa...@google.com> wrote:
> Sorry I didn't post back sooner. The cl is already written
> https://chromium-review.googlesource.com/c/infra/infra/+/1065194

That change was merged 6 days ago, yet the most recent tarball for the
dev channel (68.0.3438.3, published today) is still missing
chrome/android/profiles/afdo.prof.

>>> >> email to chromium-packag...@chromium.org.

>>> >> To view this discussion on the web visit
>>> >>
>>> >> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.
>>> >
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> > Groups
>>> > "chromium-packagers" group.
>>> > To unsubscribe from this group and stop receiving emails from it, send
>>> > an

>>> > email to chromium-packag...@chromium.org.

[George Burgess]

I know ~nothing about Chrome's packaging story, so I'm not sure I can be of much help with fixing that. :/

If this is blocking things, a temporary workaround is to add `clang_use_default_sample_profile = false` to the `gn` args that are being used to build Chromium (or patching build/config/compiler/BUILD.gn to remove `|| is_desktop_linux` from `clang_use_default_sample_profile = ...`). AFDO only exists to help the compiler make better optimization decisions, so this shouldn't result in any functional changes.

[Olivier Tilloy]

On Thu, May 24, 2018 at 11:43 PM, George Burgess <gb...@google.com> wrote:
> I know ~nothing about Chrome's packaging story, so I'm not sure I can be of
> much help with fixing that. :/
>
> If this is blocking things, a temporary workaround is to add
> `clang_use_default_sample_profile = false` to the `gn` args that are being
> used to build Chromium (or patching build/config/compiler/BUILD.gn to remove
> `|| is_desktop_linux` from `clang_use_default_sample_profile = ...`). AFDO
> only exists to help the compiler make better optimization decisions, so this
> shouldn't result in any functional changes.

That's not blocking me as I can unpack the tarball, fetch the profile
and repack it, but something that I think should be addressed as other
packagers will surely run into the same issue.

[Tom Anderson]

Sorry, that other CL was apparently only half of the solution.  Uploaded the other half here

https://chromium-review.googlesource.com/c/infra/infra/+/1072896

Please shout on this thread if it's still broken.  One day we'll get it right :)

>> >>> >> email to chromium-packagers+unsub...@chromium.org.

>> >>> >> To view this discussion on the web visit
>> >>> >>
>> >>> >>
>> >>> >> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.
>> >>> >
>> >>> >
>> >>> > --
>> >>> > You received this message because you are subscribed to the Google
>> >>> > Groups
>> >>> > "chromium-packagers" group.
>> >>> > To unsubscribe from this group and stop receiving emails from it,
>> >>> > send
>> >>> > an

>> >>> > email to chromium-packagers+unsub...@chromium.org.

[Olivier Tilloy]

On Fri, May 25, 2018 at 1:29 AM, Tom Anderson <thomasa...@google.com> wrote:
> Sorry, that other CL was apparently only half of the solution. Uploaded the
> other half here
> https://chromium-review.googlesource.com/c/infra/infra/+/1072896
>
> Please shout on this thread if it's still broken. One day we'll get it
> right :)

The 68.0.3440.7 tarball has afdo.prof. Thanks Tom and everyone
involved in fixing this!

>> >> >>> >> email to chromium-packag...@chromium.org.

>> >> >>> >> To view this discussion on the web visit
>> >> >>> >>
>> >> >>> >>
>> >> >>> >>
>> >> >>> >> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAKyXnk8rn_Hp_yHrWnAGchRuFoszP2uph8UgBBfd2kOV20r09Q%40mail.gmail.com.
>> >> >>> >
>> >> >>> >
>> >> >>> > --
>> >> >>> > You received this message because you are subscribed to the
>> >> >>> > Google
>> >> >>> > Groups
>> >> >>> > "chromium-packagers" group.
>> >> >>> > To unsubscribe from this group and stop receiving emails from it,
>> >> >>> > send
>> >> >>> > an

>> >> >>> > email to chromium-packag...@chromium.org.