setTimeout triggering immediately

[David L]

I am trying to use a setTimeout function in my Options page to show a "saved" box and then have it go away after a few seconds. I've tried the below code and nothing ever happens.

 

function saveOptions() {

// bunch of code here to save the settings

setTimeout( "alert('saved')", 5000); // attempt 1

setTimeout( function() { alert('saved'); }, 5000); // attempt 2

}

[David L]

Sorry, title should be "setTimeout not triggering"

[Abraham Williams]

You are actually executing saveOptions() right? Just pasting it into dev tools console triggers alerts as expected. Are you seeing any errors in the JS console?

Abraham
--
Abraham Williams | abrah.am | abraham+

@abraham | github.com/abraham | blog.abrah.am
This email is: [ ] shareable [x] ask first [ ] private.

On Fri, Jul 6, 2012 at 11:45 AM, David L <ree...@gmail.com> wrote:

Sorry, title should be "setTimeout not triggering"

--
You received this message because you are subscribed to the Google Groups "Chromium-extensions" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msg/chromium-extensions/-/Ey2c0sCxgRgJ.

To post to this group, send email to chromium-...@chromium.org.
To unsubscribe from this group, send email to chromium-extens...@chromium.org.
For more options, visit this group at http://groups.google.com/a/chromium.org/group/chromium-extensions/?hl=en.

[David L]

I actually get the same thing, it worked for me in the dev console also. No errors at all in the console. I think I have found the issue by viewing the Timeline but not sure why it's happening. It appears that the options.html page is actually reloading after I hit the save button. Here is more code, maybe I'm missing something or maybe setting localStorage makes the page reload, not sure.

 

The Javascript: 

function save_options() {

 //save settings code here

 localStorage["setting1"] = "value";

  

 setTimeout( function() { alert('saved'); }, 5000);

}

document.getElementById("save_button").addEventListener("click", save_options, false);

 

 

The HTML Button: 

<button id="save_button"> Save </button> 

[Abraham Williams]

I assume the button is part of a form and causing the page to "submit" to itself. You should be able to cancel the form submit.

Abraham
--
Abraham Williams | abrah.am | abraham+

@abraham | github.com/abraham | blog.abrah.am
This email is: [ ] shareable [x] ask first [ ] private.

--

You received this message because you are subscribed to the Google Groups "Chromium-extensions" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msg/chromium-extensions/-/D5qiANFgGYEJ.

[David L]

Ya, someone emailed me directly and told me about that. All fixed now. Here is the code that fixed the issue. I appreciated everyones help on this :)

 

document.getElementById('settings').addEventListener('submit', function(e) { e.preventDefault(); console.log('capture submit'); }, false); 

[Joshua Woodward]

My extension has an options page, with a save button, i just uploaded the code to github, you can check it out there.

The difference is, I have a div that I place a "saved" message in, not an alert. However I am still using a setTimeout wrapped in a save function to do it.

extension - 

https://chrome.google.com/webstore/detail/efknlbojmfmkpbfoenfidjklbhbbkdih

Code on GitHub-

https://github.com/joshuawoodward/plus1-Coins 

On Fri, Jul 6, 2012 at 12:03 PM, David L <ree...@gmail.com> wrote:

--

You received this message because you are subscribed to the Google Groups "Chromium-extensions" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msg/chromium-extensions/-/D5qiANFgGYEJ.

To post to this group, send email to chromium-...@chromium.org.
To unsubscribe from this group, send email to chromium-extens...@chromium.org.
For more options, visit this group at http://groups.google.com/a/chromium.org/group/chromium-extensions/?hl=en.

--

Joshua Woodward

@howtohtml5

[Joshua Woodward]

Found your bug

The page is not reloading, however the form is being submitted and the default action is itself, so it appears to be reloading

You need to capture the submit event, and have it do nothing, or remove the form tags, I suggest capture the event ;)

the following code will capture the form submit for you.

document.getElementById('settings').addEventListener('submit', function(e) {e.preventDefault(); console.log('capture submit');},false);