Better reporting of call stack overflows - v8-dev

The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Message from discussion Better reporting of call stack overflows
Received-SPF: pass (google.com: domain of yang...@google.com designates 209.85.219.48 as permitted sender) client-ip=209.85.219.48;
MIME-Version: 1.0
Sender: yang...@google.com
In-Reply-To: <CAFSTc_hxQyDHTvu-xLxnzwzynxpo3kpeJN16vR2+jCn7PEp...@mail.gmail.com>
References: <c3991ad5-e4f0-4d15-bec1-161a60dc3303@googlegroups.com>
	<CAFSTc_hxQyDHTvu-xLxnzwzynxpo3kpeJN16vR2+jCn7PEp...@mail.gmail.com>
Date: Mon, 5 Nov 2012 12:37:40 +0100
Message-ID: <CAFSTc_hmBccgTDp1p3mpqGS96BRt1Z5WqvJoFOXatehB13Q...@mail.gmail.com>
Subject: Re: [v8-dev] Better reporting of call stack overflows
From: Yang Guo <yang...@chromium.org>
To: "v8-dev@googlegroups.com" <v8-dev@googlegroups.com>, diz...@singly.com
Content-Type: multipart/alternative; boundary=e89a8fb20592c0a73f04cdbde92d

--e89a8fb20592c0a73f04cdbde92d
Content-Type: text/plain; charset=UTF-8

(previously sent without actually finishing the mail...)

Hi Dave,

I wasn't aware of this problem before. We currently already have redundant
ways to capture stack trace (at throw site and at creation site of the
Error object). I've been wanting to consolidate this, which would also
enable me to solve this issue.

Your current approach has some subtle problems. If you have some patience,
as I will be working on this issue, it will be solved eventually. I'll file
a bug for this.

Yang


On Mon, Nov 5, 2012 at 12:36 PM, Yang Guo <yang...@chromium.org> wrote:

> Hi Dave,
>
> I wasn't aware of this problem before. We currently already have redundant
> ways to capture stack trace (at throw site and at creation site of the
> Error object). I wanted to consolidate those
>
>
> On Sat, Nov 3, 2012 at 4:02 AM, Dave Smith <diz...@singly.com> wrote:
>
>> Hi,
>>
>> I've been using node.js (and hence, v8) for a little bit and one thing
>> that has driven me nuts is the lack of reporting when the call stack
>> overflows. So, in keeping with open source tradition, I've knocked together
>> a (simplistic) patch to fix this specific problem. My patch is here:
>>
>>
>> https://github.com/dizzyd/node/commit/40434019540ffc17e984ff0653500a3c5db87deb.patch
>>
>> (note that it's against the fork of the node codebase, which embeds v8
>> directly).
>>
>> My lack of familiarity with v8 is probably grossly evident, but perhaps
>> someone could provide some direction on improvements if this is an itch
>> bothering other people. :)
>>
>> Thanks!
>>
>> D.
>>
>>
>>
>>
>>  --
>> v8-dev mailing list
>> v8-dev@googlegroups.com
>> http://groups.google.com/group/v8-dev
>
>
>

--e89a8fb20592c0a73f04cdbde92d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div style=3D"font-family: arial, helvetica, sans-serif; font-size: 10pt"><=
div><font face=3D"arial, helvetica, sans-serif">(previously sent without ac=
tually finishing the mail...)</font></div><span style=3D"font-family:arial,=
helvetica,sans-serif;font-size:13px"><div>
<span style=3D"font-family:arial,helvetica,sans-serif;font-size:13px"><br><=
/span></div>Hi Dave,</span><div style=3D"font-family:arial,helvetica,sans-s=
erif;font-size:13px"><br></div><div style=3D"font-family:arial,helvetica,sa=
ns-serif;font-size:13px">
I wasn&#39;t aware of this problem before. We currently already have redund=
ant ways to capture stack trace (at throw site and at creation site of the =
Error object). I&#39;ve been wanting to consolidate this, which would also =
enable me to solve this issue.</div>
<div style=3D"font-family:arial,helvetica,sans-serif;font-size:13px"><br></=
div><div style=3D"font-family:arial,helvetica,sans-serif;font-size:13px">Yo=
ur current approach has some subtle problems. If you have some patience, as=
 I will be working on this issue, it will be solved eventually. I&#39;ll fi=
le a bug for this.</div>
<div style=3D"font-family:arial,helvetica,sans-serif;font-size:13px"><br></=
div><div style=3D"font-family:arial,helvetica,sans-serif;font-size:13px">Ya=
ng</div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Mo=
n, Nov 5, 2012 at 12:36 PM, Yang Guo <span dir=3D"ltr">&lt;<a href=3D"mailt=
o:yang...@chromium.org" target=3D"_blank">yang...@chromium.org</a>&gt;</spa=
n> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div style=3D"font-family:arial,helvetica,sa=
ns-serif;font-size:10pt">Hi Dave,<div><br></div><div>I wasn&#39;t aware of =
this problem before. We currently already have redundant ways to capture st=
ack trace (at throw site and at creation site of the Error object). I wante=
d to consolidate those=C2=A0</div>
<div><div class=3D"h5">
<div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Sat, Nov 3=
, 2012 at 4:02 AM, Dave Smith <span dir=3D"ltr">&lt;<a href=3D"mailto:dizzy=
d...@singly.com" target=3D"_blank">diz...@singly.com</a>&gt;</span> wrote:<br>=
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">

Hi,<div><br></div><div>I&#39;ve been using node.js (and hence, v8) for a li=
ttle bit and one thing that has driven me nuts is the lack of reporting whe=
n the call stack overflows. So, in keeping with open source tradition, I&#3=
9;ve knocked together a (simplistic) patch to fix this specific problem. My=
 patch is here:</div>

<div><br></div><div><a href=3D"https://github.com/dizzyd/node/commit/404340=
19540ffc17e984ff0653500a3c5db87deb.patch" target=3D"_blank">https://github.=
com/dizzyd/node/commit/40434019540ffc17e984ff0653500a3c5db87deb.patch</a><b=
r>

</div><div><br></div><div>(note that it&#39;s against the fork of the node =
codebase, which embeds v8 directly).</div><div><br></div><div>My lack of fa=
miliarity with v8 is probably grossly evident, but perhaps someone could pr=
ovide some direction on improvements if this is an itch bothering other peo=
ple. :)</div>

<div><br></div><div>Thanks!</div><span><font color=3D"#888888"><div><br></d=
iv><div>D.<br><div><br></div><div><br><div><br></div><div><br></div></div><=
/div>

<p></p>

-- <br>
v8-dev mailing list<br>
<a href=3D"mailto:v8-dev@googlegroups.com" target=3D"_blank">v8-dev@googleg=
roups.com</a><br>
<a href=3D"http://groups.google.com/group/v8-dev" target=3D"_blank">http://=
groups.google.com/group/v8-dev</a></font></span></blockquote></div><br></di=
v></div></div></div>
</blockquote></div><br></div></div>

--e89a8fb20592c0a73f04cdbde92d--
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
Account Options
