Feature requests: pick where the temporary file is stored, and a way to put a marker on the sessions list

23 views
Skip to first unread message

Bruno Lopes

unread,
Sep 13, 2011, 5:42:38 AM9/13/11
to nhp...@googlegroups.com
Hi,

Here's my scenario for the temp file request:
I develop with nhprof open to peek at what I'm doing. Sometimes I finish the task and move on, but don't close the profiler.
Since the application does some periodic work, it means that if I forget about NHProf, it ends up storing a 3 ou 4 gb file on my %temp% dir.

Since the %temp% dir exists on the C: drive (which isn't all that big, and doesn't have 10s of GB free) , if it fills up it means that my system drive will become full, which tends to cause more issues and crash the profiler.

I think this may be even more common with SSD drives, since those tend to be even smaller and used for system drives.

Offline profiling might solve part of the issue, but then I would have to keep opening the file and closing and refreshing and whatnot. Not fun.

If I could tell NHProf to place the temp file on a larger, slower drive with more space it wouldn't be so big an issue.
Ideally I'd also tell it to stop capturing if less than X MBs are free.

For the second request:
On some of the apps I'm doing some work that involves several sessions. It may be a workflow or some other kind of multistep scenario.
This means that I run it, look at the sessions, do some changes, run it again and then compare the last batch of sessions to the new batch.

To be able to separate where the previous batch ended and the new started I use the star, which has different semantics and meanings (I also tend to use the stars as "baseline").

My proposed feature would be to be able to add a marker line above or below a session, to serve as a visual reminder. You can see similar behaviours in IRC and IM clients,where a marker tells you the last thing that was written when the application had focus, or could be manually placed.


Ayende Rahien

unread,
Sep 13, 2011, 7:29:10 AM9/13/11
to nhp...@googlegroups.com, Fitzchak Yitzchaki
Bruno,
The temp file size should be limited to a max of 1GB
The other suggestion is great, and we will implement it.



--
You received this message because you are subscribed to the Google Groups "nhprof" group.
To view this discussion on the web visit https://groups.google.com/d/msg/nhprof/-/uN_6w0Z2n_gJ.
To post to this group, send email to nhp...@googlegroups.com.
To unsubscribe from this group, send email to nhprof+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/nhprof?hl=en.

Bruno Lopes

unread,
Sep 14, 2011, 4:37:34 AM9/14/11
to nhp...@googlegroups.com, Fitzchak Yitzchaki
Hum, I'm almost positive I deleted a 3gb file yesterday.
Is it a sparse file (meaning the size windows explorer shows is actually larger than the space it uses)?
I'll try and repeat the issue, and report if I do.

Great on the marker, thanks.

Ayende Rahien

unread,
Sep 14, 2011, 8:11:15 AM9/14/11
to nhp...@googlegroups.com
It wouldn't be, no
What is the file name?
> --
> You received this message because you are subscribed to the Google Groups "nhprof" group.
> To view this discussion on the web visit https://groups.google.com/d/msg/nhprof/-/c1WEsBPZLckJ.

> To post to this group, send email to nhp...@googlegroups.com.
> To unsubscribe from this group, send email to nhprof+un...@googlegroups.com <nhprof%2Bunsu...@googlegroups.com>.

MaggiePlusPlus

unread,
Sep 14, 2011, 9:49:45 AM9/14/11
to nhprof
Ayende,

I reported a previous issue here http://groups.google.com/group/nhprof/browse_thread/thread/31f48c1b3cede928
At that time it was fixed and the large files were deleted when you
closed the app and when you cleared the session. It has worked well
since June until recently. Using current build of 912, once again I
have large temp files building up. On Monday it filled up 46 GB
(about 5 different nhprof sessions) until the system ran out of disk
space.


Maggie

On Sep 14, 8:11 am, Ayende Rahien <aye...@ayende.com> wrote:
> It wouldn't be, no
> What is the file name?
>

Ayende Rahien

unread,
Sep 14, 2011, 10:12:45 AM9/14/11
to nhp...@googlegroups.com
Wow! That certainly shouldn't be the case, I'll look at that.
Traveling, so that might take until next week.

To unsubscribe from this group, send email to nhprof+un...@googlegroups.com.

Fitzchak Yitzchaki

unread,
Sep 19, 2011, 5:48:51 AM9/19/11
to nhp...@googlegroups.com, maggiel...@gmail.com, bruno...@gmail.com
Bruno, Maggie,
I cannot confirm what you're seeing.
When the application is closed or the session is cleared, the temp file is get deleted and a new empty one is created. 
Are you sure that the large file are coming from build #912?
Please take a look on the temp folder and see what happens to the temp file when you close the application.

Bruno,
The other suggestion is implemented and will be out soon in the next build.

MaggiePlusPlus

unread,
Sep 19, 2011, 5:00:13 PM9/19/11
to nhprof

What I observe is when the app is opened there are 2 temp files
created. When you clear the sessions they are both deleted and 2 new
ones are opened. When you close the app it looks like only 1 of the 2
files is being deleted.

yes I'm sure the large files came from build 912.


On Sep 19, 5:48 am, Fitzchak Yitzchaki
<fitzc...@hibernatingrhinos.com> wrote:
> Bruno, Maggie,
> I cannot confirm what you're seeing.
> When the application is closed or the session is cleared, the temp file is
> get deleted and a new empty one is created.
> Are you sure that the large file are coming from build #912?
> Please take a look on the temp folder and see what happens to the temp file
> when you close the application.
>
> Bruno,
> The other suggestion is implemented and will be out soon in the next build.
>
>
>
>
>
>
>
> On Wed, Sep 14, 2011 at 5:12 PM, Ayende Rahien <aye...@ayende.com> wrote:
> > Wow! That certainly shouldn't be the case, I'll look at that.
> > Traveling, so that might take until next week.
>
> > On Wed, Sep 14, 2011 at 3:49 PM, MaggiePlusPlus <maggielongsh...@gmail.com
> > > wrote:
>
> >> Ayende,
>
> >> I reported a previous issue here
> >>http://groups.google.com/group/nhprof/browse_thread/thread/31f48c1b3c...

Ayende Rahien

unread,
Sep 20, 2011, 1:43:27 AM9/20/11
to nhp...@googlegroups.com
Maggie,
What are the file names?

Bruno Lopes

unread,
Sep 20, 2011, 9:56:12 AM9/20/11
to nhp...@googlegroups.com
Hi,
I'm sorry for the delay, but only today I managed to remember a way to replicate this.
I've run our automated tests three times and managed to create a 3gb file on the temp dir and crash NHProf due to the disk filling up.
I've attached the stacktrace. I don't think I managed to report it because there was no space on the temp folder.
Here's a procexp snapshot showing the file used by nhprof and the size.
Since it crashes I need to clean it up afterwards.

nhprof crash stack trace.txt

MaggiePlusPlus

unread,
Sep 20, 2011, 9:29:19 PM9/20/11
to nhprof
I'll send some exact file names tomorrow from work; from memory they
are patterned something like tempxxxx.tmp where xxxx is alphanumeric.
I have opened the files in ultraedit and I can see that they have
nhprof namespaces/class names at the beginning than contain session
data, stack info, etc.

I installed 914 today and I observed the same thing - when I "clear"
the sessions 2 files are deleted; 2 new ones created. When I close
the application - 1 file deletes and 1 remains. They have been
anywhere from 50MB to 22GB in size but are typically 1-2 GB.

On Sep 20, 1:43 am, Ayende Rahien <aye...@ayende.com> wrote:
> Maggie,
> What are the file names?
>
> On Tue, Sep 20, 2011 at 12:00 AM, MaggiePlusPlus
> <maggielongsh...@gmail.com>wrote:

Fitzchak Yitzchaki

unread,
Sep 21, 2011, 8:39:40 AM9/21/11
to nhp...@googlegroups.com
Thanks for the info.
The size of the one of the files isn't limited, as it contains the processed data of the profiler. We made sure that from now on both of the files will be cleared on app exits.  
Will it help to have the option to store the file to different location (instead the temp folder)?

Bruno Lopes

unread,
Sep 21, 2011, 8:57:39 AM9/21/11
to nhp...@googlegroups.com, Fitzchak Yitzchaki
Hey,
To me it would help, as I can place it in a disk with more space and if it fills up it isn't as bad as running out of space on c: :)

Fitzchak Yitzchaki

unread,
Sep 21, 2011, 9:43:47 AM9/21/11
to Bruno Lopes, nhp...@googlegroups.com
ok, we'll implement it :)

Bruno Lopes

unread,
Sep 21, 2011, 9:44:58 AM9/21/11
to Fitzchak Yitzchaki, nhp...@googlegroups.com
Thanks! You're awesome :)

MaggiePlusPlus

unread,
Sep 21, 2011, 11:44:48 AM9/21/11
to nhprof
Thanks!

On Sep 21, 8:39 am, Fitzchak Yitzchaki
<fitzc...@hibernatingrhinos.com> wrote:
> Thanks for the info.
> The size of the one of the files isn't limited, as it contains the processed
> data of the profiler. We made sure that from now on both of the files will
> be cleared on app exits.
> Will it help to have the option to store the file to different location
> (instead the temp folder)?
>
> On Wed, Sep 21, 2011 at 4:29 AM, MaggiePlusPlus
> <maggielongsh...@gmail.com>wrote:

Fitzchak Yitzchaki

unread,
Sep 25, 2011, 2:10:10 AM9/25/11
to nhp...@googlegroups.com, Bruno Lopes, maggiel...@gmail.com
We added this feature in build #916. Please let us know how this feature works out for you.

Bruno Lopes

unread,
Oct 5, 2011, 11:24:03 AM10/5/11
to nhp...@googlegroups.com
Just set it now and works fine.
Now if I forget and let nhprof run through the night it wont' fill up my main hard drive :)
Thanks!
Reply all
Reply to author
Forward
0 new messages