Here's my first (very rough and slow) port of false colors on 550D.
It's inspired from AJ's 5D2 code, from which I've used the lookup
table.
Quote from AJ:
+) False colours may need 'callibrating'. I have a lookup table for each of
the 256 levels that I've guessed by analysing the Marshal webstie, and
guessing the correlation between the canon 0..255 and the 'IRE' from
Marshall.
Many thanks to AJ, it's a pleasure reading his code (at least the
non-ASM part) :D
--
http://magiclantern.wikia.com/
To post to this group, send email to ml-d...@googlegroups.com
To unsubscribe from this group, send email to ml-devel+u...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/ml-devel?hl=en
Thanks. Do you know what is the transformation between spotmeter's
percent (0-100) and IRE? Is it the same thing?
Now I'm trying to port AJ's ASM code, in order to make it really fast.
Nice, it's the same color palette used by AJ.
Now I'm trying to port AJ's ASM code, in order to make it really fast.
False Color:
- Plain C: my code, slow
- ASM (AJ): optimized code
Benchmarks (with all other stuff turned off, 720x480 area):
- Plain C: 5-6fps. JaKob got 7 fps.
- ASM (AJ): 14fps.
AJ bug:
- If I toggle Play->LiveView, on first toggle it works, on second
toggle it doesn't work. It alternates. No error message given, no idea
why it happens.
Usability:
- Plain C version does not overwrite Canon displays and other ML
displays, and disappears quickly on half-shutter press.
- ASM version overwrites everything, and doesn't disappear when
stopped. This is due to my strange "mirroring" algorithm (which isn't
used by AJ). I've added a 50px border on every side, and this also
increased the fps to 20.
- None of them can work with focus peaking at the same time.
- Would it be better to trigger this with a shortcut key?
http://img706.imageshack.us/img706/8259/falsecolors.jpg
On Sat, Jan 22, 2011 at 3:08 PM, JaKoB <jako...@gmail.com> wrote:
> Would it be better to trigger this with a shortcut key?
>
> YES YES please
>
> Is the bug on a 5dmk2 or the 550D?
On the 550D, of course. Are you reading anything from some DryOs
structures in the code I've ported?
( Changeset: https://bitbucket.org/hudson/magic-lantern/changeset/58618c491f41 )
Border: yes, only this will get around 10fps on the C version
Downsampling (2x2): it will get around 20fps.. I think. My C zebras
(30fps due to msleeps, 40fps with msleep(1)) use 4(x) * 2(y)
downsampling.
Shortcut key: I'll try to hook Dof preview or Flash button
aj_FalseColour_HistoCalc()
- False color area is smaller and faster; also a downsampled (low-res)
version is available (and used by default)
- Shortcut key: Flash button in movie mode, DOF preview in photo mode
(enabled by default, Q to disable)
Other changes:
- Fix from Deti: "This patch fixes focus peaking with HDMI display in
record mode."
- Cropmarks available in Playback mode (use Q to enable this)
- IRE spotmeter (from AJ's excel)
Also, Sawomedia created a page with many cropmarks:
http://www.sawomedia.de/magiclantern/cropmarks/
That's the main reason for not using it by default. The algorithm
seems to be pretty powerful, even if it's memory hungry (for example,
cropmarks in Playback mode was trivial with this, and Canon buttons
are still visible). Also, it handles strange situations like when
Canon flash icon appears (it's almost in the middle of the screen).
Maybe I'll understand how ASM works someday :)
Did the text "Cropmks(1/3)" change to "CropmkP(1/3)" when pressing Q?
That P appears
when cropmarks in Playback mode are enabled.
>>> ml-devel+u...@googlegroups.com
>>> For more options, visit this group at
>>> http://groups.google.com/group/ml-devel?hl=en
>>
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+u...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/ml-devel?hl=en
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+u...@googlegroups.com
To unsubscribe from this group, send email to ml-devel+u...@googlegroups.com
On Sun, Jan 23, 2011 at 10:05 PM, JaKoB <jako...@gmail.com> wrote:
> but false color is reading fine thats how i find out the meter was not
> working right for hdmi
>
Actually, I have a similar issue with 550D videos (clipped
brightness), but thought it was a problem with my codecs.
1: what I see in mplayer/vlc under Linux
2: what I get with vlc under Windows, normal still picture, silent
picture and frame export in avidemux
1 is much darker.
That's the reason I've set 10-245 limits on zebra by default...
--
http://magiclantern.wikia.com/
To post to this group, send email to ml-d...@googlegroups.com
To unsubscribe from this group, send email to ml-devel+u...@googlegroups.com
New build:
- False color area is smaller and faster; also a downsampled (low-res)
version is available (and used by default)
- Shortcut key: Flash button in movie mode, DOF preview in photo mode
(enabled by default, Q to disable)
Other changes:
- Fix from Deti: "This patch fixes focus peaking with HDMI display in
record mode."
- Cropmarks available in Playback mode (use Q to enable this)
- IRE spotmeter (from AJ's excel)
Also, Sawomedia created a page with many cropmarks:
http://www.sawomedia.de/magiclantern/cropmarks/
Thanks in advance...
On 23 ene, 15:42, cristian paradiso <guit...@yahoo.it> wrote:
> NO it didnt
>
> ________________________________
> Da: Alex <broscutama...@gmail.com>
> A: ml-d...@googlegroups.com
> Inviato: Dom 23 gennaio 2011, 18:35:43
> Oggetto: Re: [ML] [550D] False colors
>
> > Sorry Alex cropmarks in playback mode seems not working, I press Q but nothing
> >happens
>
> Did the text "Cropmks(1/3)" change to "CropmkP(1/3)" when pressing Q?
> That P appears
> when cropmarks in Playback mode are enabled.
>
>
>
>
>
>
>
>
>
>
>
> On Sun, Jan 23, 2011 at 8:33 PM, Alex <broscutama...@gmail.com> wrote:
> > Thanks, AJ. What I'd like is to integrate it with the mirror
> > algorithm, to avoid overwriting other stuff (here, the focus
> > rectangle, the spotmeter and part of histogram; maybe the Canon side
> > menus, if I'll expand the area).
>
> > That's the main reason for not using it by default. The algorithm
> > seems to be pretty powerful, even if it's memory hungry (for example,
> > cropmarks in Playback mode was trivial with this, and Canon buttons
> > are still visible). Also, it handles strange situations like when
> > Canon flash icon appears (it's almost in the middle of the screen).
>
> > Maybe I'll understand how ASM works someday :)
>
> > On Sun, Jan 23, 2011 at 8:07 PM, Antony Newman <antony.new...@gmail.com>
> >>=
> >> // Pix1a
>
> >>//======================================================================= =====================
> >>=
>
> >> " AND r14,r7,#0x0000FF00\n" // Luma of Vpixel 1 (shifted)
> >> " MOV r14,r14,LSR#6\n" // Luma x 4 (ie create word
> >> position to add)
>
> >> " LDR r5,[r0, r14]\n" // r5 = False Col + Hist value
> >> " ORR r6,r6,r5,LSR#24\n" // add to bottom (1st) byte of
> >> Overlay colour
>
> >>//======================================================================= =====================
> >>=
> >> // Pix1b
>
> >>//======================================================================= =====================
> >>=
>
> >> " AND r14,r7,#0xFF000000\n" //
> >> " MOV r14,r14,LSR#24-2\n" // Luma x 4 (ie create word
> >> position to add)
>
> >> " LDR r5,[r0, r14]\n" // r5 = False Col + Hist value
>
> >> " AND r5,r5,#0xFF<<24\n" // r5 = top byte = False colour ->
> >> get it
> >> " ORR r6,r6,r5,LSR#16\n" // add to 2nd byte of Overlay
> >> colour
>
> >>//======================================================================= =====================
> >>=
> >> // Pix2a
>
> >>//======================================================================= =====================
> >>=
>
> >> " AND r14,r8,#0x0000FF00\n" //
> >> " MOV r14,r14,LSR#6\n" // Luma x 4 (ie create word
> >> position to add)
>
> >> " LDR r5,[r0, r14]\n" // r5 = False Col + Hist value
>
> >> " AND r5,r5,#0xFF<<24\n" // r5 = top byte = False colour ->
> >> get it
> >> " ORR r6,r6,r5,LSR#8\n" // add to bottom (3rd) byte of
> >> Overlay colour
>
> >>//======================================================================= =====================
> >>=
> >> // Pix2b
>
> >>//======================================================================= =====================
> >> --
> >>http://magiclantern.wikia.com/
>
> >> To post to this group, send email to ml-d...@googlegroups.com
> >> To unsubscribe from this group, send email to
> >> ml-devel+u...@googlegroups.com
> >> For more options, visit this group at
> >>http://groups.google.com/group/ml-devel?hl=en
>
> --http://magiclantern.wikia.com/
According to this topic, the luma -> IRE transformation is:
(16...235) -> (7.5...100)
http://cinema5d.com/viewtopic.php?f=24&t=346#p4673
Would it be OK to make an IRE spotmeter according to AJ formula and
another according to Piers? That's because I don't know who is right
:D
On Sun, Jan 23, 2011 at 10:52 PM, Piers <pie...@gmail.com> wrote:
Also, I've got rid of "this function is not available in movie mode",
and applied latest patch from Deti regarding zebras on external
displays. Spotmeter is not yet fixed.
They have sharp teeth now :D
Does it happen on the external monitor only, or on built-in display
too? I did notice this a few days ago, but thought it was fixed...
On Mon, Jan 24, 2011 at 10:10 PM, cristian paradiso <gui...@yahoo.it> wrote:
> Hi Alex, this build it's great and It is wonderful to see zebras on my
> monitor and they are very fast. I have only one problem that wasnt there the
> previous firmware, The cropmarks are 1 or 2 pixel shifted to the right so
> you can see that on the left side there is a hole of 1/2 or 3 pixel. and one
> more thing, sometimes seems that the zebras make holes on the cropmarks :)
> strange I know, it makes holes that you can see trough. And I also dont
> understand how to remove the blu zebras leaving only the red ones. Thanks a
> lot for all your effort guys
> ________________________________
> Da: Alex <broscu...@gmail.com>
> A: ml-d...@googlegroups.com
> Inviato: Lun 24 gennaio 2011, 17:49:42
> Oggetto: Re: [ML] [550D] False colors
>
>>>>> ml-devel+u...@googlegroups.com
>>>>> For more options, visit this group at
>>>>> http://groups.google.com/group/ml-devel?hl=en
>>>>
>>>
>>
>> --
>> http://magiclantern.wikia.com/
>>
>> To post to this group, send email to ml-d...@googlegroups.com
>> To unsubscribe from this group, send email to
>> ml-devel+u...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/ml-devel?hl=en
>>
>> --
>> http://magiclantern.wikia.com/
>>
>> To post to this group, send email to ml-d...@googlegroups.com
>> To unsubscribe from this group, send email to
>> ml-devel+u...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/ml-devel?hl=en
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+u...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/ml-devel?hl=en
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+u...@googlegroups.com
Sent from my iPhone
Hey Alex,
there is a screenshot of the 2/3 pixel shifted cropmarks
Inviato: Lun 24 gennaio 2011, 20:58:57
>>>>> ml-devel+unsub...@googlegroups.com
>>>>> For more options, visit this group at
>>>>> http://groups.google.com/group/ml-devel?hl=en
>>>>
>>>
>>
>> --
>> http://magiclantern.wikia.com/
>>
>> To post to this group, send email to ml-d...@googlegroups.com
>> To unsubscribe from this group, send email to
>> ml-devel+unsub...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/ml-devel?hl=en
>>
>> --
>> http://magiclantern.wikia.com/
>>
>> To post to this group, send email to ml-d...@googlegroups.com
>> To unsubscribe from this group, send email to
>> ml-devel+unsub...@googlegroups.com
>> For more options, visit this group at
>> http://groups.google.com/group/ml-devel?hl=en
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+unsub...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/ml-devel?hl=en
>
> --
> http://magiclantern.wikia.com/
>
> To post to this group, send email to ml-d...@googlegroups.com
> To unsubscribe from this group, send email to
> ml-devel+unsub...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/ml-devel?hl=en
--
http://magiclantern.wikia.com/
To post to this group, send email to ml-d...@googlegroups.com
To unsubscribe from this group, send email to ml-devel+unsub...@googlegroups.com