Initial check-in of SES code. (issue1816042)

2 views
Skip to first unread message

meta...@gmail.com

unread,
Jul 12, 2010, 5:58:35 PM7/12/10
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview.appspotmail.com
Reviewers: MarkM,

Description:
SES Rewriter and runtime library. Will add support for playground,
tests,
and domita integration in future changes.

Please review this at http://codereview.appspot.com/1816042/show

Affected files:
M src/com/google/caja/parser/quasiliteral/RewriterMessageType.java
A src/com/google/caja/parser/quasiliteral/SESRewriter.java
A src/com/google/caja/ses.js
A third_party/js/narwhal/global-es5.js


meta...@gmail.com

unread,
Jul 12, 2010, 5:58:48 PM7/12/10
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview.appspotmail.com

Mark Miller

unread,
Jul 13, 2010, 5:01:26 PM7/13/10
to meta...@gmail.com, eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview.appspotmail.com
On Mon, Jul 12, 2010 at 2:58 PM, <meta...@gmail.com> wrote:

Hi Mike, my suggested changes so far are sufficiently invasive that it was more convenient to make them by editing rather than commenting. Attached are

ses-bak.js --- the state of ses.js from your snapshot that I started from
ses.js --- my suggestions made mostly by editing
ses-fixes.diff --- simply the diff of these two.

Sorry if this is an inconvenient form. Please let me know of any questions. I'll be in office tomorrow.


--
Text by me above is hereby placed in the public domain

    Cheers,
    --MarkM

ses-bak.js
ses.js
ses-fixes.diff

eri...@gmail.com

unread,
Jul 13, 2010, 5:11:52 PM7/13/10
to meta...@gmail.com, google-ca...@googlegroups.com, re...@codereview.appspotmail.com

meta...@gmail.com

unread,
Jul 21, 2010, 3:32:46 PM7/21/10
to eri...@gmail.com, google-ca...@googlegroups.com, re...@codereview.appspotmail.com
As we discussed in person, I'll submit this since nothing else depends
on it and incremental changes will be easier.

http://codereview.appspot.com/1816042/show

Reply all
Reply to author
Forward
0 new messages