On Thu, Aug 18, 2011 at 6:20 PM, Konstantinos Papalias
<pkwnstanti...@gmail.com> wrote: > Not sure if it's only me having this issue but while trying to build > cucumber-jvm with: > mvn clean install > it does fail in core project on ClasspathTest. > I'm attaching the generated errors for your convenience.
> -- > You received this message because you are subscribed to the Google Groups > "Cukes" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/cukes/-/6cFZGup6FJQJ. > To post to this group, send email to cukes@googlegroups.com. > To unsubscribe from this group, send email to > cukes+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/cukes?hl=en.
On Aug 18, 2011, at 18:23, aslak hellesoy <aslak.helle...@gmail.com> wrote:
> On Thu, Aug 18, 2011 at 6:20 PM, Konstantinos Papalias > <pkwnstanti...@gmail.com> wrote: >> Not sure if it's only me having this issue but while trying to build >> cucumber-jvm with: >> mvn clean install >> it does fail in core project on ClasspathTest. >> I'm attaching the generated errors for your convenience.
> Windows?
Should be easy to fix for Windows, just need to use backslashes in a few places.
>> -- >> You received this message because you are subscribed to the Google Groups >> "Cukes" group. >> To view this discussion on the web visit >> https://groups.google.com/d/msg/cukes/-/6cFZGup6FJQJ. >> To post to this group, send email to cukes@googlegroups.com. >> To unsubscribe from this group, send email to >> cukes+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/cukes?hl=en.
I tried to build cucumber-jvm on Windows 7 and it failed on Java Core while running the classpath test. I will modify the test and see if I can get the build to pass.
On Thu, Aug 18, 2011 at 1:20 PM, Konstantinos Papalias <
pkwnstanti...@gmail.com> wrote: > Not sure if it's only me having this issue but while trying to build > cucumber-jvm with:
> mvn clean install
> it does fail in core project on ClasspathTest.
> I'm attaching the generated errors for your convenience.
> -- > You received this message because you are subscribed to the Google Groups > "Cukes" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/cukes/-/6cFZGup6FJQJ. > To post to this group, send email to cukes@googlegroups.com. > To unsubscribe from this group, send email to > cukes+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/cukes?hl=en.
On Fri, Aug 19, 2011 at 11:54 AM, arti singh <arti.p.si...@gmail.com> wrote: > I tried to build cucumber-jvm on Windows 7 and it failed on Java Core while > running the classpath test. I will modify the test and see if I can get the > build to pass.
Changing a test to make it pass is usually equivalent to sweeping dirt under a carpet. It doesn't fix a problem, it just gives the illusion of fixing it.
To make things work you'll have to make changes to Classpath.java so it works on Windows. Maybe using File.PATH_SEPARATOR instead of "/" in a few places will do the trick.
> On Thu, Aug 18, 2011 at 1:20 PM, Konstantinos Papalias > <pkwnstanti...@gmail.com> wrote:
>> Not sure if it's only me having this issue but while trying to build >> cucumber-jvm with: >> mvn clean install >> it does fail in core project on ClasspathTest. >> I'm attaching the generated errors for your convenience.
>> -- >> You received this message because you are subscribed to the Google Groups >> "Cukes" group. >> To view this discussion on the web visit >> https://groups.google.com/d/msg/cukes/-/6cFZGup6FJQJ. >> To post to this group, send email to cukes@googlegroups.com. >> To unsubscribe from this group, send email to >> cukes+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/cukes?hl=en.
> -- > You received this message because you are subscribed to the Google Groups > "Cukes" group. > To post to this group, send email to cukes@googlegroups.com. > To unsubscribe from this group, send email to > cukes+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/cukes?hl=en.
Yes, I am using Windows to build the project, but I feel the project would benefit by being OS independent.
Even if I manually fix the test-case for windows the first test will still fail with:
looksUpInstantiableSubclassesOnClassPath(cucumber.runtime.ClasspathTest): expected:<[class cucumber.runtime.ClasspathTest$Wilma, class cucumber.runtime.ClasspathTest$Fred]> but was:<[]>
By looking at the Classpath.java file we would need to replace the hard-coded forward slashes with File.separator plus all other Unix specific path attributes.
Sender: cukes@googlegroups.com
Date: Fri, 19 Aug 2011 05:28:50 To: <cukes@googlegroups.com>
Reply-To: cukes@googlegroups.com
Cc: aslak hellesoy<aslak.helle...@gmail.com>
Subject: Re: [Cucumber:8771] Cucumber-jvm failing on Build
Hi Aslak,
Yes, I am using Windows to build the project, but I feel the project would benefit by being OS independent.
Even if I manually fix the test-case for windows the first test will still fail with:
looksUpInstantiableSubclassesOnClassPath(cucumber.runtime.ClasspathTest): expected:<[class cucumber.runtime.ClasspathTest$Wilma, class cucumber.runtime.ClasspathTest$Fred]> but was:<[]>
By looking at the Classpath.java file we would need to replace the hard-coded forward slashes with File.separator plus all other Unix specific path attributes.
Thanks,
konstantinos
-- You received this message because you are subscribed to the Google Groups "Cukes" group.
To view this discussion on the web visit https://groups.google.com/d/msg/cukes/-/OMLU7yhmCfIJ.
To post to this group, send email to cukes@googlegroups.com.
To unsubscribe from this group, send email to cukes+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cukes?hl=en.
On Fri, Aug 19, 2011 at 1:28 PM, Konstantinos Papalias
<pkwnstanti...@gmail.com> wrote: > Hi Aslak, > Yes, I am using Windows to build the project, but I feel the project would > benefit by being OS independent.
Of course, that goes without saying.
> Even if I manually fix the test-case for windows the first test will still > fail with: > looksUpInstantiableSubclassesOnClassPath(cucumber.runtime.ClasspathTest): > expected:<[class cucumber.runtime.ClasspathTest$Wilma, class > cucumber.runtime.ClasspathTest$Fred]> but was:<[]> > By looking at the Classpath.java file we would need to replace the > hard-coded forward slashes with File.separator plus all other Unix specific > path attributes.
That sounds right. Please send a pull request when you have passing tests, and I can verify that tests still pass on OS X/Linux.
