cl-cont vs SBCL -- patch to turn funcall/cc into a macro

[John Fremlin]

To avoid this SBCL bug https://bugs.launchpad.net/sbcl/+bug/404441, here is a
small patch that turns funcall/cc and apply/cc into a macro.

(I need to tidy up my major changes that speed up cl-cont a lot by doing
fewer unnecessary transformations and not making so many
funcallable/ccs, they are still not ready and this patch is not relevant
to them.)

PS. Note that according to the spec (declaim (inline ...)) should occur
before the function definition (unless you do that thing won't actually
be inlined on SBCL)

[Leslie P. Polzer]

On Jul 25, 12:08 pm, John Fremlin <j...@fremlin.org> wrote:
> small patch that turns funcall/cc and apply/cc into a macro.

Better send a copy to Slava directly, he might not read it else.
AFAIK no one else has commit access to cl-cont.

> PS. Note that according to the spec (declaim (inline ...)) should occur
> before the function definition (unless you do that thing won't actually
> be inlined on SBCL)

Yes, that's known to me. It'd be nice to have a patch that cleans this
up as well.

Leslie

[John Fremlin]

"Leslie P. Polzer" <leslie...@gmx.net> writes:
[...]

>> PS. Note that according to the spec (declaim (inline ...)) should occur
>> before the function definition (unless you do that thing won't actually
>> be inlined on SBCL)
>
> Yes, that's known to me. It'd be nice to have a patch that cleans this
> up as well.

The patch I sent does it already :-)

I'll get in touch with Slava

[...]

[Leslie P. Polzer]

On Jul 26, 4:03 am, John Fremlin <j...@fremlin.org> wrote:

> "Leslie P. Polzer" <leslie.pol...@gmx.net> writes:
> > Yes, that's known to me. It'd be nice to have a patch that cleans this
> > up as well.
>
> The patch I sent does it already :-)

Ah, I thought there were more inline declamations elsewhere...

[John Fremlin]

"Leslie P. Polzer" <leslie...@gmx.net> writes:

Not according to grep(?) -- should there be? I don't think anything else is
called at runtime?

[...]

[Leslie P. Polzer]

John Fremlin wrote:

>> Ah, I thought there were more inline declamations elsewhere...
>
> Not according to grep(?) -- should there be? I don't think anything else is
> called at runtime?

No, you're right.

[Leslie P. Polzer]

On Jul 25, 12:08 pm, John Fremlin <j...@fremlin.org> wrote:

> small patch that turns funcall/cc and apply/cc into a macro.

I have applied and pushed your patch using my newly granted
permissions.

Thank you!