[PATCH] Cross-compilation patch to avoid looking for /usr/local at compile time

0 views
Skip to first unread message

Philip Prindeville

unread,
Jan 9, 2008, 10:55:51 PM1/9/08
to vim...@googlegroups.com
This is simple enough: suppress the detecting of /usr/local and putting it into the load path (etc) if we're cross-compiling.

Please review this and if it looks reasonable, signal to whomever to commit it to the source tree (as a patch, obviously) or cast a positive vote or whatever is necessary to bless it and assure its commission.

I sent it out-of-band a couple of times to Bram but it hasn't been approved (or rejected for that matter), so I figure I should be sending it to someone else (but don't know who that would be).

vim-7.1-philipp.patch.txt

Ben Schmidt

unread,
Jan 10, 2008, 2:13:00 AM1/10/08
to vim...@googlegroups.com

Bram is the right person to send it to. His to do list is massive, but if you
update your runtime files and do

:help todo.txt

you will find this on it:

"Patch for configure.in to support cross-compiling: Marc Haisenko, 2007 Sep 24.
Again 2007 Dec 12 Some more from Philip Prindeville, 2007 Dec 18."

Thus he will get around to it when he has the time, and when he does, it will be
accepted, or accepted with modifications, or you'll be contacted to address one
issue or another.

I believe he is particularly careful about making changes to the build process of
Vim, because it needs to work on so many systems.

Ben.


Send instant messages to your online friends http://au.messenger.yahoo.com

Bram Moolenaar

unread,
Jan 10, 2008, 4:10:12 PM1/10/08
to Philip Prindeville, vim...@googlegroups.com

Philip Prindeville wrote:

The reason you don't hear from me is that most of my emails to you
bounce back.

What I tried to say: excluding /usr/local/[include|lib] is not specific
for cross compiling. This should be a separate setting. Then it can
also be set for cross compiling.

Most configure features are explained in the Makefile. Or in the
INSTALL file. I prefer the Makefile, there you can uncomment a line to
have it used, no need to type it (configure doesn't warn for
unrecognized arguments).

--
Michael: There is no such thing as a dump question.
Bernard: Sure there is. For example "what is a core dump?"

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ download, build and distribute -- http://www.A-A-P.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Michael Haubenwallner

unread,
Jan 11, 2008, 4:50:05 AM1/11/08
to vim...@googlegroups.com, Philip Prindeville
On Thu, 2008-01-10 at 22:10 +0100, Bram Moolenaar wrote:

> Philip Prindeville wrote:

> What I tried to say: excluding /usr/local/[include|lib] is not specific
> for cross compiling. This should be a separate setting. Then it can
> also be set for cross compiling.

Thank you for the trigger to rework my old patch
http://www.mail-archive.com/vim...@vim.org/msg02896.html
to check gcc if it already uses the wanted local-dir.

/haubi/

--
13. - 14. Februar 2008
Salomon Automation am 6. Hamburger Logistiktag, Kreuzfahrtterminal Hamburg, Deutschland

19. - 21. Februar 2008
Salomon Automation auf der LogiMAT 2008, Neue Messe Stuttgart, Deutschland
Halle 6, Stand 527

23. - 27. Februar 2008
MoveRetail auf der EuroShop 2008 in Düsseldorf, Deutschland
Halle 6, Stand C50

Salomon Automation GmbH - Friesachstrasse 15 - A-8114 Friesach bei Graz
Sitz der Gesellschaft: Friesach bei Graz
UID-NR:ATU28654300 - Firmenbuchnummer: 49324 K
Firmenbuchgericht: Landesgericht für Zivilrechtssachen Graz

with-local-dir.patch

Marc Haisenko

unread,
Jan 11, 2008, 8:15:35 AM1/11/08
to vim...@googlegroups.com, Bram Moolenaar
On Thursday 10 January 2008, Bram Moolenaar wrote:
> The reason you don't hear from me is that most of my emails to you
> bounce back.

Ouch, that's bad... don't know why that happens.

> What I tried to say: excluding /usr/local/[include|lib] is not specific
> for cross compiling. This should be a separate setting. Then it can
> also be set for cross compiling.

Philip's patch is independent of mine, I think... the problem it addresses
just happened to bite him while cross-compiling.

> Most configure features are explained in the Makefile. Or in the
> INSTALL file. I prefer the Makefile, there you can uncomment a line to
> have it used, no need to type it (configure doesn't warn for
> unrecognized arguments).

What about the main "configure.in fixes for cross-compiling" patch by me ? Is
there anything I need to tweak so you can accept it or is there some reason
why you'd say the patch wouldn't be necessary ?

Don't get me wrong, I wouldn't be mad if you'd declined it, I just want a
definitive "accepted" or "declined".

Bye,
Marc

--
Marc Haisenko

Comdasys AG
Rüdesheimer Str. 7
80686 München
Germany

Tel.: +49 (0)89 548 433 321

Bram Moolenaar

unread,
Jan 11, 2008, 3:07:28 PM1/11/08
to Marc Haisenko, vim...@googlegroups.com

Marc Haisenko wrote:

> On Thursday 10 January 2008, Bram Moolenaar wrote:
> > The reason you don't hear from me is that most of my emails to you
> > bounce back.
>
> Ouch, that's bad... don't know why that happens.
>
> > What I tried to say: excluding /usr/local/[include|lib] is not specific
> > for cross compiling. This should be a separate setting. Then it can
> > also be set for cross compiling.
>
> Philip's patch is independent of mine, I think... the problem it addresses
> just happened to bite him while cross-compiling.
>
> > Most configure features are explained in the Makefile. Or in the
> > INSTALL file. I prefer the Makefile, there you can uncomment a line to
> > have it used, no need to type it (configure doesn't warn for
> > unrecognized arguments).
>
> What about the main "configure.in fixes for cross-compiling" patch by
> me ? Is there anything I need to tweak so you can accept it or is
> there some reason why you'd say the patch wouldn't be necessary ?

When adding a new argument to configure it's always good to document
this in the appropriate places.

> Don't get me wrong, I wouldn't be mad if you'd declined it, I just want a
> definitive "accepted" or "declined".

I still need to look into this. Configure patches are always tricky.

--
If "R" is Reverse, how come "D" is FORWARD?

Marc Haisenko

unread,
Jan 14, 2008, 8:39:09 AM1/14/08
to Bram Moolenaar, vim...@googlegroups.com
On Friday 11 January 2008, Bram Moolenaar wrote:

>
> Marc Haisenko wrote:
> > What about the main "configure.in fixes for cross-compiling" patch by
> > me ? Is there anything I need to tweak so you can accept it or is
> > there some reason why you'd say the patch wouldn't be necessary ?
>
> When adding a new argument to configure it's always good to document
> this in the appropriate places.

No worry, the patch doesn't add any new arguments. It only allows to use the
appropiate autoconf mechanism (well-named environment variables) to pass the
results of tests in environments where those tests can't be done
(cross-compiling).

Is there any file I'd need to document them ? Haven't seen any yet.

> > Don't get me wrong, I wouldn't be mad if you'd declined it, I just want a
> > definitive "accepted" or "declined".
>
> I still need to look into this. Configure patches are always tricky.

Yes, they are :-)

Philip Prindeville

unread,
Jan 14, 2008, 8:29:18 PM1/14/08
to vim...@googlegroups.com, Br...@moolenaar.net
Michael Haubenwallner wrote:
> On Thu, 2008-01-10 at 22:10 +0100, Bram Moolenaar wrote:
>
>
>> Philip Prindeville wrote:
>>
>
>
>> What I tried to say: excluding /usr/local/[include|lib] is not specific
>> for cross compiling. This should be a separate setting. Then it can
>> also be set for cross compiling.
>>
>
> Thank you for the trigger to rework my old patch
> http://www.mail-archive.com/vim...@vim.org/msg02896.html
> to check gcc if it already uses the wanted local-dir.
>
> /haubi/
>

That would work for me.

-Philip

Reply all
Reply to author
Forward
0 new messages