bugfix in indent/perl.vim

2 views
Skip to first unread message

Andrei Flame

unread,
Sep 10, 2008, 6:11:24 PM9/10/08
to vim...@vim.org
Hi,
i think that i've just fixed a folding-related bug in perl indentation plugin ( indent/perl.vim ) in vim 7.2.

I have the following Perl settings in my .vimrc:
" Perl
let perl_fold=1
let perl_fold_blocks=1
let perl_include_pod=1

When I'm trying to indent ( with gg=G ) the following code:

while ($x--) {
     print "x = $x\n";
}

it becomes:

while ($x--) {
print "x = $x\n";
}

i.e. print loses its indentation, that is clearly a bug.

Fix is very simple, here is the diff output between default and fixed plugin files:

$ diff /usr/local/share/vim/vim72/indent/perl.vim perl.vim
136c136
<           \ || synid =~ '^perl\(Sub\|BEGINEND\|If\)Fold'
---
>           \ || synid =~ '^perl\(Sub\|BEGINEND\|If\|Block\)Fold'
151c151
<           \ || synid =~ '^perl\(Sub\|BEGINEND\|If\)Fold'
---
>           \ || synid =~ '^perl\(Sub\|BEGINEND\|If\|Block\)Fold'

Patch is attached.







indent.patch

James Vega

unread,
Sep 10, 2008, 7:33:54 PM9/10/08
to vim...@googlegroups.com
On Wed, Sep 10, 2008 at 03:11:24PM -0700, Andrei Flame wrote:
> i think that i've just fixed a folding-related bug in perl indentation
> plugin ( indent/perl.vim ) in vim 7.2.

I sent the same patch to the maintainer of the Perl indent file (as well
as patches for a couple other scripts under his name) back in July and
have yet to receive a response.

Richard Hartmann

unread,
Sep 10, 2008, 8:22:18 PM9/10/08
to vim...@googlegroups.com
On Thu, Sep 11, 2008 at 01:33, James Vega <jame...@jamessan.com> wrote:

> I sent the same patch to the maintainer of the Perl indent file (as well
> as patches for a couple other scripts under his name) back in July and
> have yet to receive a response.

Are the any provisions for such cases like deadline, NMU or something?


Richard

Tony Mechelynck

unread,
Sep 10, 2008, 9:29:23 PM9/10/08
to vim...@googlegroups.com

If the maintainer-of-record doesn't answer in a reasonable time (I'd say
a few months), send your patch to Bram (or make sure he's aware of it
and of the fact that the maintainer cannot be reached anymore). He may
ask you to become the (or at least a) new maintainer of that file.


Best regards,
Tony.
--
I've found my niche. If you're wondering why I'm not there, there was
this little hole in the bottom ...
-- John Croll

Reply all
Reply to author
Forward
0 new messages