Changeset 1686 causes 6 tests to fail

1 view
Skip to first unread message

Roger Demetrescu

unread,
Jul 29, 2006, 10:16:55 PM7/29/06
to turbo...@googlegroups.com
Running nosetests in branch 1.0 gives me some failures due the fact
that turbogears.view.engines is not been initialized (at least during
the tests)...

Cheers

Roger

matt...@gmail.com

unread,
Jul 30, 2006, 4:00:36 PM7/30/06
to TurboGears

Oops. Nose itself was crashing on me so I haven't been able to run the
tests.

Kevin, is there a reason the loading of the template engines was
deferred? Loading them at module load-time seems to work, but I don't
know if there's a reason this wasn't done previously:

Index: turbogears/view/base.py
===================================================================
--- turbogears/view/base.py (revision 1695)
+++ turbogears/view/base.py (working copy)
@@ -77,7 +77,6 @@
variableProviders = DeprecatedVariableProviders()

def _choose_engine(template):
- _load_engines()
if isinstance(template, basestring):
colon = template.find(":")
if colon > -1:
@@ -342,3 +341,4 @@
engine = entrypoint.load()
engines[entrypoint.name] = engine(stdvars, engine_options)

+_load_engines()

Reply all
Reply to author
Forward
0 new messages