[RFC] saving/restoring column widths

11 views
Skip to first unread message

Johan Samyn

unread,
Sep 6, 2010, 7:24:28 AM9/6/10
to thg-dev mailing list
Steve,
On sep 2 (cset d87c34d43370) you removed my note from the wiki NIT page
about saving/restoring the widths of the changelog columns in the
workbench. Why not do that ? I find myself adjusting the width of the
columns over and over again, to get maximum readability/visibility.
That's why I made that note. What do others think about this ?
-- Johan

Steve Borho

unread,
Sep 6, 2010, 2:02:41 PM9/6/10
to thg...@googlegroups.com

We currently have logic for determining column widgets based on the
contents in each column (at least for the first few hundred rows).
This logic is somewhat expensive, and is currently broken for the
side-by-side file diffs, so it is not without flaws.

If we save / restore widths I think we'll have to do abandon the smart
resizing logic. I'm ok with this, but I'm curious how others feel.

--
Steve Borho

Johan Samyn

unread,
Sep 6, 2010, 2:40:38 PM9/6/10
to thg...@googlegroups.com
Then perhaps an option to indicate which of both methods the user wants
to use could be the solution ?
Standard method is like now, with automatic calculating logic. When user
flags menu option 'Save column widths' column widths are saved as they
are when the window is closed, and restored upon restart. Anytime the
option is unset, standard auto calculating logic is reactivated (upon
next restart ?). The 'Save col widths' option should/could also be on a
per window/dialog basis (much like the qt geom settings and so now are).
-- Johan

Reply all
Reply to author
Forward
0 new messages