Put unit propagation and pure literal rules inside the same loop (reducing the number of choices needed).

3 views
Skip to first unread message

Christian Muise

unread,
Mar 26, 2010, 2:54:23 PM3/26/10
to sympy-patches
This corresponds to issue 1875 ( http://code.google.com/p/sympy/issues/detail?id=1875
).

Branch is 'unit-prop' at git://github.com/haz/sympy.git

Vinzent Steinberg

unread,
Apr 2, 2010, 8:12:20 AM4/2/10
to sympy-...@googlegroups.com
2010/3/26 Christian Muise <christi...@gmail.com>:

> This corresponds to issue 1875 ( http://code.google.com/p/sympy/issues/detail?id=1875
> ).
>
>  Branch is 'unit-prop' at git://github.com/haz/sympy.git

I think when cleaning up your branches on github you deleted this one.

Vinzent

Christian Muise

unread,
Apr 2, 2010, 9:45:28 AM4/2/10
to sympy-...@googlegroups.com
That was intentional. Issue 1875 has since been marked invalid so I removed the branch (it was a fix that fixed nothing). Issue 1879 is the current patch unchecked. Message is here:
- http://groups.google.com/group/sympy-patches/browse_thread/thread/b209b7986080d7d0


--
You received this message because you are subscribed to the Google Groups "sympy-patches" group.
To post to this group, send email to sympy-...@googlegroups.com.
To unsubscribe from this group, send email to sympy-patche...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.


Vinzent Steinberg

unread,
Apr 2, 2010, 2:07:04 PM4/2/10
to sympy-...@googlegroups.com
2010/4/2 Christian Muise <christi...@gmail.com>:

> That was intentional. Issue 1875 has since been marked invalid so I removed
> the branch (it was a fix that fixed nothing). Issue 1879 is the current
> patch unchecked. Message is here:
> -
> http://groups.google.com/group/sympy-patches/browse_thread/thread/b209b7986080d7d0

I think I already reviewed this one positively, didn't I?

Vinzent

Christian Muise

unread,
Apr 2, 2010, 2:15:52 PM4/2/10
to sympy-...@googlegroups.com
It got the +1, but never made it into the repo.


Vinzent

Vinzent Steinberg

unread,
Apr 2, 2010, 2:19:59 PM4/2/10
to sympy-...@googlegroups.com, Fabian Pedregosa
2010/4/2 Christian Muise <christi...@gmail.com>:

> It got the +1, but never made it into the repo.

I think someone wanted the opinion of Fabian, but I'll push it in soon.

Vinzent

Vinzent Steinberg

unread,
Apr 3, 2010, 6:38:02 AM4/3/10
to sympy-...@googlegroups.com
2010/4/2 Vinzent Steinberg <vinzent....@googlemail.com>:

It's in.

Reply all
Reply to author
Forward
0 new messages