[PATCH] LCD+Flash 2 in 1 against rev491

[Anthony Lee]

Hi 各位，

不好意思，这个补丁拖了一段时间了。
顺便也把 LinuxFans 论坛中提到的一个 flash 的问题改了。

现在可以进行 GCC 版本检测以及 LCD 环境检测了，
但是仍然存在问题。

对比与 1.2.4 版本，现 SVN 上的版本 arch/arm/common/armmem.c 好像变化很大，
所以现在 LCD 仍然是用不了！请在补丁后看 device/lcd/skyeye_lcd.c 第 126 行。
请熟悉现在 mem_bank 机制的成员看看怎么修改吧。


谢谢。
A.L.

[michael.kang]

好像你的patch中有些问题，我提交到仓库中，现在会在configure过程中出错，目前在 skyeye-1.2.5上测试，也会出错，错误信息
如下：
ksh@server:/opt/testsuite/tmp/skyeye-1.2.5_REL> ./configure
checking build system type... x86_64-suse-linux-gnu
checking host system type... x86_64-suse-linux-gnu
checking target system type... x86_64-suse-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for g++... g++
checking for C++ compiler default output file name... a.out
checking whether the C++ compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables...
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for style of include used by make... GNU
checking dependency style of g++... gcc3
checking for gawk... (cached) gawk
checking for gcc... gcc
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking whether make sets $(MAKE)... (cached) yes
checking how to run the C preprocessor... gcc -E
checking for ranlib... ranlib
checking for gcc... done
./configure: line 4478: syntax error near unexpected token `GTK,'
./configure: line 4478: ` PKG_CHECK_MODULES(GTK, gtk+-2.0 >=
2.0.0,'
ksh@server:/opt/testsuite/tmp/skyeye-1.2.5_REL>


Thanks
MK

> skyeye-flash.diff
> < 1KViewDownload
>
> skyeye-lcd.diff
> 11K查看下载

[Anthony Lee]

> 好像你的patch中有些问题，我提交到仓库中，现在会在configure过程中出错，目前在 skyeye-1.2.5上测试，也会出错，错误信息

是你的 aclocal.m4 没有更新的原因。其实我比较反对在源码树上放 autotools 自动生成的文件。:)
以下是我对现在 SVN 上 r518 版本测试的纪录，其中前几步就是更新 autotools 自动生成的文件。

Anthony@HOME /i/src/skyeye-svn-r518
$ ls
AUTHORS MAINTAINERS REPORTING-BUGS binary configure.in misc
COPYING Makefile.am TODO config.guess dbct missing
ChangeLog Makefile.in aclocal.m4 config.h.in depcomp utils
INSTALL NEWS arch config.sub device
LICENSE README autom4te.cache configure install-sh

Anthony@HOME /i/src/skyeye-svn-r518
$ rm aclocal.m4; aclocal -I /MinGW/share/aclocal

Anthony@HOME /i/src/skyeye-svn-r518
$ autoheader;autoconf;automake --copy --add-missing

Anthony@HOME /i/src/skyeye-svn-r518
$ ./configure --prefix=/MinGW
checking build system type... i686-pc-mingw32
checking host system type... i686-pc-mingw32
checking target system type... i686-pc-mingw32
checking for a BSD-compatible install... /bin/install -c

checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes

checking for C++ compiler default output file name... a.exe

checking whether the C++ compiler works... yes
checking whether we are cross compiling... no

checking for suffix of executables... .exe

checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for style of include used by make... GNU
checking dependency style of g++... gcc3
checking for gawk... (cached) gawk
checking for gcc... gcc
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking whether make sets $(MAKE)... (cached) yes

checking how to run the C preprocessor... cpp

checking for ranlib... ranlib
checking for gcc... done

checking for main in -lc... no
checking for main in -liberty... yes
checking for main in -lintl... no
checking for main in -lm... yes
checking for main in -ln... no
checking for bfd_openr in -lbfd... yes
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking netdb.h usability... no
checking netdb.h presence... no
checking for netdb.h... no
checking netinet/in.h usability... no
checking netinet/in.h presence... no
checking for netinet/in.h... no
checking stddef.h usability... yes
checking stddef.h presence... yes
checking for stddef.h... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking sys/file.h usability... yes
checking sys/file.h presence... yes
checking for sys/file.h... yes
checking sys/ioctl.h usability... no
checking sys/ioctl.h presence... no
checking for sys/ioctl.h... no
checking sys/socket.h usability... no
checking sys/socket.h presence... no
checking for sys/socket.h... no
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking termios.h usability... no
checking termios.h presence... no
checking for termios.h... no
checking for unistd.h... (cached) yes
checking bfd.h usability... yes
checking bfd.h presence... yes
checking for bfd.h... yes
checking for stdbool.h that conforms to C99... yes
checking for _Bool... yes
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int8_t... yes
checking for off_t... yes
checking for size_t... yes
checking for ssize_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking whether struct tm is in sys/time.h or time.h... time.h
checking for uid_t in sys/types.h... no
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for working volatile... yes
checking for error_at_line... no
checking whether gcc needs -traditional... no
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for working memcmp... yes
checking for stdlib.h... (cached) yes
checking for unistd.h... (cached) yes
checking for getpagesize... yes
checking for working mmap... no
checking for stdlib.h... (cached) yes
checking for GNU libc compatible realloc... yes
checking sys/select.h usability... no
checking sys/select.h presence... no
checking for sys/select.h... no
checking for sys/socket.h... (cached) no
checking types of arguments for select... int,int *,struct timeval *
checking return type of signal handlers... void
checking for vprintf... yes
checking for _doprnt... no
checking for atexit... yes
checking for bzero... yes
checking for getpagesize... (cached) yes
checking for gettimeofday... yes
checking for memmove... yes
checking for memset... yes
checking for munmap... no
checking for select... no
checking for setlocale... yes
checking for socket... no
checking for sqrt... yes
checking for strcasecmp... yes
checking for strchr... yes
checking for strdup... yes
checking for strerror... yes
checking for strspn... yes
checking for strtol... yes
checking for strtoul... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating arch/arm/Makefile
config.status: creating arch/bfin/Makefile
config.status: creating arch/coldfire/Makefile
config.status: creating arch/mips/Makefile
config.status: creating arch/ppc/Makefile
config.status: creating device/Makefile
config.status: creating utils/Makefile
config.status: creating config.h
config.status: executing depfiles commands

Anthony@HOME /i/src/skyeye-svn-r518
$

[Anthony Lee]

Hi Michael,

另外请你删除掉你自己加上去的 GTK+ 链接库，相应的 patch 如下，并附上 Windows 下执行 LCD 的画面。

Index: Makefile.am
===================================================================
--- Makefile.am (revision 518)
+++ Makefile.am (working copy)

@@ -4,7 +4,7 @@

#AM_LDFLAGS = $(LIBLS) --start-group $(top_srcdir)/arch/arm/libarm.a
$(top_srcdir)/arch/bfin/libbfin.a
$(top_srcdir)/arch/coldfire/libcoldfire.a
$(top_srcdir)/arch/mips/libmips.a $(top_srcdir)/arch/ppc/libppc.a
$(top_srcdir)/device/libdev.a $(top_srcdir)/utils/libutils.a
--end-group
#AM_LDFLAGS = $(LIBLS) -L$(top_srcdir)/arch/arm/
-L$(top_srcdir)/arch/bfin/ -L$(top_srcdir)/arch/coldfire/
-L$(top_srcdir)/arch/mips/ -L$(top_srcdir)/device/
-L$(top_srcdir)/utils/ --start-group -larm -lbfin -lcoldfire -lmips
-L$(top_srcdir)/arch/ppc/ -lppc -ldev -lutils --end-group

-skyeye_LDADD = $(top_srcdir)/utils/libutils.a
$(top_srcdir)/arch/arm/libarm.a $(top_srcdir)/device/libdev.a
$(top_srcdir)/arch/mips/libmips.a $(top_srcdir)/arch/ppc/libppc.a
$(top_srcdir)/arch/bfin/libbfin.a $(top_srcdir)/arch/mips/libmips.a
$(top_srcdir)/arch/coldfire/libcoldfire.a -lgtk-x11-2.0 -lgdk-x11-2.0
-latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo
-lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0
+skyeye_LDADD = $(top_srcdir)/utils/libutils.a
$(top_srcdir)/arch/arm/libarm.a $(top_srcdir)/device/libdev.a
$(top_srcdir)/arch/mips/libmips.a $(top_srcdir)/arch/ppc/libppc.a
$(top_srcdir)/arch/bfin/libbfin.a $(top_srcdir)/arch/mips/libmips.a
$(top_srcdir)/arch/coldfire/libcoldfire.a

# some functions in "libutils.a" which is required by other libs
skyeye_LDADD += $(top_srcdir)/utils/libutils.a

[michael.kang]

On Aug 12, 12:33 am, "Anthony Lee" <don.anthony....@gmail.com> wrote:
> > 好像你的patch中有些问题，我提交到仓库中，现在会在configure过程中出错，目前在 skyeye-1.2.5上测试，也会出错，错误信息
>
> 是你的 aclocal.m4 没有更新的原因。其实我比较反对在源码树上放 autotools 自动生成的文件。:)

是啊，我也觉得似乎不妥，把一些自动生成的文件提交到源码仓库中。但是我发现autoconf和automake，似乎不能正确的判断依赖关系，它们不
能检查configure.in和Makefile.am，来自动运行，是否是这样的？
这个问题我再仔细考虑考虑，看看有什么比较好的办法。

[michael.kang]

Ok, I had commited your patch to both trunk and skyeye-1.2.6 branch.

Thanks
MK

> lcd-win32.png
> 60KViewDownload