Code Review Process

[jon]

Hi all,

After fully installing and reviewing reviewboard today, I realized
that this product is kind of the opposite of what I'm looking for
because my development model is a bit different than the one that this
product supports. Instead of creating a patch and waiting for my co-
workers to review it, I'd rather see a system where reviews are done
on already committed code and there is a workflow around that system
instead. To keep this email short, I just wrote a blog posting
detailing my issues:

http://lookfirst.com/2008/07/code-reviews.html

I'd love to hear the experts here comment on my views.

thanks,

jon

[Christian Hammond]

Hi Jon.

Love the title of your blog :)

Though we don't advertise it nearly as much, Review Board can post review requests of already committed code. The web UI doesn't have support for this (yet) but the command line post-review tool does. You can specify a revision range to put up for review and people can review that.

In time, probably after extensions support goes in, I envision a small repository browser that lets you easily put committed code up for review. But in the meantime, post-review is your best option. If you check the wiki, there's some documentation on using post-review in this way.

Christian


--
Christian Hammond - chi...@chipx86.com
VMware, Inc.