BUG: quote escaping destroys text (with spec patch)

[Andreas S.]

SPEC:

diff --git a/test/spec_rack_request.rb b/test/spec_rack_request.rb
index 43a4b87..cfda3a1 100644
--- a/test/spec_rack_request.rb
+++ b/test/spec_rack_request.rb
@@ -555,4 +555,12 @@ EOF
req2.params.should.equal "foo" => "#{b}bar#{b}"
end
}
+
+ specify "should not remove text containing quotes" do
+ url = "/?foo=" + CGI.escape("bar\n\"baz\"")
+ env = Rack::MockRequest.env_for(url)
+ req = Rack::Request.new(env)
+ req.GET.should.equal "foo" => "bar\n\"baz\""
+ req.params.should.equal "foo" => "bar\n\"baz\""
+ end
end


RESULT:
3) Failure:
test_spec {Rack::Request} 129 [should not remove text containing
quotes](Rack::Request) [./test/spec_rack_request.rb:563]:
<{"foo"=>"bar\n\"baz\""}> expected but was
<{"foo"=>"baz"}>.

[Simon Chiang]

This has tripped up numerous people. See also:

* http://groups.google.com/group/rack-devel/browse_thread/thread/94b8116ecdef5ec5
* http://groups.google.com/group/rack-devel/browse_thread/thread/befbad49b6409b45
* http://groups.google.com/group/rack-devel/browse_thread/thread/f81f79e633b9e086
* http://github.com/rack/rack/issues#issue/16

A patch that removes quote parsing and fixes the specs (including the
one reported on this thread) is here:
http://github.com/bahuvrihi/rack/commit/ec6edf522d581336a8900e68bde46

[Michael Fellinger]

OK, I applied the patch from bahuvrihi, will update the bug trackers.

--
Michael Fellinger
CTO, The Rubyists, LLC