Crash with semicolon in filename

[Sylvain]

Hi,

If I upload a file with a semicolon (;) ["my;file.pdf"], Tornado
crashes

File "tornado\wsgi.py", line 172, in _parse_mime_body
name, name_value = name_part.strip().split("=", 1)
ValueError: need more than 1 value to unpack

Semicolon in filename is most of the time nerver well handled in
python (don't know why it is not fixed... or maybe I don't know how it
works) and we "often' get : "my" instead of "my;file.pdf".

But here, it crashes, so I think it needs to be fixed.

Best regards.

Sylvain

[Bret Taylor]

Thanks, we will investigate and fix.

[Matt Goodall]

On Sep 30, 5:04 pm, Sylvain <sylvain.viv...@gmail.com> wrote:

> Semicolon in filename is most of the time nerver well handled in
> python (don't know why it is not fixed... or maybe I don't know how it
> works) and we "often' get : "my" instead of "my;file.pdf".

Use urlparse.urlsplit and your paths will be fine.

urlparse.urlparse tries to handle path args but gets it wrong. It's
best not to use it.

- Matt

[Sylvain]

Here, the issue is when you upload a file (in a form with a file input
for example)
then the content-disposition is not well parsed.
Content-Disposition looks like that : attachment;
filename="myfile.pdf"

I think the "bug" in python is in cgi.parse_header (same kind of error
in Tornado I think)
http://pydoc.org/get.cgi/usr/local/lib/python2.5/cgi.py

There is a .split(";") --> error because, semi-colon can be used in
the filename too.

Regards.