[perl #41331] Imposition of coding standards breaks tests in tcl.

[Will Coleda]

# New Ticket Created by Will Coleda
# Please include the string: [perl #41331]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=41331 >

To quote ticket 41329:

> However, when repositioning code in test files,
> one is well advised to re-run the tests to see if they all still
> pass. This apparently was not done.

Ditto tcl: after the coding standards were blindly applied, the
following tests fail in tcl:

Failed Test Stat Wstat Total Fail List of Failed
------------------------------------------------------------------------
-------
t/cmd_cd.t 255 65280 3 6 1-3
t/cmd_exit.t 255 65280 3 6 1-3
t/cmd_exprOld.t 255 65280 80 160 1-80
t/cmd_inline.t 255 65280 3 6 1-3
t/cmd_parray.t 255 65280 6 12 1-6
t/cmd_puts.t 255 65280 5 10 1-5
t/cmd_pwd.t 255 65280 2 4 1-2
t/cmd_rename.t 255 65280 9 18 1-9
t/cmd_source.t 255 65280 2 4 1-2
t/cmd_stringOld.t 255 65280 5 10 1-5
t/cmd_uplevel.t 255 65280 10 20 1-10
t/tcl_backslash.t 255 65280 35 70 1-35
t/tcl_misc.t 255 65280 33 66 1-33
3 subtests skipped.
Failed 13/73 test scripts. 196/1321 subtests failed.
Files=73, Tests=1321, 108 wallclock secs (98.08 cusr + 6.07 csys =
104.15 CPU)
Failed 13/73 test programs. 196/1321 subtests failed.

--
Will "Coke" Coleda
wi...@coleda.com

[Paul Cochrane]

> To quote ticket 41329:
>
> > However, when repositioning code in test files,
> > one is well advised to re-run the tests to see if they all still
> > pass. This apparently was not done.
>
> Ditto tcl: after the coding standards were blindly applied, the
> following tests fail in tcl:

I did run the tests otherwise I wouldn't have committed the changes.
However, I would guess that I ran the *wrong* tests. This won't
happen again.

Paul

[Paul Cochrane]

> Failed Test Stat Wstat Total Fail List of Failed
> ------------------------------------------------------------------------
> -------
> t/cmd_cd.t 255 65280 3 6 1-3
> t/cmd_exit.t 255 65280 3 6 1-3
> t/cmd_exprOld.t 255 65280 80 160 1-80
> t/cmd_inline.t 255 65280 3 6 1-3
> t/cmd_parray.t 255 65280 6 12 1-6
> t/cmd_puts.t 255 65280 5 10 1-5
> t/cmd_pwd.t 255 65280 2 4 1-2
> t/cmd_rename.t 255 65280 9 18 1-9
> t/cmd_source.t 255 65280 2 4 1-2
> t/cmd_stringOld.t 255 65280 5 10 1-5
> t/cmd_uplevel.t 255 65280 10 20 1-10
> t/tcl_backslash.t 255 65280 35 70 1-35
> t/tcl_misc.t 255 65280 33 66 1-33
> 3 subtests skipped.
> Failed 13/73 test scripts. 196/1321 subtests failed.
> Files=73, Tests=1321, 108 wallclock secs (98.08 cusr + 6.07 csys =
> 104.15 CPU)
> Failed 13/73 test programs. 196/1321 subtests failed.

Tests are passing as of r16774