Found an small error in NHibernate source and included a possible fix

5 views
Skip to first unread message

Basuitdelft

unread,
Feb 18, 2010, 3:42:12 AM2/18/10
to nhusers
I did find a errors in the NHibernate source.
In 'AbstractNullnessCheckNode.cs' and 'BinaryLogicOperatorNode.cs'
files there are these lines:
String[] splits = StringHelper.Split( ", ", nodeText );

If think the author wanted to make a sting like this "value1, value2"
to be split in 2 parts but the StringHelper.Split method splits it in
3 parts because the method splits on characters and not on strings. So
I changed the lines to:
string[] splits = nodeText.Split(new[] {", "},
StringSplitOptions.RemoveEmptyEntries);
and the error went away.

I also saw a similar thing in 'IncrementGenerator.cs', it might have
to be changed there too.

Bas

kor

unread,
Feb 18, 2010, 4:08:27 AM2/18/10
to nhusers
hi, use jira to send bug and/or bugfix at http://jira.nhforge.org
(it's more easy to manage them with jira)


note: in this days the server is down for maintenance, so wait same
days when it will be up to send your bug and bugfix

Reply all
Reply to author
Forward
0 new messages