superreview requested: [Bug 473045] Implement Windows 7 Jump List features : [Attachment 402751] widget v.4

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <r...@ocallahan.org> for superreview:
Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 402751: widget v.4
https://bugzilla.mozilla.org/attachment.cgi?id=402751&action=edit

------- Additional Comments from Jim Mathies <jmat...@mozilla.com>
fully updated to comments and tested via the browser bits.

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has asked Robert O'Callahan (:roc) (Mozilla
Corporation) <r...@ocallahan.org> for superreview:
Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 402776: widget v.4
https://bugzilla.mozilla.org/attachment.cgi?id=402776&action=edit

------- Additional Comments from Jim Mathies <jmat...@mozilla.com>

- updated to roc's comments. (went with JUMPLIST_ITEM_EMPTY)
- updated and added more tests
- fixed a bug where the second param on addBuildList should have been optional.

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has canceled Jim Mathies
<jmat...@mozilla.com>'s request for superreview:

Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 402751: widget v.4
https://bugzilla.mozilla.org/attachment.cgi?id=402751&action=edit

------- Additional Comments from Jim Mathies <jmat...@mozilla.com>

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has canceled Jim Mathies
<jmat...@mozilla.com>'s request for superreview:
Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 402776: widget v.4
https://bugzilla.mozilla.org/attachment.cgi?id=402776&action=edit

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has asked Robert O'Callahan (:roc) (Mozilla

Corporation) <r...@ocallahan.org> for superreview:

Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 403286: widget v.5
https://bugzilla.mozilla.org/attachment.cgi?id=403286&action=edit

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has canceled Jim Mathies

<jmat...@mozilla.com>'s request for superreview:

Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 403286: widget v.5
https://bugzilla.mozilla.org/attachment.cgi?id=403286&action=edit

------- Additional Comments from Jim Mathies <jmat...@mozilla.com>
Ok, at bz's suggestion I've updated this to use nsICryptoHash instead of the
nsCRT has code. Added a few more tests as well for the hashing.

[bugzill...@mozilla.org]

Jim Mathies <jmat...@mozilla.com> has asked Robert O'Callahan (:roc) (Mozilla

Corporation) <r...@ocallahan.org> for superreview:

Bug 473045: Implement Windows 7 Jump List features
https://bugzilla.mozilla.org/show_bug.cgi?id=473045

Attachment 404071: widget v.6
https://bugzilla.mozilla.org/attachment.cgi?id=404071&action=edit

[bugzill...@mozilla.org]

Robert O'Callahan (:roc) (Mozilla Corporation) <r...@ocallahan.org> has granted
Jim Mathies <jmat...@mozilla.com>'s request for superreview: