[Mifos-developer] [PATCH] MIFOS-3584 Monthly Schedule is inaccurate for loans due on the 31st

[Artur Siekielski]

Hello.
I'm a new developer from Polish team and this is my first submitted patch.

This issue is a rather fragile thing so I think it needs to be checked
by someone who knows good how loan monthly schedule generation work.

The issue is that a scheduled date can be "adjusted" by moving it
forward because of vacations and working days. But when adjusted date is
moved to a next month, then calculation of next scheduled date is wrong.
I changed the algorithm for monthly schedule generation to use
non-adjusted dates for computing base dates for further adjusting. I
tried to change the calendar utility function but it cannot be done in
that place due to lack of knowledge what was the date before adjustment.

Besides fixing current code there is wrong data in databases in systems
this bug appeared ("loan_schedule" records are inserted during loan
generation). Is there a need for preparing some scripts etc. fixing such
databases?

Regards,
Artur

[Kay Chau]

Arthur, thanks for sending an email on this to the dev list! I agree
this area is rather complicated!

On this question

>
> Besides fixing current code there is wrong data in databases in
systems this bug appeared
> ("loan_schedule" records are inserted during loan generation). Is
there a need for
> preparing some scripts etc. fixing such databases?

Can you determine if this issue ONLY occurs if you have scheduled a
monthly loan that happens to be on the end of the month?

Or is it more widespread, ie any loan schedule that might end up w/ a
date on the end of a month might be affected by this issue?

Kay

------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev

[Artur Siekielski]

On 09/23/2010 08:52 PM, Kay Chau wrote:
> Can you determine if this issue ONLY occurs if you have scheduled a
> monthly loan that happens to be on the end of the month?
>
> Or is it more widespread, ie any loan schedule that might end up w/ a
> date on the end of a month might be affected by this issue?
>

Hi.
This issue touches only monthly schedules, because source of error is
function used only in monthly schedule generation
(CalendarUtils.getNextDateForMonthOnDate). Error is for all scheduled
dates which are moved to new month because of working days/vacations
adjustments (eg. when planned date is 31th October but because it's
Sunday it's adjusted to 1st November - computed date will be 30th November).

In my patch it is visible in unit test
CalendarUtils.shouldPlaceNextMonthDateInTheSameMonth. The function
getNextDateForMonthOnDate gets adjusted date which is 1st November and
returns 30th November. I'm attaching a patch with new tests showing this
behaviour.

Regars,
Artur

[Kay Chau]

Thanks Artur, saw that you've checked in the fix. I think it's fine to
not do an update on previous incorrect schedules for now.

Did you check if Redo Loan is also fixed from this?

> -----Original Message-----
> From: Artur Siekielski [mailto:asiek...@soldevelo.com]
> Sent: Friday, September 24, 2010 12:58 AM
> To: Mifos software development
> Subject: Re: [Mifos-developer] [PATCH] MIFOS-3584 Monthly Schedule is
inaccurate for
> loans due on the 31st
>

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev