lift-openid broken

1 view
Skip to first unread message

Vassil

unread,
Aug 16, 2009, 6:48:15 PM8/16/09
to Lift
Hello guys,

It seems the HTTP refactoring around 10 days ago broke OpenId. Here's
a small patch that made it work for me:

--- dpp-liftweb-e845b3c129baf16bc35b46df9ee5b5049d4aee3a/lift-openid/
src/main/scala/net/liftweb/openid/OpenId.scala 2009-08-16
17:36:58.000000000 +0300
+++ dpp-liftweb-fixed/lift-openid/src/main/scala/net/liftweb/openid/
OpenId.scala 2009-08-17 01:43:46.000000000 +0300
@@ -267,7 +267,7 @@

// retrieve the previously stored discovery information
val discovered = httpReq.session.attribute("openid-disc") match {
- case Full(d: DiscoveryInformation)=> d
+ case d: DiscoveryInformation=> d
case _ => throw ResponseShortcutException.redirect("/")
}

@@ -275,7 +275,7 @@
var receivingURL = httpReq.url
val queryString = httpReq.queryString openOr ""
if (queryString != null && queryString.length() > 0) {
- receivingURL += "?" + httpReq.queryString;
+ receivingURL += "?" + queryString;
}

marius d.

unread,
Aug 17, 2009, 2:52:43 AM8/17/09
to Lift
Thank you for pointing this out. Most likely I'll make the corrections
today.

Br's,
Marius

David Pollak

unread,
Aug 17, 2009, 2:39:22 PM8/17/09
to lif...@googlegroups.com
On Sun, Aug 16, 2009 at 11:52 PM, marius d. <marius...@gmail.com> wrote:

Thank you for pointing this out. Most likely I'll make the corrections
today.

Please let us know when the changes are rolled in.
 



--
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Git some: http://github.com/dpp

marius d.

unread,
Aug 17, 2009, 3:35:29 PM8/17/09
to Lift
Done.

Br's,
Marius

On Aug 17, 9:39 pm, David Pollak <feeder.of.the.be...@gmail.com>
wrote:
> Beginning Scalahttp://www.apress.com/book/view/1430219890

David Pollak

unread,
Aug 17, 2009, 3:46:27 PM8/17/09
to lif...@googlegroups.com


On Mon, Aug 17, 2009 at 12:35 PM, marius d. <marius...@gmail.com> wrote:

Done.

Tnx
 



--
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890

Vassil

unread,
Aug 18, 2009, 4:15:44 PM8/18/09
to Lift
> Done.

Great, propagated to maven repo now. Thanks.
Reply all
Reply to author
Forward
0 new messages