@auto save dialog problem

4 views
Skip to first unread message

Kent Tenney

unread,
Jan 8, 2010, 5:01:34 PM1/8/10
to leo-e...@googlegroups.com
A recent change in the trunk results in extraneous
"Overwrite existing file?"
dialog when saving the Leo file after changing in an @auto <file> subtree

Thanks,
Kent

Edward K. Ream

unread,
Jan 8, 2010, 5:15:46 PM1/8/10
to leo-editor

Hmm. That was the opposite of the intended effect :-) I'll look into
this immediately.

Edward

Edward K. Ream

unread,
Jan 13, 2010, 5:27:45 PM1/13/10
to leo-editor

On Jan 8, 4:01 pm, Kent Tenney <kten...@gmail.com> wrote:

Are you sure about this? I've gotten this message several times, and
in each case the message was valid, though it sometime took me awhile
to realize that, for example, bzr had updated a file while a .leo file
was open.

Can you give a reliable way to demonstrate this bug?

Edward

Kent Tenney

unread,
Jan 13, 2010, 8:43:04 PM1/13/10
to leo-e...@googlegroups.com

Currently, any time I save a Leo file which includes changes
under an @auto node, I get the dialog.

>
> Edward
>
> --
> You received this message because you are subscribed to the Google Groups "leo-editor" group.
> To post to this group, send email to leo-e...@googlegroups.com.
> To unsubscribe from this group, send email to leo-editor+...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
>
>
>
>

Edward K. Ream

unread,
Jan 14, 2010, 6:51:12 AM1/14/10
to leo-editor

On Jan 13, 7:43 pm, Kent Tenney <kten...@gmail.com> wrote:

> > Can you give a reliable way to demonstrate this bug?
>
> Currently, any time I save a Leo file which includes changes
> under an @auto node, I get the dialog.

Thanks. The fix is on the trunk at rev 2679. All unit tests pass.

Edward

Kent Tenney

unread,
Jan 14, 2010, 10:36:29 AM1/14/10
to leo-e...@googlegroups.com

Try this:

- rclick on @auto <file> node, choose "Edit <file> in gvim"
- edit in gvim
- rclick on @auto <file> node, choose "Refresh from disk"
- save Leo file
- get dialog "<file> has been modified outside Leo, overwrite?"

This warning seems unnecessary and misleading.

Thanks,
Kent

Edward K. Ream

unread,
Jan 15, 2010, 9:14:46 AM1/15/10
to leo-editor

On Jan 14, 9:36 am, Kent Tenney <kten...@gmail.com> wrote:

> Try this:
>
> - rclick on @auto <file> node, choose "Edit <file> in gvim"
> - edit in gvim
> - rclick on @auto <file> node, choose "Refresh from disk"
> - save Leo file
> - get dialog "<file> has been modified outside Leo, overwrite?"
>
> This warning seems unnecessary and misleading.

Thanks for this report. I'll fix it for b2.

Edward

Edward K. Ream

unread,
Jan 15, 2010, 11:10:15 AM1/15/10
to leo-editor

On Jan 14, 9:36 am, Kent Tenney <kten...@gmail.com> wrote:

> Try this:
>
> - rclick on @auto <file> node, choose "Edit <file> in gvim"
> - edit in gvim
> - rclick on @auto <file> node, choose "Refresh from disk"
> - save Leo file
> - get dialog "<file> has been modified outside Leo, overwrite?"
>
> This warning seems unnecessary and misleading.

The fix is on the trunk at rev 2683. All unit tests pass.

Please report any other problems in this are immediately: the code is
simple in concept but complex in practice.

Edward

Reply all
Reply to author
Forward
0 new messages