kdirwatch patch

1 view
Skip to first unread message

Shie Erlich

unread,
Feb 2, 2006, 4:32:38 PM2/2/06
to krusade...@googlegroups.com
rafi, csaba,
can you have a look at
http://krusader.sourceforge.net/phpBB/viewtopic.php?t=1455


thanks!

--
Shie Erlich
Krusader Krew
http://www.krusader.org/

Karai Csaba

unread,
Feb 3, 2006, 4:29:00 AM2/3/06
to krusade...@googlegroups.com
Rafi,

Once I made the modification the patch writer suggests.
Why was it put back?

I know, that the patch works right, but don't know why it was revoked.
That's why I won't commit it again.

Can you tell something about it?

Thanks,

Csaba


ext Shie Erlich írta:

Rafi Yanai

unread,
Feb 4, 2006, 6:56:50 AM2/4/06
to krusade...@googlegroups.com
I don't remember...

I tried to look at the CVS logs for normal_vfs but I could not find a trace of such a patch or it's removal...
AFAIK you added such a code in the populateVfsList() function but not in other places in the code.

I don't like to destruct the KDirWatch object but i seem that we have to it because the stopScan() method is buggy and does not "release" watched directories.

I think that we can safely apply this patch.

Rafi.

Reply all
Reply to author
Forward
0 new messages