problems building on openSUSE11.3 / error: too few arguments to function filp->f_op->fsync

98 views
Skip to first unread message

dipe

unread,
Jan 22, 2011, 7:23:21 PM1/22/11
to KQStor ZFS Discussion
Hi, I don't seem to be able to build on openSUSE11.3

first I need to adjust the build environment a little to make it
compatible to create_rpm.sh

>mkdir /usr/src/kernels
>ln -s /usr/src/linux "/usr/src/kernels/$(uname -r)"
>cp /usr/src/linux-obj/x86_64/desktop/Module.symvers /usr/src/linux
>cd /usr/src/linux; make oldconfig; make prepare


then I am not sure what to make out of this error:

ox2:/zfs-build # cat /tmp/logzfs/logfile2011-01-22
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c: In function â
€˜spl_debug_dump_all_pages’:
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: warning:
passing argument 2 of ‘filp->f_op->fsync’ makes pointer from
integer without a cast
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: note:
expected ‘struct dentry *’ but argument is of type ‘int’
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: error:
too few arguments to function ‘filp->f_op->fsync’
make[5]: *** [/zfs-build/spl/module/spl/../../module/spl/spl-debug.o]
Error 1
make[4]: *** [/zfs-build/spl/module/spl] Error 2
make[3]: *** [_module_/zfs-build/spl/module] Error 2
make[2]: *** [modules] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Error : spl make error


This is the entire output of create_rpm.sh:
---------------------------------------------------------------------------------------------------------------------------

M META
M scripts/Makefile.in
Already up-to-date.
checking metadata... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking whether to enable maintainer-specific portions of
Makefiles... no
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/x86_64-suse-linux/bin/ld
checking if the linker (/usr/x86_64-suse-linux/bin/ld) is GNU ld...
yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/x86_64-suse-linux/bin/ld option to reload object
files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for ar... ar
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/x86_64-suse-linux/bin/ld -m
elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking spl license... GPL
checking whether rpm is available... yes (4.8.0)
checking whether rpmbuild is available... yes (4.8.0)
checking whether dpkg is available... no
checking whether dpkg-buildpackage is available... no
checking whether alien is available... no
checking linux distribution... sles
checking default package type... rpm
checking spl config... all
checking kernel source directory... /usr/src/kernels/2.6.34.7-0.7-
desktop/
checking kernel build directory... /usr/src/kernels/2.6.34.7-0.7-
desktop/
checking kernel source version... 2.6.34.7-0.7-desktop
checking kernel file name for module symbols... Module.symvers
checking whether debugging is enabled... no
checking whether basic kmem accounting is enabled... yes
checking whether detailed kmem tracking is enabled... no
checking whether atomic types use spinlocks... yes
checking whether kernel defines atomic64_t... no
checking whether kernel defines atomic64_cmpxchg... no
checking whether kernel defines atomic64_xchg... no
checking whether kernel defines uintptr_t... no
checking whether INIT_WORK wants 3 args... no
checking whether register_sysctl_table() wants 2 args... no
checking whether set_shrinker() available... no
checking whether shrinker callback wants 3 args... no
checking whether struct path used in struct nameidata... no
checking whether symbol task_curr is exported... no
checking whether unnumbered sysctl support exists... no
checking whether struct ctl_table has ctl_name... no
checking whether fls64() is available... no
checking whether symbol device_create is exported... yes
checking whether device_create() wants 5 args... no
checking whether symbol class_device_create is exported... no
checking whether symbol set_normalized_timespec is exported... yes
checking whether set_normalized_timespec() is an inline... yes
checking whether timespec_sub() is available... no
checking whether init_utsname() is available... no
checking whether header linux/fdtable.h exists... no
checking whether files_fdtable() is available... no
checking whether header linux/uaccess.h exists... no
checking whether kmalloc_node() is available... no
checking whether symbol monotonic_clock is exported... no
checking whether struct inode has i_mutex... no
checking whether struct mutex has owner... no
checking whether mutex_lock_nested() is available... no
checking whether on_each_cpu() wants 3 args... no
checking whether symbol kallsyms_lookup_name is exported... yes
checking whether symbol get_vmalloc_info is exported... no
checking whether symbol *_pgdat exist... yes
checking whether symbol first_online_pgdat is exported... yes
checking whether symbol next_online_pgdat is exported... yes
checking whether symbol next_zone is exported... no
checking whether symbol pgdat_list is exported... no
checking whether global_page_state() is available... no
checking whether page state NR_FREE_PAGES is available... no
checking whether page state NR_INACTIVE is available... no
checking whether page state NR_INACTIVE_ANON is available... no
checking whether page state NR_INACTIVE_FILE is available... no
checking whether page state NR_ACTIVE is available... no
checking whether page state NR_ACTIVE_ANON is available... no
checking whether page state NR_ACTIVE_FILE is available... no
checking whether symbol get_zone_counts is needed... yes
checking whether symbol get_zone_counts is exported... no
checking whether symbol user_path_at is exported... yes
checking whether symbol set_fs_pwd is exported... no
checking whether set_fs_pwd() wants 2 args... no
checking whether vfs_unlink() wants 2 args... no
checking whether vfs_rename() wants 4 args... no
checking whether struct fs_struct uses spinlock_t... no
checking whether struct cred exists... no
checking whether symbol groups_search is exported... no
checking whether symbol __put_task_struct is exported... no
checking whether proc_handler() wants 5 args... no
checking whether symbol kvasprintf is exported... yes
checking whether file_fsync() wants 3 args... no
checking whether symbol rwsem_is_locked is exported... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating lib/Makefile
config.status: creating cmd/Makefile
config.status: creating module/Makefile
config.status: creating module/spl/Makefile
config.status: creating module/splat/Makefile
config.status: creating include/Makefile
config.status: creating scripts/Makefile
config.status: creating spl.spec
config.status: creating spl-modules.spec
config.status: creating spl_config.h
config.status: executing depfiles commands
config.status: executing libtool commands
make all-recursive
make[1]: Entering directory `/zfs-build/spl'
Making all in lib
make[2]: Entering directory `/zfs-build/spl/lib'
/bin/sh ../libtool --tag=CC --silent --mode=compile gcc -
DHAVE_CONFIG_H -include ../spl_config.h -Wall -Wshadow -Wstrict-
prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -g -O2 -
MT list.lo -MD -MP -MF .deps/list.Tpo -c -o list.lo list.c
mv -f .deps/list.Tpo .deps/list.Plo
/bin/sh ../libtool --tag=CC --silent --mode=link gcc -Wall -Wshadow -
Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -
g -O2 -o libcommon.la list.lo
make[2]: Leaving directory `/zfs-build/spl/lib'
Making all in cmd
make[2]: Entering directory `/zfs-build/spl/cmd'
gcc -DHAVE_CONFIG_H -include ../spl_config.h -I../lib -Wall -
Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -
DNDEBUG -g -O2 -MT spl.o -MD -MP -MF .deps/spl.Tpo -c -o spl.o spl.c
mv -f .deps/spl.Tpo .deps/spl.Po
/bin/sh ../libtool --tag=CC --silent --mode=link gcc -Wall -Wshadow -
Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -
g -O2 -o spl spl.o
gcc -DHAVE_CONFIG_H -include ../spl_config.h -I../lib -Wall -
Wshadow -Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -
DNDEBUG -g -O2 -MT splat.o -MD -MP -MF .deps/splat.Tpo -c -o splat.o
splat.c
mv -f .deps/splat.Tpo .deps/splat.Po
/bin/sh ../libtool --tag=CC --silent --mode=link gcc -Wall -Wshadow -
Wstrict-prototypes -fno-strict-aliasing -D__USE_LARGEFILE64 -DNDEBUG -
g -O2 ../lib/libcommon.la -o splat splat.o
make[2]: Leaving directory `/zfs-build/spl/cmd'
Making all in scripts
make[2]: Entering directory `/zfs-build/spl/scripts'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/zfs-build/spl/scripts'
Making all in module
make[2]: Entering directory `/zfs-build/spl/module'
make -C /usr/src/kernels/2.6.34.7-0.7-desktop/ SUBDIRS=`pwd` modules
make[3]: Entering directory `/usr/src/linux-2.6.34.7-0.7'
CC [M] /zfs-build/spl/module/spl/../../module/spl/spl-debug.o
make[3]: Leaving directory `/usr/src/linux-2.6.34.7-0.7'
make[2]: Leaving directory `/zfs-build/spl/module'
make[1]: Leaving directory `/zfs-build/spl'



Di Pe

unread,
Jan 28, 2011, 8:21:33 AM1/28/11
to KQStor ZFS Discussion
is there any indication that I'm doing something wrong here?

Neependra Khare

unread,
Jan 28, 2011, 9:24:00 AM1/28/11
to kqstor-zf...@googlegroups.com
Hi,

On Sun, Jan 23, 2011 at 5:53 AM, dipe <dip...@gmail.com> wrote:
Hi, I don't seem to be able to build on openSUSE11.3

first I need to adjust the build environment a little to make it
compatible to create_rpm.sh

>mkdir /usr/src/kernels
>ln -s /usr/src/linux "/usr/src/kernels/$(uname -r)"
>cp /usr/src/linux-obj/x86_64/desktop/Module.symvers /usr/src/linux
>cd /usr/src/linux; make oldconfig; make prepare


then I am not sure what to make out of this error:

ox2:/zfs-build # cat /tmp/logzfs/logfile2011-01-22
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c: In function â
€˜spl_debug_dump_all_pages’:
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: warning:
passing argument 2 of ‘filp->f_op->fsync’ makes pointer from
integer without a cast
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: note:
expected ‘struct dentry *’ but argument is of type ‘int’
/zfs-build/spl/module/spl/../../module/spl/spl-debug.c:961:9: error:
too few arguments to function ‘filp->f_op->fsync’
make[5]: *** [/zfs-build/spl/module/spl/../../module/spl/spl-debug.o]
Error 1

In the "spl/config/spl-build.m4" file following is mentioned, which checks how many arguments "file_fsync"  takes.

dnl #
dnl # 2.6.35 API change,
dnl # Unused 'struct dentry *' removed from prototype.
dnl #
AC_DEFUN([SPL_AC_3ARGS_FILE_FSYNC], [
        AC_MSG_CHECKING([whether file_fsync() wants 3 args])
        SPL_LINUX_TRY_COMPILE([
                #include <linux/buffer_head.h>
        ],[
                file_fsync(NULL, NULL, 0);
        ],[
                AC_MSG_RESULT(yes)
                AC_DEFINE(HAVE_3ARGS_FILE_FSYNC, 1,
                          [file_fsync() wants 3 args])
        ],[
                AC_MSG_RESULT(no)
        ])
])

 
Depending on above "HAVE_3ARGS_FILE_FSYNC" is set in "spl_config.h" file, which is used for compilation.

From the error it looks that it is not correctly set.

We'll compile the source locally on OpenSuse for 2.6.34 and kernel and will get back to you.

From the next minor release, we'll be building and uploading the packages for OpenSuse as well.


Thanks and Regards,
Neependra
KQ Stor Support




 

dipe

unread,
Feb 13, 2011, 7:56:54 PM2/13/11
to KQStor ZFS Discussion
Neependra,

any news on this? I just checked out from GIT but am still having the
same error.

Thanks

Denis J. Cirulis

unread,
Feb 14, 2011, 4:57:01 AM2/14/11
to kqstor-zf...@googlegroups.com
Yes, it would be great to hear results on openSUSE. I've tried multiple times to build the ports both from install.sh or manually using source from git.
The next question is how stable is the port for production use ? My target is to make nfs shared pool for virtual machine datastore.
Reply all
Reply to author
Forward
0 new messages