Version information variables in JVersion class backwards incompatible between Joomla 1.7 and 1.6 (and all previous versions): Changes made on purpose ?

[Beat]

Hi all,

I started checking what's needed to make CB run on Joomla 1.7 svn
trunk, but the very first thing I stumbled upon and that became
backwards incompatible with Joomla 1.6, 1.5, 1.0 and Mambo is the
version information location (!!!) :

I'm not sure if this is really wanted in Joomla 1.7, but I have
noticed in class JVersion:

- 2 fundamental and existing since Mambo times public variable being
renamed:

/** @public int Sub Release Level */
public $DEV_LEVEL = '2';

becomes:

/** @var string Maintenance version. */
public $MAINTENANCE = '0';


and

/** @public string Development Status */
public $DEV_STATUS = 'Stable';

becomes:

/** @var string Development STATUS. */
public $STATUS = 'Beta';


Also, an integer documented as string becomes a string documented as
integrer:


/** @var string Build number. */
public $BUILD = 0;

becomes:

/** @public int build Number */
public $BUILD = '';


Less important, but still part of the annoying changes:

/** @public string Date */
public $RELDATE = '14-Apr-2011';
/** @public string Time */
public $RELTIME = '23:00';
/** @public string Timezone */
public $RELTZ = 'GMT';

/** @public string URL */
public $URL = '<a href="http://www.joomla.org">Joomla!</a> is Free
Software released under the GNU General Public License.';


becomes:

/** @var string Code name. */
public $CODE_NAME = 'Ember';

/** @var string Release date. */
public $RELEASE_DATE = '28-Jun-2011';

/** @var string Release time. */
public $RELEASE_TIME = '23:00';

/** @var string Link text. */
public $LINK_TEXT = '<a href="http://www.joomla.org">Joomla!</a> is
Free Software released under the GNU General Public License.';


These renamings, looking as being there just for the sake of renaming
things make even the version checking incompatible between minor
Joomla releases.

Rather annoying to have to check with isset() for even version
information at each page load. The methods inside are not available on
all versions, and can't be used either.

Any reason to rename those variables ?
And will that stay so for 1.7 stable releases ?

Thanks in advance for clarifying,

Beat
www.joomlapolis.com

[Andrew Eddie]

Hi Beat

It's a long story, but can you do a patch to bring JVersion (in
/includes/version.php) back in line with previous versions please.

Thanks.

Regards,
Andrew Eddie
http://learn.theartofjoomla.com - training videos for Joomla 1.6 developers

> --
> You received this message because you are subscribed to the Google Groups "Joomla! CMS Development" group.
> To post to this group, send an email to joomla-...@googlegroups.com.
> To unsubscribe from this group, send email to joomla-dev-cm...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/joomla-dev-cms?hl=en-GB.
>
>

[Beat]

Thank you Andrew.

Patch proposed here:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=26362

tested, also did full source code search on JVersion use, and seen
that unit tests for JVersion still did have correct previous variable
names, so need for changes on unit tests. ;-)

Hope the patch gets accepted for 1.7 RC and 1.7.0 Stable.

Best Regards,
Beat
http://www.joomlapolis.com/

On Jul 9, 1:38 am, Andrew Eddie <mambob...@gmail.com> wrote:
> Hi Beat
>
> It's a long story, but can you do a patch to bring JVersion (in
> /includes/version.php) back in line with previous versions please.
>
> Thanks.
>
> Regards,

> Andrew Eddiehttp://learn.theartofjoomla.com- training videos for Joomla 1.6 developers