Revision Control on 1.6

3 views
Skip to the first unread message

Victor Carbune

unread,
31 Jul 2009, 13:03:2331/07/2009
to joomla-...@googlegroups.com
Hello,

As a result of a discussion with Andrew some time ago, I started implementing revisions in com_content and now I'm almost finished. I have made a patch[1] through Eclipse for the 1.6 trunk which applies the changes, by adding necessary files and
making some minor modifications in order to enable access to revision features and parameters.

All the features from the 1.5 component have been successfully integrated with 1.6 com_content, except draft mode. I'm working on it, as I wish to implement autosaving feature along with concurrent editing, as suggested in a previous discussion and on the forum[2] by dukeofgaming. Would concurrent editing be useful to you in 1.6 ?

Please, if you have time, reply-in with suggestion, bug reports on the current patch. I have applied the patch and archived the files so that you could test it easier, just by extracting and installing as you would do from the trunk[3].

Brief report of changes:
1. Added to com_content 3 models/view/controllers: revisions (main browsing view for an articles versions), revision (revision preview) and compare (used to compare/merge/html compare two revisions).
Articles view from com_content has been slightly modified so that it integrates a starting point for revisions view.
Config.xml was also modified in order to add revision parameters.
Modified the article save method from the article model in order to save revisions if revision control is enabled (avoiding plugins).

2. Language file (administrator/language/en-GB) has been modified accordingly, to add parameters and descriptions.

3. Installation file(joomla.sql) in order to add #__versioncontrol_version and #__versioncontrol_latest, tables needed by version control.

I certainly know that this can be improved, but I need some more experienced feedback regarding features and quality of the files addded/changed. I have made use of JModelList and tried to generally enhance the code so that it uses things available in 1.6.

Thank you,
Victor

[1] http://rosedu.cs.pub.ro/~victorc/trunk/trunk_revisions_31_07_2009.patch
[2] http://forum.joomla.org/viewtopic.php?f=304&t=396204
[3] http://rosedu.cs.pub.ro/~victorc/trunk/revisions_trunk.rar

Bob

unread,
3 Aug 2009, 11:35:0603/08/2009
to Joomla! CMS Development
Do you have a patch that doens't include 1.6? I'd like to test this on
the latest rev of the trunk.

Thanks!

On 31 July, 13:03, Victor Carbune <victor.carb...@gmail.com> wrote:
> Hello,
>
> As a result of a discussion with Andrew some time ago, I started
> implementing revisions in com_content and now I'm almost finished. I have
> made a patch[1]* *through Eclipse for the 1.6 trunk which applies the
> changes, by adding necessary files and
> making some minor modifications in order to enable access to revision
> features and parameters.
>
> All the features from the 1.5 component have been successfully integrated
> with 1.6 com_content, except draft mode. I'm working on it, as I wish to
> implement autosaving feature along with concurrent editing, as suggested in
> a previous discussion and on the forum[2] by dukeofgaming. Would concurrent
> editing be useful to you in 1.6 ?
>
> Please, if you have time, reply-in with suggestion, bug reports on the
> current patch. I have applied the patch and archived the files so that you
> could test it easier, just by extracting and installing as you would do from
> the trunk[3].
>
> Brief report of changes:
> 1. Added to com_content 3 models/view/controllers: *revisions *(main
> browsing view for an articles versions), *revision *(revision preview) and *
> compare* (used to compare/merge/html compare two revisions).
> *Articles* view from com_content has been slightly modified so that it
> integrates a starting point for revisions view.
> *Config.xml *was also modified in order to add revision parameters.
> Modified the article save method from the article model in order to save
> revisions if revision control is enabled (avoiding plugins).
>
> 2. Language file (administrator/language/en-GB) has been modified
> accordingly, to add parameters and descriptions.
>
> 3. Installation file(joomla.sql) in order to add #__versioncontrol_version
> and #__versioncontrol_latest, tables needed by version control.
>
> I certainly know that this can be improved, but I need some more experienced
> feedback regarding features and quality of the files addded/changed. I have
> made use of JModelList and tried to generally enhance the code so that it
> uses things available in 1.6.
>
> Thank you,
> Victor
>
> [1]http://rosedu.cs.pub.ro/~victorc/trunk/trunk_revisions_31_07_2009.patch<http://rosedu.cs.pub.ro/%7Evictorc/trunk/trunk_revisions_31_07_2009.p...>
> [2]http://forum.joomla.org/viewtopic.php?f=304&t=396204
> [3]http://rosedu.cs.pub.ro/~victorc/trunk/revisions_trunk.rar<http://rosedu.cs.pub.ro/%7Evictorc/trunk/revisions_trunk.rar>

Victor Carbune

unread,
3 Aug 2009, 11:46:4803/08/2009
to joomla-...@googlegroups.com
Hello Bob,

The patch [1] does not include 1.6, it just needs to be applied on the (current) trunk.
On the test site [2] I just checked out the svn, applied the patch and installed as you would normally do.

Or this is not what you meant?

[1] http://rosedu.cs.pub.ro/~victorc/trunk/trunk_revisions_31_07_2009.patch
[2] http://rosedu.cs.pub.ro/~victorc/trunk/

Regards,
Victor

Luis Galárraga

unread,
3 Aug 2009, 11:54:0503/08/2009
to joomla-...@googlegroups.com
Download and installed, impressions and suggestions coming soon.

2009/8/3 Victor Carbune <victor....@gmail.com>
Reply all
Reply to author
Forward
0 new messages