sebastien.lelong commented on SVN revision 123.

[codesite...@google.com]

sebastien.lelong commented on SVN revision 123.
Details are at http://code.google.com/p/jallib/source/detail?r=123

Score: Neutral

General Comment:
Should we have a ascii lib ? Something like (or same as) jascii.jal ?

const byte ASCII_NULL = 00
const byte ASCII_SOH = 01
const byte ASCII_STX = 02
const byte ASCII_ETX = 03
const byte ASCII_EOT = 04
...

(original jascii is GPL'd...)

Line-by-line comments:

File: /trunk/unvalidated/include/jal/print.jal (r123)
===============================================================================

Line 58: device = 10
-------------------------------------------------------------------------------
We could include equivalent of jascii.jal and use ascii names here ?
Seb

Respond to these comments at
http://code.google.com/p/jallib/source/detail?r=123
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[Joep Suijs]

I'd say it's not worth it. I only use 3 ascii constants, CR, LF and
(sometimes) TAB. I added the ASCII meaning as comment for now.
As an alternative, i could check if \r \n and \t work properly, but
that's also only meaningfull for a limited audience...

Joep

2008/8/17, codesite...@google.com <codesite...@google.com>:

[Sebastien Lelong]

OK, let's forget it !
Seb

On Aug 18, 9:14 am, "Joep Suijs" <jsu...@gmail.com> wrote:
> I'd say it's not worth it. I only use 3 ascii constants, CR, LF and
> (sometimes) TAB. I added the ASCII meaning as comment for now.
> As an alternative, i could check if \r \n and \t work properly, but
> that's also only meaningfull for a limited audience...
>
> Joep
>

> 2008/8/17, codesite-nore...@google.com <codesite-nore...@google.com>:

>
>
>
> > sebastien.lelong commented on SVN revision 123.

> > Details are athttp://code.google.com/p/jallib/source/detail?r=123

[Rob Hamerling]

> sebastien.lelong commented on SVN revision 123.

> Should we have a ascii lib ? Something like (or same as) jascii.jal ?

>
> const byte ASCII_NULL = 00
> const byte ASCII_SOH = 01
> const byte ASCII_STX = 02
> const byte ASCII_ETX = 03
> const byte ASCII_EOT = 04
> ...

Well, I think not many people will use these characters and then only a
few of these characters (I myself have some of these programs). And
those who need thes chars can probably help themselves! It's better to
spend your time on something more useful for the short term.

Regards, Rob.

--
Rob Hamerling, Vianen, NL (http://www.robh.nl/)

[Eur van Andel]

On 17 Aug 2008, at 11:31 , codesite...@google.com wrote:

Should we have a ascii lib ? Something like (or same as) jascii.jal ?

const byte ASCII_NULL = 00

const byte ASCII_SOH  = 01

const byte ASCII_STX  = 02

const byte ASCII_ETX  = 03

const byte ASCII_EOT  = 04

Yes.

But not:

ASCII_CAPITAL_A

---

ir EE van Andel e...@fiwihex.nl  http://www.fiwihex.nl

Fiwihex B.V. Wierdensestraat 74, NL7604BK Almelo, Netherlands

tel+31-546-491106 fax+31-546-491107

[Sebastien Lelong]

We've finally decided to let this point "floating in the sweet air of
procrastination" (I'm getting tired...) :)

Seb

On Aug 20, 4:43 pm, Eur van Andel <e...@fiwihex.nl> wrote: