The environment LDFLAGS is leaked to final pkg-config file due to broken m4/ax_create_pkgconfig_info.m4

[Samuli Suominen]

To reproduce:

# export LDFLAGS="-Wl,-O1 -Wl,--as-needed"
# ./configure
# make
# make install

Now the "-Wl,-O1 -Wl,--as-needed" is in the Libs: line of the pkg-
config file (isl.pc)

This should not happen

Libs and Libs.private lines are really only for libs and libpaths, as
in -l and -L flags

The responsible .m4 macro should be patch to get rid of this LDFLAGS
reference to avoid polluting the system

[Samuli Suominen]

Also reported here, http://bugs.gentoo.org/382737

On Nov 20, 7:35 am, Samuli Suominen <ssuominen.priv...@gmail.com>
wrote:

[Sven Verdoolaege]

On Sat, Nov 19, 2011 at 09:35:16PM -0800, Samuli Suominen wrote:
> The responsible .m4 macro should be patch to get rid of this LDFLAGS
> reference to avoid polluting the system

Do you have such a patch?

skimo

[Samuli Suominen]

--- m4/ax_create_pkgconfig_info.m4
+++ m4/ax_create_pkgconfig_info.m4
@@ -214,7 +214,7 @@
Description: @PACKAGE_DESCRIPTION@
Version: @PACKAGE_VERSION@
Requires: @PACKAGE_REQUIRES@
-Libs: -L\${libdir} @LDFLAGS@ @LIBS@
+Libs: -L\${libdir} @LIBS@
Cflags: -I\${includedir} @CPPFLAGS@
AXEOF
fi # DONE generate $pkgconfig_generate.in

[Sven Verdoolaege]

On Mon, Dec 12, 2011 at 12:14:07PM -0800, Samuli Suominen wrote:
> --- m4/ax_create_pkgconfig_info.m4
> +++ m4/ax_create_pkgconfig_info.m4

I'd rather not touch this file, unless you can get it changed
upstream (http://savannah.gnu.org/projects/autoconf-archive/).

Btw, please read doc/SubmittingPatches for guidelines on how
to submit patches.

skimo

[dirtye...@gmail.com]

On Monday, 12 December 2011 15:36:58 UTC-6, skimo wrote:

On Mon, Dec 12, 2011 at 12:14:07PM -0800, Samuli Suominen wrote:
> --- m4/ax_create_pkgconfig_info.m4
> +++ m4/ax_create_pkgconfig_info.m4

I'd rather not touch this file, unless you can get it changed
upstream (http://savannah.gnu.org/projects/autoconf-archive/).

This is now fixed upstream.

 http://git.savannah.gnu.org/cgit/autoconf-archive.git/commit/m4/ax_create_pkgconfig_info.m4?id=b7f95244497a32f67f60ec16dabc665c05bab734

[Sven Verdoolaege]

Would you care to send a proper patch
to update ax_create_pkgconfig_info.m4 in isl?

skimo

[dirtye...@gmail.com]

On Tuesday, 8 January 2013 11:24:58 UTC-6, skimo wrote:

Would you care to send a proper patch
to update ax_create_pkgconfig_info.m4 in isl?

Attached patch syncs the file with upstream.  Note the license changed to GPL-3.

[Sven Verdoolaege]

> https://groups.google.com/forum/?fromgroups=#!topic/isl-development/N62HZVflDyw
>
> 2013-01-13 Ryan Hill <dirt...@gentoo.org>
>
> * m4/ax_create_pkgconfig_info.m4: Sync with upstream.

I'm sorry, but especially for a small patch like this,
I'm going to have to insist on a _proper_ patch
(according to the guidelines in doc/SubmittingPatches).

In particular, the commit message does not have a one-line summary,
there is no explanation of why this change is useful and there
is no sign-off.

skimo

[ssuomine...@gmail.com]

So, for 2 years ISL has been adding the build host's LDFLAGS to the resulting .pc file which ends up in all generated packages causing all builds fail... The file you are using is fixed in upstream... And now you have to read a handbook to get
it synced?

That's insane. I don't know about others but I'll rather keep patching this locally than go through reading handbook for this.