Selecting and moving multiple images in Hugin's Image Tab.

[Steeve]

All

I recently had sometime on hand and decided to look at some of the bottlenecks in my use of hugin..

The first one was not being able to move multiple images up and down in the list on the image tab. Working in HDR, I often want to move groups of images up and down, at present you can only move one image at a time which takes considerable time. (Through with hindsight this appears to be a bug?)

When swapping two images, image1 selected and image2 the destination, something seems wrong in UpdatePreviewImage() (called as a result of pano.changeFinished) it loads the destination image2.. This makes moving a single image1 slow, since all the images it is swapping with get loaded and scaled, despite them never being displayed. This is not a problem with moving multiple images, since panoramaImagesChanged tests for selection size equal to one...

The above aside, it seems relatively easy support moving mutiple selected images. Patch (based on 2010.2) attached if anybody would like to try it.. I've opted to just automate swapping images pairs to shuffle a block of images. This avoided writing a new method to delete and re-insert images into the list.

Seems too easy, can anybody see anything I've missed?

Hope this is of interest to other users.

Regards
Stephen

[T. Modes]

Hi Steeve,

> Seems too easy, can anybody see anything I've missed?
>

The patch needs more work:
1.) First, it creates for every image an own command in the command
history, what makes is complicated to use the undo function.
2.) Your patch goes mad, if you select several non-adjacent images. In
this case it moves n images following the first selected image (with n
the number of selected images), but not the selected images. This is
the main reason why moving several images is not so easy. You can not
assume that all selected images are adjacent. If you force this, you
break exisiting functionality.

Thomas

[Steeve]

Thomas.

Apologies for the re-posting.. I did not see the orignal appear in the
group? Since I'd used another emailer to send it I assumed it had been
block.

Yes I'd completely over-looked the fact that non-adjacent images could
be selected..

The 'shuffling' of image does generate alot of 'history'. I'd been
thinking about Yuv's recent post on undo history. For some reason I
never use undo, not that I don't make mistakes, just Hugin provides
other ways to get around mistakes... So again I never thought to test
this patch for it's undo behavoiur. Looks like I do want to write
methods to delete and insert images into the list.

Thank-you for taking the time to review the patch..

Regards
Stephen