[4636] trunk/htdocs/system/classes/xmlrpcclient.php: Add a couple of @todo' s about poor code.

[svn-N...@habariproject.org]

Revision

4636

Author

chrismeller

Date

2010-11-28 00:11:44 +0000 (Sun, 28 Nov 2010)

Log Message

Add a couple of @todo's about poor code.

Modified Paths

• trunk/htdocs/system/classes/xmlrpcclient.php

Diff

Modified: trunk/htdocs/system/classes/xmlrpcclient.php (4635 => 4636)

--- trunk/htdocs/system/classes/xmlrpcclient.php	2010-11-28 00:00:18 UTC (rev 4635)
+++ trunk/htdocs/system/classes/xmlrpcclient.php	2010-11-28 00:11:44 UTC (rev 4636)
@@ -87,9 +87,11 @@
 
 		if ( $request->executed() ) {
 			$response = $request->get_response_body();
+			// @todo this should use the MultiByte class, not directly call mb_string functions
 			$enc = mb_detect_encoding($response);
 			$responseutf8 = mb_convert_encoding($response, 'UTF-8', $enc);
 			try {
+				// @todo this should use libxml_use_internal_errors() instead of trying to hide the PHP warning see the plugin info parsing code for an example
 				$bit = ini_get('error_reporting');
 				error_reporting($bit && !E_WARNING);
 				$responsexml = new SimpleXMLElement($responseutf8);