ServletModule should allow specification of scopes

[Gili]

Hi,

I tried using com.wideplay.warp.persist.PersistenceFilter with guice-
servlet and got this error:

javax.servlet.ServletException: Filters must be bound as singletons.
Key[type=com.wideplay.warp.persist.PersistenceFilter, annotation=
[none]] was not bound in singleton scope.

Fair enough, but there is no way for me to do this. Shouldn't
ServletModule.filter() allow me to specify a scope? I don't think it's
realistic to assume that I can modify existing Filters because as this
example shows sometimes I am trying to use 3rd-party code which I
cannot modify.

Either guice-servlet needs to automatically bind all servlets and
filters to a singleton scope (which is my personal preference) or it
needs to allow me to specify a scope on a Module level without having
to modify the existing Servlet/Filter class.

Gili

[Gili]

Adding:

binder.bind(PersistenceFilter.class).in(Scopes.SINGLETON);

in a separate Module helped. If this is what developers are supposed
to be doing it wasn't immediately obvious to me. If you wish to keep
the API as-is I would suggest mentioning in the documentation that
Servlet/Filter scopes are supposed to be bound in a separate Module.

Gili

[Gili]

I filed http://code.google.com/p/google-guice/issues/detail?id=334

I believe this needs to be resolved for Guice 2.0 since it affects the
specification.

Gili

[Dhanji R. Prasanna]

We should really annotate PersistenceFilter as a @Singleton in warp-persist. I will fix this shortly.

Dhanji.

[Robbie Vanbrabant]

Done: http://code.google.com/p/warp-persist/source/detail?r=300

Robbie

[Dhanji R. Prasanna]

Thanks! my svn commit failed yesterday, so this is opportune =)