1.5 Maven artifacts staged

177 views
Skip to first unread message

Robert Munteanu

unread,
Feb 22, 2011, 6:17:31 PM2/22/11
to googl...@googlegroups.com
Hi,

I've just staged the 1.5 Gin release at

https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/

Some notes:

1. Due to lack of time, this is completely untested. Please verify it
, as I will not promote it to central without verifications.
2. This is the 'post-2.2' version of the artifact. The build process
is tuned for one jar deliverable, but I'm willing to update it if
someone comes up with a patch (
http://github.com/rombert/google-gin-pom ) and include the 'pre-2.2'
one as well.
3. Is the developer list still up-to-date ? Please let me know if I
should add someone ( see
https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/com/googlecode/gwt/inject/gin/1.5/gin-1.5.pom
, developers section )

As I've said, this is completely untested so please give it a spin.

Robert

--
Sent from my (old) computer

Philippe Beaudoin

unread,
Feb 22, 2011, 6:57:51 PM2/22/11
to googl...@googlegroups.com
Thanks for doing this! I tested it on gwt-platform and it works fine.

Is there a reason for the group id being com.googlecode.gwt.inject? I was using com.google.gwt.inject in my own repo, and it seems more in line with gin's package name.

Re: Developer list. From the commit log of gin there are a couple new contributors on that release:
fazal.asim
dburrows
scottb
awiner
philippe.beaudoin (myself ;))


Thomas Broyer

unread,
Feb 22, 2011, 8:13:26 PM2/22/11
to googl...@googlegroups.com

On Wednesday, February 23, 2011 12:17:31 AM UTC+1, Robert Munteanu wrote:
Hi,

I've just staged the 1.5 Gin release at

https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/

Some notes:

1. Due to lack of time, this is completely untested. Please verify it
, as I will not promote it to central without verifications.


  • GIN 1.5 now has a dependency on guice-assistedinject too.
  • same remark as Philippe: GIN 1.0 is com.google.gwt.inject:gin:1.0, not com.googlecode.…
  • I don't understand why the connection (and particularly the developerConnection) points to the tag in the SVN (that was already the case for GIN 1.0)
  • is the parent org.sonatype.oss:oss-parent:6 only for the staging version? it wasn't there for GIN 1.0, what does it change?
 

2. This is the 'post-2.2' version of the artifact. The build process
is tuned for one jar deliverable, but I'm willing to update it if
someone comes up with a patch (
http://github.com/rombert/google-gin-pom ) and include the 'pre-2.2'
one as well.


I deployed GIN as com.google.gwt.inject:gin:1.5-post-gwt-2.2 in our internal repo; is there something wrong with this kind of version number in Maven?
 

3. Is the developer list still up-to-date ? Please let me know if I
should add someone ( see
https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/com/googlecode/gwt/inject/gin/1.5/gin-1.5.pom
, developers section )

As I've said, this is completely untested so please give it a spin.

 
Is this a recompiled version or the "official" JAR?

Robert Munteanu

unread,
Feb 23, 2011, 3:50:54 AM2/23/11
to googl...@googlegroups.com
On Wed, Feb 23, 2011 at 1:57 AM, Philippe Beaudoin
<philippe...@gmail.com> wrote:
> Thanks for doing this! I tested it on gwt-platform and it works fine.
>
> Is there a reason for the group id being com.googlecode.gwt.inject? I was
> using com.google.gwt.inject in my own repo, and it seems more in line with
> gin's package name.


Hi,

The deployment groupId need to be altered since it would fit in with
the 'com.google' deployment profile, which I am not a member of. I've
discussed this with Juven Xu from Sonatype - please see

OSSRH-203: GIN (GWT INjection)
https://issues.sonatype.org/browse/OSSRH-203

, especially the last comments:

>
> Re: Developer list. From the commit log of gin there are a couple new
> contributors on that release:
> fazal.asim
> dburrows
> scottb
> awiner
> philippe.beaudoin (myself ;))

Will update, thanks.

Robert

>
>
> --
> You received this message because you are subscribed to the Google Groups
> "google-gin" group.
> To post to this group, send email to googl...@googlegroups.com.
> To unsubscribe from this group, send email to
> google-gin+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/google-gin?hl=en.

Robert Munteanu

unread,
Feb 23, 2011, 3:59:58 AM2/23/11
to googl...@googlegroups.com
On Wed, Feb 23, 2011 at 3:13 AM, Thomas Broyer <t.br...@gmail.com> wrote:
>
> On Wednesday, February 23, 2011 12:17:31 AM UTC+1, Robert Munteanu wrote:
>>
>> Hi,
>>
>> I've just staged the 1.5 Gin release at
>>
>> https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/
>>
>> Some notes:
>>
>> 1. Due to lack of time, this is completely untested. Please verify it
>> , as I will not promote it to central without verifications.
>
> GIN 1.5 now has a dependency on guice-assistedinject too.

Noted, thanks. Is this the one I should depend on -
http://mavencentral.sonatype.com/#artifactdetails%7Ccom.google.inject.extensions%7Cguice-assisted-inject%7C2.0
?

> same remark as Philippe: GIN 1.0 is com.google.gwt.inject:gin:1.0, not
> com.googlecode.…

Please see my previous reply.

> I don't understand why the connection (and particularly the
> developerConnection) points to the tag in the SVN (that was already the case
> for GIN 1.0)

It should point to the source control location which was used to build
the artifact. Usually this is done by tagging, but for - SNAPSHOT it
usually is trunk. It is also similar to what the maven-release-plugin
does.

> is the parent org.sonatype.oss:oss-parent:6 only for the staging version? it
> wasn't there for GIN 1.0, what does it change?

The parent is used to inherit some basic settings, following the
instructions at
https://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repository+Usage+Guide#SonatypeOSSMavenRepositoryUsageGuide-7a.1.POMandsettingsconfig
. Currently it does the following:

- declares the Sonatype snapshot and staging repositories;
- verifies that the Maven version used is one which we know produced
valid GPG checksums;
- configures some proper defaults when releasing ( sources, javadoc,
gpg ) - but that only affects Maven-based deployments, and I'm using
Ant.

>
>
>>
>> 2. This is the 'post-2.2' version of the artifact. The build process
>> is tuned for one jar deliverable, but I'm willing to update it if
>> someone comes up with a patch (
>> http://github.com/rombert/google-gin-pom ) and include the 'pre-2.2'
>> one as well.
>
> I deployed GIN as com.google.gwt.inject:gin:1.5-post-gwt-2.2 in our internal
> repo; is there something wrong with this kind of version number in Maven?
> (it looks OK to me according
> to http://sonatype.com/books/maven-book/reference/pom-relationships-sect-pom-syntax.html )

I would prefer building with a qualifier, similar to what TestNG does
( or rather did ):

com.google.gwt.inject:gin:1.5:post-gwt-2.2
com.google.gwt.inject:gin:1.5:pre-gwt-2.2

But I have not gotten around to updating the build to do so.

>
>>
>> 3. Is the developer list still up-to-date ? Please let me know if I
>> should add someone ( see
>>
>> https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/com/googlecode/gwt/inject/gin/1.5/gin-1.5.pom
>> , developers section )
>>
>> As I've said, this is completely untested so please give it a spin.
>
>
> Is this a recompiled version or the "official" JAR?

No, I have used the files from the Google Code project downloads section.

Robert

>
> --
> You received this message because you are subscribed to the Google Groups
> "google-gin" group.
> To post to this group, send email to googl...@googlegroups.com.
> To unsubscribe from this group, send email to
> google-gin+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/google-gin?hl=en.
>

--

Pierre

unread,
Feb 23, 2011, 9:26:32 AM2/23/11
to google-gin
Hi,

Should the staged gin-1.5 jar be the one compiled with Java 1.5 and
not Java 1.6 (see issue 140)?

Thanks,
Pierre

On Feb 23, 3:59 am, Robert Munteanu <robert.munte...@gmail.com> wrote:
> On Wed, Feb 23, 2011 at 3:13 AM, Thomas Broyer <t.bro...@gmail.com> wrote:
>
> > On Wednesday, February 23, 2011 12:17:31 AM UTC+1, Robert Munteanu wrote:
>
> >> Hi,
>
> >> I've just staged the 1.5 Gin release at
>
> >>https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-...
>
> >> Some notes:
>
> >> 1. Due to lack of time, this is completely untested. Please verify it
> >> , as I will not promote it to central without verifications.
>
> > GIN 1.5 now has a dependency on guice-assistedinject too.
>
> Noted, thanks. Is this the one I should depend on -http://mavencentral.sonatype.com/#artifactdetails%7Ccom.google.inject...
> ?
>
> > same remark as Philippe: GIN 1.0 is com.google.gwt.inject:gin:1.0, not
> > com.googlecode.…
>
> Please see my previous reply.
>
> > I don't understand why the connection (and particularly the
> > developerConnection) points to the tag in the SVN (that was already the case
> > for GIN 1.0)
>
> It should point to the source control location which was used to build
> the artifact. Usually this is done by tagging, but for - SNAPSHOT it
> usually is trunk. It is also similar to what the maven-release-plugin
> does.
>
> > is the parent org.sonatype.oss:oss-parent:6 only for the staging version? it
> > wasn't there for GIN 1.0, what does it change?
>
> The parent is used to inherit some basic settings, following the
> instructions athttps://docs.sonatype.org/display/Repository/Sonatype+OSS+Maven+Repos...
> . Currently it does the following:
>
> - declares the Sonatype snapshot and staging repositories;
> - verifies that the Maven version used is one which we know produced
> valid GPG checksums;
> - configures some proper defaults when releasing ( sources, javadoc,
> gpg ) - but that only affects Maven-based deployments, and I'm using
> Ant.
>
>
>
> >> 2. This is the 'post-2.2' version of the artifact. The build process
> >> is tuned for one jar deliverable, but I'm willing to update it if
> >> someone comes up with a patch (
> >>http://github.com/rombert/google-gin-pom) and include the 'pre-2.2'
> >> one as well.
>
> > I deployed GIN as com.google.gwt.inject:gin:1.5-post-gwt-2.2 in our internal
> > repo; is there something wrong with this kind of version number in Maven?
> > (it looks OK to me according
> > to http://sonatype.com/books/maven-book/reference/pom-relationships-sect...)
>
> I would prefer building with a qualifier, similar to what TestNG does
> ( or rather did ):
>
> com.google.gwt.inject:gin:1.5:post-gwt-2.2
> com.google.gwt.inject:gin:1.5:pre-gwt-2.2
>
> But I have not gotten around to updating the build to do so.
>
>
>
> >> 3. Is the developer list still up-to-date ? Please let me know if I
> >> should add someone ( see
>
> >>https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-...
> >> , developers section )
>
> >> As I've said, this is completely untested so please give it a spin.
>
> > Is this a recompiled version or the "official" JAR?
>
> No, I have used the files from the Google Code project downloads section.
>
> Robert
>
>
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "google-gin" group.
> > To post to this group, send email to googl...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > google-gin+...@googlegroups.com.
> > For more options, visit this group at
> >http://groups.google.com/group/google-gin?hl=en.
>
> --
> Sent from my (old) computer- Hide quoted text -
>
> - Show quoted text -

Robert Munteanu

unread,
Feb 23, 2011, 9:36:07 AM2/23/11
to googl...@googlegroups.com
On Wed, Feb 23, 2011 at 4:26 PM, Pierre <plco...@gmail.com> wrote:
> Hi,
>
> Should the staged gin-1.5 jar be the one compiled with Java 1.5 and
> not Java 1.6 (see issue 140)?

If the 'final' 1.5 jar will be compiled with Java 1.5 that is the one
I will pick up.

Robert

Thomas Broyer

unread,
Feb 23, 2011, 1:40:24 PM2/23/11
to googl...@googlegroups.com


On Wednesday, February 23, 2011 9:59:58 AM UTC+1, Robert Munteanu wrote:
On Wed, Feb 23, 2011 at 3:13 AM, Thomas Broyer <t.br...@gmail.com> wrote:
>
> On Wednesday, February 23, 2011 12:17:31 AM UTC+1, Robert Munteanu wrote:
>>
>> Hi,
>>
>> I've just staged the 1.5 Gin release at
>>
>> https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/
>>
>> Some notes:
>>
>> 1. Due to lack of time, this is completely untested. Please verify it
>> , as I will not promote it to central without verifications.
>
> GIN 1.5 now has a dependency on guice-assistedinject too.

Noted, thanks. Is this the one I should depend on -
http://mavencentral.sonatype.com/#artifactdetails%7Ccom.google.inject.extensions%7Cguice-assisted-inject%7C2.0
?


 

> same remark as Philippe: GIN 1.0 is com.google.gwt.inject:gin:1.0, not
> com.googlecode.…

Please see my previous reply.


Too bad!
Cannot someone from Google publish GIN then? (maybe ask on the Guice list?)

>> 2. This is the 'post-2.2' version of the artifact. The build process
>> is tuned for one jar deliverable, but I'm willing to update it if
>> someone comes up with a patch (
>> http://github.com/rombert/google-gin-pom ) and include the 'pre-2.2'
>> one as well.
>
> I deployed GIN as com.google.gwt.inject:gin:1.5-post-gwt-2.2 in our internal
> repo; is there something wrong with this kind of version number in Maven?
> (it looks OK to me according
> to http://sonatype.com/books/maven-book/reference/pom-relationships-sect-pom-syntax.html )

I would prefer building with a qualifier, similar to what TestNG does
( or rather did ):

com.google.gwt.inject:gin:1.5:post-gwt-2.2
com.google.gwt.inject:gin:1.5:pre-gwt-2.2


You mean a classifier? (like testng's jdk14 and jdk15?)
but then there would be a single gin-1.5.pom, right? and they do not have the same GWT dependencies!

Brian Reilly

unread,
Feb 23, 2011, 2:04:11 PM2/23/11
to googl...@googlegroups.com
I think it would be worth trying to create a single jar that will work with both versions. It's an issue I've been talking up some on the GWT users group (https://groups.google.com/d/topic/google-web-toolkit/PNvhvNaWaVc/discussion). Application developers may have other problems to deal with when upgrading to GWT 2.2. Worrying about which builds of 3rd party libraries they need should be avoided if at all possible. Instead, library developers (myself included) should take on that burden.

My basic idea is that the library JAR could contain 2 compilations of the generator code, one against 2.1.1 and the other against 2.2+. There might be a couple of ways to choose between them:

1. Check a gwt.version property inside the generate-with tag in the library's module XML (or some other property if there is no gwt.version... but maybe now is the time for one to be added)
2. Add some bootstrap code that uses reflection to check whether JType is an interface or a class, as suggested by Scott Blum (https://groups.google.com/d/msg/google-web-toolkit/PNvhvNaWaVc/86or2--pn-IJ)
3. Provide multiple module XML files. This still puts some burden on the application developer, but at least they don't have to worry about different JARs (which I think could get complicated when using maven).

Creating such a JAR could be a pain, but I think it would be worth it both for ease of use and ease of support.

-Brian

Robert Munteanu

unread,
Feb 24, 2011, 8:11:28 AM2/24/11
to googl...@googlegroups.com
On Wed, Feb 23, 2011 at 8:40 PM, Thomas Broyer <t.br...@gmail.com> wrote:
>
>
> On Wednesday, February 23, 2011 9:59:58 AM UTC+1, Robert Munteanu wrote:
>>
>> On Wed, Feb 23, 2011 at 3:13 AM, Thomas Broyer <t.br...@gmail.com> wrote:
>> >
>> > On Wednesday, February 23, 2011 12:17:31 AM UTC+1, Robert Munteanu
>> > wrote:
>> >>
>> >> Hi,
>> >>
>> >> I've just staged the 1.5 Gin release at
>> >>
>> >>
>> >> https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-220/
>> >>
>> >> Some notes:
>> >>
>> >> 1. Due to lack of time, this is completely untested. Please verify it
>> >> , as I will not promote it to central without verifications.
>> >
>> > GIN 1.5 now has a dependency on guice-assistedinject too.
>>
>> Noted, thanks. Is this the one I should depend on -
>>
>> http://mavencentral.sonatype.com/#artifactdetails%7Ccom.google.inject.extensions%7Cguice-assisted-inject%7C2.0
>> ?
>
> No,
> com.google.inject.extensions:guice-assistedinject:3.0-rc2 http://mavencentral.sonatype.com/#artifactdetails%7Ccom.google.inject.extensions%7Cguice-assistedinject%7C3.0-rc2

Thanks, updated.

>
>>
>> > same remark as Philippe: GIN 1.0 is com.google.gwt.inject:gin:1.0, not
>> > com.googlecode.…
>>
>> Please see my previous reply.
>
> Too bad!
> Cannot someone from Google publish GIN then? (maybe ask on the Guice list?)

That's unfortunately out of my court. Perhaps someone at Google
already working on Gin can short-circuit the process. Last time I
checked, I could not find the one who deployed it. But, of course, the
scripts can be easily reused by someone who can deploy in the
com.google profile ( see https://github.com/rombert/google-gin-pom ).

>>
>> >> 2. This is the 'post-2.2' version of the artifact. The build process
>> >> is tuned for one jar deliverable, but I'm willing to update it if
>> >> someone comes up with a patch (
>> >> http://github.com/rombert/google-gin-pom ) and include the 'pre-2.2'
>> >> one as well.
>> >
>> > I deployed GIN as com.google.gwt.inject:gin:1.5-post-gwt-2.2 in our
>> > internal
>> > repo; is there something wrong with this kind of version number in
>> > Maven?
>> > (it looks OK to me according
>> >
>> > to http://sonatype.com/books/maven-book/reference/pom-relationships-sect-pom-syntax.html )
>>
>> I would prefer building with a qualifier, similar to what TestNG does
>> ( or rather did ):
>>
>> com.google.gwt.inject:gin:1.5:post-gwt-2.2
>> com.google.gwt.inject:gin:1.5:pre-gwt-2.2
>
> You mean a classifier? (like testng's jdk14 and jdk15?)
> but then there would be a single gin-1.5.pom, right? and they do not have
> the same GWT dependencies!

That's correct, I've updated the script to deploy two different
versions. One question though, what is the minimum GWT version
required for the pre-2.2 artifact?

Robert Munteanu

unread,
Feb 24, 2011, 8:13:03 AM2/24/11
to googl...@googlegroups.com
Thanks! I've updated the developers list. One thing though - except
for you and Fazal Asim, I can't extract any proper names from the
usernames. I can easily guess, but don't want to. So I've left just
the usernames and will add names as well if anyone can send me a list.

Robert

On Wed, Feb 23, 2011 at 1:57 AM, Philippe Beaudoin
<philippe...@gmail.com> wrote:

> Re: Developer list. From the commit log of gin there are a couple new
> contributors on that release:
> fazal.asim
> dburrows
> scottb
> awiner
> philippe.beaudoin (myself ;))

--

Brian Stoler

unread,
Feb 24, 2011, 9:58:46 AM2/24/11
to googl...@googlegroups.com, Robert Munteanu, Peter Schmitt
Peter (aragos) and I work at Google (along with awiner and scottb). (I created Gin but am currently just a lurker here.) What do we need to do to get the packages created with the right names?

--

Robert Munteanu

unread,
Feb 24, 2011, 10:20:44 AM2/24/11
to Brian Stoler, googl...@googlegroups.com, Peter Schmitt
On Thu, Feb 24, 2011 at 4:58 PM, Brian Stoler <bst...@google.com> wrote:
> Peter (aragos) and I work at Google (along with awiner and scottb). (I
> created Gin but am currently just a lurker here.) What do we need to do to
> get the packages created with the right names?

Find out who is responsible for deploying on Maven central for the
com.google profile and ask them to deploy the artifacts. He/she can
use my github project as a starting point.

Robert

Robert Munteanu

unread,
Feb 24, 2011, 4:32:41 PM2/24/11
to Brian Stoler, googl...@googlegroups.com, Peter Schmitt
In the meantime I've re-staged 1.5 , with two versions: 1.5.0-pre-2.2
and 1.5.0-post-2.2 . They depend on GWT 1.5.3 ( as did Gin 1.0 ) and
GWT 2.2.0 .

Please find them at
https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-026/

As for the groupId discussion, I'll just wait for a decision from the
devs. From the central repo statistics I can see that there have been
11k downloads of GIN 1.0, so this version is indeed in use. If the
decision is to deploy with the com.google groupId, I will not promote
this one to staging.

Cheers,

Robert

Peter Schmitt

unread,
Feb 24, 2011, 5:23:49 PM2/24/11
to Robert Munteanu, Brian Stoler, googl...@googlegroups.com
I'm working on getting the right permissions to use the com.google profile so I should be able to push the "correct" version. The new jar is also ready (just need someone to confirm) so the final release will also soon be available.

Peter

Robert Munteanu

unread,
Feb 24, 2011, 5:25:30 PM2/24/11
to Peter Schmitt, Brian Stoler, googl...@googlegroups.com
Goodie. Let me know if you plan on using my script, I can help you
with the initial setup.

David Chandler

unread,
Feb 24, 2011, 6:06:04 PM2/24/11
to google-gin
Thanks, Robert. I'm working with Peter and looking at your POM. FYI,
assistedinject should be one word (no hyphen) in the dependency.

What are the chances of getting GIN to build with maven so deployment
will be that much easier? I did a quick test by moving src and test
into src/main/java, src/test/java and adding the compiler plugin with
1.6. I get a boatload of TypeLiteral errs like

[ERROR] /home/drfibonacci/code/gin/src/main/java/com/google/gwt/inject/
rebind/util/SourceWriteUtil.java:[254,35] cannot find symbol
symbol : method getRawType()
location: class com.google.inject.TypeLiteral<capture#456 of ?>

/dmc


On Feb 24, 5:25 pm, Robert Munteanu <robert.munte...@gmail.com> wrote:
> Goodie. Let me know if you plan on using my script, I can help you
> with the initial setup.
>
>
>
>
>
>
>
>
>
> On Fri, Feb 25, 2011 at 12:23 AM, Peter Schmitt <ara...@gmail.com> wrote:
> > I'm working on getting the right permissions to use the com.google profile
> > so I should be able to push the "correct" version. The new jar is also ready
> > (just need someone to confirm) so the final release will also soon be
> > available.
> > Peter
>
> > On Thu, Feb 24, 2011 at 16:32, Robert Munteanu <robert.munte...@gmail.com>
> > wrote:
>
> >> In the meantime I've re-staged 1.5 , with two versions: 1.5.0-pre-2.2
> >> and 1.5.0-post-2.2 . They depend on GWT 1.5.3 ( as did Gin 1.0 ) and
> >> GWT 2.2.0 .
>
> >> Please find them at
> >>https://oss.sonatype.org/content/repositories/comgooglecodegwtinject-...
>
> >> As for the groupId discussion, I'll just wait for a decision from the
> >> devs. From the central repo statistics I can see that there have been
> >> 11k downloads of GIN 1.0, so this version is indeed in use. If the
> >> decision is to deploy with the com.google groupId, I will not promote
> >> this one to staging.
>
> >> Cheers,
>
> >> Robert
>
> >> On Thu, Feb 24, 2011 at 5:20 PM, Robert Munteanu
> >> <robert.munte...@gmail.com> wrote:
> >> > On Thu, Feb 24, 2011 at 4:58 PM, Brian Stoler <bsto...@google.com>
> >> > wrote:
> >> >> Peter (aragos) and I work at Google (along with awiner and scottb). (I
> >> >> created Gin but am currently just a lurker here.) What do we need to do
> >> >> to
> >> >> get the packages created with the right names?
>
> >> > Find out who is responsible for deploying on Maven central for the
> >> > com.google profile and ask them to deploy the artifacts. He/she can
> >> > use my github project as a starting point.
>
> >> > Robert
>
> >> >> On Thu, Feb 24, 2011 at 5:13 AM, Robert Munteanu
> >> >> <robert.munte...@gmail.com>

Peter Schmitt

unread,
Feb 24, 2011, 6:15:03 PM2/24/11
to googl...@googlegroups.com
What are the chances of getting GIN to build with maven so deployment
will be that much easier? I did a quick test by moving src and test
into src/main/java, src/test/java and adding the compiler plugin with
1.6. I get a boatload of TypeLiteral errs like

Gin uses super-source to emulate certain Guice types in the GWT compiler. We exclude these definitions in the ant build, see also  http://code.google.com/p/google-gin/source/browse/trunk/build.xml#144

Robert Munteanu

unread,
Feb 24, 2011, 6:15:47 PM2/24/11
to googl...@googlegroups.com
On Fri, Feb 25, 2011 at 1:06 AM, David Chandler <drfib...@google.com> wrote:
> Thanks, Robert. I'm working with Peter and looking at your POM. FYI,
> assistedinject should be one word (no hyphen) in the dependency.

OK, fixed.

>
> What are the chances of getting GIN to build with maven so deployment
> will be that much easier? I did a quick test by moving src and test
> into src/main/java, src/test/java and adding the compiler plugin with
> 1.6. I get a boatload of TypeLiteral errs like

It might work, I'm not aware of any limitations.

>
> [ERROR] /home/drfibonacci/code/gin/src/main/java/com/google/gwt/inject/
> rebind/util/SourceWriteUtil.java:[254,35] cannot find symbol
> symbol  : method getRawType()
> location: class com.google.inject.TypeLiteral<capture#456 of ?>
>

I'll have to try myself...

Robert

Robert Munteanu

unread,
Feb 24, 2011, 6:21:09 PM2/24/11
to googl...@googlegroups.com
On Fri, Feb 25, 2011 at 1:15 AM, Robert Munteanu
<robert....@gmail.com> wrote:
> On Fri, Feb 25, 2011 at 1:06 AM, David Chandler <drfib...@google.com> wrote:
>> Thanks, Robert. I'm working with Peter and looking at your POM. FYI,
>> assistedinject should be one word (no hyphen) in the dependency.
>
> OK, fixed.
>
>>
>> What are the chances of getting GIN to build with maven so deployment
>> will be that much easier? I did a quick test by moving src and test
>> into src/main/java, src/test/java and adding the compiler plugin with
>> 1.6. I get a boatload of TypeLiteral errs like
>
> It might work, I'm not aware of any limitations.

As long as Gin will create two artifacts per release, with different
versions, I think Maven will be a rough fit. It might be more
worthwhile for me to come up with a patch to the build process which
includes deployment to the Sonatype repository ( snapshots and
releases ).

Robert

David Chandler

unread,
Feb 24, 2011, 6:32:44 PM2/24/11
to googl...@googlegroups.com, Robert Munteanu
Sounds good, Robert.
David Chandler
Developer Programs Engineer, Google Web Toolkit
w: http://code.google.com/
b: http://googlewebtoolkit.blogspot.com/
t: @googledevtools

Robert Munteanu

unread,
Feb 24, 2011, 6:50:05 PM2/24/11
to David Chandler, googl...@googlegroups.com
I'll set some time aside in the near future to contribute a patch
which would include the contents of my build.xml and the pom.xml.in
template.

Robert

Peter Schmitt

unread,
Feb 28, 2011, 5:31:53 PM2/28/11
to googl...@googlegroups.com, Robert Munteanu, David Chandler
Hi all,

I pushed the gin 1.5 release (post-gwt-2.2) to staging under com.google.gwt.inject: https://oss.sonatype.org/content/repositories/central_bundles-142/

Please test the release and let me know whether it works (me having very little experience with maven :). If things are satisfactory I'll release this version.

Thanks!

Peter

Philippe Beaudoin

unread,
Feb 28, 2011, 5:53:16 PM2/28/11
to googl...@googlegroups.com, Robert Munteanu, David Chandler
Worked perfectly for me on GWT-platform. I'll use it on GWTP trunk as soon as it lands on Maven Central.

Thanks!

   Philippe

Thomas Broyer

unread,
Feb 28, 2011, 7:15:21 PM2/28/11
to googl...@googlegroups.com, Robert Munteanu, David Chandler


On Monday, February 28, 2011 11:31:53 PM UTC+1, Aragos wrote:
Hi all,

I pushed the gin 1.5 release (post-gwt-2.2) to staging under com.google.gwt.inject: https://oss.sonatype.org/content/repositories/central_bundles-142/

So, only the post-gwt-2.2 will be published on a Maven repo? I'm fine with it as were already using GWT trunk, and another project recently upgraded to GWT 2.2 (so I don't think we have any project still on pre-2.2, or they are projects in "maintenance mode");but it might not be the case for everyone (particularly if they use other 3rd party libs with no 2.2-compatible release).

About the dependencies, gwt-servlet is probably not needed, as GIN has nothing to do with the server side of apps.

(in theory there should be gwt-dev, as GIN is a generator, but given how people are using GWT in their projects, I think it's OK to leave it out, gwt-dev will be provided to/by the compiler/devmode anyway)

David Chandler

unread,
Feb 28, 2011, 7:47:22 PM2/28/11
to googl...@googlegroups.com
Yes, that's the plan. Folks who really need pre-2.2 can use this version uploaded by (Robert?)

<dependency>
  <groupId>com.googlecode.gwt.inject</groupId>
  <artifactId>gin</artifactId>
  <version>1.5.0-pre-2.2</version>
</dependency>

/dmc

Pierre

unread,
Feb 28, 2011, 9:02:43 PM2/28/11
to google-gin
I tested it on Mvp4g and it works well.

Thanks for your work,
Pierre

Peter Schmitt

unread,
Mar 1, 2011, 1:59:39 PM3/1/11
to googl...@googlegroups.com, Pierre
The release has been pushed and is available in maven central now: http://repo2.maven.org/maven2/com/google/gwt/inject/gin/1.5.0

Enjoy!

Peter

Jamie Whitehouse

unread,
Mar 3, 2011, 3:44:16 PM3/3/11
to google-gin
On Feb 28, 5:31 pm, Peter Schmitt <ara...@gmail.com> wrote:
> Hi all,
>
> I pushed the gin 1.5 release (post-gwt-2.2) to staging under
> com.google.gwt.inject:https://oss.sonatype.org/content/repositories/central_bundles-142/
>
> Please test the release and let me know whether it works (me having very
> little experience with maven :). If things are satisfactory I'll release
> this version.

Has this been released? I can't find it in Maven central nor does the
above URL resolve to anything useful.

Thanks,
Jamie.

>
> Thanks!
>
> Peter
>
> On Thu, Feb 24, 2011 at 18:50, Robert Munteanu <robert.munte...@gmail.com>wrote:
>
>
>
>
>
>
>
> > I'll set some time aside in the near future to contribute a patch
> > which would include the contents of my build.xml and the pom.xml.in
> > template.
>
> > Robert
>
> > On Fri, Feb 25, 2011 at 1:32 AM, David Chandler <drfibona...@google.com>
> > wrote:
> > > Sounds good, Robert.
>
> > > On Thu, Feb 24, 2011 at 6:21 PM, Robert Munteanu <
> > robert.munte...@gmail.com>
> > > wrote:
>
> > >> On Fri, Feb 25, 2011 at 1:15 AM, Robert Munteanu
> > >> <robert.munte...@gmail.com> wrote:
> > >> > On Fri, Feb 25, 2011 at 1:06 AM, David Chandler <
> > drfibona...@google.com>

Peter Schmitt

unread,
Mar 3, 2011, 3:57:33 PM3/3/11
to googl...@googlegroups.com, Jamie Whitehouse
Yes, see this earlier message:

On Tue, Mar 1, 2011 at 13:59, Peter Schmitt <ara...@gmail.com> wrote:
The release has been pushed and is available in maven central now: http://repo2.maven.org/maven2/com/google/gwt/inject/gin/1.5.0

Enjoy!

Peter
 

Jamie Whitehouse

unread,
Mar 4, 2011, 10:17:13 AM3/4/11
to google-gin
Thanks. Somehow I missed the second google groups page that mentioned
this.

On Mar 3, 3:57 pm, Peter Schmitt <ara...@gmail.com> wrote:
> Yes, see this earlier message:
>
> On Tue, Mar 1, 2011 at 13:59, Peter Schmitt <ara...@gmail.com> wrote:
> > The release has been pushed and is available in maven central now:
> >http://repo2.maven.org/maven2/com/google/gwt/inject/gin/1.5.0
>
> > Enjoy!
>
> > Peter
>
> On Thu, Mar 3, 2011 at 15:44, Jamie Whitehouse
> <basil.whiteho...@gmail.com>wrote:

Robert Munteanu

unread,
Mar 8, 2011, 3:50:01 PM3/8/11
to Peter Schmitt, googl...@googlegroups.com, David Chandler
On Tue, Mar 1, 2011 at 12:31 AM, Peter Schmitt <ara...@gmail.com> wrote:
> Hi all,
> I pushed the gin 1.5 release (post-gwt-2.2) to staging under
> com.google.gwt.inject:
> https://oss.sonatype.org/content/repositories/central_bundles-142/
> Please test the release and let me know whether it works (me having very
> little experience with maven :). If things are satisfactory I'll release
> this version.
> Thanks!
> Peter

Did you set up a deployment mechanism or would you still be interested
in my submitting a patch for automating the deployment?

crllvnc

unread,
Mar 9, 2011, 8:52:54 AM3/9/11
to google-gin
Silly question : can someone provide the sonatype repo address where
to get this dependency?

Thomas Broyer

unread,
Mar 9, 2011, 2:04:57 PM3/9/11
to googl...@googlegroups.com
Same silly question as was asked 8 days ago. Let's try a more imaginative answer ;-)

Peter Schmitt

unread,
Mar 9, 2011, 2:25:42 PM3/9/11
to Robert Munteanu, googl...@googlegroups.com, David Chandler
Hoi Robert,

I've had some help in the form of a script provided by someone else but a formalized approach would be great. Right now I don't really have the time to go over it but hopefully in a few weeks I'll be able to take another look. Feel free to create an issue and a code review, I'll take a look as soon as it's possible.
Reply all
Reply to author
Forward
0 new messages