escape

[Mike Stay]

Cajita overrides the function escape, typically used to do url
escaping. Was that intentional?

--
Mike Stay - meta...@gmail.com
http://math.ucr.edu/~mike
http://reperiendi.wordpress.com

[Mike Samuel]

Use encodeURIComponent instead.

2010/2/2 Mike Stay <meta...@gmail.com>

[Mark S. Miller]

On Mon, Feb 1, 2010 at 6:49 PM, Mike Stay <meta...@gmail.com> wrote:

Cajita overrides the function escape, typically used to do url
escaping.  Was that intentional?

Just looked. This is a bug. The intension was to define a cajita.escape() that had nothing to do with the global escape. However, the code for capturing the global escape, if there is one, in sharedImports is

  sharedImports = {

    ...

    escape: escape ? markFuncFreeze(escape) : (void 0),

    ...

  };

Since this appears within the main body of cajita.js, it is accidentally capturing the internally defined escape function intended for use as cajita.escape(). We should simply rename cajita.escape(). To what? Please, no one suggest "cajita.callWithEscapeContinuation()" ;).

 

--
Mike Stay - meta...@gmail.com
http://math.ucr.edu/~mike
http://reperiendi.wordpress.com

--
   Cheers,
   --MarkM

[Mike Stay]

On Tue, Feb 2, 2010 at 2:44 PM, Mark S. Miller <eri...@google.com> wrote:
> On Mon, Feb 1, 2010 at 6:49 PM, Mike Stay <meta...@gmail.com> wrote:
>>
>> Cajita overrides the function escape, typically used to do url
>> escaping.  Was that intentional?
>>
>
> Just looked. This is a bug. The intension was to define a cajita.escape()
> that had nothing to do with the global escape. However, the code for
> capturing the global escape, if there is one, in sharedImports is
>   sharedImports = {
>     ...
>     escape: escape ? markFuncFreeze(escape) : (void 0),
>     ...
>   };
> Since this appears within the main body of cajita.js, it is accidentally
> capturing the internally defined escape function intended for use as
> cajita.escape(). We should simply rename cajita.escape(). To what? Please,
> no one suggest "cajita.callWithEscapeContinuation()" ;).

Why rename cajita.escape? I think it's perfectly fine. Just use
global.escape in the section above, or replace it with
escapeURIComponent or don't include it at all.

[Mark S. Miller]

On Mon, Feb 1, 2010 at 8:07 PM, Mike Stay <meta...@gmail.com> wrote:

On Tue, Feb 2, 2010 at 2:44 PM, Mark S. Miller <eri...@google.com> wrote:
> On Mon, Feb 1, 2010 at 6:49 PM, Mike Stay <meta...@gmail.com> wrote:
>>
>> Cajita overrides the function escape, typically used to do url
>> escaping.  Was that intentional?
>>
>
> Just looked. This is a bug. The intension was to define a cajita.escape()
> that had nothing to do with the global escape. However, the code for
> capturing the global escape, if there is one, in sharedImports is
>   sharedImports = {
>     ...
>     escape: escape ? markFuncFreeze(escape) : (void 0),
>     ...
>   };
> Since this appears within the main body of cajita.js, it is accidentally
> capturing the internally defined escape function intended for use as
> cajita.escape(). We should simply rename cajita.escape(). To what? Please,
> no one suggest "cajita.callWithEscapeContinuation()" ;).

Why rename cajita.escape?

To avoid an unnecessary coincidence if another name that's as good could be found. But I haven't thought of anything.

 

 I think it's perfectly fine.  Just use
global.escape in the section above, or replace it with
escapeURIComponent or don't include it at all.

That would also be fine. 

 

--

Mike Stay - meta...@gmail.com
http://math.ucr.edu/~mike
http://reperiendi.wordpress.com

--
   Cheers,
   --MarkM

[Mike Samuel]

Has a bug been filed?

2010/2/2 Mark S. Miller <eri...@google.com>

[David-Sarah Hopwood]

Mike Stay wrote:
> On Tue, Feb 2, 2010 at 2:44 PM, Mark S. Miller <eri...@google.com> wrote:
>> On Mon, Feb 1, 2010 at 6:49 PM, Mike Stay <meta...@gmail.com> wrote:
>>> Cajita overrides the function escape, typically used to do url
>>> escaping. Was that intentional?
>>>
>> Just looked. This is a bug. The intension was to define a cajita.escape()
>> that had nothing to do with the global escape. However, the code for
>> capturing the global escape, if there is one, in sharedImports is
>> sharedImports = {
>> ...
>> escape: escape ? markFuncFreeze(escape) : (void 0),
>> ...
>> };
>> Since this appears within the main body of cajita.js, it is accidentally
>> capturing the internally defined escape function intended for use as
>> cajita.escape(). We should simply rename cajita.escape(). To what? Please,
>> no one suggest "cajita.callWithEscapeContinuation()" ;).
>
> Why rename cajita.escape? I think it's perfectly fine.

I wouldn't have had any idea that cajita.escape had something to do with
escape continuations. I suggest cajita.callWithEscape.

--
David-Sarah Hopwood ⚥ http://davidsarah.livejournal.com

[Mark S. Miller]

As a description of what it actually does, perhaps callWithEjector?

 

--
David-Sarah Hopwood  ⚥  http://davidsarah.livejournal.com

--
   Cheers,
   --MarkM

[David-Sarah Hopwood]

Mark S. Miller wrote:
> David-Sarah Hopwood <david...@jacaranda.org> wrote:
>> Mike Stay wrote:
>>> On Tue, Feb 2, 2010 at 2:44 PM, Mark S. Miller <eri...@google.com>
>> wrote:

>>>> ... We should simply rename cajita.escape(). To what?

>>>> Please, no one suggest "cajita.callWithEscapeContinuation()" ;).
>>>
>>> Why rename cajita.escape? I think it's perfectly fine.
>>
>> I wouldn't have had any idea that cajita.escape had something to do with
>> escape continuations. I suggest cajita.callWithEscape.
>
> As a description of what it actually does, perhaps callWithEjector?

Yes, that's better.

[Mark S. Miller]

On Mon, Feb 1, 2010 at 10:14 PM, Mike Samuel <mikes...@gmail.com> wrote:

Has a bug been filed?

Has now. http://code.google.com/p/google-caja/issues/detail?id=1183

--
   Cheers,
   --MarkM