Re: Use dynamic linker provided information to fill library mappings in linux minidumps, when possible (issue 587002)

[ted.mie...@gmail.com]

Just some nits.


https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc
File src/client/linux/minidump_writer/minidump_writer.cc (right):

https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc#newcode901
src/client/linux/minidump_writer/minidump_writer.cc:901:
dumper_->CopyFromProcess(&one_dyn, GetCrashThread(), dyn++,
Google style frowns upon using prefix/postfix operators in an
expression, they should be their own statement.

https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc#newcode937
src/client/linux/minidump_writer/minidump_writer.cc:937: PageAllocator&
allocator, bool only_entry_and_gate = false) {
Google style doesn't allow default parameters.

https://breakpad.appspot.com/587002/diff/1/src/client/linux/minidump_writer/minidump_writer.cc#newcode973
src/client/linux/minidump_writer/minidump_writer.cc:973: // another
stream in the file.
Can you fix this comment to be in third-person while you're moving it?

https://breakpad.appspot.com/587002/