Re: Try getting file-ids from memory when possible, and fallback to reading files otherwise (issue 586002)

[ted.mie...@gmail.com]

Just one comment, otherwise LGTM.


https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc
File src/client/linux/minidump_writer/linux_dumper.cc (right):

https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode106
src/client/linux/minidump_writer/linux_dumper.cc:106: size_t size =
getpagesize();
This should probably be using sys_sysconf(_SC_PAGESIZE) to avoid glibc.

https://breakpad.appspot.com/586002/

[ted.mie...@gmail.com]

https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc
File src/client/linux/minidump_writer/linux_dumper.cc (right):

https://breakpad.appspot.com/586002/diff/1/src/client/linux/minidump_writer/linux_dumper.cc#newcode106
src/client/linux/minidump_writer/linux_dumper.cc:106: size_t size =
getpagesize();

The comments about avoiding glibc were mostly about our
dynamic-linker-avoidance in the crashed process in general, so
sys_sysconf would be the syscall implementation from
linux_syscall_support.

https://breakpad.appspot.com/586002/