golang-codereviews

Contact owners and managers

1–30 of 93612

0 selected

Jes Cok (Gerrit)

7:26 AM

[go] net/http: check index-out-of-bounds for Request.matches in PathValue, SetPathValue

Jes Cok has uploaded the change for review Commit message net/http: check index-out-of-bounds for

unread,

[go] net/http: check index-out-of-bounds for Request.matches in PathValue, SetPathValue

Jes Cok has uploaded the change for review Commit message net/http: check index-out-of-bounds for

7:26 AM

Felix Geisendörfer (Gerrit)2

7:24 AM

[go] runtime: make maxStack runtime configurable

Felix Geisendörfer added 4 comments File src/runtime/mprof.go Line 43, Patchset 10: upperMaxStack =

unread,

[go] runtime: make maxStack runtime configurable

Felix Geisendörfer added 4 comments File src/runtime/mprof.go Line 43, Patchset 10: upperMaxStack =

7:24 AM

Gerrit Bot (Gerrit), … Alan Donovan (Gerrit)10

7:23 AM

[go] go.ast: add CommentGroup.Raw function

Attention needed from Alan Donovan, Robert Griesemer and Robert Griesemer Gerrit Bot uploaded new

unread,

[go] go.ast: add CommentGroup.Raw function

Attention needed from Alan Donovan, Robert Griesemer and Robert Griesemer Gerrit Bot uploaded new

7:23 AM

Felix Geisendörfer (Gerrit), Kenneth Roberts (Gerrit)14

7:22 AM

[go] runtime/pprof: increase mem profile stack depth to 128

Attention needed from Nick Ripley Felix Geisendörfer voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] runtime/pprof: increase mem profile stack depth to 128

Attention needed from Nick Ripley Felix Geisendörfer voted Commit-Queue+1 Commit-Queue +1 Open in

7:22 AM

Jonathan Amsterdam (Gerrit)

6:26 AM

[wiki] CodeReview.md: remove RELNOTE=

Attention needed from Dmitri Shuralyov Jonathan Amsterdam has uploaded the change for review Jonathan

unread,

[wiki] CodeReview.md: remove RELNOTE=

Attention needed from Dmitri Shuralyov Jonathan Amsterdam has uploaded the change for review Jonathan

6:26 AM

Egon Elbre (Gerrit), Alex Brainman (Gerrit)6

6:18 AM

[go] internal/runtime/atomic: fix TestAnd64 and TestOr64

Attention needed from Alex Brainman Alex Brainman voted and added 1 comment Votes added by Alex

unread,

[go] internal/runtime/atomic: fix TestAnd64 and TestOr64

Attention needed from Alex Brainman Alex Brainman voted and added 1 comment Votes added by Alex

6:18 AM

Jonathan Amsterdam (Gerrit), Dmitri Shuralyov (Gerrit)6

5:50 AM

[build] cmd/relnote: improve todo subcommand

Attention needed from Dmitri Shuralyov and Jonathan Amsterdam Jonathan Amsterdam added 1 comment File

unread,

[build] cmd/relnote: improve todo subcommand

Attention needed from Dmitri Shuralyov and Jonathan Amsterdam Jonathan Amsterdam added 1 comment File

5:50 AM

Alex Markin (Gerrit), Keith Randall (Gerrit)13

4:46 AM

[go] runtime: prefetch goroutine stack

Attention needed from Austin Clements, Keith Randall and Michael Knyszek Alex Markin uploaded new

unread,

[go] runtime: prefetch goroutine stack

Attention needed from Austin Clements, Keith Randall and Michael Knyszek Alex Markin uploaded new

4:46 AM

Egon Elbre (Gerrit), … Alex Brainman (Gerrit)37

3:51 AM

[go] testing: use QueryPerformanceCounter on Windows

Alex Brainman added 1 comment Patchset-level comments File-level comment, Patchset 6 (Latest): Alex

unread,

[go] testing: use QueryPerformanceCounter on Windows

Alex Brainman added 1 comment Patchset-level comments File-level comment, Patchset 6 (Latest): Alex

3:51 AM

Gerrit Bot (Gerrit), … Alireza Ghasemi (Gerrit)5

Apr 26

[go] net/http/httptest: add comment to Server.Client() about Server.URL

Attention needed from Damien Neil Alireza Ghasemi added 1 comment File src/net/http/httptest/server.

unread,

[go] net/http/httptest: add comment to Server.Client() about Server.URL

Attention needed from Damien Neil Alireza Ghasemi added 1 comment File src/net/http/httptest/server.

Apr 26

Damien Neil (Gerrit), … Ian Lance Taylor (Gerrit)20

Apr 26

[go] path/filepath, internal/filepathlite: move parts of filepath to filepathlite

Damien Neil submitted the change with unreviewed changes Unreviewed changes 16 is the latest approved

unread,

[go] path/filepath, internal/filepathlite: move parts of filepath to filepathlite

Damien Neil submitted the change with unreviewed changes Unreviewed changes 16 is the latest approved

Apr 26

Damien Neil (Gerrit), Ian Lance Taylor (Gerrit)5

Apr 26

[go] all: rename internal/safefilepath to internal/filepathlite

Damien Neil submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

unread,

[go] all: rename internal/safefilepath to internal/filepathlite

Damien Neil submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

Apr 26

Damien Neil (Gerrit), Ian Lance Taylor (Gerrit)8

Apr 26

[go] strings, internal/stringslite: lite version of strings package

Damien Neil submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

unread,

[go] strings, internal/stringslite: lite version of strings package

Damien Neil submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

Apr 26

Koichi Shiraishi (zchee) (Gerrit), … Robert Findley (Gerrit)7

Apr 26

[tools] gopls/internal/settings: use asStringSlice to buildFlags and directoryFilters

Attention needed from Alan Donovan and Koichi Shiraishi (zchee) Robert Findley added 1 comment File

unread,

[tools] gopls/internal/settings: use asStringSlice to buildFlags and directoryFilters

Attention needed from Alan Donovan and Koichi Shiraishi (zchee) Robert Findley added 1 comment File

Apr 26

Tim King (Gerrit), Robert Findley (Gerrit)3

Apr 26

[tools] go/ssa: fixing Named type substitution

Attention needed from Tim King Robert Findley added 7 comments File go/ssa/subst.go Line 304,

unread,

[tools] go/ssa: fixing Named type substitution

Attention needed from Tim King Robert Findley added 7 comments File go/ssa/subst.go Line 304,

Apr 26

Sam Thanawalla (Gerrit), … Michael Matloob (Gerrit)12

Apr 26

[tools] x/tools: update packages test to reflect new modules.txt requirements

Attention needed from Sam Thanawalla Michael Matloob voted and added 1 comment Votes added by Michael

unread,

[tools] x/tools: update packages test to reflect new modules.txt requirements

Attention needed from Sam Thanawalla Michael Matloob voted and added 1 comment Votes added by Michael

Apr 26

Sam Thanawalla (Gerrit), … Michael Matloob (Gerrit)36

Apr 26

[go] cmd/go: import vendored packages only listed in modules.txt

Attention needed from Sam Thanawalla Michael Matloob voted and added 1 comment Votes added by Michael

unread,

[go] cmd/go: import vendored packages only listed in modules.txt

Attention needed from Sam Thanawalla Michael Matloob voted and added 1 comment Votes added by Michael

Apr 26

Gerrit Bot (Gerrit), … Michael Matloob (Gerrit)6

Apr 26

[go] cmd/go: report trimpath erasing ldflags, and allow override

Attention needed from Sam Thanawalla Michael Matloob added 1 comment Patchset-level comments File-

unread,

[go] cmd/go: report trimpath erasing ldflags, and allow override

Attention needed from Sam Thanawalla Michael Matloob added 1 comment Patchset-level comments File-

Apr 26

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)3

Apr 26

[go] encoding/json: Simplify isValidTag character checking logic

Attention needed from Russ Cox Ian Lance Taylor added 1 comment Patchset-level comments File-level

unread,

[go] encoding/json: Simplify isValidTag character checking logic

Attention needed from Russ Cox Ian Lance Taylor added 1 comment Patchset-level comments File-level

Apr 26

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)13

Apr 26

[go] internal/weak: remove unnecessary conversion, fix typo

Gopher Robot submitted the change Change information Commit message: internal/weak: remove

unread,

[go] internal/weak: remove unnecessary conversion, fix typo

Gopher Robot submitted the change Change information Commit message: internal/weak: remove

Apr 26

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)4

Apr 26

[go] strings,bytes: imporve Repeat panic messages

Attention needed from Brad Fitzpatrick and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

unread,

[go] strings,bytes: imporve Repeat panic messages

Attention needed from Brad Fitzpatrick and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

Apr 26

Michael Matloob (Gerrit), Alan Donovan (Gerrit)4

Apr 26

[tools] go/packages/packagestest: fold modules_111.go into modules.go

Attention needed from Alan Donovan Michael Matloob uploaded new patchset Michael Matloob uploaded

unread,

[tools] go/packages/packagestest: fold modules_111.go into modules.go

Attention needed from Alan Donovan Michael Matloob uploaded new patchset Michael Matloob uploaded

Apr 26

Eric Grosse (Gerrit)2

Apr 26

[go] make.bash: tolerate ksh

Eric Grosse abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] make.bash: tolerate ksh

Eric Grosse abandoned this change Related details Attention set is empty Submit Requirements: Code-

Apr 26

Tim King (Gerrit), Alan Donovan (Gerrit)3

Apr 26

[tools] go/analysis/passes/directive: do not report adjoining //go:debug

Attention needed from Alan Donovan and Russ Cox Tim King voted and added 2 comments Votes added by

unread,

[tools] go/analysis/passes/directive: do not report adjoining //go:debug

Attention needed from Alan Donovan and Russ Cox Tim King voted and added 2 comments Votes added by

Apr 26

Jes Cok (Gerrit), … Gopher Robot (Gerrit)7

Apr 26

[go] all: make use of sync.Map.Clear

Gopher Robot submitted the change Change information Commit message: all: make use of sync.Map.Clear

unread,

[go] all: make use of sync.Map.Clear

Gopher Robot submitted the change Change information Commit message: all: make use of sync.Map.Clear

Apr 26

Gerrit Bot (Gerrit), … Robert Findley (Gerrit)7

Apr 26

[tools] Fixes golang/go#66176

Robert Findley added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

unread,

[tools] Fixes golang/go#66176

Robert Findley added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest):

Apr 26

Jes Cok (Gerrit), … Ian Lance Taylor (Gerrit)10

Apr 26

[go] slices: reduce code nesting depth for Compact and CompactFunc

Attention needed from Ian Lance Taylor, Jes Cok and Keith Randall Ian Lance Taylor voted and added 1

unread,

[go] slices: reduce code nesting depth for Compact and CompactFunc

Attention needed from Ian Lance Taylor, Jes Cok and Keith Randall Ian Lance Taylor voted and added 1

Apr 26

Dustin Ward (Gerrit), … Ian Lance Taylor (Gerrit)7

Apr 26

[sys] unix: extend support for z/OS

Attention needed from Brad Fitzpatrick, Dustin Ward and Tobias Klauser Ian Lance Taylor added 6

unread,

[sys] unix: extend support for z/OS

Attention needed from Brad Fitzpatrick, Dustin Ward and Tobias Klauser Ian Lance Taylor added 6

Apr 26

Dmitri Shuralyov (Gerrit)5

Apr 26

[build] cmd/makemac: add first security macOS trybot

Attention needed from Michael Pratt Dmitri Shuralyov voted and added 1 comment Votes added by Dmitri

unread,

[build] cmd/makemac: add first security macOS trybot

Attention needed from Michael Pratt Dmitri Shuralyov voted and added 1 comment Votes added by Dmitri

Apr 26

Jonathan Amsterdam (Gerrit), Dmitri Shuralyov (Gerrit)5

Apr 26

[go] doc/README.md: discourage RELNOTE in CLs

Jonathan Amsterdam submitted the change Change information Commit message: doc/README.md: discourage

unread,

[go] doc/README.md: discourage RELNOTE in CLs

Jonathan Amsterdam submitted the change Change information Commit message: doc/README.md: discourage

Apr 26

Search

Clear search

Close search

Google apps

Main menu