Groups

golang-codereviews

Contact owners and managers

1–30 of 108526

0 selected

Sean Liao (Gerrit), … Michael Matloob (Gerrit)11

5:19 PM

[go] cmd/go/internal/help: reword packages and importpath docs

Attention needed from Sean Liao and t hepudds Michael Matloob voted Code-Review+1 Code-Review +1 Open

unread,

[go] cmd/go/internal/help: reword packages and importpath docs

Attention needed from Sean Liao and t hepudds Michael Matloob voted Code-Review+1 Code-Review +1 Open

5:19 PM

Gerrit Bot (Gerrit), … Dmitri Shuralyov (Gerrit)8

5:12 PM

[go] cmd/link: propagate Mach-O section alignment to symbol in loadmacho

Attention needed from Cherry Mui and Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1

unread,

[go] cmd/link: propagate Mach-O section alignment to symbol in loadmacho

Attention needed from Cherry Mui and Russ Cox Dmitri Shuralyov voted Code-Review+1 Code-Review +1

5:12 PM

Olivier Mengué (Gerrit), … Michael Matloob (Gerrit)22

5:10 PM

[go] cmd/go/internal/base: reject an empty tool name

Michael Matloob submitted the change Change information Commit message: cmd/go: reject an empty tool

unread,

[go] cmd/go/internal/base: reject an empty tool name

Michael Matloob submitted the change Change information Commit message: cmd/go: reject an empty tool

5:10 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)7

5:09 PM

[go] cmd/compile: encode field selectors in UIR format for struct literals

Attention needed from Robert Griesemer Robert Griesemer voted Code-Review +1 Commit-Queue +1 Open in

unread,

[go] cmd/compile: encode field selectors in UIR format for struct literals

Attention needed from Robert Griesemer Robert Griesemer voted Code-Review +1 Commit-Queue +1 Open in

5:09 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)13

5:09 PM

[go] types2: implement arbitrary field selectors for struct literals

Robert Griesemer voted and added 1 comment Votes added by Robert Griesemer Code-Review +1 Commit-

unread,

[go] types2: implement arbitrary field selectors for struct literals

Robert Griesemer voted and added 1 comment Votes added by Robert Griesemer Code-Review +1 Commit-

5:09 PM

Cherry Mui (Gerrit), … Dmitri Shuralyov (Gerrit)3

5:06 PM

[go] cmd/link: skip special symbols for label symbol generation

Attention needed from Cherry Mui Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/link: skip special symbols for label symbol generation

Attention needed from Cherry Mui Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in Gerrit

5:06 PM

Damien Neil (Gerrit), … Carlos Amedee (Gerrit)10

5:03 PM

[go] net/http: restore accidentally removed package doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net/

unread,

[go] net/http: restore accidentally removed package doc

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net/

5:03 PM

Ian Chen (Gerrit), … Carlos Amedee (Gerrit)12

5:02 PM

[go] net: correctly handle non-nil empty cmsg buffer on windows

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net:

unread,

[go] net: correctly handle non-nil empty cmsg buffer on windows

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] net:

5:02 PM

Cuong Manh Le (Gerrit), … Carlos Amedee (Gerrit)20

4:59 PM

[go] cmd/compile/internal/typecheck: simplify tcSliceHeader

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

unread,

[go] cmd/compile/internal/typecheck: simplify tcSliceHeader

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

4:59 PM

Nicholas Husin (Gerrit)2

4:50 PM

[net] quic: avoid usage of net.ReadMsgUDPAddrPort in non-linux and darwin builds

Attention needed from Richard Miller Nicholas Husin uploaded new patchset Nicholas Husin uploaded

unread,

[net] quic: avoid usage of net.ReadMsgUDPAddrPort in non-linux and darwin builds

Attention needed from Richard Miller Nicholas Husin uploaded new patchset Nicholas Husin uploaded

4:50 PM

Keith Randall (Gerrit), … Carlos Amedee (Gerrit)8

4:43 PM

[go] cmd/compile: fix bloop test

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

unread,

[go] cmd/compile: fix bloop test

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] cmd/

4:43 PM

Michael Pratt (Gerrit), … Carlos Amedee (Gerrit)12

4:41 PM

[go] runtime: fix printfloat, printcomplex buffer sizes

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] runtime

unread,

[go] runtime: fix printfloat, printcomplex buffer sizes

Carlos Amedee submitted the change Change information Commit message: [release-branch.go1.26] runtime

4:41 PM

Ethan Lee (Gerrit), … kokoro (Gerrit)16

4:30 PM

[pkgsite] internal: conditionally return documentation in GetUnit

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI+1 Kokoro presubmit

unread,

[pkgsite] internal: conditionally return documentation in GetUnit

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI+1 Kokoro presubmit

4:30 PM

Peter Weinberger (Gerrit), Hongxiang Jiang (Gerrit)10

4:28 PM

[tools] gopls/codeaction: Add dialog tests for editing struct tags

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

unread,

[tools] gopls/codeaction: Add dialog tests for editing struct tags

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

4:28 PM

Julian Zhu (Gerrit), … David Chase (Gerrit)10

4:28 PM

[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

Attention needed from Julian Zhu David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] cmd/compile: (mips64x) optimize float32(abs|sqrt64(float64(x)))

Attention needed from Julian Zhu David Chase voted Code-Review+2 Code-Review +2 Open in Gerrit

4:28 PM

Ethan Lee (Gerrit), kokoro (Gerrit)5

4:20 PM

[pkgsite] internal/api: implement module packages endpoint

Attention needed from Ethan Lee kokoro voted kokoro-CI-1 Kokoro presubmit build finished with status:

unread,

[pkgsite] internal/api: implement module packages endpoint

Attention needed from Ethan Lee kokoro voted kokoro-CI-1 Kokoro presubmit build finished with status:

4:20 PM

pawan kalyan (Gerrit), … Nicholas Husin (Gerrit)6

4:11 PM

[go] net/http: validate structural validity of IP-literal Host headers

Attention needed from Nicholas Husin pawan kalyan added 1 comment File src/net/http/serve_test.go

unread,

[go] net/http: validate structural validity of IP-literal Host headers

Attention needed from Nicholas Husin pawan kalyan added 1 comment File src/net/http/serve_test.go

4:11 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)5

4:09 PM

[tools] internal/pkgbits: sync version.go with goroot

Attention needed from Alan Donovan Robert Griesemer voted and added 1 comment Votes added by Robert

unread,

[tools] internal/pkgbits: sync version.go with goroot

Attention needed from Alan Donovan Robert Griesemer voted and added 1 comment Votes added by Robert

4:09 PM

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)11

4:03 PM

[tools] gopls/internal/cmd: fix flaky MCP logging test

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted and added 2 comments

unread,

[tools] gopls/internal/cmd: fix flaky MCP logging test

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted and added 2 comments

4:03 PM

Junyang Shao (Gerrit), … Cherry Mui (Gerrit)37

3:49 PM

[arch] arm64/instgen: add assembler code generator for SVE

Attention needed from Cherry Mui and David Chase Junyang Shao uploaded new patchset Junyang Shao

unread,

[arch] arm64/instgen: add assembler code generator for SVE

Attention needed from Cherry Mui and David Chase Junyang Shao uploaded new patchset Junyang Shao

3:49 PM

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)5

3:36 PM

[tools] go/analysis/passes/modernize: avoid non-bool assignment rewrite in slicescontains

Madeline Kalil submitted the change Change information Commit message: go/analysis/passes/modernize:

unread,

[tools] go/analysis/passes/modernize: avoid non-bool assignment rewrite in slicescontains

Madeline Kalil submitted the change Change information Commit message: go/analysis/passes/modernize:

3:36 PM

Ethan Lee (Gerrit), kokoro (Gerrit)9

3:24 PM

[pkgsite] internal/api: implement search endpoint

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI+1 Kokoro presubmit

unread,

[pkgsite] internal/api: implement search endpoint

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI+1 Kokoro presubmit

3:24 PM

Michael Matloob (Gerrit)

3:20 PM

[go] debug/buildinfo: remove macho/elf DataStart fallback code

Attention needed from Cherry Mui and Dmitri Shuralyov New activity on the change Open in Gerrit

unread,

[go] debug/buildinfo: remove macho/elf DataStart fallback code

Attention needed from Cherry Mui and Dmitri Shuralyov New activity on the change Open in Gerrit

3:20 PM

Michael Matloob (Gerrit), Dmitri Shuralyov (Gerrit)4

3:15 PM

[go] cmd/distpack: add a test on distribution size

Michael Matloob abandoned this change. View Change Abandoned I'm going to abandon this in favor

unread,

[go] cmd/distpack: add a test on distribution size

Michael Matloob abandoned this change. View Change Abandoned I'm going to abandon this in favor

3:15 PM

Ethan Lee (Gerrit), kokoro (Gerrit)5

3:04 PM

[pkgsite] internal/api: implement module versions endpoint

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI-1 Kokoro presubmit

unread,

[pkgsite] internal/api: implement module versions endpoint

Attention needed from Ethan Lee and Jonathan Amsterdam kokoro voted kokoro-CI-1 Kokoro presubmit

3:04 PM

AutoUpdate Robot (Gerrit)

3:01 PM

[pkgsite] all: Update postcss from 8.4.38 to 8.5.8 in root

AutoUpdate Robot has uploaded the change for review Commit message all: Update postcss from 8.4.38 to

unread,

[pkgsite] all: Update postcss from 8.4.38 to 8.5.8 in root

AutoUpdate Robot has uploaded the change for review Commit message all: Update postcss from 8.4.38 to

3:01 PM

AutoUpdate Robot (Gerrit)

3:01 PM

[pkgsite] all: Update postcss-resolve-nested-selector from 0.1.1 to 0.1.6 in package-lock.json

AutoUpdate Robot has uploaded the change for review Commit message all: Update postcss-resolve-nested

unread,

[pkgsite] all: Update postcss-resolve-nested-selector from 0.1.1 to 0.1.6 in package-lock.json

AutoUpdate Robot has uploaded the change for review Commit message all: Update postcss-resolve-nested

3:01 PM

Chencheng Jiang (Gerrit), Madeline Kalil (Gerrit)5

2:55 PM

[go] cmd/fix: avoid non-bool assignment rewrite in slicescontains

Attention needed from Chencheng Jiang Madeline Kalil added 1 comment Patchset-level comments File-

unread,

[go] cmd/fix: avoid non-bool assignment rewrite in slicescontains

Attention needed from Chencheng Jiang Madeline Kalil added 1 comment Patchset-level comments File-

2:55 PM

Jayanth Krishnamurthy (Gerrit), … Cherry Mui (Gerrit)28

2:54 PM

[go] cmd/compile: ppc64x fold (x+x)<<c into x<<(c+1)

Attention needed from Archana Ravindar, Cherry Mui, Michael Munday and Paul Murphy Jayanth

unread,

[go] cmd/compile: ppc64x fold (x+x)<<c into x<<(c+1)

Attention needed from Archana Ravindar, Cherry Mui, Michael Munday and Paul Murphy Jayanth

2:54 PM

Nicholas Husin (Gerrit), Ethan Lee (Gerrit)5

2:46 PM

[net] internal/http3: skip TestNetHTTPIntegration on plan9

Nicholas Husin submitted the change Change information Commit message: internal/http3: skip

unread,

[net] internal/http3: skip TestNetHTTPIntegration on plan9

Nicholas Husin submitted the change Change information Commit message: internal/http3: skip

2:46 PM

Search

Clear search

Close search

Google apps

Main menu