Groups

golang-codereviews

Contact owners and managers

1–30 of 107557

0 selected

Nicholas Husin (Gerrit)2

Feb 6

[net] internal/http3: more robust handling of request & response with no body

Attention needed from Damien Neil and Nicholas Husin Nicholas Husin uploaded new patchset Nicholas

unread,

[net] internal/http3: more robust handling of request & response with no body

Attention needed from Damien Neil and Nicholas Husin Nicholas Husin uploaded new patchset Nicholas

Feb 6

Ian Lance Taylor (Gerrit), Pagol Mon (Gerrit)7

Feb 6

[go] cmd/link: put itabs in the .go.type section

Attention needed from Cherry Mui, Ian Lance Taylor and Russ Cox Pagol Mon voted Code-Review+1 Code-

unread,

[go] cmd/link: put itabs in the .go.type section

Attention needed from Cherry Mui, Ian Lance Taylor and Russ Cox Pagol Mon voted Code-Review+1 Code-

Feb 6

Gerrit Bot (Gerrit), … jub0bs (Gerrit)8

Feb 6

[go] net/http: add ProxyConnectError type for proxy CONNECT failures

jub0bs added 1 comment File src/net/http/transport.go Line 1774, Patchset 3 (Latest): f := strings.

unread,

[go] net/http: add ProxyConnectError type for proxy CONNECT failures

jub0bs added 1 comment File src/net/http/transport.go Line 1774, Patchset 3 (Latest): f := strings.

Feb 6

Ravi Sastry Kadali (Gerrit)3

Feb 6

[go] cmd/go: fix panic in 'go run -C' when flag value is missing

Ravi Sastry Kadali abandoned this change. View Change Abandoned https://go-review.googlesource.com/c/

unread,

[go] cmd/go: fix panic in 'go run -C' when flag value is missing

Ravi Sastry Kadali abandoned this change. View Change Abandoned https://go-review.googlesource.com/c/

Feb 6

Alexander Musman (Gerrit), Keith Randall (Gerrit)5

Feb 6

[go] runtime: conservatively scan the extended register state on ARM64

Attention needed from Alexander Musman, Austin Clements, Dmitry Vyukov, Keith Randall and Michael

unread,

[go] runtime: conservatively scan the extended register state on ARM64

Attention needed from Alexander Musman, Austin Clements, Dmitry Vyukov, Keith Randall and Michael

Feb 6

Ian Lance Taylor (Gerrit), … Carlos Amedee (Gerrit)24

Feb 6

[go] cmd/compile: set alignment for all content-addressable symbols

Attention needed from Matthew Dempsky and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

unread,

[go] cmd/compile: set alignment for all content-addressable symbols

Attention needed from Matthew Dempsky and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

Feb 6

Ian Lance Taylor (Gerrit), … Carlos Amedee (Gerrit)8

Feb 6

[go] cmd/compile, runtime: set alignment of type descriptors

Attention needed from Martin Möhrmann and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

unread,

[go] cmd/compile, runtime: set alignment of type descriptors

Attention needed from Martin Möhrmann and Robert Griesemer Ian Lance Taylor voted Commit-Queue+1

Feb 6

Ian Lance Taylor (Gerrit)3

Feb 6

[go] cmd/internal/obj: add Align field to LSym

Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] cmd/internal/obj: add Align field to LSym

Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Feb 6

Ian Lance Taylor (Gerrit), … Dmitri Shuralyov (Gerrit)9

Feb 6

[go] runtime: use unsafe.Slice in itabInit

Attention needed from Michael Knyszek and Michael Pratt Ian Lance Taylor voted Commit-Queue+1 Commit-

unread,

[go] runtime: use unsafe.Slice in itabInit

Attention needed from Michael Knyszek and Michael Pratt Ian Lance Taylor voted Commit-Queue+1 Commit-

Feb 6

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)23

Feb 6

[go] runtime: print error code on Windows VirtualAlloc failure

Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/go#77145 has been closed.

unread,

[go] runtime: print error code on Windows VirtualAlloc failure

Gopher Robot abandoned this change. View Change Abandoned GitHub PR golang/go#77145 has been closed.

Feb 6

Ian Lance Taylor (Gerrit), … Dmitri Shuralyov (Gerrit)7

Feb 6

[go] internal/abi, runtime: put type descriptor sizes in internal/abi

Attention needed from Dmitri Shuralyov Ian Lance Taylor voted and added 1 comment Votes added by Ian

unread,

[go] internal/abi, runtime: put type descriptor sizes in internal/abi

Attention needed from Dmitri Shuralyov Ian Lance Taylor voted and added 1 comment Votes added by Ian

Feb 6

Ian Lance Taylor (Gerrit), … Cherry Mui (Gerrit)12

Feb 6

[go] internal/abi: set MaxPtrmaskBytes to 16

Attention needed from Ian Lance Taylor Ian Lance Taylor uploaded new patchset Ian Lance Taylor

unread,

[go] internal/abi: set MaxPtrmaskBytes to 16

Attention needed from Ian Lance Taylor Ian Lance Taylor uploaded new patchset Ian Lance Taylor

Feb 6

Ian Lance Taylor (Gerrit)6

Feb 6

[go] runtime, cmd/link: remote itablinks

Attention needed from Cherry Mui and Than McIntosh Ian Lance Taylor uploaded new patchset Ian Lance

unread,

[go] runtime, cmd/link: remote itablinks

Attention needed from Cherry Mui and Than McIntosh Ian Lance Taylor uploaded new patchset Ian Lance

Feb 6

abner chenc (Gerrit), … Michael Knyszek (Gerrit)8

Feb 6

[go] runtime: simplify the implementation of walltime and nanotime1 on loong64

abner chenc submitted the change Change information Commit message: runtime: simplify the

unread,

[go] runtime: simplify the implementation of walltime and nanotime1 on loong64

abner chenc submitted the change Change information Commit message: runtime: simplify the

Feb 6

Nicholas Husin (Gerrit), Damien Neil (Gerrit)7

Feb 6

[net] internal/http3: add Expect: 100-continue support to ClientConn

Nicholas Husin submitted the change Change information Commit message: internal/http3: add Expect:

unread,

[net] internal/http3: add Expect: 100-continue support to ClientConn

Nicholas Husin submitted the change Change information Commit message: internal/http3: add Expect:

Feb 6

Nicholas Husin (Gerrit), Damien Neil (Gerrit)10

Feb 6

[net] internal/http3: add Expect: 100-continue support to Server

Nicholas Husin submitted the change Change information Commit message: internal/http3: add Expect:

unread,

[net] internal/http3: add Expect: 100-continue support to Server

Nicholas Husin submitted the change Change information Commit message: internal/http3: add Expect:

Feb 6

Sean Liao (Gerrit), … Michael Pratt (Gerrit)4

Feb 6

[go] io/fs: document that Sub does not check for existence

Sean Liao submitted the change Change information Commit message: io/fs: document that Sub does not

unread,

[go] io/fs: document that Sub does not check for existence

Sean Liao submitted the change Change information Commit message: io/fs: document that Sub does not

Feb 6

Yongqi Jia (Gerrit), … Keith Randall (Gerrit)4

Feb 6

[go] cmd/compile: treat function parameters as probably constant in string comparison

Attention needed from Matthew Dempsky, Robert Griesemer and Yongqi Jia Keith Randall added 1 comment

unread,

[go] cmd/compile: treat function parameters as probably constant in string comparison

Attention needed from Matthew Dempsky, Robert Griesemer and Yongqi Jia Keith Randall added 1 comment

Feb 6

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)6

Feb 6

[go] cmd/link: run ELF tests on Solaris

Gopher Robot submitted the change Change information Commit message: cmd/link: run ELF tests on

unread,

[go] cmd/link: run ELF tests on Solaris

Gopher Robot submitted the change Change information Commit message: cmd/link: run ELF tests on

Feb 6

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)7

Feb 6

[go] cmd/link: only run ELF tests on ELF systems

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

unread,

[go] cmd/link: only run ELF tests on ELF systems

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

Feb 6

Gopher Robot (Gerrit), Gerrit Bot (Gerrit)4

Feb 6

[go] crypto/ed25519: don't panic on public keys with incorrect lengths

Attention needed from Daniel McCarney, Filippo Valsorda and Roland Shoemaker Gerrit Bot uploaded new

unread,

[go] crypto/ed25519: don't panic on public keys with incorrect lengths

Attention needed from Daniel McCarney, Filippo Valsorda and Roland Shoemaker Gerrit Bot uploaded new

Feb 6

Dmitri Shuralyov (Gerrit), Michael Pratt (Gerrit)5

Feb 6

[build] cmd/gopherbot: close reopened cherry-pick issues

Attention needed from Dmitri Shuralyov Michael Pratt voted Code-Review+2 Code-Review +2 Open in

unread,

[build] cmd/gopherbot: close reopened cherry-pick issues

Attention needed from Dmitri Shuralyov Michael Pratt voted Code-Review+2 Code-Review +2 Open in

Feb 6

kami sama (Gerrit), … Gopher Robot (Gerrit)7

Feb 6

[go] net/url: add test case to ResolveReference

Gopher Robot submitted the change Change information Commit message: net/url: add test case to

unread,

[go] net/url: add test case to ResolveReference

Gopher Robot submitted the change Change information Commit message: net/url: add test case to

Feb 6

John S (Gerrit), … Damien Neil (Gerrit)3

Feb 6

[go] net/http/httptrace: document Got1xxResponse compose behavior

Attention needed from John S and Sean Liao Damien Neil added 2 comments File src/net/http/httptrace/

unread,

[go] net/http/httptrace: document Got1xxResponse compose behavior

Attention needed from John S and Sean Liao Damien Neil added 2 comments File src/net/http/httptrace/

Feb 6

Chressie Himpel (Gerrit), … Cherry Mui (Gerrit)7

Feb 6

[go] runtime: add race instrumentation for moduleToTypelinksLock

Attention needed from Chressie Himpel Cherry Mui voted and added 1 comment Votes added by Cherry Mui

unread,

[go] runtime: add race instrumentation for moduleToTypelinksLock

Attention needed from Chressie Himpel Cherry Mui voted and added 1 comment Votes added by Cherry Mui

Feb 6

Tobias Klauser (Gerrit), … Gopher Robot (Gerrit)5

Feb 6

[go] internal/bytealg: unexport {Last,}IndexRabinKarp helpers

Gopher Robot submitted the change Change information Commit message: internal/bytealg: unexport {Last

unread,

[go] internal/bytealg: unexport {Last,}IndexRabinKarp helpers

Gopher Robot submitted the change Change information Commit message: internal/bytealg: unexport {Last

Feb 6

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)8

Feb 6

[go] cmd/link: make TestTypePlacement work on AIX

Gopher Robot submitted the change Change information Commit message: cmd/link: make TestTypePlacement

unread,

[go] cmd/link: make TestTypePlacement work on AIX

Gopher Robot submitted the change Change information Commit message: cmd/link: make TestTypePlacement

Feb 6

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)10

Feb 6

[go] cmd/link: use correct alignment for type descriptors on AIX

Gopher Robot submitted the change Change information Commit message: cmd/link: use correct alignment

unread,

[go] cmd/link: use correct alignment for type descriptors on AIX

Gopher Robot submitted the change Change information Commit message: cmd/link: use correct alignment

Feb 6

Adriano Sela (Gerrit), … Damien Neil (Gerrit)4

Feb 6

[go] Add JSFetch Options to Transport

Attention needed from Adriano Sela Damien Neil voted and added 1 comment Votes added by Damien Neil

unread,

[go] Add JSFetch Options to Transport

Attention needed from Adriano Sela Damien Neil voted and added 1 comment Votes added by Damien Neil

Feb 6

Keith Randall (Gerrit), Cherry Mui (Gerrit)6

Feb 6

[go] cmd/link: align covctrs symbol

Keith Randall submitted the change Change information Commit message: cmd/link: align covctrs symbol

unread,

[go] cmd/link: align covctrs symbol

Keith Randall submitted the change Change information Commit message: cmd/link: align covctrs symbol

Feb 6

Search

Clear search

Close search

Google apps

Main menu