Groups

golang-codereviews

Contact owners and managers

1–30 of 106713

0 selected

Hongxiang Jiang (Gerrit), … Madeline Kalil (Gerrit)11

10:51 AM

[tools] gopls/internal/test/marker: add optional error to typedef marker

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted Code-Review+2 Code-Review

unread,

[tools] gopls/internal/test/marker: add optional error to typedef marker

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted Code-Review+2 Code-Review

10:51 AM

Pontus Leitzler (Gerrit), Alan Donovan (Gerrit)5

10:50 AM

[tools] gopls/internal/cache: avoid unnecessary mod tidy invalidation

Attention needed from Pontus Leitzler Alan Donovan voted and added 1 comment Votes added by Alan

unread,

[tools] gopls/internal/cache: avoid unnecessary mod tidy invalidation

Attention needed from Pontus Leitzler Alan Donovan voted and added 1 comment Votes added by Alan

10:50 AM

Hongxiang Jiang (Gerrit), … Madeline Kalil (Gerrit)21

10:49 AM

[tools] gopls/internal/server: support type def with selected range

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted Code-Review+2 Code-Review

unread,

[tools] gopls/internal/server: support type def with selected range

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted Code-Review+2 Code-Review

10:49 AM

Quim Muntal (Gerrit), Cherry Mui (Gerrit)6

10:40 AM

[go] cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

Attention needed from David Chase and Quim Muntal Cherry Mui voted Code-Review+2 Code-Review +2 Open

unread,

[go] cmd/dist: preserve existing GOEXPERIMENTs when running tests with additional experiments

Attention needed from David Chase and Quim Muntal Cherry Mui voted Code-Review+2 Code-Review +2 Open

10:40 AM

10:40 AM

unread,

10:40 AM

Nicholas Husin (Gerrit), Markus Kusano (Gerrit)3

10:27 AM

[vulndb] data/reports: fix 2 reports which contains inaccurate information

Attention needed from Neal Patel and Nicholas Husin Markus Kusano voted Code-Review+2 Code-Review +2

unread,

[vulndb] data/reports: fix 2 reports which contains inaccurate information

Attention needed from Neal Patel and Nicholas Husin Markus Kusano voted Code-Review+2 Code-Review +2

10:27 AM

Daniel Morsing (Gerrit), t hepudds (Gerrit)3

10:16 AM

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing and Michael Knyszek t hepudds added 2 comments Patchset-level

unread,

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing and Michael Knyszek t hepudds added 2 comments Patchset-level

10:16 AM

Alan Donovan (Gerrit)5

9:27 AM

[telemetry] cmd/stacks: record current predicate in each "claimed by comment

Attention needed from Alan Donovan and Michael Pratt Alan Donovan uploaded new patchset Alan Donovan

unread,

[telemetry] cmd/stacks: record current predicate in each "claimed by comment

Attention needed from Alan Donovan and Michael Pratt Alan Donovan uploaded new patchset Alan Donovan

9:27 AM

Joel Sing (Gerrit), … Mark Ryan (Gerrit)14

5:31 AM

[go] runtime: add vector implementation of memclrNoHeapPointers for riscv64

Attention needed from Joel Sing and Meng Zhuo Mark Ryan added 1 comment File src/runtime/

unread,

[go] runtime: add vector implementation of memclrNoHeapPointers for riscv64

Attention needed from Joel Sing and Meng Zhuo Mark Ryan added 1 comment File src/runtime/

5:31 AM

Sean Liao (Gerrit), Michael Schaller (Gerrit)5

3:58 AM

[go] go/doc: exclude examples with results

Attention needed from Alan Donovan and Sean Liao Michael Schaller added 1 comment File src/go/doc/

unread,

[go] go/doc: exclude examples with results

Attention needed from Alan Donovan and Sean Liao Michael Schaller added 1 comment File src/go/doc/

3:58 AM

Nhan Nguyen (Gerrit)

2:25 AM

[go] cmd/compile: implement reverse bounds check elimination

Nhan Nguyen has uploaded the change for review Commit message cmd/compile: implement reverse bounds

unread,

[go] cmd/compile: implement reverse bounds check elimination

Nhan Nguyen has uploaded the change for review Commit message cmd/compile: implement reverse bounds

2:25 AM

Boyao Wang (Gerrit), Meng Zhuo (Gerrit)5

2:02 AM

[go] cmd/internal/obj/riscv: add assembly support for CMO instructions

Attention needed from Boyao Wang, Cherry Mui, Joel Sing, Mark Ryan and Meng Zhuo Boyao Wang uploaded

unread,

[go] cmd/internal/obj/riscv: add assembly support for CMO instructions

Attention needed from Boyao Wang, Cherry Mui, Joel Sing, Mark Ryan and Meng Zhuo Boyao Wang uploaded

2:02 AM

Alex Brainman (Gerrit), … Emmanuel Odeke (Gerrit)10

12:04 AM

[go] debug/pe: avoid panic in File.ImportedSymbols

Attention needed from Alex Brainman Emmanuel Odeke added 3 comments Patchset-level comments File-

unread,

[go] debug/pe: avoid panic in File.ImportedSymbols

Attention needed from Alex Brainman Emmanuel Odeke added 3 comments Patchset-level comments File-

12:04 AM

Michael Knyszek (Gerrit), … Gopher Robot (Gerrit)8

Dec 15

[build] cmd/resultdbpprof: add tool to get a test execution profile

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

unread,

[build] cmd/resultdbpprof: add tool to get a test execution profile

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 2 is the latest approved

Dec 15

Ian Lance Taylor (Gerrit), Michael Knyszek (Gerrit)8

Dec 15

[go] internal/abi: set MaxPtrmaskBytes to 16

Attention needed from Cherry Mui Ian Lance Taylor added 1 comment File src/internal/abi/type.go Line

unread,

[go] internal/abi: set MaxPtrmaskBytes to 16

Attention needed from Cherry Mui Ian Lance Taylor added 1 comment File src/internal/abi/type.go Line

Dec 15

Gerrit Bot (Gerrit), … Hongxiang Jiang (Gerrit)6

Dec 15

[vscode-go] extension: add followExec and followExecRegex options in launch request

Attention needed from Madeline Kalil Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[vscode-go] extension: add followExec and followExecRegex options in launch request

Attention needed from Madeline Kalil Hongxiang Jiang voted Commit-Queue+1 Commit-Queue +1 Open in

Dec 15

Wanbiao Ye (Gerrit)2

Dec 15

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer and Russ Cox Wanbiao Ye uploaded new patchset Wanbiao Ye

unread,

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer and Russ Cox Wanbiao Ye uploaded new patchset Wanbiao Ye

Dec 15

Jayanth Krishnamurthy (Gerrit), David Chase (Gerrit)10

Dec 15

[go/release-branch.go1.25] [release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers

Attention needed from Carlos Amedee, David Chase, Dmitry Vyukov, Ian Lance Taylor and Jayanth

unread,

[go/release-branch.go1.25] [release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers

Attention needed from Carlos Amedee, David Chase, Dmitry Vyukov, Ian Lance Taylor and Jayanth

Dec 15

Ethan Lee (Gerrit), Hongxiang Jiang (Gerrit)28

Dec 15

[tools] internal/server: store vulncheck prompt preference

Attention needed from Ethan Lee Hongxiang Jiang added 1 comment File gopls/internal/server/

unread,

[tools] internal/server: store vulncheck prompt preference

Attention needed from Ethan Lee Hongxiang Jiang added 1 comment File gopls/internal/server/

Dec 15

Ethan Lee (Gerrit), Hongxiang Jiang (Gerrit)4

Dec 15

[tools] gopls/internal/server: modify checkGoModDeps condition

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[tools] gopls/internal/server: modify checkGoModDeps condition

Attention needed from Ethan Lee Hongxiang Jiang voted Code-Review+1 Code-Review +1 Open in Gerrit

Dec 15

Hongxiang Jiang (Gerrit)5

Dec 15

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Attention needed from Alan Donovan and Madeline Kalil Hongxiang Jiang added 2 comments Patchset-level

unread,

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Attention needed from Alan Donovan and Madeline Kalil Hongxiang Jiang added 2 comments Patchset-level

Dec 15

Gerrit Bot (Gerrit), … Carlo Alberto Ferraris (Gerrit)12

Dec 15

[go] runtime: optimize zeroing of registers in secret_amd64.s

Attention needed from Dmitry Vyukov and Ian Lance Taylor Carlo Alberto Ferraris added 1 comment

unread,

[go] runtime: optimize zeroing of registers in secret_amd64.s

Attention needed from Dmitry Vyukov and Ian Lance Taylor Carlo Alberto Ferraris added 1 comment

Dec 15

Madeline Kalil (Gerrit), … Hongxiang Jiang (Gerrit)11

Dec 15

[tools] gopls/internal/golang: implement type definition for builtin types

Attention needed from Madeline Kalil Hongxiang Jiang voted and added 1 comment Votes added by

unread,

[tools] gopls/internal/golang: implement type definition for builtin types

Attention needed from Madeline Kalil Hongxiang Jiang voted and added 1 comment Votes added by

Dec 15

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)12

Dec 15

[website] _content/doc/go1.26: add notes for race detector support on linux/riscv64

Gopher Robot submitted the change Change information Commit message: _content/doc/go1.26: add notes

unread,

[website] _content/doc/go1.26: add notes for race detector support on linux/riscv64

Gopher Robot submitted the change Change information Commit message: _content/doc/go1.26: add notes

Dec 15

David Chase (Gerrit), Ian Lance Taylor (Gerrit)2

Dec 15

[go] runtime, cmd/link, cmd/internal/objfile: adapting pclntab/lrodata patch

Attention needed from David Chase Ian Lance Taylor added 1 comment File src/runtime/stkframe.go Line

unread,

[go] runtime, cmd/link, cmd/internal/objfile: adapting pclntab/lrodata patch

Attention needed from David Chase Ian Lance Taylor added 1 comment File src/runtime/stkframe.go Line

Dec 15

Sean Liao (Gerrit), Ian Lance Taylor (Gerrit)4

Dec 15

[website] _content/doc/go1.26: add note for http.Client cookie Host change

Attention needed from Damien Neil and Sean Liao Ian Lance Taylor voted and added 1 comment Votes

unread,

[website] _content/doc/go1.26: add note for http.Client cookie Host change

Attention needed from Damien Neil and Sean Liao Ian Lance Taylor voted and added 1 comment Votes

Dec 15

Nicholas Husin (Gerrit)

Dec 15

[vulndb] data/reports: narrow down vulnerable versions and symbols in 2 reports

Attention needed from Ethan Lee and Neal Patel Nicholas Husin has uploaded the change for review

unread,

[vulndb] data/reports: narrow down vulnerable versions and symbols in 2 reports

Attention needed from Ethan Lee and Neal Patel Nicholas Husin has uploaded the change for review

Dec 15

Michael Knyszek (Gerrit), … Gopher Robot (Gerrit)4

Dec 15

[go/release-branch.go1.26] [release-branch.go1.26] all: merge master (d14b642) into release-branch.go1.26

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.26] all:

unread,

[go/release-branch.go1.26] [release-branch.go1.26] all: merge master (d14b642) into release-branch.go1.26

Gopher Robot submitted the change Change information Commit message: [release-branch.go1.26] all:

Dec 15

Madeline Kalil (Gerrit)17

Dec 15

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Dec 15

Roland Shoemaker (Gerrit), Keith Randall (Gerrit)8

Dec 15

[go] internal/runtime/sys: improve DIT assembly

Attention needed from Austin Clements and Keith Randall Roland Shoemaker voted Commit-Queue+1 Commit-

unread,

[go] internal/runtime/sys: improve DIT assembly

Attention needed from Austin Clements and Keith Randall Roland Shoemaker voted Commit-Queue+1 Commit-

Dec 15

Search

Clear search

Close search

Google apps

Main menu