Groups

golang-codereviews

Contact owners and managers

1–30 of 108008

0 selected

Jake Bailey (Gerrit), Michael Pratt (Gerrit)23

1:43 PM

[go] internal/runtime/maps: use KKKKVVVV slot order

Attention needed from Michael Pratt Jake Bailey voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] internal/runtime/maps: use KKKKVVVV slot order

Attention needed from Michael Pratt Jake Bailey voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

1:43 PM

bmon Dor (Gerrit), … Keith Randall (Gerrit)4

1:37 PM

[go] cmd/compile: forward small Load through Move to avoid redundant copies (issue #77720)

Attention needed from Martin Möhrmann and bmon Dor Keith Randall added 8 comments Commit Message Line

unread,

[go] cmd/compile: forward small Load through Move to avoid redundant copies (issue #77720)

Attention needed from Martin Möhrmann and bmon Dor Keith Randall added 8 comments Commit Message Line

1:37 PM

Oleksandr Redko (Gerrit)

1:27 PM

[website] _content/blog: fix duplicated words

Oleksandr Redko has uploaded the change for review Commit message _content/blog: fix duplicated words

unread,

[website] _content/blog: fix duplicated words

Oleksandr Redko has uploaded the change for review Commit message _content/blog: fix duplicated words

1:27 PM

Francisco Ferraz (Gerrit), … Mateusz Poliwczak (Gerrit)11

1:19 PM

[go] cmd/compile: fix internal compiler error: bad write barrier type

Attention needed from Keith Randall, Keith Randall and Mateusz Poliwczak Francisco Ferraz added 2

unread,

[go] cmd/compile: fix internal compiler error: bad write barrier type

Attention needed from Keith Randall, Keith Randall and Mateusz Poliwczak Francisco Ferraz added 2

1:19 PM

Jake Bailey (Gerrit)

1:16 PM

[go] internal/abi, cmd/link: centralize type descriptor size calculation

Message from Jake Bailey Set Ready For Review Open in Gerrit Related details Attention set is empty

unread,

[go] internal/abi, cmd/link: centralize type descriptor size calculation

Message from Jake Bailey Set Ready For Review Open in Gerrit Related details Attention set is empty

1:16 PM

Junyang Shao (Gerrit)

1:15 PM

[go] cmd/internal/obj/arm64: support more pure vector SVE instructions

Junyang Shao has uploaded the change for review Commit message cmd/internal/obj/arm64: support more

unread,

[go] cmd/internal/obj/arm64: support more pure vector SVE instructions

Junyang Shao has uploaded the change for review Commit message cmd/internal/obj/arm64: support more

1:15 PM

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)15

1:10 PM

[go] cmd/compile: optimize sccp for faster convergence

Attention needed from Jorropo and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review +1

unread,

[go] cmd/compile: optimize sccp for faster convergence

Attention needed from Jorropo and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review +1

1:10 PM

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

1:00 PM

[go] slog: use time.Time.AppendFormat to write value

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[go] slog: use time.Time.AppendFormat to write value

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

1:00 PM

Ian Chen (Gerrit), Alex Brainman (Gerrit)5

12:56 PM

[sys] windows: add GetIfTable2Ex, GetIpInterface{Entry,Table}, GetUnicastIpAddressTable

Attention needed from Alex Brainman, Brad Fitzpatrick, Ian Lance Taylor and Quim Muntal Ian Chen

unread,

[sys] windows: add GetIfTable2Ex, GetIpInterface{Entry,Table}, GetUnicastIpAddressTable

Attention needed from Alex Brainman, Brad Fitzpatrick, Ian Lance Taylor and Quim Muntal Ian Chen

12:56 PM

Yongqi Jia (Gerrit), … Keith Randall (Gerrit)16

12:55 PM

[go] cmd/compile: treat function parameters as probably constant in string comparison

Attention needed from Daniel Morsing, Matthew Dempsky, Robert Griesemer and Yongqi Jia Keith Randall

unread,

[go] cmd/compile: treat function parameters as probably constant in string comparison

Attention needed from Daniel Morsing, Matthew Dempsky, Robert Griesemer and Yongqi Jia Keith Randall

12:55 PM

Madeline Kalil (Gerrit), … Hongxiang Jiang (Gerrit)36

12:54 PM

[tools] gopls/internal/golang: MoveType - extract type to new file

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted and added 11 comments

unread,

[tools] gopls/internal/golang: MoveType - extract type to new file

Attention needed from Alan Donovan and Hongxiang Jiang Madeline Kalil voted and added 11 comments

12:54 PM

abner chenc (Gerrit), Keith Randall (Gerrit)4

12:51 PM

[go] cmd/compile: use OpMove instead of memmove more on loong64

Attention needed from Martin Möhrmann, Meidan Li, abner chenc and sophie zhao Keith Randall voted

unread,

[go] cmd/compile: use OpMove instead of memmove more on loong64

Attention needed from Martin Möhrmann, Meidan Li, abner chenc and sophie zhao Keith Randall voted

12:51 PM

Damien Neil (Gerrit), Nicholas Husin (Gerrit)3

12:43 PM

[net] http2: Move most tests from the http2 package to the http2_test package.

Attention needed from Damien Neil Nicholas Husin voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[net] http2: Move most tests from the http2 package to the http2_test package.

Attention needed from Damien Neil Nicholas Husin voted Code-Review+1 Code-Review +1 Open in Gerrit

12:43 PM

Paschalis Tsilias (Gerrit), … Michael Matloob (Gerrit)10

12:43 PM

[go] testing: add individual timer for tests, benchmarks and fuzz targets

Attention needed from Alan Donovan, Caleb Spare, Damien Neil, Ian Lance Taylor and Paschalis Tsilias

unread,

[go] testing: add individual timer for tests, benchmarks and fuzz targets

Attention needed from Alan Donovan, Caleb Spare, Damien Neil, Ian Lance Taylor and Paschalis Tsilias

12:43 PM

Junyang Shao (Gerrit)

12:08 PM

[arch] arm64/instgen: allow only certain AClasses in gen

Junyang Shao has uploaded the change for review Commit message arm64/instgen: allow only certain

unread,

[arch] arm64/instgen: allow only certain AClasses in gen

Junyang Shao has uploaded the change for review Commit message arm64/instgen: allow only certain

12:08 PM

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)5

11:44 AM

[go] runtime: unified the calculate for max objects per span

Attention needed from Michael Knyszek and Michael Pratt Keith Randall voted Code-Review+1 Code-Review

unread,

[go] runtime: unified the calculate for max objects per span

Attention needed from Michael Knyszek and Michael Pratt Keith Randall voted Code-Review+1 Code-Review

11:44 AM

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)5

11:39 AM

[go] syscall: fix incorrect defer usage in acquireForkLock

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Keith Randall added 1

unread,

[go] syscall: fix incorrect defer usage in acquireForkLock

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Keith Randall added 1

11:39 AM

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)4

11:37 AM

[go] multiple: fix lock management bugs and improve error handling

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Keith Randall added 3

unread,

[go] multiple: fix lock management bugs and improve error handling

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Tobias Klauser Keith Randall added 3

11:37 AM

Junyang Shao (Gerrit), … Cherry Mui (Gerrit)34

11:34 AM

[go] cmd/compile: add new arm64 assembler data structure

Attention needed from Cherry Mui and David Chase Junyang Shao uploaded new patchset Junyang Shao

unread,

[go] cmd/compile: add new arm64 assembler data structure

Attention needed from Cherry Mui and David Chase Junyang Shao uploaded new patchset Junyang Shao

11:34 AM

Zephyr C (Gerrit), Damien Neil (Gerrit)8

11:32 AM

[go] net/netip: avoid allocation in Addr and AddrPort UnmarshalText

Attention needed from Damien Neil and Ian Lance Taylor Zephyr C uploaded new patchset Zephyr C

unread,

[go] net/netip: avoid allocation in Addr and AddrPort UnmarshalText

Attention needed from Damien Neil and Ian Lance Taylor Zephyr C uploaded new patchset Zephyr C

11:32 AM

Ian Alexander (Gerrit), … Michael Matloob (Gerrit)17

11:31 AM

[go] cmd/go: ensure that go.mod and go.sum remain consistent after `go get -tool`

Attention needed from Ian Alexander Michael Matloob voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] cmd/go: ensure that go.mod and go.sum remain consistent after `go get -tool`

Attention needed from Ian Alexander Michael Matloob voted Code-Review+2 Code-Review +2 Open in Gerrit

11:31 AM

Madeline Kalil (Gerrit), … Gopher Robot (Gerrit)11

11:29 AM

[tools] go/analysis/passes/modernize: rangeint: omit unneeded type cast

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

unread,

[tools] go/analysis/passes/modernize: rangeint: omit unneeded type cast

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 3 is the latest approved

11:29 AM

Des Kramer (Gerrit), … Cherry Mui (Gerrit)4

11:26 AM

[go] nil pointer deref in arm64.gensymlate fix

Attention needed from Des Kramer, Ian Lance Taylor and Russ Cox Cherry Mui added 1 comment File src/

unread,

[go] nil pointer deref in arm64.gensymlate fix

Attention needed from Des Kramer, Ian Lance Taylor and Russ Cox Cherry Mui added 1 comment File src/

11:26 AM

Damien Neil (Gerrit), … Gopher Robot (Gerrit)12

11:14 AM

[go] os: avoid escape from Root via ReadDir or Readdir

Damien Neil has uploaded the change for review Commit message [release-branch.go1.26] os: avoid

unread,

[go] os: avoid escape from Root via ReadDir or Readdir

Damien Neil has uploaded the change for review Commit message [release-branch.go1.26] os: avoid

11:14 AM

Keith Randall (Gerrit), … Cherry Mui (Gerrit)15

11:02 AM

[website] _content/blog: stack allocation optimizations

Keith Randall submitted the change with unreviewed changes Unreviewed changes 3 is the latest

unread,

[website] _content/blog: stack allocation optimizations

Keith Randall submitted the change with unreviewed changes Unreviewed changes 3 is the latest

11:02 AM

Gerrit Bot (Gerrit), … Tamir Duberstein (Gerrit)6

10:35 AM

[go] runtime/cgo: avoid unused parameter warning

Attention needed from Ian Lance Taylor Tamir Duberstein added 1 comment Patchset-level comments File-

unread,

[go] runtime/cgo: avoid unused parameter warning

Attention needed from Ian Lance Taylor Tamir Duberstein added 1 comment Patchset-level comments File-

10:35 AM

Alan Donovan (Gerrit)2

10:11 AM

[tools] gopls/internal/lsprpc: increase test timeout 1s -> 10s

Attention needed from Hongxiang Jiang Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

unread,

[tools] gopls/internal/lsprpc: increase test timeout 1s -> 10s

Attention needed from Hongxiang Jiang Alan Donovan voted Auto-Submit+1 Auto-Submit +1 Open in Gerrit

10:11 AM

Alan Donovan (Gerrit)3

10:01 AM

[tools] go/ssa: emit short-circuit control flow for boolean switch cases

Attention needed from Alan Donovan and Robert Griesemer Alan Donovan uploaded new patchset Alan

unread,

[tools] go/ssa: emit short-circuit control flow for boolean switch cases

Attention needed from Alan Donovan and Robert Griesemer Alan Donovan uploaded new patchset Alan

10:01 AM

Hyang-Ah Hana Kim (Gerrit)4

9:56 AM

[tools] go/analysis/passes/inline: fix panic in inlineAlias with instantiated generic alias

Attention needed from Hyang-Ah Hana Kim Hyang-Ah Hana Kim uploaded new patchset Hyang-Ah Hana Kim

unread,

[tools] go/analysis/passes/inline: fix panic in inlineAlias with instantiated generic alias

Attention needed from Hyang-Ah Hana Kim Hyang-Ah Hana Kim uploaded new patchset Hyang-Ah Hana Kim

9:56 AM

Daniel Morsing (Gerrit), … Alan Donovan (Gerrit)9

9:54 AM

[tools] go/analysis/passes/modernize: don't consider selects for min/max pass

Attention needed from Daniel Morsing, David Chase and Mark Freeman Alan Donovan voted and added 1

unread,

[tools] go/analysis/passes/modernize: don't consider selects for min/max pass

Attention needed from Daniel Morsing, David Chase and Mark Freeman Alan Donovan voted and added 1

9:54 AM

Search

Clear search

Close search

Google apps

Main menu