Groups

golang-codereviews

Contact owners and managers

1–30 of 110786

0 selected

Gerrit Bot (Gerrit), … M Shulhan (Gerrit)4

12:34 AM

[crypto] #29286: proposal for interface which exposes either callback or db.

M Shulhan voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is empty

unread,

[crypto] #29286: proposal for interface which exposes either callback or db.

M Shulhan voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is empty

12:34 AM

Chencheng Jiang (Gerrit), qiu laidongfeng (Gerrit)2

12:02 AM

[go] types2, go/types: fix conversion error for pointer to type param

Attention needed from Chencheng Jiang, Robert Findley and Robert Griesemer qiu laidongfeng voted

unread,

[go] types2, go/types: fix conversion error for pointer to type param

Attention needed from Chencheng Jiang, Robert Findley and Robert Griesemer qiu laidongfeng voted

12:02 AM

Meng Zhuo (Gerrit)2

Jun 6

[go] cmd/compile/internal/ssa: optimaze multiply-by-constant on riscv64

Attention needed from Joel Sing and Mark Ryan Meng Zhuo voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/compile/internal/ssa: optimaze multiply-by-constant on riscv64

Attention needed from Joel Sing and Mark Ryan Meng Zhuo voted Commit-Queue+1 Commit-Queue +1 Open in

Jun 6

qiu laidongfeng (Gerrit)2

Jun 6

[go] testing/synctest: add Subtest

qiu laidongfeng voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] testing/synctest: add Subtest

qiu laidongfeng voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Jun 6

Chencheng Jiang (Gerrit), Ian Lance Taylor (Gerrit)7

Jun 6

[go] syscall: use direct socket syscalls on linux/386 and linux/s390x

Attention needed from Brad Fitzpatrick, Chencheng Jiang and Tobias Klauser Ian Lance Taylor voted

unread,

[go] syscall: use direct socket syscalls on linux/386 and linux/s390x

Attention needed from Brad Fitzpatrick, Chencheng Jiang and Tobias Klauser Ian Lance Taylor voted

Jun 6

Jorropo (Gerrit)

Jun 6

[go] cmd/compile: add the ability to eat InvertFlags to ADCQ and SBBQ

Jorropo has uploaded the change for review Commit message cmd/compile: add the ability to eat

unread,

[go] cmd/compile: add the ability to eat InvertFlags to ADCQ and SBBQ

Jorropo has uploaded the change for review Commit message cmd/compile: add the ability to eat

Jun 6

Jorropo (Gerrit)

Jun 6

[go] cmd/compile: fix misscompilation of Rsh with 32bits rhs on arm64

Jorropo has uploaded the change for review Commit message cmd/compile: fix misscompilation of Rsh

unread,

[go] cmd/compile: fix misscompilation of Rsh with 32bits rhs on arm64

Jorropo has uploaded the change for review Commit message cmd/compile: fix misscompilation of Rsh

Jun 6

Gerrit Bot (Gerrit), … Nasanbat (Gerrit)9

Jun 6

[crypto] openpgp/elgamal: fix index out of range panic in Decrypt when ciphertext is zero

Attention needed from Alan Donovan, Daniel McCarney, Filippo Valsorda and Roland Shoemaker Nasanbat

unread,

[crypto] openpgp/elgamal: fix index out of range panic in Decrypt when ciphertext is zero

Attention needed from Alan Donovan, Daniel McCarney, Filippo Valsorda and Roland Shoemaker Nasanbat

Jun 6

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)9

Jun 6

[go] net: reject non-IPv6 addresses in brackets in SplitHostPort

Attention needed from Damien Neil and Nicholas Husin Ian Lance Taylor added 1 comment Patchset-level

unread,

[go] net: reject non-IPv6 addresses in brackets in SplitHostPort

Attention needed from Damien Neil and Nicholas Husin Ian Lance Taylor added 1 comment Patchset-level

Jun 6

Joel Sing (Gerrit), Ian Lance Taylor (Gerrit)3

Jun 6

[go] cmd/cgo: fix TestFortran on openbsd

Attention needed from Joel Sing and Michael Pratt Ian Lance Taylor voted and added 2 comments Votes

unread,

[go] cmd/cgo: fix TestFortran on openbsd

Attention needed from Joel Sing and Michael Pratt Ian Lance Taylor voted and added 2 comments Votes

Jun 6

Quim Muntal (Gerrit), Michael Matloob (Gerrit)2

Jun 6

[go] cmd/go/internal/load: use file path prefix check for GOROOT dirs

Attention needed from Ian Alexander and Quim Muntal Michael Matloob voted Code-Review+2 Code-Review +

unread,

[go] cmd/go/internal/load: use file path prefix check for GOROOT dirs

Attention needed from Ian Alexander and Quim Muntal Michael Matloob voted Code-Review+2 Code-Review +

Jun 6

Aurélien Rainone (Gerrit), … Aurelien RAINONE (Gerrit)6

Jun 6

[tools] go/analysis/passes/atomicalign: handle various selector types

Aurelien RAINONE abandoned this change. View Change Abandoned Aurelien RAINONE abandoned this change

unread,

[tools] go/analysis/passes/atomicalign: handle various selector types

Aurelien RAINONE abandoned this change. View Change Abandoned Aurelien RAINONE abandoned this change

Jun 6

Aurélien Rainone (Gerrit), … Aurelien RAINONE (Gerrit)24

Jun 6

[tools] go/analysis/passes/atomicalign: handle pointers to struct

Aurelien RAINONE abandoned this change. View Change Abandoned Aurelien RAINONE abandoned this change

unread,

[tools] go/analysis/passes/atomicalign: handle pointers to struct

Aurelien RAINONE abandoned this change. View Change Abandoned Aurelien RAINONE abandoned this change

Jun 6

Gerrit Bot (Gerrit), … Abhinav Gaur (Gerrit)5

Jun 6

[go] archive/tar: test tarinsecurepath behavior for link targets

Attention needed from Joseph Tsai Abhinav Gaur added 1 comment Patchset-level comments File-level

unread,

[go] archive/tar: test tarinsecurepath behavior for link targets

Attention needed from Joseph Tsai Abhinav Gaur added 1 comment Patchset-level comments File-level

Jun 6

Chencheng Jiang (Gerrit), Jorropo (Gerrit)4

Jun 6

[go] cmd/compile/internal/ssa: check used const op sizes

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Chencheng Jiang added 1 comment

unread,

[go] cmd/compile/internal/ssa: check used const op sizes

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Chencheng Jiang added 1 comment

Jun 6

Hongxiang Jiang (Gerrit), … Danny Tuppeny (Gerrit)30

Jun 6

[proposal] design: add LSP interactive refactoring proposals

Attention needed from Alan Donovan, Hongxiang Jiang, Madeline Kalil and Peter Weinberger Danny

unread,

[proposal] design: add LSP interactive refactoring proposals

Attention needed from Alan Donovan, Hongxiang Jiang, Madeline Kalil and Peter Weinberger Danny

Jun 6

Gerrit Bot (Gerrit), … Daniel Martí (Gerrit)17

Jun 6

[go] net: eliminate bounds checks in hasUpperCase

Attention needed from Ian Lance Taylor Daniel Martí voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] net: eliminate bounds checks in hasUpperCase

Attention needed from Ian Lance Taylor Daniel Martí voted Commit-Queue+1 Commit-Queue +1 Open in

Jun 6

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)4

Jun 6

[crypto] ssh: enforce source-address critical option for all auth methods

Attention needed from Nicola Murino Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3

unread,

[crypto] ssh: enforce source-address critical option for all auth methods

Attention needed from Nicola Murino Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #3

Jun 6

Gerrit Bot (Gerrit), … Dmitri Shuralyov (Gerrit)4

Jun 6

[website] solutions: update urfave/cli link to v3 GitHub URL

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

unread,

[website] solutions: update urfave/cli link to v3 GitHub URL

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to this change. Open in Gerrit

Jun 6

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)6

Jun 6

[govulncheck-action] action.yml: unset GOOS/GOARCH when installing govulncheck

Sean Liao voted and added 1 comment Votes added by Sean Liao Auto-Submit +1 TryBot-Bypass +1 1

unread,

[govulncheck-action] action.yml: unset GOOS/GOARCH when installing govulncheck

Sean Liao voted and added 1 comment Votes added by Sean Liao Auto-Submit +1 TryBot-Bypass +1 1

Jun 6

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)4

Jun 6

[wiki] GoUsers: add First Point (Turkey)

Sean Liao submitted the change Change information Commit message: GoUsers: add First Point (Turkey)

unread,

[wiki] GoUsers: add First Point (Turkey)

Sean Liao submitted the change Change information Commit message: GoUsers: add First Point (Turkey)

Jun 6

Gopher Robot (Gerrit), … Sean Liao (Gerrit)25

Jun 6

[go] net/mail: enhance address parser to include IPv6 address tags

Sean Liao submitted the change Change information Commit message: net/mail: parse ipv6 in addresses

unread,

[go] net/mail: enhance address parser to include IPv6 address tags

Sean Liao submitted the change Change information Commit message: net/mail: parse ipv6 in addresses

Jun 6

Koichi Shiraishi (zchee) (Gerrit), Alan Donovan (Gerrit)5

Jun 6

[tools] gopls/internal/cache/methodsets: fix panic on types with generic methods

Attention needed from Alan Donovan Koichi Shiraishi (zchee) added 1 comment Patchset-level comments

unread,

[tools] gopls/internal/cache/methodsets: fix panic on types with generic methods

Attention needed from Alan Donovan Koichi Shiraishi (zchee) added 1 comment Patchset-level comments

Jun 6

Paul Jolly (Gerrit), … Daniel Martí (Gerrit)12

Jun 6

[go] text/template/parse: respect delims in String representations

Attention needed from David Chase, Paul Jolly and Rob Pike Daniel Martí voted Commit-Queue+1 Commit-

unread,

[go] text/template/parse: respect delims in String representations

Attention needed from David Chase, Paul Jolly and Rob Pike Daniel Martí voted Commit-Queue+1 Commit-

Jun 6

Jorropo (Gerrit), … Keith Randall (Gerrit)13

Jun 6

[go] cmd/compile: add the concept of dual instructions to ssa/_gen

Attention needed from David Chase, Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new

unread,

[go] cmd/compile: add the concept of dual instructions to ssa/_gen

Attention needed from David Chase, Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new

Jun 6

Jorropo (Gerrit)5

Jun 6

[go] cmd/compile: teach regalloc how to commute amd64 CMOV

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new patchset

unread,

[go] cmd/compile: teach regalloc how to commute amd64 CMOV

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new patchset

Jun 6

Jorropo (Gerrit)

Jun 6

[go] cmd/compile: cleanup PPC64 atomics ssa asm generation

Jorropo has uploaded the change for review Commit message cmd/compile: cleanup PPC64 atomics ssa asm

unread,

[go] cmd/compile: cleanup PPC64 atomics ssa asm generation

Jorropo has uploaded the change for review Commit message cmd/compile: cleanup PPC64 atomics ssa asm

Jun 6

Jorropo (Gerrit), … Gopher Robot (Gerrit)12

Jun 6

[go] cmd/compile,sync/atomic: make Add And & Or SQCST on PPC64

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[go] cmd/compile,sync/atomic: make Add And & Or SQCST on PPC64

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Jun 6

Jorropo (Gerrit)

Jun 6

[go] cmd/compile: fix prove to generate Const64 for 64bits slicemasks

Jorropo has uploaded the change for review Commit message cmd/compile: fix prove to generate Const64

unread,

[go] cmd/compile: fix prove to generate Const64 for 64bits slicemasks

Jorropo has uploaded the change for review Commit message cmd/compile: fix prove to generate Const64

Jun 6

Jorropo (Gerrit)3

Jun 5

[go] cmd/compile: fix AMD64 misscompilation due to AMD64 SETcc and Jcc mapping

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new patchset

unread,

[go] cmd/compile: fix AMD64 misscompilation due to AMD64 SETcc and Jcc mapping

Attention needed from Jorropo, Keith Randall and Martin Möhrmann Jorropo uploaded new patchset

Jun 5

Search

Clear search

Close search

Google apps

Main menu