Groups

golang-codereviews

Contact owners and managers

1–30 of 105962

0 selected

Gopher Robot (Gerrit), … Sergei G (Gerrit)21

12:42 AM

[go] io: add Err field to LimitedReader

Attention needed from Robert Griesemer Sergei G added 1 comment Patchset-level comments File-level

unread,

[go] io: add Err field to LimitedReader

Attention needed from Robert Griesemer Sergei G added 1 comment Patchset-level comments File-level

12:42 AM

Alan Donovan (Gerrit), … Gopher Robot (Gerrit)7

Nov 11

[go] std,cmd: go fix -any std cmd

Gopher Robot submitted the change Change information Commit message: std,cmd: go fix -any std cmd

unread,

[go] std,cmd: go fix -any std cmd

Gopher Robot submitted the change Change information Commit message: std,cmd: go fix -any std cmd

Nov 11

Alan Donovan (Gerrit), Robert Findley (Gerrit)5

Nov 11

[tools] gopls/internal/cache: discard fixes that touch generated files

Attention needed from Robert Findley Alan Donovan added 1 comment Patchset-level comments File-level

unread,

[tools] gopls/internal/cache: discard fixes that touch generated files

Attention needed from Robert Findley Alan Donovan added 1 comment Patchset-level comments File-level

Nov 11

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)3

Nov 11

[go] Plan9 arm64 port

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[go] Plan9 arm64 port

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

Nov 11

Michael Munday (Gerrit)3

Nov 11

[go] cmd/compile: optimize comparisons with single bit difference

Attention needed from Keith Randall and Martin Möhrmann Michael Munday voted Commit-Queue+1 Commit-

unread,

[go] cmd/compile: optimize comparisons with single bit difference

Attention needed from Keith Randall and Martin Möhrmann Michael Munday voted Commit-Queue+1 Commit-

Nov 11

Ian Lance Taylor (Gerrit)

Nov 11

[go] cmd/link: put runtime.findfunctab in the .gopclntab section

Ian Lance Taylor has uploaded the change for review Commit message cmd/link: put runtime.findfunctab

unread,

[go] cmd/link: put runtime.findfunctab in the .gopclntab section

Ian Lance Taylor has uploaded the change for review Commit message cmd/link: put runtime.findfunctab

Nov 11

Alan Donovan (Gerrit), … Dmitri Shuralyov (Gerrit)9

Nov 11

[tools] go/analysis/passes/modernize: respect bootstrap toolchain version

Attention needed from Alan Donovan Dmitri Shuralyov added 1 comment File go/analysis/passes/

unread,

[tools] go/analysis/passes/modernize: respect bootstrap toolchain version

Attention needed from Alan Donovan Dmitri Shuralyov added 1 comment File go/analysis/passes/

Nov 11

Mark Freeman (Gerrit), Robert Griesemer (Gerrit)41

Nov 11

[go] go/types, types2: check for direct cycles as a separate phase

Attention needed from Mark Freeman and Robert Griesemer Robert Griesemer voted Auto-Submit +1 Code-

unread,

[go] go/types, types2: check for direct cycles as a separate phase

Attention needed from Mark Freeman and Robert Griesemer Robert Griesemer voted Auto-Submit +1 Code-

Nov 11

Jayanth Krishnamurthy (Gerrit), Paul Murphy (Gerrit)12

Nov 11

[go] runtime: enable race detector for atomic operations on linux/ppc64le

Attention needed from Jayanth Krishnamurthy Paul Murphy added 1 comment File src/runtime/race_ppc64le

unread,

[go] runtime: enable race detector for atomic operations on linux/ppc64le

Attention needed from Jayanth Krishnamurthy Paul Murphy added 1 comment File src/runtime/race_ppc64le

Nov 11

Michael Munday (Gerrit), Keith Randall (Gerrit)8

Nov 11

[go] cmd/compile: use FCLASSD for subnormal checks on riscv64

Attention needed from Joel Sing, Meng Zhuo and Michael Munday Keith Randall voted Code-Review+1 Code-

unread,

[go] cmd/compile: use FCLASSD for subnormal checks on riscv64

Attention needed from Joel Sing, Meng Zhuo and Michael Munday Keith Randall voted Code-Review+1 Code-

Nov 11

Junyang Shao (Gerrit), … David Chase (Gerrit)13

Nov 11

[go/dev.simd] [dev.simd] runtime/gc: generate greentea expand kernels in Go SIMD

Attention needed from Junyang Shao and Michael Knyszek David Chase added 1 comment File src/internal/

unread,

[go/dev.simd] [dev.simd] runtime/gc: generate greentea expand kernels in Go SIMD

Attention needed from Junyang Shao and Michael Knyszek David Chase added 1 comment File src/internal/

Nov 11

Michael Pratt (Gerrit), … Michael Knyszek (Gerrit)21

Nov 11

[go] runtime: prefer to restart Ps on the same M after STW

Attention needed from Michael Pratt Michael Knyszek voted and added 2 comments Votes added by Michael

unread,

[go] runtime: prefer to restart Ps on the same M after STW

Attention needed from Michael Pratt Michael Knyszek voted and added 2 comments Votes added by Michael

Nov 11

Ian Alexander (Gerrit), Michael Matloob (Gerrit)4

Nov 11

[go] cmd/go: consolidate global vars

Attention needed from Ian Alexander Michael Matloob voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[go] cmd/go: consolidate global vars

Attention needed from Ian Alexander Michael Matloob voted Code-Review+2 Code-Review +2 Open in Gerrit

Nov 11

Markus Kusano (Gerrit)7

Nov 11

[tools] refactor/inline: support inlining generics

Attention needed from Alan Donovan Markus Kusano voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[tools] refactor/inline: support inlining generics

Attention needed from Alan Donovan Markus Kusano voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Nov 11

Keith Randall (Gerrit)

Nov 11

[go] cmd/compile: use 4-word slice and 3-word strings while in registers

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

unread,

[go] cmd/compile: use 4-word slice and 3-word strings while in registers

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

Nov 11

Keith Randall (Gerrit)

Nov 11

[go] cmd/compile: add loop invariant code motion

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

unread,

[go] cmd/compile: add loop invariant code motion

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

Nov 11

Madeline Kalil (Gerrit), Robert Findley (Gerrit)35

Nov 11

[tools] gpls/internal/golang: check conditions for package move

Attention needed from Robert Findley Madeline Kalil uploaded new patchset Madeline Kalil uploaded

unread,

[tools] gpls/internal/golang: check conditions for package move

Attention needed from Robert Findley Madeline Kalil uploaded new patchset Madeline Kalil uploaded

Nov 11

Junyang Shao (Gerrit), David Chase (Gerrit)17

Nov 11

[go/dev.simd] [dev.simd] cmd/compile: add masked merging ops

Junyang Shao submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved

unread,

[go/dev.simd] [dev.simd] cmd/compile: add masked merging ops

Junyang Shao submitted the change with unreviewed changes Unreviewed changes 8 is the latest approved

Nov 11

t hepudds (Gerrit), … Keith Randall (Gerrit)26

Nov 11

[proposal] design/74299-runtime-free.md: add runtime.free and use via compiler and stdlib to reduce GC work

Attention needed from Keith Randall t hepudds added 1 comment File design/74299-runtime-free.md Line

unread,

[proposal] design/74299-runtime-free.md: add runtime.free and use via compiler and stdlib to reduce GC work

Attention needed from Keith Randall t hepudds added 1 comment File design/74299-runtime-free.md Line

Nov 11

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)6

Nov 11

[tools] gopls/internal/settings: correct git issue for fieldalignment deprecation message

Gopher Robot submitted the change Change information Commit message: gopls/internal/settings: correct

unread,

[tools] gopls/internal/settings: correct git issue for fieldalignment deprecation message

Gopher Robot submitted the change Change information Commit message: gopls/internal/settings: correct

Nov 11

Michael Pratt (Gerrit), … Gopher Robot (Gerrit)7

Nov 11

[go] WIP: runtime: doubly-linked sched.midle list

Gopher Robot submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

unread,

[go] WIP: runtime: doubly-linked sched.midle list

Gopher Robot submitted the change Unreviewed changes 3 is the latest approved patch-set. No files

Nov 11

Michael Pratt (Gerrit), … Gopher Robot (Gerrit)14

Nov 11

[go] runtime: use new list type for spanSPMCs

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 12 is the latest

unread,

[go] runtime: use new list type for spanSPMCs

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 12 is the latest

Nov 11

Junyang Shao (Gerrit), … Austin Clements (Gerrit)13

Nov 11

[go] cmd/compile: change testing.B.Loop keep alive semantic

Attention needed from Cherry Mui, David Chase and Junyang Shao Austin Clements added 1 comment

unread,

[go] cmd/compile: change testing.B.Loop keep alive semantic

Attention needed from Cherry Mui, David Chase and Junyang Shao Austin Clements added 1 comment

Nov 11

Jayanth Krishnamurthy (Gerrit), Paul Murphy (Gerrit)14

Nov 11

[go] cmd/compile: use immediates for uint8/uint16 bitwise ops on PPC64

Attention needed from Archana Ravindar and Jayanth Krishnamurthy Paul Murphy added 3 comments

unread,

[go] cmd/compile: use immediates for uint8/uint16 bitwise ops on PPC64

Attention needed from Archana Ravindar and Jayanth Krishnamurthy Paul Murphy added 3 comments

Nov 11

Sean Liao (Gerrit), Keith Randall (Gerrit)3

Nov 11

[go] os/exec: include Cmd.Start in the list of methods that run Cmd

Attention needed from Sean Liao Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] os/exec: include Cmd.Start in the list of methods that run Cmd

Attention needed from Sean Liao Keith Randall voted Code-Review+1 Code-Review +1 Open in Gerrit

Nov 11

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)13

Nov 11

[telemetry] internal/chartconfig: add gopls/setting/staticcheck counter

Gopher Robot submitted the change Change information Commit message: internal/chartconfig: add gopls/

unread,

[telemetry] internal/chartconfig: add gopls/setting/staticcheck counter

Gopher Robot submitted the change Change information Commit message: internal/chartconfig: add gopls/

Nov 11

Michael Pratt (Gerrit), … Gopher Robot (Gerrit)9

Nov 11

[go] runtime: reusable intrusive doubly-linked list

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

unread,

[go] runtime: reusable intrusive doubly-linked list

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 4 is the latest approved

Nov 11

Jayanth Krishnamurthy (Gerrit), … Paul Murphy (Gerrit)21

Nov 11

[go] cmd/compile: ppc64x fold (x+x)<<c into x<<(c+1)

Attention needed from Archana Ravindar, Michael Munday and Paul Murphy Jayanth Krishnamurthy voted

unread,

[go] cmd/compile: ppc64x fold (x+x)<<c into x<<(c+1)

Attention needed from Archana Ravindar, Michael Munday and Paul Murphy Jayanth Krishnamurthy voted

Nov 11

Michael Pratt (Gerrit), Michael Knyszek (Gerrit)4

Nov 11

[go] runtime: switch p.gcFractionalMarkTime to atomic.Int64

Michael Pratt voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] runtime: switch p.gcFractionalMarkTime to atomic.Int64

Michael Pratt voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Nov 11

Daniel Morsing (Gerrit), Keith Randall (Gerrit)4

Nov 11

[go] cmd/compile: optimize liveness in stackalloc

Attention needed from Daniel Morsing and Martin Möhrmann Keith Randall added 5 comments File src/cmd/

unread,

[go] cmd/compile: optimize liveness in stackalloc

Attention needed from Daniel Morsing and Martin Möhrmann Keith Randall added 5 comments File src/cmd/

Nov 11

Search

Clear search

Close search

Google apps

Main menu