Groups

golang-codereviews

Contact owners and managers

1–30 of 105446

0 selected

Ian Alexander (Gerrit), Michael Matloob (Gerrit)6

8:19 PM

[go] cmd/go: inject state parameter into `fmtcmd.runFmt`

Attention needed from Michael Matloob Ian Alexander added 1 comment File src/cmd/go/internal/fmtcmd/

unread,

[go] cmd/go: inject state parameter into `fmtcmd.runFmt`

Attention needed from Michael Matloob Ian Alexander added 1 comment File src/cmd/go/internal/fmtcmd/

8:19 PM

Vasiliy Leonenko (Gerrit), … Cherry Mui (Gerrit)6

8:18 PM

[go] cmd/internal/obj: move ARM64RegisterExtension from cmd/asm/internal/arch

Attention needed from Keith Randall, Keith Randall and Vasiliy Leonenko Cherry Mui voted Code-Review

unread,

[go] cmd/internal/obj: move ARM64RegisterExtension from cmd/asm/internal/arch

Attention needed from Keith Randall, Keith Randall and Vasiliy Leonenko Cherry Mui voted Code-Review

8:18 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)12

8:07 PM

[net] net/http2: pool transport gzip readers

Gopher Robot submitted the change Change information Commit message: net/http2: pool transport gzip

unread,

[net] net/http2: pool transport gzip readers

Gopher Robot submitted the change Change information Commit message: net/http2: pool transport gzip

8:07 PM

Tobias Klauser (Gerrit), Damien Neil (Gerrit)3

8:01 PM

[go] all: remove unnecessary loop variable copies in tests

Attention needed from Ian Lance Taylor, Michael Pratt and Tobias Klauser Damien Neil voted Auto-

unread,

[go] all: remove unnecessary loop variable copies in tests

Attention needed from Ian Lance Taylor, Michael Pratt and Tobias Klauser Damien Neil voted Auto-

8:01 PM

Gerrit Bot (Gerrit), … Damien Neil (Gerrit)14

7:54 PM

[go] net/url: reduce allocs in Encode

Attention needed from Russ Cox Damien Neil voted and added 1 comment Votes added by Damien Neil Code-

unread,

[go] net/url: reduce allocs in Encode

Attention needed from Russ Cox Damien Neil voted and added 1 comment Votes added by Damien Neil Code-

7:54 PM

Rhys Hiltner (Gerrit), Damien Neil (Gerrit)3

7:33 PM

[net] quic: send ECN feedback to peers

Attention needed from Ian Lance Taylor and Rhys Hiltner Damien Neil voted and added 1 comment Votes

unread,

[net] quic: send ECN feedback to peers

Attention needed from Ian Lance Taylor and Rhys Hiltner Damien Neil voted and added 1 comment Votes

7:33 PM

Mark Freeman (Gerrit), … Robert Griesemer (Gerrit)33

6:51 PM

[go] go/types, types2: clean up Named assertions and establish RHS invariant

Attention needed from Mark Freeman Robert Griesemer voted and added 6 comments Votes added by Robert

unread,

[go] go/types, types2: clean up Named assertions and establish RHS invariant

Attention needed from Mark Freeman Robert Griesemer voted and added 6 comments Votes added by Robert

6:51 PM

Keith Randall (Gerrit), Cherry Mui (Gerrit)5

6:23 PM

[go] runtime: increase repeat count for alloc test

Keith Randall submitted the change Change information Commit message: runtime: increase repeat count

unread,

[go] runtime: increase repeat count for alloc test

Keith Randall submitted the change Change information Commit message: runtime: increase repeat count

6:23 PM

Neal Patel (Gerrit), … Jonathan Amsterdam (Gerrit)26

5:48 PM

[pkgsite] internal/frontend: migrate go-mod-viewer.appspot.com to pkgsite.go.dev/go-mod-viewer

Attention needed from Alan Donovan and Neal Patel Jonathan Amsterdam voted Code-Review+2 Code-Review

unread,

[pkgsite] internal/frontend: migrate go-mod-viewer.appspot.com to pkgsite.go.dev/go-mod-viewer

Attention needed from Alan Donovan and Neal Patel Jonathan Amsterdam voted Code-Review+2 Code-Review

5:48 PM

Damien Neil (Gerrit), … Gopher Robot (Gerrit)7

5:41 PM

[go] net/http/httptest: record failed ResponseWriter writes

Gopher Robot submitted the change Change information Commit message: net/http/httptest: record failed

unread,

[go] net/http/httptest: record failed ResponseWriter writes

Gopher Robot submitted the change Change information Commit message: net/http/httptest: record failed

5:41 PM

Alan Donovan (Gerrit), … Michael Matloob (Gerrit)21

5:30 PM

[go] cmd: update to x/tools@4df13e3

Attention needed from Michael Matloob and Michael Matloob Alan Donovan voted Auto-Submit+1 Auto-

unread,

[go] cmd: update to x/tools@4df13e3

Attention needed from Michael Matloob and Michael Matloob Alan Donovan voted Auto-Submit+1 Auto-

5:30 PM

Alan Donovan (Gerrit), … Gopher Robot (Gerrit)6

5:11 PM

[tools] gopls/internal/test/integration/workspace: fix broken test

Gopher Robot submitted the change Change information Commit message: gopls/internal/test/integration/

unread,

[tools] gopls/internal/test/integration/workspace: fix broken test

Gopher Robot submitted the change Change information Commit message: gopls/internal/test/integration/

5:11 PM

Madeline Kalil (Gerrit), … Alan Donovan (Gerrit)15

5:10 PM

[tools] gopls/internal/analysis/modernize: add strings.Cut modernizer

Madeline Kalil voted and added 18 comments Votes added by Madeline Kalil Commit-Queue +1 18 comments

unread,

[tools] gopls/internal/analysis/modernize: add strings.Cut modernizer

Madeline Kalil voted and added 18 comments Votes added by Madeline Kalil Commit-Queue +1 18 comments

5:10 PM

Junyang Shao (Gerrit), David Chase (Gerrit)3

5:09 PM

[go/dev.simd] [dev.simd] simd/_gen: parse SHA features from XED

Attention needed from Junyang Shao David Chase voted and added 1 comment Votes added by David Chase

unread,

[go/dev.simd] [dev.simd] simd/_gen: parse SHA features from XED

Attention needed from Junyang Shao David Chase voted and added 1 comment Votes added by David Chase

5:09 PM

Roland Shoemaker (Gerrit), … Gopher Robot (Gerrit)8

5:04 PM

[go] net/url: allow IP-literals with IPv4-mapped IPv6 addresses

Attention needed from Carlos Amedee Roland Shoemaker voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] net/url: allow IP-literals with IPv4-mapped IPv6 addresses

Attention needed from Carlos Amedee Roland Shoemaker voted Commit-Queue+1 Commit-Queue +1 Open in

5:04 PM

Mateusz Poliwczak (Gerrit), … Gopher Robot (Gerrit)6

5:03 PM

[net] dns/dnsmessage: return an error for too long SVCParam.Value

Gopher Robot submitted the change Change information Commit message: dns/dnsmessage: return an error

unread,

[net] dns/dnsmessage: return an error for too long SVCParam.Value

Gopher Robot submitted the change Change information Commit message: dns/dnsmessage: return an error

5:03 PM

Ian Chen (Gerrit), … Quim Muntal (Gerrit)25

5:00 PM

[sys] windows: add iphlpapi routing functions

Attention needed from Alex Brainman, Michael Pratt and Quim Muntal Ian Chen added 1 comment Patchset-

unread,

[sys] windows: add iphlpapi routing functions

Attention needed from Alex Brainman, Michael Pratt and Quim Muntal Ian Chen added 1 comment Patchset-

5:00 PM

Alan Donovan (Gerrit), Cherry Mui (Gerrit)5

4:54 PM

[go] cmd: fix three printf problems reported by newest vet

Alan Donovan submitted the change Change information Commit message: cmd: fix three printf problems

unread,

[go] cmd: fix three printf problems reported by newest vet

Alan Donovan submitted the change Change information Commit message: cmd: fix three printf problems

4:54 PM

Wanbiao Ye (Gerrit), … Gopher Robot (Gerrit)7

4:48 PM

[go] cmd/compile: fix an error in comments

Gopher Robot submitted the change Change information Commit message: cmd/compile: fix an error in

unread,

[go] cmd/compile: fix an error in comments

Gopher Robot submitted the change Change information Commit message: cmd/compile: fix an error in

4:48 PM

Robert Griesemer (Gerrit), Mark Freeman (Gerrit)6

4:46 PM

[go] go/types, types2: fix misleading internal comment

Robert Griesemer submitted the change Change information Commit message: go/types, types2: fix

unread,

[go] go/types, types2: fix misleading internal comment

Robert Griesemer submitted the change Change information Commit message: go/types, types2: fix

4:46 PM

Quim Muntal (Gerrit), … Cherry Mui (Gerrit)13

4:45 PM

[go] runtime,syscall: implement and use syscallN on darwin

Attention needed from Cherry Mui and Michael Pratt Quim Muntal added 1 comment Patchset-level

unread,

[go] runtime,syscall: implement and use syscallN on darwin

Attention needed from Cherry Mui and Michael Pratt Quim Muntal added 1 comment Patchset-level

4:45 PM

Rhys Hiltner (Gerrit), … Gopher Robot (Gerrit)7

4:27 PM

[net] internal/quic/cmd/interop: test ChaCha20 on server

Gopher Robot submitted the change Change information Commit message: internal/quic/cmd/interop: test

unread,

[net] internal/quic/cmd/interop: test ChaCha20 on server

Gopher Robot submitted the change Change information Commit message: internal/quic/cmd/interop: test

4:27 PM

Gerrit Bot (Gerrit), … Keith Randall (Gerrit)8

4:27 PM

[go] cmd/cgo: improve error messages

Attention needed from Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Keith Randall and Sean Liao

unread,

[go] cmd/cgo: improve error messages

Attention needed from Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Keith Randall and Sean Liao

4:27 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)4

4:26 PM

[go] net/url: speed up escape and unescape

Attention needed from jub0bs Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to

unread,

[go] net/url: speed up escape and unescape

Attention needed from jub0bs Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to

4:26 PM

今も元気ハツラツ太郎 (Gerrit), … Sean Liao (Gerrit)5

4:20 PM

[net] xsrf: sha1 -> sha256

Attention needed from Damien Neil, Ian Lance Taylor and 今も元気ハツラツ太郎 Sean Liao added 1 comment Patchset

unread,

[net] xsrf: sha1 -> sha256

Attention needed from Damien Neil, Ian Lance Taylor and 今も元気ハツラツ太郎 Sean Liao added 1 comment Patchset

4:20 PM

Filippo Valsorda (Gerrit), Daniel McCarney (Gerrit)5

4:15 PM

[go] crypto/internal/fips140/entropy: move to crypto/internal/entropy/v1.0.0

Attention needed from Roland Shoemaker Filippo Valsorda voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] crypto/internal/fips140/entropy: move to crypto/internal/entropy/v1.0.0

Attention needed from Roland Shoemaker Filippo Valsorda voted Commit-Queue+1 Commit-Queue +1 Open in

4:15 PM

Dmitri Shuralyov (Gerrit), Alan Donovan (Gerrit)5

4:14 PM

[build] internal/relui: include a package in fake golang.org/x/build module

Attention needed from Dmitri Shuralyov Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[build] internal/relui: include a package in fake golang.org/x/build module

Attention needed from Dmitri Shuralyov Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit

4:14 PM

Vinay Kulkarni (Gerrit), … Gopher Robot (Gerrit)11

4:01 PM

[website] update dropbox blog link

Gopher Robot submitted the change Change information Commit message: _content/solutions: update

unread,

[website] update dropbox blog link

Gopher Robot submitted the change Change information Commit message: _content/solutions: update

4:01 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)9

4:01 PM

[website] _content/doc/gc-guide: fix typo

Gopher Robot submitted the change Change information Commit message: _content/doc/gc-guide: fix typo

unread,

[website] _content/doc/gc-guide: fix typo

Gopher Robot submitted the change Change information Commit message: _content/doc/gc-guide: fix typo

4:01 PM

Gerrit Bot (Gerrit), … Michael Pratt (Gerrit)24

4:00 PM

[arch] riscv64: add support for Zicond instructions

Attention needed from Cherry Mui Michael Pratt voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[arch] riscv64: add support for Zicond instructions

Attention needed from Cherry Mui Michael Pratt voted Code-Review+1 Code-Review +1 Open in Gerrit

4:00 PM

Search

Clear search

Close search

Google apps

Main menu