Groups

golang-codereviews

Contact owners and managers

1–30 of 106883

0 selected

Alan Donovan (Gerrit), … Nicolas Hillegeer (Gerrit)18

6:26 AM

[go] os/exec: second call to Cmd.Start is always an error

Nicolas Hillegeer added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest):

unread,

[go] os/exec: second call to Cmd.Start is always an error

Nicolas Hillegeer added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest):

6:26 AM

Xie Yuchen (Gerrit)2

6:18 AM

[tools] gopls/internal/analysis/modernize: mapsloop: undefined loop-var

Attention needed from Alan Donovan Xie Yuchen voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[tools] gopls/internal/analysis/modernize: mapsloop: undefined loop-var

Attention needed from Alan Donovan Xie Yuchen voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

6:18 AM

Ori Bernstein (Gerrit), … Richard Miller (Gerrit)3

5:51 AM

[go] os/exec_test: fix test on Plan 9

Attention needed from Ori Bernstein Richard Miller added 1 comment Patchset-level comments File-level

unread,

[go] os/exec_test: fix test on Plan 9

Attention needed from Ori Bernstein Richard Miller added 1 comment Patchset-level comments File-level

5:51 AM

Daniel Morsing (Gerrit)

4:38 AM

[go] runtime/secret: make tests more sturdy

Daniel Morsing has uploaded the change for review Commit message runtime/secret: make tests more

unread,

[go] runtime/secret: make tests more sturdy

Daniel Morsing has uploaded the change for review Commit message runtime/secret: make tests more

4:38 AM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)6

Dec 27

[go] errors: fix errors.Join single unwrappable errors

Sean Liao abandoned this change Related details Attention set is empty Submit Requirements: Code-

unread,

[go] errors: fix errors.Join single unwrappable errors

Sean Liao abandoned this change Related details Attention set is empty Submit Requirements: Code-

Dec 27

Lin Lin (Gerrit), … Sean Liao (Gerrit)6

Dec 27

[go] cmd: fix unused errors reported by ineffassign

Sean Liao submitted the change Change information Commit message: cmd: fix unused errors reported by

unread,

[go] cmd: fix unused errors reported by ineffassign

Sean Liao submitted the change Change information Commit message: cmd: fix unused errors reported by

Dec 27

sachin ruhil (Gerrit), Sean Liao (Gerrit)2

Dec 27

[go] net/smtp: preserve EHLO error for non-502 responses

Attention needed from Brad Fitzpatrick and sachin ruhil Sean Liao voted Commit-Queue+1 Commit-Queue +

unread,

[go] net/smtp: preserve EHLO error for non-502 responses

Attention needed from Brad Fitzpatrick and sachin ruhil Sean Liao voted Commit-Queue+1 Commit-Queue +

Dec 27

Emmanuel Odeke (Gerrit), Sean Liao (Gerrit)3

Dec 27

[go] log/syslog: document that this package no longer works after macOS 12.0, 13.0

Attention needed from Emmanuel Odeke, Ian Lance Taylor and Michael Pratt Sean Liao added 3 comments

unread,

[go] log/syslog: document that this package no longer works after macOS 12.0, 13.0

Attention needed from Emmanuel Odeke, Ian Lance Taylor and Michael Pratt Sean Liao added 3 comments

Dec 27

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)6

Dec 27

[go] encoding/gob: clarify docs about pointers to zero values not being sent

Sean Liao voted Code-Review +1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[go] encoding/gob: clarify docs about pointers to zero values not being sent

Sean Liao voted Code-Review +1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Dec 27

Cherry Mui (Gerrit), David Chase (Gerrit)3

Dec 27

[go] simd/archsimd: add tests for Convert operations

Cherry Mui submitted the change Change information Commit message: simd/archsimd: add more tests for

unread,

[go] simd/archsimd: add tests for Convert operations

Cherry Mui submitted the change Change information Commit message: simd/archsimd: add more tests for

Dec 27

Cherry Mui (Gerrit)2

Dec 27

[go] simd/archsimd: add tests for Extend operations

Cherry Mui submitted the change Change information Commit message: simd/archsimd: add more tests for

unread,

[go] simd/archsimd: add tests for Extend operations

Cherry Mui submitted the change Change information Commit message: simd/archsimd: add more tests for

Dec 27

Dmitri Shuralyov (Gerrit), … Moises García (Gerrit)5

Dec 27

[go/dev.boringcrypto.go1.17] [dev.boringcrypto.go1.17] all: merge go1.17.13 into dev.boringcrypto.go1.17

Moises García voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[go/dev.boringcrypto.go1.17] [dev.boringcrypto.go1.17] all: merge go1.17.13 into dev.boringcrypto.go1.17

Moises García voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

Dec 27

Gopher Robot (Gerrit), … Jorge Pinto (Gerrit)5

Dec 27

[go] internal/trace/version: change message to lowercase idiomatic go

Attention needed from Michael Knyszek, Michael Pratt and t hepudds Jorge Pinto added 1 comment File

unread,

[go] internal/trace/version: change message to lowercase idiomatic go

Attention needed from Michael Knyszek, Michael Pratt and t hepudds Jorge Pinto added 1 comment File

Dec 27

Gerrit Bot (Gerrit), … Jorge Pinto (Gerrit)3

Dec 27

[go] internal/profile: fix error message casing for function ID not found

Attention needed from Cherry Mui and Michael Pratt Jorge Pinto added 1 comment Patchset-level

unread,

[go] internal/profile: fix error message casing for function ID not found

Attention needed from Cherry Mui and Michael Pratt Jorge Pinto added 1 comment Patchset-level

Dec 27

Gerrit Bot (Gerrit)

Dec 27

[go] net/rpc: correct comment for isExportedOrBuiltinType function

Gerrit Bot has uploaded the change for review Commit message net/rpc: correct comment for

unread,

[go] net/rpc: correct comment for isExportedOrBuiltinType function

Gerrit Bot has uploaded the change for review Commit message net/rpc: correct comment for

Dec 27

Gerrit Bot (Gerrit)

Dec 27

[go] simd/archsimd/_gen/simdgen: fix typos in error messages

Gerrit Bot has uploaded the change for review Commit message simd/archsimd/_gen/simdgen: fix typos in

unread,

[go] simd/archsimd/_gen/simdgen: fix typos in error messages

Gerrit Bot has uploaded the change for review Commit message simd/archsimd/_gen/simdgen: fix typos in

Dec 27

Michael Matloob (Gerrit), … Tadeusz Cieślik (Gerrit)8

Dec 27

[go] cmd/go/internal/doc: clean up after merge with cmd/internal/doc

Tadeusz Cieślik voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[go] cmd/go/internal/doc: clean up after merge with cmd/internal/doc

Tadeusz Cieślik voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

Dec 27

Gopher Robot (Gerrit), … Xueqi Luo (Gerrit)6

Dec 27

[go] cmd/internal/obj/riscv: add assembly support of Zfa extension

Attention needed from Joel Sing, Mark Ryan, Meng Zhuo and Pengcheng Wang Xueqi Luo added 2 comments

unread,

[go] cmd/internal/obj/riscv: add assembly support of Zfa extension

Attention needed from Joel Sing, Mark Ryan, Meng Zhuo and Pengcheng Wang Xueqi Luo added 2 comments

Dec 27

Matthew “strager” Glazar (Gerrit), … Xu Liu (Gerrit)6

Dec 27

[tools] go/analysis/passes/modernize: treat 'i += 1' as 'i++'

Xu Liu added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest): Xu Liu .

unread,

[tools] go/analysis/passes/modernize: treat 'i += 1' as 'i++'

Xu Liu added 1 comment Patchset-level comments File-level comment, Patchset 2 (Latest): Xu Liu .

Dec 27

David Chase (Gerrit), … Edgar Manuel Ruiz Arias (Gerrit)3

Dec 27

[text] all: regenerate for Unicode 15.0.0

Edgar Manuel Ruiz Arias added 1 comment Patchset-level comments File-level comment, Patchset 2 (

unread,

[text] all: regenerate for Unicode 15.0.0

Edgar Manuel Ruiz Arias added 1 comment Patchset-level comments File-level comment, Patchset 2 (

Dec 27

Cherry Mui (Gerrit)

Dec 26

[go] simd/archsimd: add tests for Truncate operations

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

unread,

[go] simd/archsimd: add tests for Truncate operations

Attention needed from David Chase New activity on the change Open in Gerrit Related details Attention

Dec 26

Jayanth Krishnamurthy (Gerrit), … David Chase (Gerrit)14

Dec 26

[go/release-branch.go1.25] [release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers

Attention needed from Carlos Amedee, Cherry Mui, Dmitry Vyukov, Ian Lance Taylor and Jayanth

unread,

[go/release-branch.go1.25] [release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers

Attention needed from Carlos Amedee, Cherry Mui, Dmitry Vyukov, Ian Lance Taylor and Jayanth

Dec 26

Gerrit Bot (Gerrit), … Hongxiang Jiang (Gerrit)10

Dec 26

[vscode-go] extension: add followExec and followExecRegex options in launch request

Hongxiang Jiang submitted the change Change information Commit message: extension: add followExec and

unread,

[vscode-go] extension: add followExec and followExecRegex options in launch request

Hongxiang Jiang submitted the change Change information Commit message: extension: add followExec and

Dec 26

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)5

Dec 26

[vulndb] all: Remove O(N^2) alias check and redundant disk I/O

Gopher Robot submitted the change Change information Commit message: all: remove O(N^2) alias check

unread,

[vulndb] all: Remove O(N^2) alias check and redundant disk I/O

Gopher Robot submitted the change Change information Commit message: all: remove O(N^2) alias check

Dec 26

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)6

Dec 26

[website] _content/tour: fix offline mode `go.mod` lacking version

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #4 to this change. Open in Gerrit

unread,

[website] _content/tour: fix offline mode `go.mod` lacking version

Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #4 to this change. Open in Gerrit

Dec 26

Frank Kuehnel (Gerrit), … Daniel Morsing (Gerrit)16

Dec 26

[go] internal/ssa: Implemented data driven live variable analysis.

Attention needed from Frank Kuehnel, Keith Randall, Martin Möhrmann and t hepudds Daniel Morsing

unread,

[go] internal/ssa: Implemented data driven live variable analysis.

Attention needed from Frank Kuehnel, Keith Randall, Martin Möhrmann and t hepudds Daniel Morsing

Dec 26

Gerrit Bot (Gerrit), … Jorge Pinto (Gerrit)4

Dec 26

[go] regexp: standardize error message format in find_test.go

Attention needed from Russ Cox Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to

unread,

[go] regexp: standardize error message format in find_test.go

Attention needed from Russ Cox Gerrit Bot uploaded new patchset Gerrit Bot uploaded patch set #2 to

Dec 26

Gopher Robot (Gerrit), … Jorge Pinto (Gerrit)5

Dec 26

[go] test: correct test output formatting in strength.go

Attention needed from Ian Lance Taylor Jorge Pinto added 1 comment Patchset-level comments File-level

unread,

[go] test: correct test output formatting in strength.go

Attention needed from Ian Lance Taylor Jorge Pinto added 1 comment Patchset-level comments File-level

Dec 26

Gerrit Bot (Gerrit), … Jorge Pinto (Gerrit)3

Dec 26

[go] test/typeparam: fix malformed string and casing in sliceimp test

Jorge Pinto added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[go] test/typeparam: fix malformed string and casing in sliceimp test

Jorge Pinto added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

Dec 26

Gerrit Bot (Gerrit), … Jorge Pinto (Gerrit)3

Dec 26

[go] test: fix malformed string and casing in slices.go typeparam test

Jorge Pinto added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[go] test: fix malformed string and casing in slices.go typeparam test

Jorge Pinto added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

Dec 26

Search

Clear search

Close search

Google apps

Main menu