Groups

golang-codereviews

Contact owners and managers

1–30 of 106786

0 selected

Keith Randall (Gerrit), Cherry Mui (Gerrit)2

1:00 AM

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[sys] sys/cpu: add symbolic constants for remaining cpuid bits

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

1:00 AM

Keith Randall (Gerrit), Cherry Mui (Gerrit)2

12:58 AM

[sys] sys/cpu: use symbolic names for masks

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[sys] sys/cpu: use symbolic names for masks

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

12:58 AM

Keith Randall (Gerrit), Cherry Mui (Gerrit)2

12:56 AM

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[sys] sys/cpu: modify x86 port to match what internal/cpu does

Attention needed from Keith Randall Cherry Mui voted Code-Review+2 Code-Review +2 Open in Gerrit

12:56 AM

Nhan Nguyen (Gerrit)2

Dec 18

[tools] gopls/internal/golang/completion: skip duplicate std/ packages

Attention needed from Nhan Nguyen and Xie Yuchen Nhan Nguyen uploaded new patchset Nhan Nguyen

unread,

[tools] gopls/internal/golang/completion: skip duplicate std/ packages

Attention needed from Nhan Nguyen and Xie Yuchen Nhan Nguyen uploaded new patchset Nhan Nguyen

Dec 18

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)15

Dec 18

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

unread,

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 5 is the latest approved

Dec 18

Lin Lin (Gerrit), Alan Donovan (Gerrit)5

Dec 18

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Attention needed from Alan Donovan and Michael Matloob Lin Lin added 1 comment Patchset-level

unread,

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Attention needed from Alan Donovan and Michael Matloob Lin Lin added 1 comment Patchset-level

Dec 18

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)10

Dec 18

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Gopher Robot submitted the change Change information Commit message: gopls/internal/server: disable

unread,

[tools] gopls/internal/server: disable TestCheckGoModDeps for js

Gopher Robot submitted the change Change information Commit message: gopls/internal/server: disable

Dec 18

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

Dec 18

[tools] gopls: add "Replace := with var declaration" code action

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[tools] gopls: add "Replace := with var declaration" code action

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

Dec 18

David Chase (Gerrit), … Cherry Mui (Gerrit)9

Dec 18

[go] internal/cpu: repair VNNI feature check

David Chase submitted the change Change information Commit message: internal/cpu: repair VNNI feature

unread,

[go] internal/cpu: repair VNNI feature check

David Chase submitted the change Change information Commit message: internal/cpu: repair VNNI feature

Dec 18

shuang cui (Gerrit), Keith Randall (Gerrit)6

Dec 18

[go] all: fix some minor grammatical issues in the comments

Attention needed from Joseph Tsai, Keith Randall and Michael Knyszek shuang cui voted and added 1

unread,

[go] all: fix some minor grammatical issues in the comments

Attention needed from Joseph Tsai, Keith Randall and Michael Knyszek shuang cui voted and added 1

Dec 18

Keith Randall (Gerrit), Cuong Manh Le (Gerrit)6

Dec 18

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Cuong Manh Le voted Code-Review+2 Code-Review +

unread,

[go] cmd/compile: ensure ops have the expected argument widths

Attention needed from Keith Randall and Michael Pratt Cuong Manh Le voted Code-Review+2 Code-Review +

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)3

Dec 18

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

unread,

[go] runtime: replace sort.Slice with slices.Sort

Attention needed from Dmitry Vyukov, Ian Lance Taylor, Martin Möhrmann and Robert Griesemer Kirill

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)4

Dec 18

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace reflect.TypeOf(x) with TypeFor[T]()

Attention needed from Ian Lance Taylor, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

unread,

[go] all: replace explicit loops over maps with calls to maps package

Attention needed from Austin Clements, Ian Lance Taylor and Robert Griesemer Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

Dec 18

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

unread,

[go] all: replace []byte(fmt.Sprintf) with fmt.Appendf

Attention needed from Brad Fitzpatrick, Jonathan Amsterdam and Robert Griesemer Kirill Kolyshkin

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)6

Dec 18

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

unread,

[go] all: replace += with strings.Builder

Attention needed from Ian Lance Taylor, Rob Pike and Robert Griesemer Kirill Kolyshkin voted and

Dec 18

Kirill Kolyshkin (Gerrit), Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace ranging over Split/Fields with SplitSeq/FieldsSeq

Attention needed from Filippo Valsorda, Robert Griesemer and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit)4

Dec 18

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

unread,

[go] all: replace HasPrefix/TrimPrefix with CutPrefix

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and Roland Shoemaker Kirill Kolyshkin voted

Dec 18

Kirill Kolyshkin (Gerrit), … Robert Griesemer (Gerrit)5

Dec 18

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

unread,

[go] all: replace if/else statements with calls to min or max

Attention needed from Alan Donovan, Austin Clements, Ian Lance Taylor, Michael Pratt, Robert

Dec 18

leow kimfui (melalui Google Drive)

Dec 18

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui (cokiw...@gmail.com) telah berkongsi item berikut: ai-

unread,

Item yang dikongsi dengan anda: "ai-responsibility-update-published-february-2025 (1)_salinan.pdf"

leow kimfui berkongsi satu item leow kimfui (cokiw...@gmail.com) telah berkongsi item berikut: ai-

Dec 18

Marcellus Salvatore

Dec 18

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

unread,

Looking for an awesome blog post? We’ve got it!

Hi, I am Marcellus, A B2B writer committed to composing impactful, SEO-friendly articles for

Dec 18

Wanbiao Ye (Gerrit), Robert Griesemer (Gerrit)4

Dec 18

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer, Russ Cox and Wanbiao Ye Robert Griesemer voted and added 1

unread,

[go] math/pow10: remove overlapping boundary (n=0)

Attention needed from Robert Griesemer, Russ Cox and Wanbiao Ye Robert Griesemer voted and added 1

Dec 18

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)22

Dec 18

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted and added 3 comments Votes added by Madeline

unread,

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Alan Donovan Madeline Kalil voted and added 3 comments Votes added by Madeline

Dec 18

Alan Donovan (Gerrit), Madeline Kalil (Gerrit)4

Dec 18

[tools/internal-branch.go1.26-vendor] [internal-branch.go1.26-vendor] go/analysis/passes/modernize: disable reflecttypefor modernizer for unnamed struct/interface

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools/internal-branch.go1.26-vendor] [internal-branch.go1.26-vendor] go/analysis/passes/modernize: disable reflecttypefor modernizer for unnamed struct/interface

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Dec 18

Alan Donovan (Gerrit), … Madeline Kalil (Gerrit)12

Dec 18

[tools] go/analysis/passes/modernize: rangeint: result vars are implicit uses

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[tools] go/analysis/passes/modernize: rangeint: result vars are implicit uses

Alan Donovan voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Dec 18

Gerrit Bot (Gerrit), … Armin Günther (Gerrit)19

Dec 18

[go] math/big: add Floor and Ceil methods to Rat

Attention needed from Alan Donovan and Robert Griesemer Gerrit Bot uploaded new patchset Gerrit Bot

unread,

[go] math/big: add Floor and Ceil methods to Rat

Attention needed from Alan Donovan and Robert Griesemer Gerrit Bot uploaded new patchset Gerrit Bot

Dec 18

Kirill Kolyshkin (Gerrit), … Gopher Robot (Gerrit)5

Dec 18

[tools] gopls/internal/analysis/modernize: fix URL

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/

unread,

[tools] gopls/internal/analysis/modernize: fix URL

Gopher Robot submitted the change Change information Commit message: gopls/internal/analysis/

Dec 18

Lin Lin (Gerrit), … Michael Knyszek (Gerrit)3

Dec 18

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Lin Lin and Than McIntosh Michael Knyszek voted Code-Review+1 Code-Review +1

unread,

[go] cmd: fix unused errors reported by ineffassign

Attention needed from Lin Lin and Than McIntosh Michael Knyszek voted Code-Review+1 Code-Review +1

Dec 18

Kirill Kolyshkin (Gerrit), Alan Donovan (Gerrit)4

Dec 18

[go] all: replace strings.Index etc. with strings.Cut

Attention needed from Damien Neil, Kirill Kolyshkin and Robert Griesemer Alan Donovan voted and added

unread,

[go] all: replace strings.Index etc. with strings.Cut

Attention needed from Damien Neil, Kirill Kolyshkin and Robert Griesemer Alan Donovan voted and added

Dec 18

Peter Weinberger (Gerrit), … Alan Donovan (Gerrit)39

Dec 18

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Alan Donovan added 7 comments File gopls/doc/features/

unread,

[tools] gopls/mod: find references to required modules

Attention needed from Peter Weinberger Alan Donovan added 7 comments File gopls/doc/features/

Dec 18

Search

Clear search

Close search

Google apps

Main menu