golang-codereviews - Google Groups

Groups

Contact owners and managers

1–30 of 114876

0 selected

Julian Zhu (Gerrit)2

5:31 AM

[go] cmd/internal/obj/riscv: add displacements to vector loads and stores

Julian Zhu voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[go] cmd/internal/obj/riscv: add displacements to vector loads and stores

Julian Zhu voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

5:31 AM

Quim Muntal (Gerrit), … Alex Brainman (Gerrit)6

5:27 AM

[go] runtime, testing: use a precise monotonic clock on Windows

Quim Muntal voted and added 1 comment Votes added by Quim Muntal <quimm...@gmail.com> Commit-

unread,

[go] runtime, testing: use a precise monotonic clock on Windows

Quim Muntal voted and added 1 comment Votes added by Quim Muntal <quimm...@gmail.com> Commit-

5:27 AM

Quim Muntal (Gerrit), Cherry Mui (Gerrit)3

5:20 AM

[go] runtime: avoid missed retries when pausing goroutines

Attention needed from Austin Clements and Michael Pratt Quim Muntal added 1 comment File src/runtime/

unread,

[go] runtime: avoid missed retries when pausing goroutines

Attention needed from Austin Clements and Michael Pratt Quim Muntal added 1 comment File src/runtime/

5:20 AM

Julian Zhu (Gerrit)2

5:15 AM

[go] cmd/internal/obj/riscv: reject a masked instruction writing over v0

Attention needed from Joel Sing and Meng Zhuo Julian Zhu voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/internal/obj/riscv: reject a masked instruction writing over v0

Attention needed from Joel Sing and Meng Zhuo Julian Zhu voted Commit-Queue+1 Commit-Queue +1 Open in

5:15 AM

Quim Muntal (Gerrit), Cherry Mui (Gerrit)4

5:09 AM

[go] runtime: handle safe-point requests before executing goroutines

Attention needed from Cherry Mui and Michael Pratt Quim Muntal voted and added 1 comment Votes added

unread,

[go] runtime: handle safe-point requests before executing goroutines

Attention needed from Cherry Mui and Michael Pratt Quim Muntal voted and added 1 comment Votes added

5:09 AM

abner chenc (Gerrit), sophie zhao (Gerrit)3

4:21 AM

[go] cmd/internal/obj/loong64: optimize WORD instruction implementation

Attention needed from Meidan Li and abner chenc sophie zhao voted Code-Review+2 Code-Review +2 Open

unread,

[go] cmd/internal/obj/loong64: optimize WORD instruction implementation

Attention needed from Meidan Li and abner chenc sophie zhao voted Code-Review+2 Code-Review +2 Open

4:21 AM

sophie zhao (Gerrit), abner chenc (Gerrit)2

2:58 AM

[go] crypto/internal/fips140/aes/gcm: add loong64 AES-GCM implementation

Attention needed from Daniel McCarney, Filippo Valsorda, Roland Shoemaker and sophie zhao abner chenc

unread,

[go] crypto/internal/fips140/aes/gcm: add loong64 AES-GCM implementation

Attention needed from Daniel McCarney, Filippo Valsorda, Roland Shoemaker and sophie zhao abner chenc

2:58 AM

Gerrit Bot (Gerrit)

2:52 AM

[go] net/http/internal: allow whitespace before chunk extensions

Gerrit Bot has uploaded the change for review Commit message net/http/internal: allow whitespace

unread,

[go] net/http/internal: allow whitespace before chunk extensions

Gerrit Bot has uploaded the change for review Commit message net/http/internal: allow whitespace

2:52 AM

Alexander Musman (Gerrit), Junyang Shao (Gerrit)5

2:36 AM

[go] simd: add ARM64 64-bit element Reduce* methods

Attention needed from David Chase and Junyang Shao Alexander Musman voted and added 1 comment Votes

unread,

[go] simd: add ARM64 64-bit element Reduce* methods

Attention needed from David Chase and Junyang Shao Alexander Musman voted and added 1 comment Votes

2:36 AM

Jonathan Swinney (Gerrit), Alexander Musman (Gerrit)8

2:25 AM

[go] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Attention needed from Cherry Mui and Jonathan Swinney Alexander Musman voted Code-Review +1 Commit-

unread,

[go] [dev.simd] cmd/internal/obj/arm64: fix VFCM* compare-against-zero to accept $0

Attention needed from Cherry Mui and Jonathan Swinney Alexander Musman voted Code-Review +1 Commit-

2:25 AM

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

2:12 AM

[go] net/http: do not reuse cached unencrypted HTTP/2 connection for https requests

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

unread,

[go] net/http: do not reuse cached unencrypted HTTP/2 connection for https requests

Gopher Robot added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Gopher

2:12 AM

Sun Jing (Gerrit), Gopher Robot (Gerrit)2

1:10 AM

[tools] gopls/internal/test/integration/bench: benchmark import changes

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[tools] gopls/internal/test/integration/bench: benchmark import changes

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

1:10 AM

Will Mortensen (Gerrit)9

1:05 AM

[crypto] ssh: don't fully create channel until peer accepts outgoing req

Attention needed from Nicola Murino Will Mortensen added 1 comment File ssh/channel.go Line 417,

unread,

[crypto] ssh: don't fully create channel until peer accepts outgoing req

Attention needed from Nicola Murino Will Mortensen added 1 comment File ssh/channel.go Line 417,

1:05 AM

Will Mortensen (Gerrit), … Dmitri Shuralyov (Gerrit)10

1:02 AM

[crypto] ssh: remove channel.maxIncomingPayload

Attention needed from Carlos Amedee, Dmitri Shuralyov and Nicola Murino Will Mortensen added 2

unread,

[crypto] ssh: remove channel.maxIncomingPayload

Attention needed from Carlos Amedee, Dmitri Shuralyov and Nicola Murino Will Mortensen added 2

1:02 AM

Cuong Manh Le (Gerrit), … Cherry Mui (Gerrit)14

Oct 15

[go] cmd/compile: bound the length of shape type names

Attention needed from Cherry Mui and Keith Randall Cuong Manh Le added 1 comment File src/cmd/compile

unread,

[go] cmd/compile: bound the length of shape type names

Attention needed from Cherry Mui and Keith Randall Cuong Manh Le added 1 comment File src/cmd/compile

Oct 15

Nicholas Husin (Gerrit), … Gopher Robot (Gerrit)5

Oct 15

[go] net/http/internal/http3: do not discard response buffer on flush error

Gopher Robot submitted the change Change information Commit message: net/http/internal/http3: do not

unread,

[go] net/http/internal/http3: do not discard response buffer on flush error

Gopher Robot submitted the change Change information Commit message: net/http/internal/http3: do not

Oct 15

Hyang-Ah Hana Kim (Gerrit)4

Oct 15

[pkgsite] internal/worker: skip redis cache invalidation when inserting modules

Hyang-Ah Hana Kim voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set

unread,

[pkgsite] internal/worker: skip redis cache invalidation when inserting modules

Hyang-Ah Hana Kim voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set

Oct 15

Nicholas Husin (Gerrit), … Gopher Robot (Gerrit)4

Oct 15

[go] net/http: make redirection tests pass for HTTP/3

Gopher Robot submitted the change Change information Commit message: net/http: make redirection tests

unread,

[go] net/http: make redirection tests pass for HTTP/3

Gopher Robot submitted the change Change information Commit message: net/http: make redirection tests

Oct 15

Nicholas Husin (Gerrit), … Gopher Robot (Gerrit)4

Oct 15

[go] net/http/internal/http3: close write side of bodyless request stream ASAP

Gopher Robot submitted the change Change information Commit message: net/http/internal/http3: close

unread,

[go] net/http/internal/http3: close write side of bodyless request stream ASAP

Gopher Robot submitted the change Change information Commit message: net/http/internal/http3: close

Oct 15

sophie zhao (Gerrit), abner chenc (Gerrit)3

Oct 15

[go] crypto/internal/fips140/aes: simplify loong64 ctrBlocks4Asm carry logic

Attention needed from Daniel McCarney, Filippo Valsorda, Roland Shoemaker and sophie zhao abner chenc

unread,

[go] crypto/internal/fips140/aes: simplify loong64 ctrBlocks4Asm carry logic

Attention needed from Daniel McCarney, Filippo Valsorda, Roland Shoemaker and sophie zhao abner chenc

Oct 15

Gerrit Bot (Gerrit), Ian Lance Taylor (Gerrit)3

Oct 15

[go] cmd/go: disable C built-in functions when compiling _cgo_main.c

Attention needed from Michael Matloob Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/go: disable C built-in functions when compiling _cgo_main.c

Attention needed from Michael Matloob Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1 Open in

Oct 15

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)8

Oct 15

[go] os: return ErrClosed from RawConn methods on closed File

Attention needed from Brad Fitzpatrick and Russ Cox Ian Lance Taylor voted Commit-Queue+1 Commit-

unread,

[go] os: return ErrClosed from RawConn methods on closed File

Attention needed from Brad Fitzpatrick and Russ Cox Ian Lance Taylor voted Commit-Queue+1 Commit-

Oct 15

Ian Lance Taylor (Gerrit), Neal Patel (Gerrit)4

Oct 15

[go] encoding/binary: don't decode too far for []bool or []int8

Attention needed from Robert Griesemer Ian Lance Taylor voted Auto-Submit+1 Auto-Submit +1 Open in

unread,

[go] encoding/binary: don't decode too far for []bool or []int8

Attention needed from Robert Griesemer Ian Lance Taylor voted Auto-Submit+1 Auto-Submit +1 Open in

Oct 15

Neal Patel (Gerrit), Damien Neil (Gerrit)5

Oct 15

[go] net/rpc: document security policy explicitly

Attention needed from Neal Patel Damien Neil added 2 comments File src/net/rpc/doc.go Line 133,

unread,

[go] net/rpc: document security policy explicitly

Attention needed from Neal Patel Damien Neil added 2 comments File src/net/rpc/doc.go Line 133,

Oct 15

Alan Donovan (Gerrit), Ingo Oeser (Gerrit)8

Oct 15

[tools] gopls/internal/analysis/unusedfunc: report unused struct fields

Attention needed from Ingo Oeser and Madeline Kalil Alan Donovan added 1 comment Patchset-level

unread,

[tools] gopls/internal/analysis/unusedfunc: report unused struct fields

Attention needed from Ingo Oeser and Madeline Kalil Alan Donovan added 1 comment Patchset-level

Oct 15

Oct 15

[go] html/template: escape actions in iframe srcdoc attributes as HTML

Message from Agent Set Ready For Review Open in Gerrit Related details Attention set is empty Submit

unread,

[go] html/template: escape actions in iframe srcdoc attributes as HTML

Message from Agent Set Ready For Review Open in Gerrit Related details Attention set is empty Submit

Oct 15

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

Oct 15

[wiki] GoUsers: add Pethost

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[wiki] GoUsers: add Pethost

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

Oct 15

Josh Harshman (Gerrit), … Joel Sing (Gerrit)5

Oct 15

[go] cmd/link: use relro for internally linked openbsd executables

Attention needed from Joel Sing Josh Harshman added 1 comment File src/cmd/link/internal/ld/target.go

unread,

[go] cmd/link: use relro for internally linked openbsd executables

Attention needed from Joel Sing Josh Harshman added 1 comment File src/cmd/link/internal/ld/target.go

Oct 15

Oct 15

[tools] gopls/internal/golang: fix hover on string literals with byte escapes >= 0x80

Aman has uploaded the change for review Commit message gopls/internal/golang: fix hover on string

unread,

[tools] gopls/internal/golang: fix hover on string literals with byte escapes >= 0x80

Aman has uploaded the change for review Commit message gopls/internal/golang: fix hover on string

Oct 15

Gerrit Bot (Gerrit), … Cherry Mui (Gerrit)4

Oct 15

[go] runtime/cgo: destroy pthread attributes after use

Attention needed from Ian Lance Taylor Cherry Mui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] runtime/cgo: destroy pthread attributes after use

Attention needed from Ian Lance Taylor Cherry Mui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Oct 15

Search

Clear search

Close search

Google apps

Main menu