golang-codereviews - Google Groups

Groups

Contact owners and managers

1–30 of 111732

0 selected

shuang cui (Gerrit), Sean Liao (Gerrit)5

6:58 PM

[go] mime: reject duplicate formatted parameter names

Attention needed from Damien Neil and shuang cui Sean Liao voted Auto-Submit +1 Code-Review +2 Open

unread,

[go] mime: reject duplicate formatted parameter names

Attention needed from Damien Neil and shuang cui Sean Liao voted Auto-Submit +1 Code-Review +2 Open

6:58 PM

Nicholas Feinberg (Gerrit), … Caleb Spare (Gerrit)16

6:56 PM

[go] regexp: fix pathological slowdown in String for negated classes

Attention needed from Nicholas Feinberg and Russ Cox Caleb Spare voted Code-Review +1 Commit-Queue +1

unread,

[go] regexp: fix pathological slowdown in String for negated classes

Attention needed from Nicholas Feinberg and Russ Cox Caleb Spare voted Code-Review +1 Commit-Queue +1

6:56 PM

Gavin Li (Gerrit), Sean Liao (Gerrit)4

6:56 PM

[go] compress/flate: reuse huffman link table allocations on reinit

Attention needed from Gavin Li and Joseph Tsai Sean Liao voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] compress/flate: reuse huffman link table allocations on reinit

Attention needed from Gavin Li and Joseph Tsai Sean Liao voted Commit-Queue+1 Commit-Queue +1 Open in

6:56 PM

Tobias Klauser (Gerrit), … Sean Liao (Gerrit)3

6:51 PM

[go] maps, slices: modernize tests and benchmarks

Attention needed from Ian Lance Taylor and Tobias Klauser Sean Liao added 2 comments File src/slices/

unread,

[go] maps, slices: modernize tests and benchmarks

Attention needed from Ian Lance Taylor and Tobias Klauser Sean Liao added 2 comments File src/slices/

6:51 PM

shuang cui (Gerrit), … Sean Liao (Gerrit)6

6:46 PM

[go] os/exec: make the Cmd.Start example runnable in the playground

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and shuang cui Sean Liao voted Code-Review+2

unread,

[go] os/exec: make the Cmd.Start example runnable in the playground

Attention needed from Brad Fitzpatrick, Ian Lance Taylor and shuang cui Sean Liao voted Code-Review+2

6:46 PM

jiahua wang (Gerrit), Sean Liao (Gerrit)2

6:42 PM

[go] math/rand: update NewSource document

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] math/rand: update NewSource document

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

6:42 PM

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)10

6:41 PM

[crypto] ssh: report verified signature format to callback

Gopher Robot submitted the change Change information Commit message: ssh: report verified signature

unread,

[crypto] ssh: report verified signature format to callback

Gopher Robot submitted the change Change information Commit message: ssh: report verified signature

6:41 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)7

6:41 PM

[go] log: support millisecond timestamp resolution

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] log: support millisecond timestamp resolution

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

6:41 PM

Alex Brainman (Gerrit), … David Chase (Gerrit)7

6:41 PM

[go] cmd/internal/script: make TestInterruptCmd pass on plan9

Attention needed from Alex Brainman David Chase voted Code-Review+1 Code-Review +1 Open in Gerrit

unread,

[go] cmd/internal/script: make TestInterruptCmd pass on plan9

Attention needed from Alex Brainman David Chase voted Code-Review+1 Code-Review +1 Open in Gerrit

6:41 PM

Gido ten Cate (Gerrit), Sean Liao (Gerrit)4

6:21 PM

[go] database/sql: isolate hot atomic counters from connection-pool mutex

Attention needed from Brad Fitzpatrick, Daniel Theophanes and Gido ten Cate Sean Liao voted and added

unread,

[go] database/sql: isolate hot atomic counters from connection-pool mutex

Attention needed from Brad Fitzpatrick, Daniel Theophanes and Gido ten Cate Sean Liao voted and added

6:21 PM

Ian Alexander (Gerrit), Damien Neil (Gerrit)15

6:18 PM

[text] secure/precis: fix short destination buffer handling in Nickname profile

Attention needed from Ian Alexander and Nicholas Husin Damien Neil voted and added 1 comment Votes

unread,

[text] secure/precis: fix short destination buffer handling in Nickname profile

Attention needed from Ian Alexander and Nicholas Husin Damien Neil voted and added 1 comment Votes

6:18 PM

Gerrit Bot (Gerrit), Sean Liao (Gerrit)2

6:17 PM

[go] database/sql/driver: fix Rows.Next() comment

Attention needed from Brad Fitzpatrick and Daniel Theophanes Sean Liao voted Auto-Submit +1 Code-

unread,

[go] database/sql/driver: fix Rows.Next() comment

Attention needed from Brad Fitzpatrick and Daniel Theophanes Sean Liao voted Auto-Submit +1 Code-

6:17 PM

Nikita Pivkin (Gerrit), … Sean Liao (Gerrit)5

6:12 PM

[go] debug: close binary files

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] debug: close binary files

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

6:12 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)4

6:12 PM

[go] debug: fix comment error

Attention needed from Ian Lance Taylor Sean Liao voted Auto-Submit +1 Code-Review +1 Commit-Queue +1

unread,

[go] debug: fix comment error

Attention needed from Ian Lance Taylor Sean Liao voted Auto-Submit +1 Code-Review +1 Commit-Queue +1

6:12 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)17

6:05 PM

[go] context: fix outdated documentation

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] context: fix outdated documentation

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

6:05 PM

Gilbert Morgan (Gerrit), … Keith Randall (Gerrit)8

6:05 PM

[go] cmd/compile: use staticuint64s for small constants

Attention needed from Gilbert Morgan, Matthew Dempsky and Robert Griesemer Keith Randall added 2

unread,

[go] cmd/compile: use staticuint64s for small constants

Attention needed from Gilbert Morgan, Matthew Dempsky and Robert Griesemer Keith Randall added 2

6:05 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)5

6:04 PM

[go] container/heap: use sort.Interface where possible

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] container/heap: use sort.Interface where possible

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

6:04 PM

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)5

5:59 PM

[tools] go/analysis/passes/modernize: slicesbackward - skip is s[i] is mutated

Attention needed from Madeline Kalil Alan Donovan added 1 comment File go/analysis/passes/modernize/

unread,

[tools] go/analysis/passes/modernize: slicesbackward - skip is s[i] is mutated

Attention needed from Madeline Kalil Alan Donovan added 1 comment File go/analysis/passes/modernize/

5:59 PM

Chencheng Jiang (Gerrit), Sean Liao (Gerrit)2

5:58 PM

[go] strings, bytes: speed up TrimSpace for Unicode input

Attention needed from Brad Fitzpatrick, Chencheng Jiang, Ian Lance Taylor and Robert Griesemer Sean

unread,

[go] strings, bytes: speed up TrimSpace for Unicode input

Attention needed from Brad Fitzpatrick, Chencheng Jiang, Ian Lance Taylor and Robert Griesemer Sean

5:58 PM

Sean Liao (Gerrit)

5:47 PM

[go] bytes: add Clone function

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

unread,

[go] bytes: add Clone function

Sean Liao abandoned this change. View Change Abandoned Sean Liao abandoned this change Related

5:47 PM

Damien Neil (Gerrit), Sean Liao (Gerrit)2

5:46 PM

[go] archive/tar: avoid creating excessive implied directory entries

Attention needed from Damien Neil and Roland Shoemaker Sean Liao added 1 comment Commit Message Line

unread,

[go] archive/tar: avoid creating excessive implied directory entries

Attention needed from Damien Neil and Roland Shoemaker Sean Liao added 1 comment Commit Message Line

5:46 PM

Gerrit Bot (Gerrit), … Arne Jørgensen (Gerrit)5

5:46 PM

[govulncheck-action] action.yml: add option to skip setting up go

Arne Jørgensen added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Hyang

unread,

[govulncheck-action] action.yml: add option to skip setting up go

Arne Jørgensen added 1 comment Patchset-level comments File-level comment, Patchset 1 (Latest): Hyang

5:46 PM

Nicholas Husin (Gerrit), Damien Neil (Gerrit)2

5:44 PM

[net] internal/http3: implement idle timeout for the server

Attention needed from Nicholas Husin Damien Neil added 6 comments File internal/http3/server.go Line

unread,

[net] internal/http3: implement idle timeout for the server

Attention needed from Nicholas Husin Damien Neil added 6 comments File internal/http3/server.go Line

5:44 PM

Cyber Hamza (Gerrit), Sean Liao (Gerrit)2

5:43 PM

[go] archive/zip: only write necessary Zip64 extra field fields

Sean Liao abandoned this change. View Change Abandoned issue fixed with https://go-review.

unread,

[go] archive/zip: only write necessary Zip64 extra field fields

Sean Liao abandoned this change. View Change Abandoned issue fixed with https://go-review.

5:43 PM

Hyang-Ah Hana Kim (Gerrit), Dmitri Shuralyov (Gerrit)3

5:42 PM

[playground] all: run go fix ./...

Attention needed from Hyang-Ah Hana Kim and Nicholas Husin Dmitri Shuralyov voted Code-Review+1 Code-

unread,

[playground] all: run go fix ./...

Attention needed from Hyang-Ah Hana Kim and Nicholas Husin Dmitri Shuralyov voted Code-Review+1 Code-

5:42 PM

Hyang-Ah Hana Kim (Gerrit), Dmitri Shuralyov (Gerrit)3

5:33 PM

[playground] sandbox: instrument container wait time (queue delay)

Attention needed from Hyang-Ah Hana Kim and Nicholas Husin Dmitri Shuralyov voted Code-Review+1 Code-

unread,

[playground] sandbox: instrument container wait time (queue delay)

Attention needed from Hyang-Ah Hana Kim and Nicholas Husin Dmitri Shuralyov voted Code-Review+1 Code-

5:33 PM

Michael Pratt (Gerrit), … Cherry Mui (Gerrit)3

5:33 PM

[wiki] Watchflakes: add example for matching all subtests

Attention needed from Michael Pratt Cherry Mui voted and added 1 comment Votes added by Cherry Mui

unread,

[wiki] Watchflakes: add example for matching all subtests

Attention needed from Michael Pratt Cherry Mui voted and added 1 comment Votes added by Cherry Mui

5:33 PM

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)5

5:32 PM

[go] archive/zip: honor Modified field in CreateRaw

Attention needed from Joseph Tsai Sean Liao voted and added 1 comment Votes added by Sean Liao Commit

unread,

[go] archive/zip: honor Modified field in CreateRaw

Attention needed from Joseph Tsai Sean Liao voted and added 1 comment Votes added by Sean Liao Commit

5:32 PM

Michael Matloob (Gerrit)

5:30 PM

[go] cmd/go/internal/modload: remove state manipulation functions

Attention needed from Ian Alexander New activity on the change Open in Gerrit Related details

unread,

[go] cmd/go/internal/modload: remove state manipulation functions

Attention needed from Ian Alexander New activity on the change Open in Gerrit Related details

5:30 PM

Michael Matloob (Gerrit), … Gopher Robot (Gerrit)9

5:29 PM

[go] rewrite x-y*z to fused multiply subtract for GOAMD64=v3

Gopher Robot submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

unread,

[go] rewrite x-y*z to fused multiply subtract for GOAMD64=v3

Gopher Robot submitted the change Unreviewed changes 1 is the latest approved patch-set. No files

5:29 PM

Search

Clear search

Close search

Google apps

Main menu