Groups

golang-codereviews

Contact owners and managers

1–30 of 106733

0 selected

Ian Lance Taylor (Gerrit), … Gopher Robot (Gerrit)5

12:28 AM

[go] cmd/cgo: don't emit C local if it is not used

Gopher Robot submitted the change Change information Commit message: cmd/cgo: don't emit C local

unread,

[go] cmd/cgo: don't emit C local if it is not used

Gopher Robot submitted the change Change information Commit message: cmd/cgo: don't emit C local

12:28 AM

Cherry Mui (Gerrit)

Dec 16

[go] simd/archsimd: reword documentation of As methods

Attention needed from David Chase Cherry Mui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] simd/archsimd: reword documentation of As methods

Attention needed from David Chase Cherry Mui voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Dec 16

Gerrit Bot (Gerrit), … Marcos P. Sánchez (Gerrit)6

Dec 16

[go] runtime: use floor instead of ceil for cgroup CPU limits in adjustCgroupGOMAXPROCS

Attention needed from Austin Clements, Keith Randall and Martin Möhrmann Gerrit Bot uploaded new

unread,

[go] runtime: use floor instead of ceil for cgroup CPU limits in adjustCgroupGOMAXPROCS

Attention needed from Austin Clements, Keith Randall and Martin Möhrmann Gerrit Bot uploaded new

Dec 16

Alan Donovan (Gerrit), … Gopher Robot (Gerrit)4

Dec 16

[tools] go/types/internal/play: show astutil.Select results too

Gopher Robot submitted the change Change information Commit message: go/types/internal/play: show

unread,

[tools] go/types/internal/play: show astutil.Select results too

Gopher Robot submitted the change Change information Commit message: go/types/internal/play: show

Dec 16

Madeline Kalil (Gerrit), … Alan Donovan (Gerrit)16

Dec 16

[tools] gopls/internal/golang: implement type definition for builtin types

Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit Related details Attention set is empty

unread,

[tools] gopls/internal/golang: implement type definition for builtin types

Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit Related details Attention set is empty

Dec 16

Hongxiang Jiang (Gerrit), … Alan Donovan (Gerrit)13

Dec 16

[tools] gopls/internal/test/marker: add optional error to typedef marker

Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit Related details Attention set is empty

unread,

[tools] gopls/internal/test/marker: add optional error to typedef marker

Alan Donovan voted Code-Review+2 Code-Review +2 Open in Gerrit Related details Attention set is empty

Dec 16

Hongxiang Jiang (Gerrit), Alan Donovan (Gerrit)6

Dec 16

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Attention needed from Hongxiang Jiang and Madeline Kalil Alan Donovan added 3 comments File internal/

unread,

[tools] internal/astutil: return enclosing node when Select finds no enclosing node

Attention needed from Hongxiang Jiang and Madeline Kalil Alan Donovan added 3 comments File internal/

Dec 16

Josh Bleecher Snyder (Gerrit), … David Chase (Gerrit)4

Dec 16

[term] x/term: handle transpose

Attention needed from Josh Bleecher Snyder David Chase voted Code-Review+1 Code-Review +1 Open in

unread,

[term] x/term: handle transpose

Attention needed from Josh Bleecher Snyder David Chase voted Code-Review+1 Code-Review +1 Open in

Dec 16

Joseph Tsai (Gerrit), Michael Knyszek (Gerrit)6

Dec 16

[go] runtime: include throw and fatal message in SetCrashOutput

Attention needed from Michael Knyszek and Michael Pratt Joseph Tsai added 1 comment Patchset-level

unread,

[go] runtime: include throw and fatal message in SetCrashOutput

Attention needed from Michael Knyszek and Michael Pratt Joseph Tsai added 1 comment Patchset-level

Dec 16

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)3

Dec 16

[go] cmd/dist: detect import cycles instead of deadlocking

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[go] cmd/dist: detect import cycles instead of deadlocking

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

Dec 16

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)12

Dec 16

[tools] gopls/internal/protocol: patch RenameParams to extend PositionParams

Gopher Robot submitted the change Change information Commit message: gopls/internal/protocol: patch

unread,

[tools] gopls/internal/protocol: patch RenameParams to extend PositionParams

Gopher Robot submitted the change Change information Commit message: gopls/internal/protocol: patch

Dec 16

Hongxiang Jiang (Gerrit)5

Dec 16

[tools] WIP: migrate all pos uage to range

Hongxiang Jiang uploaded new patchset Hongxiang Jiang uploaded patch set #7 to this change. Open in

unread,

[tools] WIP: migrate all pos uage to range

Hongxiang Jiang uploaded new patchset Hongxiang Jiang uploaded patch set #7 to this change. Open in

Dec 16

Kirill Kolyshkin (Gerrit), Michael Pratt (Gerrit)4

Dec 16

[sys] unix: add CPUSetInterface for variable-size CPU affinity masks

Attention needed from Michael Pratt and Tobias Klauser Kirill Kolyshkin added 1 comment File unix/

unread,

[sys] unix: add CPUSetInterface for variable-size CPU affinity masks

Attention needed from Michael Pratt and Tobias Klauser Kirill Kolyshkin added 1 comment File unix/

Dec 16

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)9

Dec 16

[go] cmd/link: add more clang driver flags when testing flag

Attention needed from Cherry Mui and Russ Cox Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1

unread,

[go] cmd/link: add more clang driver flags when testing flag

Attention needed from Cherry Mui and Russ Cox Ian Lance Taylor voted Commit-Queue+1 Commit-Queue +1

Dec 16

Daniel Morsing (Gerrit), … t hepudds (Gerrit)14

Dec 16

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing t hepudds voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] runtime: pass actual allocation size to special free

Attention needed from Daniel Morsing t hepudds voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Dec 16

David Chase (Gerrit), Keith Randall (Gerrit)5

Dec 16

[go] cmd/compile: (wasm) optimize float32(round64(float64(x)))

Attention needed from Martin Möhrmann David Chase voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

unread,

[go] cmd/compile: (wasm) optimize float32(round64(float64(x)))

Attention needed from Martin Möhrmann David Chase voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit

Dec 16

David Chase (Gerrit), Keith Randall (Gerrit)9

Dec 16

[go] cmd/compile: (amd64) optimize float32(round64(float64(x)))

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann and Russ Cox David Chase voted

unread,

[go] cmd/compile: (amd64) optimize float32(round64(float64(x)))

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann and Russ Cox David Chase voted

Dec 16

Dmitri Shuralyov (Gerrit), … Gopher Robot (Gerrit)8

Dec 16

[build] internal/relui: fix Go version in "Mail x/tools stdlib CL" during RCs

Gopher Robot submitted the change Change information Commit message: internal/relui: fix Go version

unread,

[build] internal/relui: fix Go version in "Mail x/tools stdlib CL" during RCs

Gopher Robot submitted the change Change information Commit message: internal/relui: fix Go version

Dec 16

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)13

Dec 16

[tools] gopls/internal/server: modify checkGoModDeps condition

Gopher Robot submitted the change Unreviewed changes 4 is the latest approved patch-set. No files

unread,

[tools] gopls/internal/server: modify checkGoModDeps condition

Gopher Robot submitted the change Unreviewed changes 4 is the latest approved patch-set. No files

Dec 16

Alan Donovan (Gerrit), Madeline Kalil (Gerrit)6

Dec 16

[tools] go/analysis/passes/scannererr: report failure to check bufio.Scanner.Err

Attention needed from Alan Donovan Madeline Kalil voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[tools] go/analysis/passes/scannererr: report failure to check bufio.Scanner.Err

Attention needed from Alan Donovan Madeline Kalil voted Code-Review+2 Code-Review +2 Open in Gerrit

Dec 16

Ethan Lee (Gerrit), Hongxiang Jiang (Gerrit)35

Dec 16

[tools] internal/server: store vulncheck prompt preference

Attention needed from Hongxiang Jiang Ethan Lee voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit

unread,

[tools] internal/server: store vulncheck prompt preference

Attention needed from Hongxiang Jiang Ethan Lee voted Auto-Submit +1 Commit-Queue +1 Open in Gerrit

Dec 16

Ethan Lee (Gerrit)8

Dec 16

[tools] internal/server: add vulncheck scanning after vulncheck prompt

Attention needed from Ethan Lee and Hongxiang Jiang Ethan Lee uploaded new patchset Ethan Lee

unread,

[tools] internal/server: add vulncheck scanning after vulncheck prompt

Attention needed from Ethan Lee and Hongxiang Jiang Ethan Lee uploaded new patchset Ethan Lee

Dec 16

Gopher Robot (Gerrit), … Dmitri Shuralyov (Gerrit)6

Dec 16

[tools] internal/stdlib: update stdlib index for Go 1.26 Release Candidate 1

Attention needed from Michael Knyszek Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in

unread,

[tools] internal/stdlib: update stdlib index for Go 1.26 Release Candidate 1

Attention needed from Michael Knyszek Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in

Dec 16

Filippo Valsorda (Gerrit), … Gopher Robot (Gerrit)10

Dec 16

[go] crypto/internal/fips140only: test fips140=only mode

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

unread,

[go] crypto/internal/fips140only: test fips140=only mode

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 7 is the latest approved

Dec 16

Josh Bleecher Snyder (Gerrit), … Gopher Robot (Gerrit)5

Dec 16

[term] x/term: handle delete key

Gopher Robot submitted the change Change information Commit message: x/term: handle delete key Fixes

unread,

[term] x/term: handle delete key

Gopher Robot submitted the change Change information Commit message: x/term: handle delete key Fixes

Dec 16

Madeline Kalil (Gerrit), … Alan Donovan (Gerrit)11

Dec 16

[tools] gopls/internal/golang: MoveType - extract type to new file

Attention needed from Madeline Kalil Alan Donovan added 28 comments Commit Message Line 7, Patchset 6

unread,

[tools] gopls/internal/golang: MoveType - extract type to new file

Attention needed from Madeline Kalil Alan Donovan added 28 comments Commit Message Line 7, Patchset 6

Dec 16

Sean Liao (Gerrit), … Michael Knyszek (Gerrit)8

Dec 16

[go] go/doc: exclude examples with results

Sean Liao submitted the change Change information Commit message: go/doc: exclude examples with

unread,

[go] go/doc: exclude examples with results

Sean Liao submitted the change Change information Commit message: go/doc: exclude examples with

Dec 16

Hongxiang Jiang (Gerrit), … Gopher Robot (Gerrit)11

Dec 16

[vscode-go] extension/src/language: extend range support to type def

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[vscode-go] extension/src/language: extend range support to type def

Gopher Robot submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Dec 16

Madeline Kalil (Gerrit), Alan Donovan (Gerrit)18

Dec 16

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Madeline Kalil Alan Donovan added 4 comments Patchset-level comments File-level

unread,

[tools] gopls/internal/golang: fix incorrect missing method code action

Attention needed from Madeline Kalil Alan Donovan added 4 comments Patchset-level comments File-level

Dec 16

Gopher Robot (Gerrit), … David Chase (Gerrit)6

Dec 16

[dl] dl: add go1.26rc1

Gopher Robot submitted the change Change information Commit message: dl: add go1.26rc1 Change-Id:

unread,

[dl] dl: add go1.26rc1

Gopher Robot submitted the change Change information Commit message: dl: add go1.26rc1 Change-Id:

Dec 16

Search

Clear search

Close search

Google apps

Main menu