Groups

golang-codereviews

Contact owners and managers

1–30 of 106812

0 selected

Alex Brainman (Gerrit), … Emmanuel Odeke (Gerrit)25

7:33 PM

[go] debug/pe: avoid panic in File.ImportedSymbols

Alex Brainman added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest): Alex

unread,

[go] debug/pe: avoid panic in File.ImportedSymbols

Alex Brainman added 1 comment Patchset-level comments File-level comment, Patchset 5 (Latest): Alex

7:33 PM

Lin Lin (Gerrit), Ian Lance Taylor (Gerrit)3

6:25 PM

[go] runtime: correct a log message in TestCleanupLost

Attention needed from Austin Clements, Ian Lance Taylor, Keith Randall and Martin Möhrmann Lin Lin

unread,

[go] runtime: correct a log message in TestCleanupLost

Attention needed from Austin Clements, Ian Lance Taylor, Keith Randall and Martin Möhrmann Lin Lin

6:25 PM

Gopher Robot (Gerrit), … Elaine Pawson (Gerrit)128

5:51 PM

[mod] go.mod: update golang.org/x dependencies

Elaine Pawson voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

unread,

[mod] go.mod: update golang.org/x dependencies

Elaine Pawson voted Code-Review+1 Code-Review +1 Open in Gerrit Related details Attention set is

5:51 PM

Gerrit Bot (Gerrit), … Ian Lance Taylor (Gerrit)11

5:41 PM

[go] cmd/link: improve PE section handling

Attention needed from Cherry Mui, Meng Zhuo, Russ Cox and xie cui Ian Lance Taylor added 5 comments

unread,

[go] cmd/link: improve PE section handling

Attention needed from Cherry Mui, Meng Zhuo, Russ Cox and xie cui Ian Lance Taylor added 5 comments

5:41 PM

Gerrit Bot (Gerrit), Gopher Robot (Gerrit)2

3:16 PM

[wiki] Update GoUsers.md

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

unread,

[wiki] Update GoUsers.md

Message from Gopher Robot Congratulations on opening your first change. Thank you for your

3:16 PM

Nicola Murino (Gerrit)6

2:00 PM

[crypto] ssh/agent: WIP restrict destinations

Nicola Murino uploaded new patchset Nicola Murino uploaded patch set #7 to this change. Open in

unread,

[crypto] ssh/agent: WIP restrict destinations

Nicola Murino uploaded new patchset Nicola Murino uploaded patch set #7 to this change. Open in

2:00 PM

장재영 (Gerrit)

12:39 PM

[pkgsite] go.mod: update golang.org/x dependencies

장재영 added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): 장재영 . resolved

unread,

[pkgsite] go.mod: update golang.org/x dependencies

장재영 added 1 comment Patchset-level comments File-level comment, Patchset 3 (Latest): 장재영 . resolved

12:39 PM

Lin Lin (Gerrit), … Gopher Robot (Gerrit)9

1:38 AM

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Attention needed from Alan Donovan Lin Lin added 1 comment Patchset-level comments File-level comment

unread,

[tools] go/analysis/passes/modernize: fix doc URLs in newexpr.go and stringscurt.go

Attention needed from Alan Donovan Lin Lin added 1 comment Patchset-level comments File-level comment

1:38 AM

David Chase (Gerrit), … Mark Pulford (Gerrit)12

Dec 20

[go/dev.simd] [dev.simd] simd/archsimd: add HasAVX2() guards to tests that need them

Mark Pulford added 1 comment Patchset-level comments File-level comment, Patchset 1: Mark Pulford .

unread,

[go/dev.simd] [dev.simd] simd/archsimd: add HasAVX2() guards to tests that need them

Mark Pulford added 1 comment Patchset-level comments File-level comment, Patchset 1: Mark Pulford .

Dec 20

Ethan Lee (Gerrit), … kokoro (Gerrit)12

Dec 20

[pkgsite] tests: update docs for updating screenshot tests

Ethan Lee submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

unread,

[pkgsite] tests: update docs for updating screenshot tests

Ethan Lee submitted the change with unreviewed changes Unreviewed changes 1 is the latest approved

Dec 20

Peter Weinberger (Gerrit), … Alan Donovan (Gerrit)48

Dec 20

[tools] gopls/mod: find references to required modules

Attention needed from Alan Donovan, Peter Weinberger and antonio vereecken Peter Weinberger uploaded

unread,

[tools] gopls/mod: find references to required modules

Attention needed from Alan Donovan, Peter Weinberger and antonio vereecken Peter Weinberger uploaded

Dec 20

Peter Weinberger (Gerrit), Alan Donovan (Gerrit)9

Dec 20

[tools] internal/diff/lcs: introduce line diffs

Attention needed from Alan Donovan Peter Weinberger voted and added 10 comments Votes added by Peter

unread,

[tools] internal/diff/lcs: introduce line diffs

Attention needed from Alan Donovan Peter Weinberger voted and added 10 comments Votes added by Peter

Dec 20

Frank Kuehnel (Gerrit), t hepudds (Gerrit)4

Dec 20

[go] internal/ssa: Implemented data driven live variable analysis.

Attention needed from Frank Kuehnel, Keith Randall and Martin Möhrmann t hepudds voted Commit-Queue+1

unread,

[go] internal/ssa: Implemented data driven live variable analysis.

Attention needed from Frank Kuehnel, Keith Randall and Martin Möhrmann t hepudds voted Commit-Queue+1

Dec 20

Michael Matloob (Gerrit), Dmitri Shuralyov (Gerrit)3

Dec 20

[website] _content/doc/go1.26: add note for lower go mod init go directive version

Attention needed from Michael Matloob Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in

unread,

[website] _content/doc/go1.26: add note for lower go mod init go directive version

Attention needed from Michael Matloob Dmitri Shuralyov voted Code-Review+1 Code-Review +1 Open in

Dec 20

Jorropo (Gerrit)4

Dec 20

[go] cmd/compile: on AMD64 add an already zero argument for SETcc to write into

Attention needed from Jorropo, Keith Randall, Martin Möhrmann and Roland Shoemaker Jorropo uploaded

unread,

[go] cmd/compile: on AMD64 add an already zero argument for SETcc to write into

Attention needed from Jorropo, Keith Randall, Martin Möhrmann and Roland Shoemaker Jorropo uploaded

Dec 20

JB (Gerrit), … Sean Liao (Gerrit)7

Dec 20

[website] ix/website/tour: default for high bound is length of array

Attention needed from JB Sean Liao voted Auto-Submit +1 Code-Review +2 Open in Gerrit Related details

unread,

[website] ix/website/tour: default for high bound is length of array

Attention needed from JB Sean Liao voted Auto-Submit +1 Code-Review +2 Open in Gerrit Related details

Dec 20

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)49

Dec 20

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Gopher Robot submitted the change Change information Commit message: internal/frontend: add CodeWiki

unread,

[pkgsite] internal/frontend: add CodeWiki link support to pkgsite

Gopher Robot submitted the change Change information Commit message: internal/frontend: add CodeWiki

Dec 20

Ethan Lee (Gerrit), … Gopher Robot (Gerrit)4

Dec 20

[pkgsite] test/screentest: increase timeout for "x/net directories expanded"

Gopher Robot submitted the change Change information Commit message: test/screentest: increase

unread,

[pkgsite] test/screentest: increase timeout for "x/net directories expanded"

Gopher Robot submitted the change Change information Commit message: test/screentest: increase

Dec 20

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)6

Dec 20

[website] _content/blog: fix synctest function name (Run -> Test)

Sean Liao added 1 comment File _content/blog/synctest.md Line 107, Patchset 1 (Latest): The package

unread,

[website] _content/blog: fix synctest function name (Run -> Test)

Sean Liao added 1 comment File _content/blog/synctest.md Line 107, Patchset 1 (Latest): The package

Dec 20

Jorropo (Gerrit)2

Dec 20

[go] cmd/compile: on amd64 use 32bits copies for 64bits copies of 32bits values

Attention needed from Jorropo Jorropo uploaded new patchset Jorropo uploaded patch set #2 to this

unread,

[go] cmd/compile: on amd64 use 32bits copies for 64bits copies of 32bits values

Attention needed from Jorropo Jorropo uploaded new patchset Jorropo uploaded patch set #2 to this

Dec 20

Sean Liao (Gerrit)5

Dec 20

[go] cmd/go/internal/doc: use cfg.BuildContext instead of build.Default

Attention needed from Michael Matloob Sean Liao voted and added 1 comment Votes added by Sean Liao

unread,

[go] cmd/go/internal/doc: use cfg.BuildContext instead of build.Default

Attention needed from Michael Matloob Sean Liao voted and added 1 comment Votes added by Sean Liao

Dec 20

Sean Liao (Gerrit)4

Dec 20

[go] cmd/go/internal/doc: add -tags flags and handle GOFLAGS

Sean Liao voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

unread,

[go] cmd/go/internal/doc: add -tags flags and handle GOFLAGS

Sean Liao voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is empty

Dec 20

Gerrit Bot (Gerrit), … Sean Liao (Gerrit)7

Dec 20

[go] runtime: use floor instead of ceil for cgroup CPU limits in adjustCgroupGOMAXPROCS

Attention needed from Austin Clements, Keith Randall and Martin Möhrmann Sean Liao voted and added 1

unread,

[go] runtime: use floor instead of ceil for cgroup CPU limits in adjustCgroupGOMAXPROCS

Attention needed from Austin Clements, Keith Randall and Martin Möhrmann Sean Liao voted and added 1

Dec 20

Kevin Burke (Gerrit)2

Dec 20

[go] strconv: optimize and simplify dragonbox implementation

Kevin Burke voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

unread,

[go] strconv: optimize and simplify dragonbox implementation

Kevin Burke voted Commit-Queue+1 Commit-Queue +1 Open in Gerrit Related details Attention set is

Dec 20

Gerrit Bot (Gerrit), … Saransh Saini (Gerrit)7

Dec 19

[go] unicode: remove variation selectors from IsGraphic and IsPrint

Saransh Saini added 1 comment File src/unicode/graphic.go Line 42, Patchset 2 (Latest): if Is(

unread,

[go] unicode: remove variation selectors from IsGraphic and IsPrint

Saransh Saini added 1 comment File src/unicode/graphic.go Line 42, Patchset 2 (Latest): if Is(

Dec 19

Ethan Lee (Gerrit), … kokoro (Gerrit)7

Dec 19

[pkgsite] internal/dcensus: add metrics for codewiki link usage

Attention needed from Ethan Lee and Jonathan Amsterdam Ethan Lee uploaded new patchset Ethan Lee

unread,

[pkgsite] internal/dcensus: add metrics for codewiki link usage

Attention needed from Ethan Lee and Jonathan Amsterdam Ethan Lee uploaded new patchset Ethan Lee

Dec 19

Nicholas Husin (Gerrit), Damien Neil (Gerrit)2

Dec 19

[net] http2: support SETTINGS_NO_RFC7540_PRIORITIES in SETTINGS frame

Attention needed from Nicholas Husin Damien Neil added 1 comment File http2/server.go Line 946,

unread,

[net] http2: support SETTINGS_NO_RFC7540_PRIORITIES in SETTINGS frame

Attention needed from Nicholas Husin Damien Neil added 1 comment File http2/server.go Line 946,

Dec 19

Nicholas Husin (Gerrit), Damien Neil (Gerrit)2

Dec 19

[net] http2: only make streams non-incremental if clients are aware of RFC 9218

Attention needed from Nicholas Husin Damien Neil voted Code-Review+2 Code-Review +2 Open in Gerrit

unread,

[net] http2: only make streams non-incremental if clients are aware of RFC 9218

Attention needed from Nicholas Husin Damien Neil voted Code-Review+2 Code-Review +2 Open in Gerrit

Dec 19

Nicholas Husin (Gerrit), Damien Neil (Gerrit)2

Dec 19

[net] http2: add support for setting RFC 9218 priority via header field

Attention needed from Nicholas Husin Damien Neil added 3 comments File http2/server.go Line 2087,

unread,

[net] http2: add support for setting RFC 9218 priority via header field

Attention needed from Nicholas Husin Damien Neil added 3 comments File http2/server.go Line 2087,

Dec 19

Ian Lance Taylor (Gerrit), … Michael Knyszek (Gerrit)8

Dec 19

[gofrontend] libgo: use -W,-shared-libgcc on Solaris

Ian Lance Taylor submitted the change Change information Commit message: libgo: use -Wc,-shared-

unread,

[gofrontend] libgo: use -W,-shared-libgcc on Solaris

Ian Lance Taylor submitted the change Change information Commit message: libgo: use -Wc,-shared-

Dec 19

Search

Clear search

Close search

Google apps

Main menu