a code review (9616701) Add support for Firefox 3.1

[Zach Kuznia]

Hello aa,

I'd like you to do a code review. Please execute
g4 diff -c 9616701

or point your web browser to
http://mondrian/9616701

to review the following code:

Change 9616701 by zork@zkuznia-corp3 on 2009/01/06 13:22:34 *pending*

Add support for Firefox 3.1

R=aa
CC=gear...@googlegroups.com
DELTA=125 (93 added, 0 deleted, 32 changed)
OCL=9616701

Affected files ...

... //depot/googleclient/gears/opensource/gears/base/common/js_runner_ff.cc#33 edit
... //depot/googleclient/gears/opensource/gears/base/common/js_standalone_engine_mozjs.cc#6 edit
... //depot/googleclient/gears/opensource/gears/base/firefox/install.rdf.m4#3 edit
... //depot/googleclient/gears/opensource/gears/base/firefox/module.cc#18 edit
... //depot/googleclient/gears/opensource/gears/factory/factory_ff.cc#4 edit
... //depot/googleclient/gears/opensource/gears/tools/config.mk#95 edit
... //depot/googleclient/gears/opensource/gears/tools/rules.mk#97 edit
... //depot/googleclient/gears/opensource/gears/tools/sanity.mk#6 edit

125 delta lines: 93 added, 0 deleted, 32 changed

Also consider running:
g4 lint -c 9616701

which verifies that the changelist doesn't introduce new style violations.

If you can't do the review, please let me know as soon as possible. During
your review, please ensure that all new code has corresponding unit tests and
that existing unit tests are updated appropriately. Visit
http://www/eng/code_review.html for more information.

This is a semiautomated message from "g4 mail". Complaints or suggestions?
Mail p...@google.com.

[Zach Kuznia]

Re-uploaded.

On Mon, Jun 22, 2009 at 5:23 PM, Aaron Boodman <a...@google.com> wrote:

========================================================================
http://mondrian.corp.google.com/file/9616701///depot/googleclient/gears/opensource/gears/base/firefox/module.cc?a=3
File //depot/googleclient/gears/opensource/gears/base/firefox/module.cc (snapshot 3)
------------------------------------
Line 296: assert(false);
err... did you mean to leave this here?
========================================================================

--
To respond, reply to this email or visit http://mondrian.corp.google.com/9616701

[Aaron Boodman]

lgtm