Multipart message capability

1 view
Skip to first unread message

Suriya

unread,
Dec 23, 2006, 5:42:49 PM12/23/06
to Django developers
Hello Developers,

This is regarding ticket #1541
http://code.djangoproject.com/ticket/1541

Could someone take a look at the patch and try to integrate it into
DJango? This patch allows Django to accept tuples of (attachment name,
content as fileobject) and create email attachments.

Another approach would be to accept tuples of (attachment name, content
as string) and create attachments. I can write a patch for the latter.

I'd like to see this functionality in Django :) Is there anything else
stopping this ticket from being closed?

Thanks,
Suriya

Russell Keith-Magee

unread,
Jan 3, 2007, 8:19:21 AM1/3/07
to django-d...@googlegroups.com
On 12/24/06, Suriya <sur...@gmail.com> wrote:
>
> This is regarding ticket #1541
> http://code.djangoproject.com/ticket/1541
...

> I'd like to see this functionality in Django :) Is there anything else
> stopping this ticket from being closed?

Read the thread on the ticket - Jacob has stated what is standing
between the ticket and acceptance - documentation of the feature.

Write some documentation (or at least get an intitial draft ready),
add it to the patch, and we can get this feature into the trunk.

Yours,
Russ Magee %-)

Suriya

unread,
Jan 4, 2007, 12:15:17 AM1/4/07
to Django developers

Russell Keith-Magee wrote:
>
> Read the thread on the ticket - Jacob has stated what is standing
> between the ticket and acceptance - documentation of the feature.
>
> Write some documentation (or at least get an intitial draft ready),
> add it to the patch, and we can get this feature into the trunk.

That was written a long time ago. The new patches contain changes
to doc/email.txt as well.

Suriya

Russell Keith-Magee

unread,
Jan 8, 2007, 2:00:15 AM1/8/07
to django-d...@googlegroups.com

Ah - sorry - I didn't register that the second two patches were new,
so I recycled a response from when the same question was asked a month
ago.

The new patches deviate from the original patches that were tacitly
accepted by Jacob; in addition, there new patches provide two
competing implementations, making a total of three.

Personally, I favour the original approach to the newer versions.
There is probably some room for a helper function that implements the
magic-typing behaviour of the second patch, but I'm hesitant to encode
that sort of magic as a fundamental part of the system.

However, I'm willing to be convinced otherwise, and I won't commit
anything until there has been at least _some_ discussion on the
subject. Feel free to start and lead the discussion (if this reply
doesn't provoke any comments).

One quick comment on the new patches - the documentation examples
don't close the file handles. This is a habit that shouldn't be
encouraged.

Yours,
Russ Magee %-)

Reply all
Reply to author
Forward
0 new messages