WARNING: Use #include instead of #134: FILE: board/omap3evm/clock.c:29: +#include ERROR: return is not a function, parentheses are not required #182: FILE: board/omap3evm/clock.c:77: + return (S38_4M); ERROR: return is not a function, parentheses are not required #184: FILE: board/omap3evm/clock.c:79: + return (S26M); ERROR: return is not a function, parentheses are not required #186: FILE: board/omap3evm/clock.c:81: + return (S24M); ERROR: return is not a function, parentheses are not required #188: FILE: board/omap3evm/clock.c:83: + return (S19_2M); ERROR: return is not a function, parentheses are not required #190: FILE: board/omap3evm/clock.c:85: + return (S13M); ERROR: return is not a function, parentheses are not required #192: FILE: board/omap3evm/clock.c:87: + return (S12M); WARNING: Use #include instead of #839: FILE: board/omap3evm/mem.c:29: +#include WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #852: FILE: board/omap3evm/mem.c:42: +volatile unsigned int boot_flash_env_addr; WARNING: externs should be avoided in .c files #863: FILE: board/omap3evm/mem.c:53: +uchar env_get_char_spec(int index); WARNING: externs should be avoided in .c files #864: FILE: board/omap3evm/mem.c:54: +int env_init(void); WARNING: externs should be avoided in .c files #865: FILE: board/omap3evm/mem.c:55: +int saveenv(void); WARNING: externs should be avoided in .c files #866: FILE: board/omap3evm/mem.c:56: +void env_relocate_spec(void); WARNING: externs should be avoided in .c files #867: FILE: board/omap3evm/mem.c:57: +extern char *env_name_spec; ERROR: return is not a function, parentheses are not required #941: FILE: board/omap3evm/mem.c:131: + return (0); ERROR: return is not a function, parentheses are not required #943: FILE: board/omap3evm/mem.c:133: + return (1); WARNING: Use #include instead of #1128: FILE: board/omap3evm/nand.c:25: +#include WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #1137: FILE: board/omap3evm/nand.c:34: +volatile unsigned long gpmc_cs_base_add; WARNING: Use #include instead of #1548: FILE: board/omap3evm/omap3evm.c:32: +#include WARNING: externs should be avoided in .c files #1558: FILE: board/omap3evm/omap3evm.c:42: +extern struct nand_chip nand_dev_desc[CFG_MAX_NAND_DEVICE]; WARNING: externs should be avoided in .c files #1574: FILE: board/omap3evm/omap3evm.c:58: + __asm__ volatile ("1:\n" "subs %0, %1, #1\n" WARNING: externs should be avoided in .c files #1636: FILE: board/omap3evm/omap3evm.c:120: + __asm__ __volatile__("mrc p15, 0, %0, c1, c1, 2":"=r"(i)); WARNING: externs should be avoided in .c files #1638: FILE: board/omap3evm/omap3evm.c:122: + __asm__ __volatile__("orr %0, %0, #0xC00":"=r"(i)); WARNING: externs should be avoided in .c files #1641: FILE: board/omap3evm/omap3evm.c:125: + __asm__ __volatile__("orr %0, %0, #0x70000":"=r"(i)); WARNING: externs should be avoided in .c files #1642: FILE: board/omap3evm/omap3evm.c:126: + __asm__ __volatile__("mcr p15, 0, %0, c1, c1, 2":"=r"(i)); WARNING: externs should be avoided in .c files #1645: FILE: board/omap3evm/omap3evm.c:129: + __asm__ __volatile__("mrc p15, 0, %0, c1, c0, 1":"=r"(i)); WARNING: externs should be avoided in .c files #1646: FILE: board/omap3evm/omap3evm.c:130: + __asm__ __volatile__("orr %0, %0, #0x10":"=r"(i)); WARNING: externs should be avoided in .c files #1647: FILE: board/omap3evm/omap3evm.c:131: + __asm__ __volatile__("mcr p15, 0, %0, c1, c0, 1":"=r"(i)); WARNING: externs should be avoided in .c files #1650: FILE: board/omap3evm/omap3evm.c:134: + __asm__ __volatile__("mrc p15, 0, %0, c1, c1, 0":"=r"(i)); WARNING: externs should be avoided in .c files #1651: FILE: board/omap3evm/omap3evm.c:135: + __asm__ __volatile__("orr %0, %0, #0x31":"=r"(i)); WARNING: externs should be avoided in .c files #1652: FILE: board/omap3evm/omap3evm.c:136: + __asm__ __volatile__("mcr p15, 0, %0, c1, c1, 0":"=r"(i)); WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #1663: FILE: board/omap3evm/omap3evm.c:147: + volatile unsigned int j; WARNING: externs should be avoided in .c files #1665: FILE: board/omap3evm/omap3evm.c:149: + __asm__ __volatile__("mov %0, r12":"=r"(j)); WARNING: externs should be avoided in .c files #1666: FILE: board/omap3evm/omap3evm.c:150: + __asm__ __volatile__("mov %0, r0":"=r"(i)); WARNING: externs should be avoided in .c files #1670: FILE: board/omap3evm/omap3evm.c:154: + __asm__ __volatile__("mov r12, #0x3"); WARNING: externs should be avoided in .c files #1671: FILE: board/omap3evm/omap3evm.c:155: + __asm__ __volatile__("mrc p15, 0, r0, c1, c0, 1"); WARNING: externs should be avoided in .c files #1673: FILE: board/omap3evm/omap3evm.c:157: + __asm__ __volatile__("orr r0, r0, #0x10"); WARNING: externs should be avoided in .c files #1675: FILE: board/omap3evm/omap3evm.c:159: + __asm__ __volatile__(".word 0xE1600070"); WARNING: externs should be avoided in .c files #1676: FILE: board/omap3evm/omap3evm.c:160: + __asm__ __volatile__("mov r0, %0":"=r"(i)); WARNING: externs should be avoided in .c files #1677: FILE: board/omap3evm/omap3evm.c:161: + __asm__ __volatile__("mov r12, %0":"=r"(j)); ERROR: return is not a function, parentheses are not required #1787: FILE: board/omap3evm/omap3evm.c:271: + return (0); WARNING: externs should be avoided in .c files #1875: FILE: board/omap3evm/omap3evm.c:359: + extern flash_info_t flash_info[]; WARNING: Use #include instead of #1939: FILE: board/omap3evm/sys_info.c:29: +#include ERROR: return is not a function, parentheses are not required #1951: FILE: board/omap3evm/sys_info.c:41: + return (2); ERROR: return is not a function, parentheses are not required #1961: FILE: board/omap3evm/sys_info.c:51: + return (CPU_3430); WARNING: externs should be avoided in .c files #1974: FILE: board/omap3evm/sys_info.c:64: + __asm__ __volatile__("mrc p15, 0, %0, c0, c0, 0":"=r"(cpuid)); WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #1987: FILE: board/omap3evm/sys_info.c:77: + volatile u32 *burst = (volatile u32 *) (SDRC_MR_0 + SDRC_CS0_OSET); ERROR: return is not a function, parentheses are not required #1989: FILE: board/omap3evm/sys_info.c:79: + return (1); ERROR: return is not a function, parentheses are not required #1990: FILE: board/omap3evm/sys_info.c:80: + return (0); ERROR: return is not a function, parentheses are not required #1999: FILE: board/omap3evm/sys_info.c:89: + return (DDR_DISCRETE); ERROR: return is not a function, parentheses are not required #2013: FILE: board/omap3evm/sys_info.c:103: + return (size); ERROR: return is not a function, parentheses are not required #2038: FILE: board/omap3evm/sys_info.c:128: + return (0x0000003F & __raw_readl(CONTROL_STATUS)); ERROR: return is not a function, parentheses are not required #2059: FILE: board/omap3evm/sys_info.c:149: + return (b); ERROR: return is not a function, parentheses are not required #2067: FILE: board/omap3evm/sys_info.c:157: + return (WIDTH_16BIT); ERROR: return is not a function, parentheses are not required #2076: FILE: board/omap3evm/sys_info.c:166: + return (0x20); WARNING: externs should be avoided in .c files #2159: FILE: board/omap3evm/sys_info.c:249: + __asm__ __volatile__("mov %0, pc \n":"=r"(val)::"memory"); ERROR: return is not a function, parentheses are not required #2162: FILE: board/omap3evm/sys_info.c:252: + return (val); ERROR: return is not a function, parentheses are not required #2172: FILE: board/omap3evm/sys_info.c:262: + return (1); /* in flash */ ERROR: return is not a function, parentheses are not required #2174: FILE: board/omap3evm/sys_info.c:264: + return (0); /* running in SRAM or SDRAM */ ERROR: return is not a function, parentheses are not required #2184: FILE: board/omap3evm/sys_info.c:274: + return (1); /* in SRAM */ ERROR: return is not a function, parentheses are not required #2186: FILE: board/omap3evm/sys_info.c:276: + return (0); /* running in FLASH or SDRAM */ ERROR: return is not a function, parentheses are not required #2196: FILE: board/omap3evm/sys_info.c:286: + return (1); /* in sdram */ ERROR: return is not a function, parentheses are not required #2198: FILE: board/omap3evm/sys_info.c:288: + return (0); /* running in SRAM or FLASH */ ERROR: return is not a function, parentheses are not required #2221: FILE: board/omap3evm/sys_info.c:311: + return (mode >>= 8); WARNING: Use #include instead of #2256: FILE: board/omap3evm/syslib.c:29: +#include WARNING: externs should be avoided in .c files #2271: FILE: board/omap3evm/syslib.c:44: + __asm__ volatile ("1:\n" "subs %0, %1, #1\n" ERROR: return is not a function, parentheses are not required #2299: FILE: board/omap3evm/syslib.c:72: + return (1); ERROR: return is not a function, parentheses are not required #2301: FILE: board/omap3evm/syslib.c:74: + return (0); WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #2652: FILE: include/configs/omap3evm.h:276: +extern volatile unsigned int boot_flash_env_addr; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #2668: FILE: include/configs/omap3evm.h:292: + do {*(volatile u32 *)(GPMC_CONFIG) |= 0x00000010; } while (0) WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #2670: FILE: include/configs/omap3evm.h:294: + do {*(volatile u32 *)(GPMC_CONFIG) &= ~0x00000010; } while (0) total: 29 errors, 42 warnings, 2581 lines checked patches/u-boot-omap3-p1.txt has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.