[AOLSERVER] ns_httptime -1 crashes AOLserver on Windows

[Fenton, Brian]

Hi

 

My Windows version of AOLserver crashes hard if I call ns_httptime with a value of -1. The version is

AOLserver/4.5.0 (aolserver4_5)
CVS Tag:         $Name: aolserver_v45_r0 $
Built:           May  2 2008 at 14:54:44
Tcl version:     8.5
Platform:        win32

 

Can anyone else confirm this problem? I realise there is a more recent Windows version of AOLserver - does anyone know if it is resolved there?

 

I'm getting it on Windows Server 2003 [Version 5.2.3790]

 

It seems to work fine on a unix version of AOLserver 4.5 that I tested.

 

thanks

Brian

--
AOLserver - http://www.aolserver.com/

To Remove yourself from this list, simply send an email to <list...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.

[Tom Jackson]

Quick workaround for your problem:

proc ::ns_time { } {

return [clock seconds]
}

proc ::ns_httptime { seconds } {

return [clock format $seconds -format "%a, %d %b %Y %H:%M:%S %Z" -gmt 1]
}

Just redefine ns_httptime.

tom jackson

(However, does the C code crash, or just the tcl API?)

[Fenton, Brian]

Nice workaround Tom.

It actually kills the AOLserver process instantly, requiring a restart.

Brian

________________________________________
From: AOLserver Discussion [AOLS...@LISTSERV.AOL.COM] On Behalf Of Tom Jackson [t...@RMADILO.COM]
Sent: 22 November 2010 19:02
To: AOLS...@LISTSERV.AOL.COM
Subject: Re: [AOLSERVER] ns_httptime -1 crashes AOLserver on Windows

[Tom Jackson]

I'll just note that Ns_HttpTime, which is called by ns_httptime is
also called for nearly every request in Ns_ConnSetRequiredHeaders

Ns_ConnSetRequiredHeaders --
384 *
385 * Set a sane set of minimal headers for any response:
386 * MIME-Version, Date, Server, Content-Type, Content-Length

....

410 Ns_ConnCondSetHeaders(conn, "Date", Ns_HttpTime(&ds, NULL));

So if your server is only crashing in ns_httptime, that should narrow
down the source of the bug.

tom jackson